GitLab

Add an error if marker file creation failed.

Bug: 1065585
Change-Id: Iaa86c52b63111097b675f93bdad95ce706cde3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148840Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758868}

If a reporter is replaced by a new reporter, but the frame had not
produced a frame, then use the timestamp of the 'did not produce'
notification as the termination-time to end the trace-event, rather than
the time of the replacement.

BUG=none

Change-Id: I91ad6b9a1b0c31afe5309f89e7f8aaf43121e8eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146517
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758867}

Bug: 1067783
Change-Id: I624d43ee3863272bb4d7bef347b157164e886d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145861Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758866}

https://chromium-review.googlesource.com/c/chromium/src/+/2079258
deleted third_party/blink/common/origin_policy, but not the public API.
Additionally, various OWNERS files were left pointing at a nonexistent
file.  AFAICT the new canonical home is services/network/origin_policy,
so point to that.

Bug: none
Change-Id: I2f27b9a63083e92c708590955849122fef9ffe00
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144106Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758865}

The member variables should be private, and can be accessed in
tests via protected accessors.

BUG=none
TBR=behdadb@chromium.org

Change-Id: I40e19a3d76323800df9b6c2aa45ad27efe1bc31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149275Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758864}

Update cros_healthd telemetry handling code to check for and log errors
from TimezoneInfo request.

Bug: chromium:1041153
Change-Id: I2319094bd80b478c275ee4ceee35faa9e75263f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145925Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Trent Begin <tbegin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758863}

Also enable snapshot debugging when "snapshot" option is set for avd create.
Plus some minor fixes for root_ini and logging for emulator start

Bug: 922145
Change-Id: I6aaebc099ce25e9180efb6a66c097f885b804db2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145957Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Haiyang Pan <hypan@google.com>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758862}

According to a study done in go/canvas-flaky-spreadsheet-2020 there are
some tests that are not flaky anymore. Updating the expectations
accordingly.

Change-Id: Ib4acb4c200abbe9424af18036232e3f925952836
Bug: 1011060, 990918, 786641, 831496, 922951, 971612, 1061131, 1050306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136858Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758861}

Bug: 1043108
Change-Id: I069cfb88d15f2c480ca76d2d06b10dcb1c7cbd69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130187Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Anastasiia N <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758860}

BUG=767015, 1063749
R=svillar@chromium.org

Change-Id: I635081a2f98896e52d8f5aa1c95dc1f1d9836f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148072
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#758859}

This CL is a reland of the following CL. It fixes the issues that
produced lint warnings.

https://chromium-review.googlesource.com/c/chromium/src/+/2120724

TBR=dominickn@chromium.org, twellington@chromium.org, agrieve@chromium.org, yfriedman@chromium.org

Bug: 980567
Change-Id: Ia48f18c9f10ce3a2239781d0c97174de4d234d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142251Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758858}

Migrating the supported release branch for DeviceChromeVariations and
ChromeVariations into M83, instead of referencing to the defunct M82
release.

BYPASS_POLICY_COMPATIBILITY_CHECK=both policies were never used

Bug: 1070442
Change-Id: I9f46fc428a0b0968cfc086b5cee5a1ae68fa34a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148312Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Cr-Commit-Position: refs/heads/master@{#758857}

This reverts commit 8c860979.

Reason for revert: Rohit sees the failures on the internal waterfall.

Original change's description:
> Revert "Disable testSucessfullDownloadInIncognito on device."
> 
> This reverts commit 0e8c98fa.
> 
> Reason for revert: Download test server performance was improved,
> which might have fixed the test. I don't have access to iPad device and won't have for a while, so reverting to see if the test still failing/flaky.
> 
> Original change's description:
> > Disable testSucessfullDownloadInIncognito on device.
> > 
> > Bug: 1059320
> > Change-Id: Ib14a8dd209e277d01b7d2769b2b7ff6da5169f7e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091937
> > Auto-Submit: Eugene But <eugenebut@chromium.org>
> > Reviewed-by: Sergio Collazos <sczs@chromium.org>
> > Commit-Queue: Sergio Collazos <sczs@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#747837}
> 
> TBR=eugenebut@chromium.org,sczs@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1059320
> Change-Id: I47716dd36214b3e2204ab2a4e1400f1b246b9310
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148168
> Auto-Submit: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758806}

TBR=eugenebut@chromium.org,sczs@chromium.org

Change-Id: Ic91761c6dfa9ea731ea87dd93d7195edc7581160
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1059320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148964Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758856}

Using wpt-import in Chromium fe1175d9.
With Chromium commits locally applied on WPT:
d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers"
c53a40f4 "Update size.attributes.parse.trailingjunk"
86131ac4 "Add a test for ReplaceTrack that verifies video track content."
2f3bb77d "[device-orientation] Upstream web tests to WPT"
d53acfce "[css-grid] Migrate positioned-grid-items-crash.html to WPT"
03a85d57 "[client hints]: Properly apply persisted accept-CH policy in 3P context"
f064e48f "Make will-change: backdrop-filter a containing block for fixed and abs"
c21ee9b0 "[css-masking] Migrate clip-path-descendant-text-mutated.html to WPT"
8ab053d0 "[css-flexbox] Move stretch-table-child.html test to WPT"
b99c852b "[css-grid] Migrate flex-and-minmax-content-resolution-rows to WPT"
2b980e38 "Add regression test for https://crbug.com/1064676"
304e175c "[css-masking] Migrate clip-path-reference-nonexisting-existing-local.html to WPT"
fe1175d9 "[css-grid] Migrate compute-intrinsic-widths-scrollbar.html to WPT"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: I69c4584d600fd879e900b03623b401f9b6bfb035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147957Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758855}

C++ aggregate initializers will only initializer the first member
of a union, which in the case of v4l2_format leaves a lot of data
uninitialized. Fix this by initializing it with memset().

BUG=chromium:1068447
BUG=b:153935975
TEST=VDAtest passes on nyan_kitty.

Change-Id: I7138b49780a9845ea924be00f11ccaa7a6904f6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147399Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758854}

https://github.com/WICG/content-index/issues/21

Change-Id: I829db49bc39ae49288c198f4080e334c226c33f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144077Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758853}

Interactive Widget tests now use WidgetAutoclosePtr where
applicable.

Bug: None
Change-Id: Ibf3e904585b1f25817e5e51a7a5d9e743679193a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148123
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758852}

We previously required `CSPRO` headers to contain `report-uri`. Since we
added a DOM interface (`SecurityPolicyViolation` events and Reporting
API integration), that requirement is no longer applied. We still
surface a warning, but that's more verbose than it needs to be, given
that the use case it warns about is completely legitimate.

Bug: 1070533
Change-Id: Ica89fa0c8d53d563c6510426e2f6f11d2e7400c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145881
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758851}

This is a reland of c195e902
with a higher token limit in check_op.cc to accommodate release component
dcheck_always_on=true builds on Linux (see crbug.com/1069971).

It also addresses some post-commit comments on the original CL.

Original change's description:
> [base] Move the CHECK and CHECK_op macros to more light-weight headers
>
> This provides cheaper (in terms of compile time) alternatives for code
> that just wants to do a few simple CHECKs without pulling in the full
> weight of logging.h. On Linux, the preprocessed size of check.h and
> check_op.h are 2% and 62% of logging.h, respectively.
>
> Splitting the CHECK and CHECK_op macros out to separate files also
> reduces the complexity of logging.h which has become very complicated.
>
> As a bonus, the new implementation is leaner, causing a 3% local
> compile-time reduction for the chrome target on Linux even though no
> includes have been changed yet.
>
> Bug: 1031540
> Change-Id: If7aca321f077110bea0907e487d2e8d29a8c50fd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128112
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758287}

Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng
Bug: 1031540
Change-Id: Ie524997796b90bea593c1a5f04be5ae0c89f8954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144180
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758850}

Bug: 1065122
Change-Id: I2d73a5d5d1e9ed59f26afe10fcce421572ca7fe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147813Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758849}

This CL adds eg2 tests for changes in crrev.com/c/2140953.

The test fixture in this CL must enable certain command-line flags
to be able to run the managed bookmarks enterprise policy.

The eg2 tests for managed bookmarks include testing:
- disabling long-press for managed items (URLs and folders)
- disabling swipe-to-delete for managed items (URLs and folders)
- disabling new folder context menu button when inside a managed folder
- disabling edit context menu button when inside a managed folder

Bug: 1065187
Change-Id: Ide92b87f03585d186b133f192d1e39a4fbbaa1cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145260Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758848}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/603aaa5f..a0ab3490

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I49c3231c5bdaf6c071d0fb71fbad5e892937c1ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147958Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758847}

BUG=767015,1063749
R=jfernandez@igalia.com

Change-Id: I810770fc14973b41e6560eff55da0e26fc3d1f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145639
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#758846}

https://webrtc.googlesource.com/src.git/+log/2d2c2947fd50..39fb817efdce

git log 2d2c2947fd50..39fb817efdce --date=short --first-parent --format='%ad %ae %s'
2020-04-14 ilnik@webrtc.org [Video, Svc] Remove inactive spatial layers in codec initializer
2020-04-14 mbonadei@webrtc.org Remove OpenSSLIdentity::GenerateWithExpiration.

Created with:
  gclient setdep -r src/third_party/webrtc@39fb817efdce

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I2ed25d5977161b999614ac363abae8045e95672b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148725Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758845}

https://skia.googlesource.com/skia.git/+log/ad653d8378d7..871d40b74c63

git log ad653d8378d7..871d40b74c63 --date=short --first-parent --format='%ad %ae %s'
2020-04-14 westont@google.com [infra] Add Debian9 docker image.

Created with:
  gclient setdep -r src/third_party/skia@871d40b74c63

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: kjlubick@google.com
Change-Id: I385e75fb26bd1d032b50d30d584bf1d49424245e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148727Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758844}

Updates PopulateAccessibilityData() in |TreeView| to ensure it does not lookup row/depth information for nodes inside collapsed subtrees via GetRowForInternalNode(). Previously, the check only worked when the node's immediate parent was collapsed. This changelist expands it to examine ancestors as well.

PopulateAccessibilityData() can happen when assistive technologies attempt to retrieve property information for arbitrary tree items inside |TreeView| subtrees. Previously, this would lead to a DCHECK failure during row/depth lookup at GetRowForInternalNode().

Bug: 811277
Change-Id: I83e1a127adfcf24dac7a3a9643a659b42a198cff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146134
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Brian Liu Xu <brx@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#758843}

This reverts commit c7743509.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1052316#c19

Original change's description:
> Show enterprise disclosure as a bottom status indicator in login/lock screen
>
> Bug: 1015746
> Change-Id: I995eb65b7f99f47a9f2ec5bd33798ee74fb78699
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929813
> Commit-Queue: Thomas Tellier <tellier@google.com>
> Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718850}

TBR=xiyuan@chromium.org,rsorokin@chromium.org,raleksandrov@google.com,tellier@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1015746
Change-Id: I2694ddd0eb17d23d47789e3910d974b6ab8bf542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148737Reviewed-by: Thomas Tellier <tellier@google.com>
Commit-Queue: Thomas Tellier <tellier@google.com>
Cr-Commit-Position: refs/heads/master@{#758842}

This CL moves column-property-should-not-apply-on-grid-container.html
from fast/css-grid-layout/ to external/wpt/css/css-grid/grid-model/.
It also adds links and references to the related spec, and expected behavior.
Last, it removes the uses of -webkit-column-* and -moz-column-* in favor of
their respective column-* counterparts.

Relevant spec change: https://github.com/w3c/csswg-drafts/issues/1364
([css-multicol-1][css-flexbox-1][css-grid-1] Clarify that column-*
properties only apply to block containers).

BUG=767015, 1063749
R=dgrogan@chromium.org

Change-Id: I1a5b27a863be4f7b10ffda4e65ed52050dbf0f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144720
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#758841}

This avoids a copy of viz::BeginFrameArgs for the argument.
sizeof(viz::BeginFrameArgs) is 56 on LP64 systems.

Change-Id: I2d0c99ae490824563907cdfbe86b5196f3015936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146784
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758840}

Chromecast should focus on the full screen shell surface node
that holds the child tree for the UI.  Otherwise, things like
live regions will fail to find a focused root node and will
not work.

Bug: NONE
Test: Local chromecast build
Change-Id: I5b34eb40fd3c7240b8584fc83bf312727f9e2658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134568Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758839}

https://swiftshader.googlesource.com/SwiftShader.git/+log/20220a0b0640..e52e2dbcdf9d

git log 20220a0b0640..e52e2dbcdf9d --date=short --first-parent --format='%ad %ae %s'
2020-04-14 digit@google.com [vulkan] Implement VK_FUCHSIA_external_memory extension.

Created with:
  gclient setdep -r src/third_party/swiftshader@e52e2dbcdf9d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I900301a48378a97db557c5519d260a2bbee121e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148726Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758838}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11d03194c82f..e5fe03bb8982


Created with:
  gclient setdep -r src-internal@e5fe03bb8982

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com
Change-Id: Ic5c85925cd9e7bc176e5f1dfe2d165eebe13e4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148728Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758837}

Bug: 1065906
Change-Id: Ia8fc6d9e5bd352c3616bb0a9a99c5835055b74e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144676Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758836}

This patch allows the existing locks to be forced multiple times by
keeping count of how many times to force them.

R=cbiesinger@chromium.org, chrishtr@chromium.org

Change-Id: Ieccb60f9698edcb5aad2b57792a53f164563fae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144618Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758835}

https://chromium.googlesource.com/angle/angle.git/+log/965eedbfbf1e..3d894d87b25b

git log 965eedbfbf1e..3d894d87b25b --date=short --first-parent --format='%ad %ae %s'
2020-04-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 9d2fd9c161ab..711867566999 (3 commits)
2020-04-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 46572440189e..4d2298bfd78a (1 commits)
2020-04-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 490e39372126..ae0f0ead3a56 (1 commits)
2020-04-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 34be23373b9e..e70d25f6fa5d (3 commits)

Created with:
  gclient setdep -r src/third_party/angle@3d894d87b25b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: timvp@google.com
Change-Id: Ifadb848aadb4bdff6eccf2703091273e322f9475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148722Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758834}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dfd18c4e7516..575e040c7661

git log dfd18c4e7516..575e040c7661 --date=short --first-parent --format='%ad %ae %s'
2020-04-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@575e040c7661

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7d5b2925642bc431f6916ce0cdd274c53bc2c798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148730Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758833}

This reverts commit 011b4cb3.

Reason for revert: Broke internal builder (renaming of a method:
LocationBarLayout::performSearchQueryForTest)

Original change's description:
> Query Tiles: Submit query on last level tile click
> 
> This CL adds :
> 1 - Submit query and show SRP on the last level tile click
> 2 - Shorten most visited tile section to 1 row for smaller screens
> 
> Bug: 1068308
> Change-Id: Icae29ad8bcc563ca6cfa3bfd35d18fa90ff65b7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147041
> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758724}

TBR=dtrainor@chromium.org,shaktisahu@chromium.org

Change-Id: I606eaefdff636668d0c8e30759d4bb8cbf38def8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1068308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148958Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758832}

This CL adds an empty state preventing the user from seeing the loading
state forever if no passwords are available after unlocking the account
storage.
An empty state is preferable over closing the dropdown since it provides
the feedback that the requested action (look in account storage) turned
up empty and provides the user with a path to settings.

Thus, the empty state completes the unlock flow:
1. Focus a password field
2. Click on the unlock button
3. Reauth
4. Wait for store to push an update (either new data or delete data)
 a. Use the newly available suggestions.  <-- Already implemented.
 b. See the empty state; go to settings.  <-- This CL


Screenshot for with empty state string:
https://storage.cloud.google.com/chromium-translation-screenshots/5a36eba8302b1aca1911d2a2873ecbc09363d290

See linked bug for a short video.

Bug: 1068555
Change-Id: I419d508e1faa2c230f3e4c85de71a9e08da1df54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142113Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758831}

Fixed: 1069098
Fixed: 1068868
Change-Id: Ie16fdd37bd551ba637856034dea681741e371d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148736Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758830}

We want to get rid of the single argument AddHeader() method as the two
argument AddHeader() and SetHeader() methods are safer and more flexible.

Bug: 1068194
Change-Id: Iffa9b5356aae762fad68a2d309eec94cf0a43568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147692
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758829}