- 20 Jan, 2020 40 commits
-
-
Nina Satragno authored
Disable CrSettingsPrivacyPageTest.PrivacyPageSoundTests and CrSettingsPrivacyPageTest.UMALoggingTests as they are crashing on Linux Tests (dbg) Looks like the previous revert did not solve the issue :'( TBR=dbeam@chromium.org No-try: true Bug: 1043665 Change-Id: I7711e99fdeeb24c6ba1d6c47e205b16c2dd34431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011289 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#733463}
-
Nick Burris authored
This reverts commit ae629163. Reason for revert: Verifying on Canary that this caused an artificial regression in scroll metrics, will reland. Original change's description: > viz: Fix FindLatestSurfaceUpTo when there is conflict > > The condition used in the binary search was wrong. Fixed it and added > a unit test. > > Bug: 1000868 > Change-Id: Iaf4af1bdfdb88db1082bfae89a3783faed860934 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800743 > Auto-Submit: Saman Sami <samans@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696170} TBR=jonross@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000868, 1015120 Change-Id: Ia91e27f3acb11772980c5b5ff872827af53e548f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940998Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#733462}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-3987.39-1578912426-benchmark-81.0.4019.0-r1 to 81-4025.0-1579517934-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I879108952a722cfa0ba7f14b1f9da02d97e0d4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010327Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733461}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb76282b5443..abf20c44084a Created with: gclient setdep -r src-internal@abf20c44084a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0153029c5f73b5c834bd52a8a57666f676ef3a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009836Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733460}
-
Andrew Grieve authored
Causes "git cl format" and "git cl upload" presubmit checks to format changed lines in a review to adhere to our style guide (PEP-8). Bug: 846432 Change-Id: I0a91f85df9f69fff7a87868c40479cad671dc892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989512 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#733459}
-
Navid Zolghadr authored
Feel free to revert if it causes any regressions. Bug: 1000682 Change-Id: Ia65f85a763d20f906e5bcba1f4c3e565dcb64b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011135Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733458}
-
Sahel Sharify authored
Change-Id: I2efdc8098f3dd95eefe645701d833dcfd46279ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005375Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#733457}
-
Maksim Ivanov authored
Don't allow the user to submit the dialog (e.g., click "Next") before entering anything into the input field. Before the CL, the user could submit an empty field, which would lead to unexpected effect for the user, since an empty input is treated internally like a cancellation. This CL changes this to only allow cancelling the dialog in case there's no input yet. In the (rare) case the user's smart card is not protected by a PIN, it's the responsibility of the smart card middleware to not request the PIN input at all. Bug: 1024251 Test: start SAML login using a smart card, reach the PIN dialog, check that the "Next" button is disabled and pressing "Enter" has no effect, enter any digit, check that the "Next" button is enabled Change-Id: I07bc8e48ffe802aa0fcfeda45f0db489a95fad5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002510Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#733456}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If1f3a513057aca9d727ae280a6feffea1f82bf53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011172Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#733455}
-
Nina Satragno authored
Disable virtual/web-components-v0-disabled/external/wpt/html/dom/reflection-grouping.html for linux -- it's flaking on "WebKit Linux Leak" See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/9703 TBR=masonfreed@chromium.org No-try: true Bug: 1043774 Change-Id: I729f72639d69fee4288edc29ea1abd0cb73e3fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011283Reviewed-by:
-
Michael Thiessen authored
This makes tests defined by CalledByNativeJavaTest easier to disable by using the DisabledCalledByNativeJavaTest annotation. Bug: 1042808 Change-Id: I8e30d5a092e765c786927d753b0a3a22be4a605d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008311 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#733453}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d8f8c29bb25a..0fee6ccc2e6e git log d8f8c29bb25a..0fee6ccc2e6e --date=short --first-parent --format='%ad %ae %s' 2020-01-20 rharrison@chromium.org Rolling 2 dependencies Created with: gclient setdep -r src/third_party/dawn@0fee6ccc2e6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I02bb77481c5e97c18d638d178e215d0575bd6fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009835Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ebf1fafe..5ddbe062 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I675e740e0895a9ad64ee073ba1d2674b0061a3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010928Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733451}
-
Peng Huang authored
Bug: none Change-Id: I09d906ed6d642e7a819b75d5b36715c5677387e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010181Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#733450}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/61380c09e241..1a68679e65af git log 61380c09e241..1a68679e65af --date=short --first-parent --format='%ad %ae %s' 2020-01-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f777073e..2a6702f0 (733282:733412) 2020-01-20 ilnik@webrtc.org Propagate is_bw_limited flag with bw allocation everywhere it's copied 2020-01-20 danilchap@webrtc.org Publish DependencyDescriptor structures in the api Created with: gclient setdep -r src/third_party/webrtc@1a68679e65af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9cf386f91647b8ea75e6bdc0376635abf61e5440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011213Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0f9c87a6. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I36f6d309b6e8c687b740bb5ede428fcaa680d456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010927Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733448}
-
Randy Rossi authored
This API is requested by the chromevox extension manifest but not used in chromecast. This causes a DCHECK failure in the manifest permissions parser. Adding the feature/permission here so DCHECK doesn't cause failure to install the extension in eng builds. Test: Local build with x86 chromecast simulator (eng) Bug: None Change-Id: I9ceb769b768f15ab523653afe3defc7f1627d9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007477Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#733447}
-
Albert Chaulk authored
This allows querying the CanGoBack status of the underlying app Bug: b/145762033 Test: None Change-Id: I330d7124dd7817db69f5ff41bfa58f6059971113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008066Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#733446}
-
Albert Chaulk authored
GRPC appears to barf if Finish() is called on a stream that is still active on the read side. The intent was to allow shutting down by cast_shell at any time, however we have to wait until both read and write are inactive Call OnError() at any time from any thread, sets errored_ The flows now are If this happens between a read completion and the start of the next read - If send_pending_ is false, ReadComplete calls Finish - Else, read_pending_ becomes false - Later, WriteComplete will call Finish If the read has started and a write is pending - If the write finishes first, sets send_pending_ false -- Then, the read completion will call Finish - If the read finishes first, sets read_pending_ false -- Then, the write completion will call Finish A consequence of this is that we can now only shut down most of the time after the next message from the client is received Bug: b/146500172 Test: with patch 1985810 Change-Id: I51df0503b412f86e888143eecae76b6610762552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008367 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/900f1f215dee..bb76282b5443 Created with: gclient setdep -r src-internal@bb76282b5443 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:989667 Tbr: jbudorick@google.com Change-Id: Id66a72545bf5b1bf81e5090f1512532736c81a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011211Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fa9410e8e8a6..cbab43ca0aa3 git log fa9410e8e8a6..cbab43ca0aa3 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 tvanderlippe@chromium.org Typecheck Trie.js with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@cbab43ca0aa3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I918401305b15c2805c448f43577b693c9b65818a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011210Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c5af6931c0ed..e5aad3baed2b git log c5af6931c0ed..e5aad3baed2b --date=short --first-parent --format='%ad %ae %s' 2020-01-20 lalitm@google.com bazel: add indirection layer for public visibility 2020-01-20 lalitm@google.com Merge "perfetto: don't enable perfetto before running tests" 2020-01-20 lalitm@google.com Merge "trace_processor: make slice stack ids safe for JS" 2020-01-20 lalitm@google.com Merge "trace_processor: add flamegraph virtual table" Created with: gclient setdep -r src/third_party/perfetto@e5aad3baed2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I19c839771a8b37a8d84fa56bc98c1a05e08aea76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011145Reviewed-by:
-
Denis Kuznetsov authored
By polymer specification all styling should be done inside <template> element. Preprocessor embeds <link rel="stylesheet"> into resulting HTML. Bug: 955194 Change-Id: I91cbadf0b73cc771619a9041e2f7c662199f3740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010773 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733441}
-
Kevin Schoedel authored
Bug: b/147496970 Change-Id: Iea93191737ff06d4d4844b16a7ab38ecb0d50a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011163Reviewed-by:
-
Aaron Krajeski authored
Because we don't return the skia canvas when the context is lost we can invalidate the save stack if we save on our end. This is testable (https://bugs.chromium.org/p/chromium/issues/detail?id=1035224) but only with the --enable-experimental-web-platform-features flag. Bug: 1035224 Change-Id: I0048dc5c9e26908b5568173aa6431adc11a013b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002929 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#733439}
-
Nazerke authored
This CL updates AppLauncherCoordinator to use the browser-based initializers, and updates unit tests. Also this CL converts AppLauncherCoordinator to ChromeCoordinator subclass. Bug: 906541, 1029346 Change-Id: I327200dd6d7dfbfb9fa032e719996aa319233723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010863Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#733438}
-
Anqing Zhao authored
According to the suggestion from jennschen@ during ChromeOS-UXImpl review: we don't say 'Android applications' anywhere in the settings UI but instead use Play Store terminology and iconography. Therefore, the corresponding description and icon need be changed. Bug: 1010213 Change-Id: I96f2e6c73c295c53dd68a624d281e0e14c7edf16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010945Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#733437}
-
Maksim Ivanov authored
This is a pure cleanup CL. It replaces the use of "position: absolution" in the smart card SAML PIN dialog (a.k.a. the security_token_pin dialog) with the normal positioning. This makes the implementation less fragile against future changes, as it doesn't rely on the absolute coordinates of the PIN input field and its sizes anymore. Bug: 1024251 Test: take screenshot of the SAML smart card PIN dialog before and after the change, check they're equal Change-Id: Ibce4d99d07016ef9437782ba528c7e3c2744b799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007647Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5546abd6b001..c533f76b91f8 git log 5546abd6b001..c533f76b91f8 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 phoglund@google.com Fix dev_server (method disappeared after recent refactoring). Created with: gclient setdep -r src/third_party/catapult@c533f76b91f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: sadrul@google.com Change-Id: I572b2fb36108b211152f423d7e168edd6100a30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011141Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e54bb9023e14..900f1f215dee Created with: gclient setdep -r src-internal@900f1f215dee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9dcf2b09d42b5a6cf056748bd7f77903b874eac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011128Reviewed-by:
-
Henrique Nakashima authored
Use SharedPreferencesManager consistently instead of SharedPreferences directly. Move the usages to methods in SigninPreferencesManager. Bug: 1022108, 1034960 Change-Id: I24b5d9f20d847e7c3c8573b0cd7e712e114e3d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988603 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#733433}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85de0bc72ef7..fa9410e8e8a6 git log 85de0bc72ef7..fa9410e8e8a6 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 aerotwist@chromium.org Updates Chromium builds Created with: gclient setdep -r src/third_party/devtools-frontend/src@fa9410e8e8a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id92393c4f6cbc78217e772660cb3378b25e3a426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011140Reviewed-by:
-
Oleg Davydov authored
This commit does the following changes in order to better collect data about content verification, detection of extension corruptions and reinstalling corrupted policy-based extensions: * Extensions.ContentVerification.ComputeHashesOnInstallResult. A new histogram which collects success rate of computing hashes (required for content verification) during installation. Not collected when hashes were not computed. * Extensions.ContentVerification.ComputeHashesOnInstallTime. A new histogram which collects time spent on computing hashes, if it was successful. * Extensions.CorruptPolicyExtensionDetected3. An upgrade of previous version of this histogram, now it collects not only number of extensions scheduled for reinstall, but also a brief information about decision: was it extension from Chrome Web Store or not, or was it just an extension without hashes, so we need to reinstall it to compute ones. Note that corruption detection for off-store extensions is not enabled yet. So these histograms are mostly unused by now, but will be in the future. Bug: 958794 Change-Id: Idc38de1300204cafe00210507519ebaf20c2057e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998401 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#733431}
-
Jonathan Backer authored
Change-Id: Ia4c19af1a17a3938fba396253e989aefc6495789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976554 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#733430}
-
Dave Tapuska authored
The gfx types can be used natively inside blink so we don't need to typemap them. This will allow us to progressively remove the platform types. BUG=640049 Change-Id: I028e4f4c6cd806661bbc74078e0a0d0c91609a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007279Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1042208 Change-Id: I0b00fde7e51ad9084d8bf00e1113137260971556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007587 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733428}
-
Stepan Khapugin authored
Reparents signinInteractionCooordinator and cleans up guts interfaces. Note the new method in SceneControllerGuts that allows MC to cleanup a SC before shutdown. I think this is fine at least temporarily, but we need to iron out how this happens in iOS 12 compat in the future. Bug: none Change-Id: Ie214b60b830548f1aaec56207298cdf6ba6ddd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007051 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Nina Satragno authored
Test is flaky, e.g.: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1958 TBR=csharrison@chromium.org Bug: 1043619 Change-Id: I1a3356592a50c3cb3018bd0a490547188f0c1137 No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011164Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1042208 Change-Id: I5e7941be37469d17ae0610fb475ae10533cd79f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010788 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Ewann authored
- Replaces UIDocumentInteractionController by UIActivityViewController to allow custom actions. - Adds @OpenDownloadsFolderActivity. - Adds eg2 tests. Bug: 1013572 Change-Id: I29b74036151b5206ee99f2deb311046d1aaf6eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884550 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#733424}
-
