GitLab

Creates a new helper function to extract search terms from the URL irrespective of the availability of InstantExtendedEnabledParam. 

Previously, InstantSearchPrerenderer invoked chrome::GetSearchTermsFromURL() to extract search terms from the search page url. chrome::GetSearchTermsFromURL() returns a valid non-empty string iff the url has an InstantExtendedEnabledParam("&espv"). If the query extraction is turned off, the search request url will not have an InstantExtendedEnabledParam. In those cases, chrome::GetSearchTermsFromURL() returns an empty string to the InstantSearchPrerenderer.

To extract search terms for InstantSearchPrerenderer, we should not depend on the query extraction flag or the Instant support state of the page.

Follow up of crrev.com/151813002.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/141893009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251234 0039d316-1c4b-4281-b951-d872f2087c98

BUG=256870

Review URL: https://codereview.chromium.org/165063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341941,94925
TBR=vclarke@chromium.org

Review URL: https://codereview.chromium.org/165803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251232 0039d316-1c4b-4281-b951-d872f2087c98

This file is being added to the Chromium repo and removed from the NaCl repo.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3787
TEST=NaCl SDK trybots
R=binji@chromium.org, bradnelson@google.com

Review URL: https://codereview.chromium.org/164323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251230 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId. (https://codereview.chromium.org/150003004/)

Reason for revert:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GTK%20Builder/builds/497

Original issue's description:
> Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId.
> 
> The functionality is the same, just moving the code to a new place.
> 
> NOTRY=True
> BUG=333995
> R=bauerb@chromium.org, brettw@chromium.org, joaodasilva@chromium.org, nhiroki@chromium.org, noms@chromium.org, rlarocque@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251221

TBR=joaodasilva@chromium.org,noms@chromium.org,bauerb@chromium.org,rlarocque@chromium.org,sky@chromium.org,nhiroki@chromium.org,brettw@chromium.org,rogerta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=333995

Review URL: https://codereview.chromium.org/165543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251228 0039d316-1c4b-4281-b951-d872f2087c98

Test that the expected languages and keyboard layouts are available in the
OOBE network screen.

BUG=327034
R=nkostylev@chromium.org, achuith@chromium.org

Review URL: https://codereview.chromium.org/153473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251227 0039d316-1c4b-4281-b951-d872f2087c98

Add a missing break statement in developer_private_api.cc (I'm actually shocked
this didn't cause runtime errors).

TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/163863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251226 0039d316-1c4b-4281-b951-d872f2087c98

We guard all calls to AppendNativeEventMask with X11 platform checks.
It appends native masks and are defined only on X11 platform. This CL
adds the missing check in AppendNativeEventMask.

Review URL: https://codereview.chromium.org/164223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343580
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/163233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251224 0039d316-1c4b-4281-b951-d872f2087c98

It is an unused class from back when we thought we may want to have
multi-account support in the devices page.

BUG=

Review URL: https://codereview.chromium.org/163943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251223 0039d316-1c4b-4281-b951-d872f2087c98

R=benwells@chromium.org
BUG=332115

Review URL: https://codereview.chromium.org/152143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251222 0039d316-1c4b-4281-b951-d872f2087c98

The functionality is the same, just moving the code to a new place.

NOTRY=True
BUG=333995
R=bauerb@chromium.org, brettw@chromium.org, joaodasilva@chromium.org, nhiroki@chromium.org, noms@chromium.org, rlarocque@chromium.org

Review URL: https://codereview.chromium.org/150003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251221 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/165593002/)

Reason for revert:
https://chromium-review.googlesource.com/#/c/185937/ just got landed and this CL can go in now. 

Original issue's description:
> Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163793004/)
> 
> Reason for revert:
> https://chromium-review.googlesource.com/#/c/185937/ has to go in first. 
> 
> 
> Original issue's description:
> > Turn on icu_use_data_file_flag on CrOS
> > 
> > See also https://chromium-review.googlesource.com/#/c/185937/
> > 
> > The switch has to be turned on in two places (chromeos-chrome.ebuild and
> > build/common.gypi). One or the other can get landed separately, though.
> > 
> > BUG=72633
> > TEST=net_unittests:*IDN* and base_unittests:*String*
> > TBR=mark
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213
> 
> TBR=mark@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=72633
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251214

TBR=mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633

Review URL: https://codereview.chromium.org/164333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251220 0039d316-1c4b-4281-b951-d872f2087c98

1. Log IP address of the receiver in every message to help with debugging
2. Remove dependency on cast_channel_api.pb.h from cast_socket.h to avoid
   flaky build issue
3. Log lower priority messages at level 2

Review URL: https://codereview.chromium.org/160973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251219 0039d316-1c4b-4281-b951-d872f2087c98

Device enumeration code has been lifted from
src/chrome/browser/extensions/api/serial and moved into src/device/serial.

The enumeration impl for Linux now uses udev to enumerate devices matching the
"tty" subsystem, rather than matching /dev node name patterns.

The Windows implementation remains effectively unchanged, and the Mac
implementation has had its /dev pattern filter relaxed to catch devices of the
more generic forms "/dev/tty.*" and "/dev/cu.*".

BUG=334698

Review URL: https://codereview.chromium.org/158063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251218 0039d316-1c4b-4281-b951-d872f2087c98

> Fixes crashes wrt to the maximize button when:
> - A user hovers the minimize button with the mouse then taps the snap left / snap right button
> - When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment #6 in bug)
> 
> BUG=342867
> TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch
> 
> Review URL: https://codereview.chromium.org/160493004

Reverting as broke compile on windows:

[2431/3743] CXX
obj\chrome\browser\extensions\api\cast_channel\browser_extensions.cast_auth_util_nss.obj
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.maximize_bubble_controller.obj.rsp /c
..\..\ash\wm\caption_buttons\maximize_bubble_controller.cc
/Foobj\ash\wm\caption_buttons\ash.maximize_bubble_controller.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\ash.custom_frame_view_ash.obj.rsp /c
..\..\ash\wm\custom_frame_view_ash.cc
/Foobj\ash\wm\ash.custom_frame_view_ash.obj /Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.frame_caption_button_container_view.obj.rsp
/c ..\..\ash\wm\caption_buttons\frame_caption_button_container_view.cc
/Foobj\ash\wm\caption_buttons\ash.frame_caption_button_container_view.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.maximize_bubble_controller_bubble.obj.rsp
/c ..\..\ash\wm\caption_buttons\maximize_bubble_controller_bubble.cc
/Foobj\ash\wm\caption_buttons\ash.maximize_bubble_controller_bubble.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.frame_maximize_button.obj.rsp /c
..\..\ash\wm\caption_buttons\frame_maximize_button.cc
/Foobj\ash\wm\caption_buttons\ash.frame_maximize_button.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
ninja: build stopped: subcommand failed.

from: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/14916/steps/compile/logs/stdio#error1

TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/165283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251217 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
https://chromium-review.googlesource.com/#/c/185937/ has to go in first. 


Original issue's description:
> Turn on icu_use_data_file_flag on CrOS
> 
> See also https://chromium-review.googlesource.com/#/c/185937/
> 
> The switch has to be turned on in two places (chromeos-chrome.ebuild and
> build/common.gypi). One or the other can get landed separately, though.
> 
> BUG=72633
> TEST=net_unittests:*IDN* and base_unittests:*String*
> TBR=mark
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213

TBR=mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633

Review URL: https://codereview.chromium.org/165593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251214 0039d316-1c4b-4281-b951-d872f2087c98

See also https://chromium-review.googlesource.com/#/c/185937/

The switch has to be turned on in two places (chromeos-chrome.ebuild and
build/common.gypi). One or the other can get landed separately, though.

BUG=72633
TEST=net_unittests:*IDN* and base_unittests:*String*
TBR=mark

Review URL: https://codereview.chromium.org/163793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251213 0039d316-1c4b-4281-b951-d872f2087c98

This removes the global constructor call for std::string kEmptyString.

This is roughly an application of b/7549760 from the internal
version of protobuf.

Upstream patch here https://codereview.appspot.com/63480043/.

R=fischman@chromium.org
TBR=darin@chromium.org
BUG=341941,94925

Review URL: https://codereview.chromium.org/164743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155363
TEST=none
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/164653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251211 0039d316-1c4b-4281-b951-d872f2087c98

When running in single-process mode, e.g. during unit tests, the utility
process cannot terminate the process and instead closes its channel to trigger
cleanup.  Ending batchmode triggers process termination for the multi-process
mode, but does nothing during single-process mode, leading to test timeout.
This can be fixed by adding the single-process mode logic to the EndBatchMode
code path.

BUG=341935

Review URL: https://codereview.chromium.org/157783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251209 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/163833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251208 0039d316-1c4b-4281-b951-d872f2087c98

- easier to read
- safer since gpu::Mailbox is constant size and checked in the ParamTraits

BUG=None

Review URL: https://codereview.chromium.org/148003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251207 0039d316-1c4b-4281-b951-d872f2087c98

- A user hovers the minimize button with the mouse then taps the snap left / snap right button
- When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment #6 in bug)

BUG=342867
TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch

Review URL: https://codereview.chromium.org/160493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251206 0039d316-1c4b-4281-b951-d872f2087c98

This means no file can be opened for write during the test run.

R=csharp@chromium.org
NOTRY=true
BUG=116251

Review URL: https://codereview.chromium.org/163553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251205 0039d316-1c4b-4281-b951-d872f2087c98

QuicConnection never calls visitor_->OnConfigNegotiated.
OnConfigNegotiated is only called by QuicCryptoStream on QuicSession.

Merge internal CL: 61467714

Remove the unused server_config_id_ member from
QuicCryptoClientConfig::CachedState.

Merge internal CL: 61394953

R=rch@chromium.org,rtenneti@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/162493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251204 0039d316-1c4b-4281-b951-d872f2087c98

I think this got borked during a merge. Adding back.

TBR as this is same code as you reviewed.

BUG=341787
TEST=none
R=sadrul@chromium.org
TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/165473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251203 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251202 0039d316-1c4b-4281-b951-d872f2087c98

$ git log f9538eebbc..de4e7cfa --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2014-02-13 maruel Fix flaky test in run_test_cases_smoke_test.py.
2014-02-12 vapier@gentoo.org isolateserver: pull _PushState into module scope
2014-02-12 maruel Reduce code duplication to define the --isolate-server argument.
2014-02-09 maruel Add isolateserver.py hashtable which enforces paths vs isolateserver.py archive.
2014-02-09 maruel Adds primitive support to upload results back in run_isolated.py
2014-02-06 maruel Fix swarming.py to stop hardcoding the namespace to 'default'
2014-02-06 maruel Partially fix support for umask.
2014-02-05 vadimsh Improve --help output for OAuth command line options.
2014-02-05 vadimsh Command line option to switch auth to use file storage instead of keyring.
2014-02-04 maruel Fix examples that were broken since f9538eebbc82.
2014-02-04 maruel Fix googletest/README.py and improve doc.
2014-02-04 vadimsh Do not trigger OAuth2 code path when running on bots.
2014-02-03 maruel Disable test_crash_after_pass.
2014-02-02 vadimsh Never run interactive login in the middle of a script execution.
2014-01-31 vadimsh Remove google imports from httplib2.
2014-01-31 maruel Raise an error if --task-name is not provided.
2014-01-31 maruel Fix regression introduced in f9538eebbc82.

(Was slightly overdue)

R=csharp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/163853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251201 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251200 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167066:167110&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/164413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251199 0039d316-1c4b-4281-b951-d872f2087c98

    
Add Reykjavik, Oslo, Lisbon, Bucharest, Budapest, Ho Chi Minh, etc.
    
BUG=chrome-os-partner:23902
TEST=Added timezones show up in the zone selection  menu.
TBR=satorux

Review URL: https://codereview.chromium.org/161703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251198 0039d316-1c4b-4281-b951-d872f2087c98

This is reflecting the Views change made in r240444 and is specific to
the OriginChip being enabled.

BUG=315944
R=shess@chromium.org

Review URL: https://codereview.chromium.org/138983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251197 0039d316-1c4b-4281-b951-d872f2087c98

R=mkearney@chromium.org

Review URL: https://codereview.chromium.org/164813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251195 0039d316-1c4b-4281-b951-d872f2087c98

> Split out InputMethodMenuManager from InputMethodManager.
> 
> Rename input_method_property to input_method_menu_item, and move to ash/ime.
> 
> BUG=342336, 343044
> 
> Review URL: https://codereview.chromium.org/150203015

I'm reverting as test appears to be consistently failing:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/39558/steps/ash_unittests/logs/TestUninitializedGet

InputMethodMenuManagerTest.TestUninitializedGet (run #1):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (4 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #2):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (2 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #3):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (2 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #4):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (1 ms)

TBR=uekawa@chromium.org

Review URL: https://codereview.chromium.org/165453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251194 0039d316-1c4b-4281-b951-d872f2087c98

NetworkConnectionHandler::VerifyConfiguredAndConnect() did not
differentiate between the pre-shared key and certificate flow when
verifying the certificate properties of a L2TP/IPsec VPN connection
request. It always threw a 'configuration required' error and caused the
VPN configuration dialog to pop up even when all the credentials
information was available. This CL fixes this issue.

BUG=307665
TEST=Verified the following scenarios:
1. Add a 'L2TP/IPsec + pre-shared key' VPN with 'Save identity and
   password' unchecked. Connect to the VPN and then disconnect. Reconnect
   to the VPN and verify that it prompts for credentials.
2. Repeat 1 but with 'Save identity and password' checked and verify
   that it reconnects without prompting for credentials.

R=pneubeck@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/161083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251193 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326354
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/165373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251192 0039d316-1c4b-4281-b951-d872f2087c98

* Introduced WindowStateObserver::{Pre|Post}WindowShowTypeChange
 We had implicit dependency between OnWindowShowTypeChanged implementations. This clearly separate the things that should happen before and after the window's bounds is updated.

This is another step to introduce state machine.

BUG=318325
TEST=no functional change. all tests should pass.
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/149303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251191 0039d316-1c4b-4281-b951-d872f2087c98

Don't track mouse events in HWNDMessageHandler when they are forwarded by the LegacyRenderWidgetHostHWND class.

We use the TrackMouseEvent API in HWNDMessageHandler when we receive a WM_MOUSEMOVE message. This is to ensure that Windows sends us a WM_MOUSELEAVE
message when the cursor leaves our window bounds. Tooltips use this message to dismiss the tooltip for e.g.

Technically when the mouse enters the child window (LegacyRenderWidgetHostHWND) it has left the parent window. We end up getting WM_MOUSELEAVE messages
for WM_MOUSEMOVES which are sent to the parent window by the LegacyRenderWidgetHostHWND class causing tooltips to not show up and some other bugs.

Fixes as below:-
1. Add a special marker in the hiword of the WPARAM in WM_MOUSEMOVE messages sent by the LegacyRenderWidgetHostHWND class. This is to indicate to the parent
   that it should not track these mouse moves.
2. When we lose activation in HWNDMessageHandler we post a dummy WM_MOUSELEAVE message. This is enable tooltips if they were visible to be dismissed for e.g
   Based on code inspection a WM_MOUSELEAVE message should not cause any issues.
3. Forward WM_MOUSEWHEEL and WM_MOUSEHWHEEL messages via SendMessage to the parent without mucking with the parameters. The offsets are in screen coordinates in
   these messages.
4. Reposting events today fails when we click on the (LegacyRenderWidgetHostHWND) HWND. This is because the current code attempts to find an aura Window at the
   location which fails. I changed the RepostLocatedEvent function to allow a NULL window parameter on Windows. We attempt to forward the event to the HWND at the
   current location if it is on the same thread.

BUG=342323,342298,342299,341879,343246
R=cpu@chromium.org, sky@chromium.org, sky

Review URL: https://codereview.chromium.org/159713012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251190 0039d316-1c4b-4281-b951-d872f2087c98

This separates the frame-walking code from the appcache-setup code, allowing
the next Blink patch in this sequence to handle frame-walking on the Blink side.

BUG=343272
TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/161573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251187 0039d316-1c4b-4281-b951-d872f2087c98