- 26 Nov, 2019 15 commits
-
-
Tomasz Wiszkowski authored
This change ensures suggestions using BaseSuggestionView are using the light gray color as a tint color for suggestion fallback icons. Bug: 1027694 Change-Id: I073c019a57180843ce703abff16828ce9db74680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935029Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#718913}
-
Lan Wei authored
Because we can use pause action for touch points that do not move, but Devtool will generate a touch end event if we do not pass the paused touch point in the touch point list. https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/ input_handler.cc?type=cs&q=InputHandler::DispatchWebTouchEvent&g=0&l=825 Therefor, for the paused touch points that are not released, we should set type of touch move. Bug: 1020674 Change-Id: I01358b3534a8dde6b2651495034b9ad31a5f13ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933206Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#718912}
-
Kent Tamura authored
for timestamps obtained by FileUtilitiesHost. Bug: 1027959 Change-Id: Ib3c12e44b2fdeb028bcb6856943525425351e510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933838 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718911}
-
Chih-Yu Huang authored
The client of video decoder would pass the initial resolution when calling VideoDecoder::Initialize(). However, V4L2SVD could still get the resolution by AcceleratedVideoDecoder parsing the header. Therefore, V4L2SVD don't need to set the resolution at Initialize(). Moreover, at the next CL we will implement an adapter from VDA to VD. Setting the resolution at Initialize() cannot be fit with VDA api. This CL removes V4L2SVD setting resolution at Initialize(). Bug: b:136716838 Test: pass vda_tests on Kevin Change-Id: I7957bf23574ad47d3666f39b05371182f2b37301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923877Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718910}
-
Erik Staab authored
Bug: 1007791 Change-Id: Ia2eee33ff64d82c3a18abf217d1edc51a225363d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932236Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#718909}
-
Etienne Bergeron authored
The static method RectangleText::Elide(...) is only call once. There is no point to have a static method to abstract it. Follow up from: https://chromium-review.googlesource.com/c/chromium/src/+/1924882/ R=pkasting@chromium.org Bug: 1025561 Change-Id: I1aabb25116fbc2f709e442e909034bfc7c83c2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928791 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#718908}
-
David Tseng authored
Change-Id: I050e4fe94f3bcb3d9d4d01166a577998e1ec9fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931256 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#718907}
-
Tomasz Wiszkowski authored
This change ensures children with LayoutParams.height set to MATCH_PARENT are actually sized to match the height of BaseSuggestionView. Bug: 1027697 Change-Id: I89b0c40aa5246b0f4fa5c251bcb8a995caafc466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934836Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Also enabled ReturnToChromeTest on tablets as regression tests. Bug: 1027801 Change-Id: Ie73cea1eb4ab23e725b327442b80c657489f73c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931943Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718905}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c028b427175c..32d6c8d02436 git log c028b427175c..32d6c8d02436 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 egdaniel@google.com When wrapped, store ref to GrVkSecondaryCommandBuffer on GrVkRenderTarget. 2019-11-25 jvanverth@google.com Revert "Rename GLRTFBOIDIs0 to WrapsSwapchainSurface and use for Metal." 2019-11-25 michaelludwig@google.com Lift TextureSampler's proxy to SurfaceProxy 2019-11-25 csmartdalton@google.com Reland "Reland "Enable msaa ccpr on vulkan"" Created with: gclient setdep -r src/third_party/skia@32d6c8d02436 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Ic6173ae8459fb943504599d0c3cb2930e06e82fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718904}
-
Andrey Kosyakov authored
Bug: 1018108 This still retains a copy of protocol.json for compatibility with devtools front_end. Also, remove a presubmit for front-end compilation upon a change to PDL since the front-end is in another repository now. Change-Id: I2faea62feca80776d2fc0a0b4ea00a90439ae005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898538 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#718903}
-
Xiaocheng Hu authored
crrev.com/c/1922919 added a stylesheet sanitizer for clipboard, but left a loophole for SVGStyleElement. This patch also strips it. Bug: 1017871 Change-Id: Icc6c513f79597c191f732cd63a98cc59afe1fc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931412 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718902}
-
Wei Li authored
Add 'use_color_pipeline' build flag to enable building with color pipeline feature. Excluding color_unittests so it can continue running on buildbots without config changes. BUG=1003612 Change-Id: Ie90fe5da6671a0f0d3d0f93bdbb5dc1df8497ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928308Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#718901}
-
nancy authored
AppServiceAppModelBuilder is used to replace ExtensionAppModelBuilder. AppService integration to ui/app_list has been enabled for a couple of months, so it should be safe to remove ExtensionAppModelBuilder. ChromeAppIconWithModelTest.IconsTheSame unit test is removed, because we don't use ExtensionAppModelBuilder to load icon any more. ExtensionAppModelBuilderTest's unit tests are replaced to use AppServiceAppModelBuilder. A separate CL will be used to move ExtensionAppModelBuilderTest, CrostiniAppModelBuilderTest and InternalAppModelBuilderTest to src/chrome/browser/ui/app_list/app_service/ directory, then we can move the common functions, e.g. RemoveNonBuiltInApps, to app_service_test. Add PrefChangeRegistrar to ExtensionApps to handles profile prefs changes, the same as ExtensionAppModelBuilder. BUG=1016159 Change-Id: I03ae3aded435b8763444d9c6aea76d01b12ccb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928517Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718900}
-
Manu Cornet authored
Bug: 1011130 Change-Id: I4ac437f1e6e4bbfc831c50edb06359824b25bc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935039Reviewed-by:
-
- 25 Nov, 2019 25 commits
-
-
Fei Ling authored
Bug: 958627 Change-Id: I8c16b53dc62bc2aad8b70749a0d6f28d96d80e53 Fixed: 958627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934318 Commit-Queue: Fei Ling <feiling@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/15be5282e91b..6620506591b7 git log 15be5282e91b..6620506591b7 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e0dd604c..bdce3460 (718623:718772) Created with: gclient setdep -r src/third_party/webrtc@6620506591b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7cdc5f72e30c288e8b61944a14abfa3819430e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934693Reviewed-by:
-
Xiaocheng Hu authored
This reverts commit f6953a5e. Reason for revert: Manually destroyed the dummy page to ensure no leak Original change's description: > Revert "Sanitize style elements in clipboard markup" > > This reverts commit d96236b5. > > Reason for revert: This may cause "WebKit Linux Leak" failure > First failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/7276 > > Original change's description: > > Sanitize style elements in clipboard markup > > > > This patch sanitizes clipboard markup before pasting it into document > > by removing all pasted style elements and serializing them onto > > elements as inline style. In this way, we stop stylesheets in clipboard > > markup from being applied to the original elements in the document. > > > > This patch follows the same approach as in WebKit [1]: > > - First create a dummy document to insert the markup > > - Then computes style and layout in the dummy document > > - Re-serialize the dummy document as the markup to be inserted. This > > reuses the code path that we serialize a selection range into > > clipboard, where we need to serialize element computed style into > > inline styles so that the element styles are preserved. > > - Make sure all style elements are removed before inserting markup > > into document > > > > This patch also adds a complete test to ensure that content pasted from > > Excel is still properly styled, which is the main reason we used to > > preserve style elements in clipboard markup [2]. > > > > [1] https://trac.webkit.org/changeset/223440 > > [2] http://crbug.com/121163 > > > > Bug: 1017871 > > Change-Id: I3bb5a4ae7530a3fdef5ba251975e004857c06f1e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922919 > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718281} > > TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1017871, 1027386 > Change-Id: I1d500647d6227c9be3ae14d9604ba702e9c29834 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933452 > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718778} TBR=yosin@chromium.org,tkent@chromium.org,zmin@chromium.org,xiaochengh@chromium.org Cq-Include-Trybots=luci.chromium.try:layout_test_leak_detection Bug: 1017871, 1027386 Change-Id: Ia56ee941979cad71e2bac06998c7ac417b4731bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934650Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#718896}
-
Sahel Sharify authored
This cl enables web based payment handlers on Android to notify the merchant about shipping address/option changes and wait for updated payment details. Bug: 984694 Change-Id: I2dec41e5d3b8b2a8628c9fa22ee1feb5e5a161fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932894 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718895}
-
Tao Bai authored
Related downstream change: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2172237 Binary-Size: all added code was from downstream, the size increase is expected. Bug: 951275 Change-Id: Ibf56135e2a7d2f437f167dc0cdb7761bce447e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922603Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#718894}
-
Ahmed Mehfooz authored
This change removes a previous feature which caused system priority notifications to pop back up even if the system tray was opened and closed. Bug: 1007031 Change-Id: Iddf1f233cd20c256db2a48adf025881bf511a717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929448 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
-
Jay Harris authored
The Cinnamon Desktop Environment requires file handlers to specify a %F argument to specify where file arguments should be placed. Other DEs (such as Plasma) don't have this restriction. The fix is to (conditionally) append a '%F' argument to the command line of web apps with file handlers. If the argument is added unconditionally all web apps will show up as options in the 'Choose Another App' dialog, which is undesirable. Bug: 1027994 Change-Id: I89f882c0854b3ee313fce6eea1845052a884c173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933683 Commit-Queue: Jay Harris <harrisjay@google.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#718892}
-
Ben Goldberger authored
Bug: 1027273 Change-Id: I86bd7a8ea15197bf31ebbc163897c5455f8823de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929648 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#718891}
-
nancy authored
Similar with AppServiceAppResult, AppServiceAppItem should use ChromeLauncherController's ActivateApp to activate apps, the same as ExtensionAppItem: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/extension_app_item.cc?q=ActivateApp&l=155&dr=C BUG=1026730 Change-Id: I28fd19df903422092052c1a33cb42682bbcf6560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933856Reviewed-by:
-
Jonathan Ross authored
The root cause of the Intel AMD failures has been addressed. I'd like to try re-enabling this. TEST=context_lost tests ContextLost_WebGL2Blocked Bug: 1008125 Change-Id: I96ccdc26e0468a384810530e10c684738699a412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934689Reviewed-by:Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#718889}
-
Kevin McNee authored
Portal contents are restricted to http(s) schemes. Since the host contents may be adopted into a portal, it should be subject to this restriction as well. It may be that we end up allowing non-http(s) schemes to create portals, but have them be unadoptable, but for now it's simpler to use the same restriction. If we do weaken this restriction, we would still want to prevent portal creation in about:blank, since this is not useful and involves unnecessary complexity. Bug: 1008992 Change-Id: I297ec36341912247d0d96833c2a5b08bff9e255c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853905 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#718888}
-
Jeremy Roman authored
We're consistent about this elsewhere in chromium, and indeed elsewhere in many of these browser test files. Change-Id: Id05ac63ef4ac1c3983e38fc16ef5072966690724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934393 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Erik Chen authored
The test suite takes 27 minutes to run with only 40 seconds overhead. It's the slowest test suite on linux_chromium_asan_rel_ng, which causes long cycle times. Bug: 1028289 Change-Id: Ib82100928d89e29747a8794f62eccc09cf27aae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932475 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#718886}
-
Wenbin Zhang authored
Currently no bot can be found for linux-perf-fyi builder. The reason is that the only one linux device in the pool has the OS version as 'Ubuntu-14.04' However, while there's no specific os dimension value defined in perf_data_generator.py, a default value 'Ubuntu-16.04' from the infra was used to look for a bot. As as fix, we now specify the os value 'Ubuntu-14.04' in perf_data_generator.py so that it will override the default and be used to look for the correct bot. Bug: chromium:1027147 Change-Id: Ib59d881c9aceecf6a4aa6e3710bc3219f07b990c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931144 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718885}
-
Jesse Schettler authored
Update IsColorModelSelected() to check for all color modes. Change-Id: I61b4922e1ddb6b9a3f906b9122b1ca4f29c8272e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901835Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#718884}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e8f39ab95539..9f65850fd60b Created with: gclient setdep -r src-internal@9f65850fd60b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028032,chromium:None,chromium:None,chromium:1024586,chromium:1026286,chromium:None Tbr: jbudorick@google.com Change-Id: I365681c609fdbd9d133e249cabb07d065f6f56db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934690Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718883}
-
Tommy Li authored
This enables tabbing to the Remove Suggestion X button, and pressing Enter or Space to trigger it. This also shows the X for the selected row, in addition to any mouse-hovered rows. This also shows a blue focus ring for the X, when it gets the keyboard focus. That may not be the final UX design. Bug: 1205 Change-Id: I6e2e175841d293d81306cec86a11d60a77edfd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931581Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#718882}
-
Trent Apted authored
It had some layering workarounds in the past for cocoa, but it can now be a component for better code health. Bug: 828273 Change-Id: Iaa84cc4cdbb466ba696b7322e6f7f7d6ab914002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933827Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#718881}
-
Alex Newcomer authored
This CL disables a flag which controls a few features: - The shelf hotseat - Modular UI which shows in tablet mode, shows pinned and active apps. - In-app shelf - Smaller shelf in tablet mode. - Dense shelf in clamshell mode - Smaller shelf in clamshell mode for certain displays. Punting all of these feature to M-81! Bug: 1027343 Change-Id: I302523d7d1938c9166a0e61c07792d8d9c6a8439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929101 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#718880}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a9f2684b. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I48a228ec2adc830b3698931aa9ef622c35be7457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932093Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718879}
-
David Black authored
Extends ProactiveSuggestionsView as the implementation of the entry point that is shown when the new "show-rich-entry-point" feature param is enabled. Note that this view hosts embedded web content and is currently stubbed. Follow up CLs will: - Replace hard-coded HTML w/ server provided HTML. - Parameterize corner radius. - Handle navigation attempts. See bug for screenshots. Bug: b:145056104 Change-Id: I17be0951e707317b4903b185043c41f17deebe5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932463 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#718878}
-
Avi Drissman authored
This allows us to remove the use of a private API. Bug: 1027401 Change-Id: I1cd0e236fdb4ded2093a4120a0af326b57d9efd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929848 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#718877}
-
Daniel Murphy authored
This change does some renamings to match the terminology outlined here: https://chromium.googlesource.com/chromium/src/+/master/content/browser/indexed_db/docs/README.md It also adds more comments to the IndexedDBActiveBlobRegistry, and splits up the method MarkDeletedCheckIfUsed into: * MarkDatabaseDeletedAndCheckIfReferenced * MarkBlobInfoDeletedAndCheckIfReferenced and changes the following methods to be more accurate: * AddBlobRef -> MarkBlobActive * RemoveBlobRef -> MarkBlobInactive Future CLs will continue renaming parts of the system to match the new README. Work planning doc: https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?pli=1#heading=h.wwk24xdiduw5 R=enne@chromium.org Bug: 1027737, 1024966 Change-Id: I3f569bad802e64eee2ccf55cacafbb170f099d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912828 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718876}
-
Kevin Qin authored
XRVisibilityState is always visible when using the OpenXR backend. The visibility state from the runtime needs to be plumbed back to Blink/Javascript. Fixed: 1024032 Change-Id: I98bb2f3e5440b407dfff97a8799c3fecc15f7a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913578Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Zheng Qin <zheqi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718875}
-
Stuart Langley authored
Because the SMB provider does not react to prefs changes, the only way to test disabling Native SMB is to disable the pref and restart the browser test. To do this, introduce a derived FilesAppBrowserTest that uses PRE_ to support setting the SMB provider preference and then restart the browser for it to take effect. Bug: 1027966 Change-Id: I3e9199d4505be145de1eede0254bc1ecf0f8fe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933840Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#718874}
-
