- 15 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b93264e2b16b..c17c1dc0e795 git log b93264e2b16b..c17c1dc0e795 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 fmayer@google.com profiling: Include PIDs in heap dumps. Created with: gclient setdep -r src/third_party/perfetto@c17c1dc0e795 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I283fb20d9a326b05c00ef13d485487d823db184b Reviewed-on: https://chromium-review.googlesource.com/c/1337479Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608369}
-
Daniel Bratell authored
-Wno-null has been disabled for clang in chrome/browser/ui since 2015 but it seems to be enough to disable that warning for mac (the only platform that used clang by default in 2015). Bug: 383820 Change-Id: Iadc03f761c120db91fb806369ecf6f3bd8459c1c Reviewed-on: https://chromium-review.googlesource.com/c/982057 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#608368}
-
Stepan Khapugin authored
Adds gambard@ as OWNER of ntp_tile_views. Gambard is the original author of ntp tiles before they were moved to this folder. Change-Id: Ie93a894cc685e4a0d5783e417ed714ae29901b14 Reviewed-on: https://chromium-review.googlesource.com/c/1337505Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608367}
-
Yves Gerey authored
This reverts commit 6d582d18. Reason for revert: The leaks are not caused by WebRTC code, but merely revealed by the tests. We re-enable those tests: either the leaks have been fixed, or we'll add a suppression (less drastic than muting the whole WebRTC test suite). Original change's description: >Disable all WebRtcBrowserTests on ASan > >Many of these tests flakily leak and thus fail on ASan bots. > >TBR=phoglund@chromium.org > >Bug: 898546 >Change-Id: Icd3cc5dc3a46d0194c807c27b66f7eb902b35794 >Reviewed-on: https://chromium-review.googlesource.com/c/1299161 >Reviewed-by: Marc Treib <treib@chromium.org> >Commit-Queue: Marc Treib <treib@chromium.org> >Cr-Commit-Position: refs/heads/master@{#602745} Bug: chromium:898546 Change-Id: Idccff7827e6381e20060f7116cac75ee2b25018f Reviewed-on: https://chromium-review.googlesource.com/c/1337626Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#608366}
-
Anders Hartvoll Ruud authored
According to a recent spec edit, any fallback in a var()-reference must match the syntax of the referenced property, otherwise the var()-reference is invalid. This applies even if the fallback is not used. To implement this, ResolveFallback now returns kNone/kFail/kSuccess instead of a bool. This is necessary, because the kNone case may be both an error state and a success state, depending on whether the fallback is being used or not, hence a plain bool is not sufficient. R=futhark@chromium.org Bug: 641877 Change-Id: I951eef6335bf1cd4064d59959d73ec4fa39c9ee0 Reviewed-on: https://chromium-review.googlesource.com/c/1335576Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#608365}
-
Clemens Arbesser authored
It takes up space and is redundant, since the user can access more specific settings pages by tapping the edit/add buttons next to the payment methods and contact details. Bug: 806868 Change-Id: I0ac076930dc605102931bfe2c7d958aa4ad36c3a Reviewed-on: https://chromium-review.googlesource.com/c/1337503Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#608364}
-
Gauthier Ambard authored
This CL changes the state of the highlighted state of the location bar, to have it shaped like a pill, as the non-highlighted state. Bug: 905630 Change-Id: Ieeb5180d514b928c158ed2cd4f5b39cfde2b7aec Reviewed-on: https://chromium-review.googlesource.com/c/1337500Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#608363}
-
David 'Digit' Turner authored
Replaces two function calls by one at each trace macro call site. This should save about 12 kiB in 32-bit ARM libmonochrome.so BUG=898794 R=primiano@chromium.org,oysteine@chromium.org,alexiln@chromium.org Change-Id: Icf64644355b584dd5ff9910920df02930344f837 Reviewed-on: https://chromium-review.googlesource.com/c/1301913 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#608362}
-
edchin authored
External Search was added for an app that no longer exists. This feature has never been enabled. This CL cleans up dead code. Bug: 904616 Change-Id: Id7df06097ac2c5a598e7bc2f0f91657481de4a9c Reviewed-on: https://chromium-review.googlesource.com/c/1332689Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608361}
-
Koji Ishii authored
This patch enables fragment caching when BFC block offset changes, as long as 1) either the cached or new doesn't have floats, and 2) the cached fragment doesn't propagate OOF objects. The latter may not be needed, but helps to simplify. Minor but mostly positive improvements are seen in pinpoint: blink_perf.layout https://pinpoint-dot-chromeperf.appspot.com/job/13a7a7f7e40000 loading.desktop https://pinpoint-dot-chromeperf.appspot.com/job/17a7a7f7e40000 2 block fragmentation tests fail with this change that this change is not enabled for block fragmentation for now. * virtual/layout_ng_experimental/fast/multicol/balance-breakafter-before-nested-block.html * virtual/layout_ng_experimental/fast/multicol/dynamic/spanner-becomes-regular-block.html Bug: 635619 Change-Id: I46826b45defd556c8dadbf861fb1bbf61c5ae658 Reviewed-on: https://chromium-review.googlesource.com/c/1335072 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#608360}
-
Erik Chen authored
A previous CL: https://chromium-review.googlesource.com/c/1333877 commented out an assert to allow default fallback to the local toolchain, but failed to update the subsequent conditional correctly. Bug: 904400 Change-Id: I8d299e60645db4821dbb79c45b57ac1c01767d57 Reviewed-on: https://chromium-review.googlesource.com/c/1335949 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
arthursonzogni authored
Flaky test: org.chromium.chrome.browser.payments.PaymentRequestPaymentAppTest#testPayViaDelayedSlowBobPay TBR=rouslan@chromium.org Bug: 769851 Change-Id: Ic9ea6a0ddd72055145fb2e738744f0d60a13df40 Reviewed-on: https://chromium-review.googlesource.com/c/1337502Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608358}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/659370e71be5..a59368241b0c Created with: gclient setdep -r src-internal@a59368241b0c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic65cb6a4973f5266810dc2531c95883dc46f90c4 Reviewed-on: https://chromium-review.googlesource.com/c/1337478Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608357}
-
Xianzhu Wang authored
Change-Id: I60a46974819d536c0f178cb2ee23ee50951982f2 Reviewed-on: https://chromium-review.googlesource.com/c/1337135Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608356}
-
David Jean authored
Also added use of cell utils in manual_fill_card_cell. Bug: 845472 Change-Id: Ie015a2335c3cfe37f34620e2efb1447b8429d3c1 Reviewed-on: https://chromium-review.googlesource.com/c/1335550 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#608355}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a859d41366c6..95140715009f git log a859d41366c6..95140715009f --date=short --no-merges --format='%ad %ae %s' 2018-11-15 magjed@webrtc.org Android: Support externally aligned timestamps 2018-11-15 srte@webrtc.org Adds OWNERS to rtc_base/experiments. 2018-11-15 jonasolsson@webrtc.org Add android bindings for PeerConnectionState. 2018-11-15 jonasolsson@webrtc.org Add ios bindings for PeerConnectionState. 2018-11-15 nisse@webrtc.org Make member internal::SynchronousMethodCall::e_ a non-pointer. Created with: gclient setdep -r src/third_party/webrtc@95140715009f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8686709667989fa57176c8bee3410bd35c2eb12b Reviewed-on: https://chromium-review.googlesource.com/c/1337476Reviewed-by:
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. Bug: 884159 Change-Id: I31374ece7bf1d6c8b72f8c894e1d9b9a5660d18f Reviewed-on: https://chromium-review.googlesource.com/c/1337495Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#608353}
-
Alexandre Frechette authored
The translate UI should not appear before the necessary information (i.e. source language) has been computed. This changes manual translations to block before the state is correct. Bug: 902803 Change-Id: I0d0549b5093774ae5b60dd0e18fd72fe7349f895 Reviewed-on: https://chromium-review.googlesource.com/c/1331688Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#608352}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de5944d2..14d42672 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I05b8d2401aece2afec0e95ba327672da68363812 Reviewed-on: https://chromium-review.googlesource.com/c/1337632Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608351}
-
Patrik Höglund authored
Missed mb_config.pyl in my previous CL. Bug: 877018 Change-Id: I897caf43b76190a8e59e07e99436f5b5e48f1b07 Tbr: jbudorick@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1337342Reviewed-by:
-
Elly Fong-Jones authored
php5 is unsupported, same as 10.13. Bug: 892187 Change-Id: I52bc19b4f6ea8408093b7fcc61f6fe5153c984fd Reviewed-on: https://chromium-review.googlesource.com/c/1335947Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#608349}
-
Vadym Doroshenko authored
Password form submission detection is based on heuristics. So it's ok, when submission is found multiple times for the same form. The function SetSubmittedFormIfIsManaged is called when a submission is detected. It might be that in call SetSubmittedFormIfIsManaged, the submitted form is invalid (eg. JavaScript removed all fields), but a previous call the submitted form was valid. Then NewPasswordFormManager should not override valid submitted form. This CL implements this. Bug: 905579, 831123 Change-Id: I5762ac98f951e941a462504aaf62ac9f60203b3e Reviewed-on: https://chromium-review.googlesource.com/c/1337616Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#608348}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/597e1587b4bf..69b44ee6a126 $ git log 597e1587b..69b44ee6a --date=short --no-merges --format='%ad %ae %s' 2018-11-15 cwallez BUILD.gn: Fix libdawn_native missing dep on its own headers 2018-11-14 cwallez Don't use shared libraries in the wire fuzzer. 2018-11-14 rharrison Set correct ASAN flags for SPIRV-cross fuzzers 2018-11-13 dneto README.md: Need pkg-config on Linux Created with: roll-dep src/third_party/dawn TBR=kainino@chromium.org Change-Id: I1cc0bd6efbca778f792004d9372eb78f9dae56fc Reviewed-on: https://chromium-review.googlesource.com/c/1337620Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#608347}
-
Mathias Carlen authored
- Update the status message with the PR prompt. - The progress bar should pulse when the PR is shown. R=arbesser@google.com Bug: 806868 Change-Id: I00e8ec07cc19c06bd13f49116955f0e09e422dd9 Reviewed-on: https://chromium-review.googlesource.com/c/1337494Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608346}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c52201b23b48..659370e71be5 Created with: gclient setdep -r src-internal@659370e71be5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I11f746791624b8dc36f4ec198d3e452b7719b951 Reviewed-on: https://chromium-review.googlesource.com/c/1337475Reviewed-by:
-
arthursonzogni authored
Disabled test: MultiprocessMessagePipeTestWithPeerSupport.ChannelPipesWithMultipleChildren TBR=rockot@chromium.org Bug: 905620 Change-Id: I228040b5c07a420beae202da43887c0db17d0e27 Reviewed-on: https://chromium-review.googlesource.com/c/1337619Reviewed-by:
-
Sergio Villar Senin authored
It used to call SiginManager::IsAuthenticated(). Replaced that call by IdentityManager::HasPrimaryAccount(). Bug: 890822 Change-Id: If6e24c69db6f4634a5f96110ad9ca590b6d74d45 Reviewed-on: https://chromium-review.googlesource.com/c/1329677Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#608343}
-
Rohit Rao authored
This is the //web counterpart to https://codereview.chromium.org/2558943002. BUG=826465 Change-Id: I83e09e189ad0cbbdccaf9fa0de104efa7a6386a3 Reviewed-on: https://chromium-review.googlesource.com/c/1333898 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#608342}
-
Friedrich Horschig authored
Whenever the layout is invoked, check whether the available content area falls below 80dp (doesn't include height of accessory). If that condition is met, hide the accessory. This ensures that the accessory doesn't consume all screen space that is left on small devices, or large keyboards in horizontal mode. Bug: 903841 Change-Id: I9a6ea1dfea61353206edaab4f2d5567b830b6f24 Reviewed-on: https://chromium-review.googlesource.com/c/1333753 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#608341}
-
Alessio Bazzica authored
Bug: webrtc:7494 Change-Id: I5b69192aa4e1a3eaed9df041334619af857ed640 Reviewed-on: https://chromium-review.googlesource.com/c/1337337Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#608340}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb3ab7dd. With Chromium commits locally applied on WPT: f482e77e "Add report-only mode to Feature Policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I4e18a6392c5b92af2f5a92596cb448c4740eed09 Reviewed-on: https://chromium-review.googlesource.com/c/1337629 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608339}
-
Peng Huang authored
RatserDecoder uses Skia to do rendering, and skia can restore indexed uniform buffer, So we don't need maintain and restore it in RasterDecoder. Bug: 902904 Change-Id: I234611646625a412d65bd632011ddd8e6647ca51 Reviewed-on: https://chromium-review.googlesource.com/c/1335733Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#608338}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7af4ac893721..a859d41366c6 git log 7af4ac893721..a859d41366c6 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 mbonadei@webrtc.org Increasing visibility of api/transport build targets. 2018-11-15 nisse@webrtc.org Change ReceiveStatistics to implement RtpPacketSinkInterface, part 2. Created with: gclient setdep -r src/third_party/webrtc@a859d41366c6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id19625aa455261499f0c3b045acb79939c44e295 Reviewed-on: https://chromium-review.googlesource.com/c/1337474Reviewed-by:
-
Gauthier Ambard authored
This CL updates the chrome matchers and actions functions to be compatible with the new type of cells in the Settings. Bug: 894791 Change-Id: I10d899a3e4946b9e171bdf8909d10ce0f50c8b2a Reviewed-on: https://chromium-review.googlesource.com/c/1333368 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#608336}
-
Hongjun Choi authored
Implement BluetoothLowEnergyDeviceMac::IsPaired()[1] by watching system property list file and storing set of device identifiers and device address which can be used to construct IOBluetoothDevice[2] object as specified in the design doc[3]. [1]: https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_device.h?type=cs&q=IsPaired&sq=package:chromium&g=0&l=262 [2]: https://developer.apple.com/documentation/iobluetooth/iobluetoothdevice?language=objc [3]: go/ispaired-macos-ble Bug: 901681 Change-Id: I606f706db0f1557af099809b54c46da3308d0db2 Reviewed-on: https://chromium-review.googlesource.com/c/1307243 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#608335}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: I2f37b2310f16f0591e503929229eada33b3aec20 Reviewed-on: https://chromium-review.googlesource.com/c/1329244Reviewed-by:
-
Anders Hartvoll Ruud authored
We currently have a class CSSTestHelper which assists test cases in creating RuleSets. This is nice, but we need a place to put general CSS testing utils (not just for RuleSet) if we want to avoid repeating ourselves many times. This CL: * Moves CSSTestHelper to css_test_helpers::TestStyleSheet. * Deduplicates the almost-identical copies of RegisterProperty found in various test files. * Removes #include css_test_helper.h from some files which didn't really use CSSTestHelper. R=futhark@chromium.org Change-Id: I495f4ac33c9eda2ff087d73f45213acdc1852114 Reviewed-on: https://chromium-review.googlesource.com/c/1335562 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
-
Peng Huang authored
With SkiaRenderer and SkDD code path, we will check the resource format and texture format. If they don't match, SkiaRenderer will not be able to draw it. So pepper should set the transferable resource format correctly, Bug: 905407 Change-Id: I864d96bb2b82681c3864304be5d63cd4826049c1 Reviewed-on: https://chromium-review.googlesource.com/c/1336212Reviewed-by:
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script. There are 3 failing requests due to missing files which is also the case on the live page. R=perezju@chromium.org Bug: 878390 Change-Id: I0732f3b5907ba44bca81f1a772ee00aec3bb37b3 Reviewed-on: https://chromium-review.googlesource.com/c/1329664Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608331}
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. Bug: 884159 Change-Id: I27fb6303c8cf201d345c6c578dd80dd2582e1575 Reviewed-on: https://chromium-review.googlesource.com/c/1335595Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#608330}
-
