- 19 Oct, 2018 40 commits
-
-
Xi Cheng authored
Change-Id: I6a41db414e7e5e834e4d90e4debe55fc9cf2269c Reviewed-on: https://chromium-review.googlesource.com/c/1290514Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#601226}
-
Findit authored
This reverts commit 02cb80e6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 601194 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAyY2I4MGU2NzA1MmU1OWQzMjRhZTFmNzhkMmM5NGM2M2RhNTI5MzkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/23519 Sample Failed Step: content_browsertests Original change's description: > Implement fallback content for RemoteFrameOwner > > RemoteFrameOwner does not implement the logic for fallback content. This > means if a cross-origin navigation fails with some error, the owner > element (in this context, <object>) in the parent process does not get > notified and will not use its fallback content (instead the frame might > show an error page). > > When the <object> has fallback content, it should always use that over > the frame's error message. To support this matter, this CL implements > fallback methods in RemoteFrameOwner. Essentially, > > * When <object> creates a local frame, the corresponding frame tree > node will be marked as the type that "can" render fallback content. This > will propagte everywhere using FrameReplicationState. > > * When the provisional loading of a frame fails, RemoteFrameOwner will > notify the browser through the current proxy for navigation. The browser > then uses the parent frame to notify the renderer process that the owner > element should render its own fallback content. > > * If the <object> does not specify fallback, the navigation to error > page commits and the error page is shown. > > * When the <object> renders its own content, the remote frame stays > alive. This is a bug but not a new one; It will be fixed in future CLs. > > Bug: 853140 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: Icad3934ccfc1823c0cdecd8e1223e6370ea4b3bb > Reviewed-on: https://chromium-review.googlesource.com/c/1105635 > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Wei Li <weili@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601194} Change-Id: I82ae325ed780fb44d8a8a0205b70f9be8bedc60b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853140 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1291997 Cr-Commit-Position: refs/heads/master@{#601225}
-
Peter Boström authored
This keeps bookmarks-bar entries more aligned with Windows style. Bug: chromium:870158 Change-Id: I7a9e5a147cd9c12a1a5c5de58b40dfdd4c8eb0c9 Reviewed-on: https://chromium-review.googlesource.com/c/1284052Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601224}
-
Ben Pastene authored
Hopefully after crrev.com/i/701289 there's enough capacity this time. TBR=jbudorick, achuith Bug: 876494 Change-Id: I10e8fa31851c8ebd5f38bb233d66c5b0b47bbf29 Reviewed-on: https://chromium-review.googlesource.com/c/1291709Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#601223}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=miu@chromium.org Bug: 681136 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If7d9e65dd131693198a2df86716ba85b0b60ab91 Reviewed-on: https://chromium-review.googlesource.com/c/1288344 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#601222}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1f120c74ea2e..9ead811969b6 git log 1f120c74ea2e..9ead811969b6 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 tsepez@chromium.org Add static asserts for FPDFDOC_AACTION_* constants. Created with: gclient setdep -r src/third_party/pdfium@9ead811969b6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1be92fc79a1c523ddb1b50f81a8b7decb86af814 Reviewed-on: https://chromium-review.googlesource.com/c/1291752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601221}
-
Malay Keshav authored
This patch introduces a new PaintOp for Skottie objects. This PaintOp currently does not support serialization/deserialization. This is needed to move the rasterization of skottie onto the worker threads. This patch also introduces a new API in PaintCanvas to accept the new PaintOp. SkiaPaintCanvas Bug: 890224 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I989cafc066f1b43ee4d497a3fa204fc2a7fa90e0 Component: PaintOp, PaintCanvas, RecordPaintCanvas, Reviewed-on: https://chromium-review.googlesource.com/c/1278350 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#601220}
-
Vladimir Levin authored
This patch adds the ability to suspend and resume the context, which when suspended prevents future tasks from running. As of right now, the work isn't prevented from finishing since we don't have co-operative work implemented and nothing is preventing the rest of the system from processing the changes. Added tests, a few of which fail due to above reason. R=chrishtr@chromium.org Bug: 882633 Change-Id: I256be53b3cd0071405c9ac783fe78fcd36dacb9c Reviewed-on: https://chromium-review.googlesource.com/c/1289432Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601219}
-
Daniel Bratell authored
Until recently ios didn't use //ipc but //services/network needs some small parts of them. Some of the rest of the ipc code won't even link in ios since ios has no discarding some unused object files before noticing they referenced non-existing symbols. base: :WaitableEventWatcher. It's built so far thanks to the linker Change-Id: Ieaf3749e1b4f0d8f46f652248b839ae9e8650282 Reviewed-on: https://chromium-review.googlesource.com/c/1273498Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601218}
-
Victor Vasiliev authored
Merge internal change: 217702541 R=rch@chromium.org Change-Id: I7f79cc85a57bce8e5c0f819ee83296b30c917320 Reviewed-on: https://chromium-review.googlesource.com/c/1287072 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#601217}
-
Hirokazu Honda authored
Decoded pictures (i.e. yuv format) on h264, vp8 and vp9 must be identical on any platforms, except its pixel format and device alignment. VideoFrameValidator checks soundness of each decoded picture comparing its md5sum value with golden md5sum. VideoFrameMapper used by VideoFrameValidator map decoded pictures and converts them, by libyuv, to I420 picture to resolve pixel format and device alignment differences. This change is the first step for it. VideoFrameValidator would support non tiled buffers. BUG=chromium:856562 TEST=VDA unittest on h264, vp8 and vp9 with --frame_validator at veyron_minnie and kevin, $ ./video_decode_accelerator_unittest --test_video_data=test-25fps.vp8:320:240:250:250:35:150:11 --ozone-platform=gbm --gtest_filter=Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 --test_import --frame_validator Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iddd284bd47b2a5bb9921dc8d54f9d77ed694f5ad Reviewed-on: https://chromium-review.googlesource.com/c/1172266 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#601216}
-
Tim Volodine authored
Make sure to execute the WebViewClient.OnReceivedError callback in the Network Service case. Also update the test filter with the tests fixed by this patch. Tests fixed: - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testNonExistentAssetUrl - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testNonExistentResourceUrl - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testOnReceivedErrorOnInvalidUrl - org.chromium.android_webview.test.ClientOnReceivedError2Test.testNotCalledOnStopLoading - org.chromium.android_webview.test.ClientOnReceivedError2Test.testOnNonExistentAssetUrl - org.chromium.android_webview.test.ClientOnReceivedError2Test.testOnNonExistentResourceUrl - org.chromium.android_webview.test.ClientOnPageStartedTest.testOnPageStartedCalledOnceOnError In more detail in this patch: - add wiring for executing the onReceivedError callback - separate GetAwContentsClientBridgeFromID into a separate function BUG=893574,893573,893572,841556 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic674c13ba0aad9a7eedc32194bb6f3fa27ea3ad5 Reviewed-on: https://chromium-review.googlesource.com/c/1279171 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601215}
-
Toni Barzic authored
The CL adds test coverage for CrOSComponentInstaller::Load method. The tests set up fake components in a scoped test dir (containing only manifest files) which is used to override component paths provided by path service, and verify that Load requests load appropriate component, issue on demand update requests as expected, and issue requests to load the components to image loader service. The focus in this cl is to add tests for behavior used for loading demo-mode-resources component, but the set of tests can be expanded in the future. Change-Id: Ib4c2fab67492f1e62a3a1b3f1343139b9aa5baeb Reviewed-on: https://chromium-review.googlesource.com/c/1278635Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#601214}
-
Weidong Guo authored
This is a reland of ae60a134 Original change's description: > Disable blur for suggestion chip and folder icon in clamshell mode > > Changes: > 1. Destroy layer for suggestion chip in clamshell mode. > 2. Set blur to 0 for folder icon in clammshell mode. > 3. Avoid recreation of suggestion chip views after update. > > Bug: 896525 > Change-Id: I4cb84c06f5e0ed5a0cc70c0c2338028573bd7017 > Reviewed-on: https://chromium-review.googlesource.com/c/1287709 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600819} TBR=xiyuan@chromium.org Bug: 896525 Change-Id: Idd17312d89e759f65a7f4fb5db125f89b96bd9af Reviewed-on: https://chromium-review.googlesource.com/c/1290133 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601213}
-
Kyle Milka authored
Before saving a custom background url to user prefs verify that it's a valid url returned by the Backdrop service. Bug: 851220 Change-Id: Iaa196ed2466499da0a0832c2d1ba7ed1d299b56b Reviewed-on: https://chromium-review.googlesource.com/c/1282222 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601212}
-
Joe Downing authored
TBR=npm@chromium.org Bug: 896765 Change-Id: I39b4ece08f31a24ae8536f3c5e4e8fe380073f7b Reviewed-on: https://chromium-review.googlesource.com/c/1291712 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#601211}
-
Antonio Gomes authored
BUG=890779 Change-Id: I8f79d3a8502fc693ad58b37012992b4e8864022a Reviewed-on: https://chromium-review.googlesource.com/c/1291250 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#601210}
-
Joe Downing authored
TBR=miu@chromium.org BUG=895120 Change-Id: Ic09e5a5721400d1c595d4b2414b5034792793ddf Reviewed-on: https://chromium-review.googlesource.com/c/1291771Reviewed-by:
-
Joe Downing authored
TBR=michaelpg@chromium.org Bug=876971 Change-Id: I9eb48bb962ff2752d8c3b712df0c0c2925705b1f Reviewed-on: https://chromium-review.googlesource.com/c/1291774Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4bcf107ea529..b026043a43f9 git log 4bcf107ea529..b026043a43f9 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 taylori@google.com Import perfetto json traces Created with: gclient setdep -r src/third_party/catapult@b026043a43f9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8d9bd206ca5f251e31eb447b8a4e70d38d1ceb18 Reviewed-on: https://chromium-review.googlesource.com/c/1291164Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I906702293b16456ca8a6d7d7dc513590132233bc Reviewed-on: https://chromium-review.googlesource.com/c/1291789Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/67ebe3f7aebe..c5a6d259c2fb git log 67ebe3f7aebe..c5a6d259c2fb --date=short --no-merges --format='%ad %ae %s' 2018-10-19 stevenperron@google.com Increase the template nesting depth for clang. (#1995) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c5a6d259c2fb The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I943fb1eb4d69342d712ce27f9de78a67f6625c5f Reviewed-on: https://chromium-review.googlesource.com/c/1291163Reviewed-by:
-
Shawn Gallea authored
Removed ash dependencies within EXO BUILD.gn file to allow non-ChromeOS compilation. Bug: 896710 Test: Compiled client on ChromeOS and verified it still builds. Change-Id: I57b36c10ad55a609b7969f00b225abecd2f55fd9 Reviewed-on: https://chromium-review.googlesource.com/c/1288894Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#601204}
-
Kyle Milka authored
Remove the use-ddljson-api flag for forcing test doodles on the NTP. Allow forcing of doodles via the url param '?force-doodle=x', for x from 0 to 4. They can also (still) be forced via the command line flag. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibf9836baf2dd43114d85b3daf892c2745a30cb89 Reviewed-on: https://chromium-review.googlesource.com/c/1278952Reviewed-by:
-
Joe Downing authored
This reverts commit ba9595ea. Reason for revert: Suspected of causing persistent BrowsingDataRemoverBrowserTest failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932222237758099792/+/steps/browser_tests_on_Windows-10-15063/0/logs/BrowsingDataRemoverBrowserTest.SessionOnlyStorageRemoved/0 This failure started after this CL was checked in and appears to be in the same area of code. The failure is being seen on the Win10 Tests x64 builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/28682 Original change's description: > Cache Storage: Clear session-only origins on shutdown > > Bug: 824533,750452 > Change-Id: I103d6b6a3bd106a6a38de03f9ff14d2766c7b269 > Reviewed-on: https://chromium-review.googlesource.com/c/1288890 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ben Kelly <wanderview@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Commit-Queue: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601141} TBR=jsbell@chromium.org,jam@chromium.org,pwnall@chromium.org,wanderview@chromium.org Change-Id: Ia41455e70e5e89598fb1296cc539f143bda8295e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824533, 750452 Reviewed-on: https://chromium-review.googlesource.com/c/1291781Reviewed-by:
-
Scott Violet authored
It's flaky on ChromeOS as well. BUG=897058 TEST=test only change TBR=lukasza@chromium.org Change-Id: I11cc721b303a738d1c1b799170887b9b5aa67db6 Reviewed-on: https://chromium-review.googlesource.com/c/1291412Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601201}
-
Wei Li authored
Other than regular fullscreen state changes, there is one more change on Mac -- turning toolbar always on/off during browser fullscreen mode. In such case, we need to make sure 'Always Show Bookmarks Bar' should be enabled/disabled accordingly. This CL triggers browser command update during such transition. BUG=894004 Change-Id: Ia0a5fb358ca5238492cb8ffca957d10a849ded3c Reviewed-on: https://chromium-review.googlesource.com/c/1279410Reviewed-by:
Sidney San Martín <sdy@chromium.org> Reviewed-by:
-
Robert Ogden authored
With the new UI in the Omnibox, showing the UI after a sometimes significant delay whenever a lofi image is loadedis not a good user experience. This moves the decision to show the UI to commit time. Bug: 896476 Change-Id: I26b2ccaf9278435c3ccdfab508937d38fa64660c Reviewed-on: https://chromium-review.googlesource.com/c/1289086 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#601199}
-
Colin Blundell authored
A straightforward port of //chrome's Profile adaptor that will be used by //ios/chrome unittests that tied to the BrowserStateKeyedServiceFactory infrastructure. Bug: 895772 Change-Id: I61cd90a0fdcb494e661711ccfb8c2bdeb411193d Reviewed-on: https://chromium-review.googlesource.com/c/1290941 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#601198}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b8db890c4ee..ab631ca2c962 Created with: gclient setdep -r src-internal@ab631ca2c962 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6675ce867ca79e55ec1137c45fd07c4e4b715426 Reviewed-on: https://chromium-review.googlesource.com/c/1291161Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601197}
-
jdoerrie authored
This change implements base::flat_tree::contains(). This mirrors C++20, which introduces contains() to the associative containers in the STL. See P0458R2 [1] for further details. [1] http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0458r2.html Bug: 682254 Change-Id: I4af8ce4fadd4647f7021d374bee4316c110c277d Reviewed-on: https://chromium-review.googlesource.com/c/1288434Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#601196}
-
Robert Ma authored
This CL changes the behavior of the git_cl.py module to only specify the bucket if it's explicitly given to it. git cl will figure out the appropriate bucket to schedule tryjobs in. TBR=robertma@chromium.org Bug: 891729 Change-Id: Id1ed02d1a3cc3aca53710bf67a69e9da1c7a8a85 Reviewed-on: https://chromium-review.googlesource.com/c/1289694 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#601195}
-
Ehsan Karamad authored
RemoteFrameOwner does not implement the logic for fallback content. This means if a cross-origin navigation fails with some error, the owner element (in this context, <object>) in the parent process does not get notified and will not use its fallback content (instead the frame might show an error page). When the <object> has fallback content, it should always use that over the frame's error message. To support this matter, this CL implements fallback methods in RemoteFrameOwner. Essentially, * When <object> creates a local frame, the corresponding frame tree node will be marked as the type that "can" render fallback content. This will propagte everywhere using FrameReplicationState. * When the provisional loading of a frame fails, RemoteFrameOwner will notify the browser through the current proxy for navigation. The browser then uses the parent frame to notify the renderer process that the owner element should render its own fallback content. * If the <object> does not specify fallback, the navigation to error page commits and the error page is shown. * When the <object> renders its own content, the remote frame stays alive. This is a bug but not a new one; It will be fixed in future CLs. Bug: 853140 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icad3934ccfc1823c0cdecd8e1223e6370ea4b3bb Reviewed-on: https://chromium-review.googlesource.com/c/1105635 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601194}
-
Antoine Labour authored
For any given BufferFormat, there is a single internal format that it is compatible with (note, the converse isn't true), as defined by gpu::IsImageFormatCompatibleWithGpuMemoryBufferFormat. Rather than leaving guess-work to the client, instead expose it via a gpu::InternalFormatForGpuMemoryBufferFormat. This in turns simplifies quite a few things, and in particular we don't need to send redundant information in IPC (BufferFormat vs internalformat) that we then need to validate. Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I34a12c71c252ba2a5199f47ce983a02307df351b Reviewed-on: https://chromium-review.googlesource.com/c/1290192Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601193}
-
Ella Ge authored
Previous CL crrev.com/c/1279204 changed the touch adjustment bound to CSS pixel; however, kMaxAdjustmentSize is a bound on the finger size in case noisy drivers or errant touches causing degenerate hit-tests that hit too many elements. The bound should be in dip so it's corresponding to a physical size. Therefore, kMaxAdjustmentSize should be in unscaled dip, and we need to convert it to scaled physical pixel to compare with touch_area, which is in root frame coordinates (scaled physical pixel). Bug: 894961 Change-Id: Ib515e55fd027ba7c17db7488d872be82b91f954a Reviewed-on: https://chromium-review.googlesource.com/c/1287201 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601192}
-
Mike Wasserman authored
Changing behavior as requested, and updating tests: 1) The mute button should toggle mute (rename mojo function). 2) Volume up/down buttons should adjust up/down normally when muted. 3) Volume up/down buttons should also un-mute (if above default mute level). 4) Volume down will still mute if the level is below the default mute level. Bug: 895550, 895552 Change-Id: I353ab3124bb0375f109b96841cce6df3c9839388 Reviewed-on: https://chromium-review.googlesource.com/c/1289990 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Xida Chen authored
It looks like a previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/985100 which removes a un-used histogram, forgot to indent this part of code. This CL doesn't introduce any behavior change. TBR=enne@chromium.org Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6897c1116f8119c0e14c436e17d2c873d3228ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1291357 Commit-Queue: Xida Chen <xidachen@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601190}
-
Scott Violet authored
It's no longer used. BUG=895619 TEST=none Change-Id: I9f5c713988f8c5838bc99769cd418778c9e3aa5c Reviewed-on: https://chromium-review.googlesource.com/c/1285121Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
dpapad authored
Bug: 896585 Change-Id: Ifdb8e98e2f58e943dbf2e3ace265a5000757077d Reviewed-on: https://chromium-review.googlesource.com/c/1289155Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601188}
-
Aldo Culquicondor authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7d2dbc7816dca5ada17ca444c8c61093a86f6fb8 Reviewed-on: https://chromium-review.googlesource.com/c/1280605Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#601187}
-
