- 13 Aug, 2018 40 commits
-
-
Balazs Engedy authored
Bug: 849323 Change-Id: Ia5ed52ee21c634a018c8652f7dc3380673852956 Reviewed-on: https://chromium-review.googlesource.com/1169212Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582560}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/90f466a6cfab..35bc74d6d139 git log 90f466a6cfab..35bc74d6d139 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 jiawei.shao@intel.com ES31: Support atomic functions on D3D11 - Part II Created with: gclient setdep -r src/third_party/angle@35bc74d6d139 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ie8c92f0d6a30925e284276d25418b9ae83880193 Reviewed-on: https://chromium-review.googlesource.com/1172244Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582559}
-
Mohamed Amir Yosef authored
Since the BookmarkSyncServiceFactory doesn't start the BookmarkUndoService, it should use it only if it exists. This was the case already in non-ios factory. https://cs.chromium.org/chromium/src/chrome/browser/sync/bookmark_sync_service_factory.cc?l=38&rcl=46520ae13478333fe882e79041b667e5a3112796 However, by mistake, it was created in iOS factory which caused tests to fail here: https://chromium-review.googlesource.com/c/chromium/src/+/1052767 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5f205fa575773b3382b1e4c90ac4afa19d41d77a Reviewed-on: https://chromium-review.googlesource.com/1171231Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#582558}
-
Anders Hartvoll Ruud authored
R=futhark@chromium.org Bug: 641877 Change-Id: Ia249aedc2abe7f249c28ab57732edfaf6c552f2e Reviewed-on: https://chromium-review.googlesource.com/1172295Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#582557}
-
Mathieu Perreault authored
Receives the data from sync and puts it in the AutofillTable. Wires the getter/setters all the way to PersonalDataManager. Bug: 870936 Test: components_unittests Change-Id: Ic6f262e63e529f42d8f7225042f0a007273e7ab7 Reviewed-on: https://chromium-review.googlesource.com/1170847Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582556}
-
Jan Wilken Dörrie authored
This change restricts the usage of WriteWithoutResponse to macOS. On macOS this is required for performance reasons, but on other platforms this can lead to misbehavior. This results in requests not being handled correctly. Bug: 763303 Change-Id: I5b609fd70eafdf4b9abad680218a9e04ac302703 Reviewed-on: https://chromium-review.googlesource.com/1167515 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Fergal Daly authored
The parser currently yields every 500ms unless it encounters a script tag. We will experiment with different values and observe the impact. https://goo.gl/zwQWyW Change-Id: I1dcec74fb41e438393e505323707c00d76b49d15 Reviewed-on: https://chromium-review.googlesource.com/1148172 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#582554}
-
Vasilii Sukhanov authored
Bug: 869343 Change-Id: Ic3506c14a51fca41a8c5ee84587d5947976178df Reviewed-on: https://chromium-review.googlesource.com/1172343 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#582553}
-
Yi Su authored
Add a helper function that returns text for tabs count: (-inf, 0] => "" (0, 100) => "num" [100, +inf) => ":)" Bug: 835801 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ica4607b10dbd1f241d4e5a07c32128a1f4607db8 Reviewed-on: https://chromium-review.googlesource.com/1172297Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582552}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I93fc321f19c2721b1bcaaee706a22969154b3911 Reviewed-on: https://chromium-review.googlesource.com/1172349 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#582551}
-
Maja Kabus authored
HTML*Element href and src test files merged into two HTMLElement-generic test files. Bug: 739170 Change-Id: I3cf49c9d72540c7f51439fb157f1d201048a349e Reviewed-on: https://chromium-review.googlesource.com/1146567 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#582550}
-
Juan Antonio Navarro Perez authored
Test started failing on: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/23204 TBR=haraken@chromium.org Bug: 873580 Change-Id: If9c53d9e0e959dd7a390434c41d3a33d40f01c65 Reviewed-on: https://chromium-review.googlesource.com/1172345Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#582549}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/578bcf103a12..96b5e500909c $ git log 578bcf103..96b5e5009 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 bungeman * src/sfnt/sfobjs.c (sfnt_done_face): Fix memory leak (#54435). 2018-08-10 ramakrishnan.nikhil Minor formatting. 2018-08-10 wl * src/base/ftobjs.c (FT_Render_Glyph_Internal): Improve tracing. 2018-08-10 wl Fix clang warnings. 2018-08-09 apodtele [raster, smooth] Reinstate bitmap size limits. 2018-08-08 apodtele [pcf] Revert massive unsigning. 2018-08-08 wl [smooth] Improve tracing. 2018-08-08 wl Add internal functions `FT_Trace_Disable' and `FT_Trace_Enable'. 2018-08-08 wl Debugging improvements. 2018-08-08 apodtele [pcf] Massive unsigning (part 2). 2018-08-08 apodtele [pcf] Massive unsigning (part 1). 2018-08-07 apodtele * src/pcf/pcfread.c (pcf_get_bitmaps): Unsign `offsets' and `bitmapSizes'. 2018-08-06 wl More comment formattings. 2018-08-06 wl * devel/ftoption.h: Synchronize with main `ftoption.h'. 2018-08-06 apodtele [pcf] Use unsigned types. 2018-08-06 wl Minor comment formatting. 2018-08-05 wl * src/truetype/ttgload.c (compute_glyph_metrics): Fix overflow. 2018-08-04 wl Ditto. 2018-08-04 wl * src/truetype/ttinterp.c (opcode_name): Fix typos. 2018-08-04 wl Fix clang warnings. 2018-07-31 wl * src/cid/cidtoken.h: Handle `XUID' keyword. 2018-07-31 wl [cid] Trace PostScript dictionaries. 2018-07-31 wl Minor documentation improvement. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng Bug: chromium:777151,pdfium:1131 Change-Id: Ib958a34663b7c1fa9dbdf63b54ac51cc21d14eea PDFium-Issue: pdfium:1133 Reviewed-on: https://chromium-review.googlesource.com/1171575 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#582548}
-
Elad Alon authored
This is a reland of 94a8710d This is the second reland of the original CL (elaboration of initial fix approach follows below). The first fix did not work on the trybots (though it did locally); stopping all threads except the tests' main thread caused problems in other modules. This second CL takes a different approach, and uses a base::WeakPtr instead of base::Unretained(this) for tasks posted to the remote-bound manager. TBR=avi@chromium.org,pastarmovj@chromium.org Original change's description: > Reland "Support dynamic refresh of WebRtcEventLogCollectionAllowed policy" > > This is a reland of 7dae0f63 > > The original CL caused flakiness because, in production code, > WebRtcEventLogManager is torn down during Chrome shutdown, after > all threads other the the UI thread have quit. For unit tests, this > was not the case, and so the tests hit some use-after-destruction. > This was fixed by making the tests stop the non-UI threads before > tearing down WebRtcEventLogManager. > > Original change's description: > > Support dynamic refresh of WebRtcEventLogCollectionAllowed policy > > > > Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed: > > 1. If the policy was disabled before, and becomes enabled, > > subsequent calls to StartRemoteLogging() will succeed (barring > > unrelated issues), even for peer connections created while the > > policy was disabled. > > 2. If the policy was enabled before, and becomes disabled: > > a. Peer connections associated with the profile reject > > calls to StartRemoteLogging(). > > b. Active logs (associated with the profile) are stopped, > > and those log files deleted. > > c. Pending log files (associated with the profile) are deleted. > > d. If a log file associated with the relevant profile is > > currently being uploaded, the upload will be cancelled, > > and the file deleted. > > > > Bug: 775415 > > Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f > > Reviewed-on: https://chromium-review.googlesource.com/1162168 > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Elad Alon <eladalon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581167} > > TBR=guidou@chromium.org > > Bug: 775415 > Change-Id: Ie6070a8843012580c9a6c069f65c01b8d63525ff > Reviewed-on: https://chromium-review.googlesource.com/1168962 > Commit-Queue: Elad Alon <eladalon@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582162} Bug: 775415 Change-Id: Ib174ee3eb9d2a7bc1c5a329e497d8b6d1de02e35 Reviewed-on: https://chromium-review.googlesource.com/1171682 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#582547}
-
Vasilii Sukhanov authored
TBR=pkotwicz@chromium.org Bug: 872847 Change-Id: Iae5cb8c652618511101b6516c918ee723712fe64 Reviewed-on: https://chromium-review.googlesource.com/1169803 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#582546}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7ae70d8fb360..90f466a6cfab git log 7ae70d8fb360..90f466a6cfab --date=short --no-merges --format='%ad %ae %s' 2018-08-13 jie.a.chen@intel.com Suppress cast warnings for active textures mask 2018-08-13 oetuaho@nvidia.com Clean up varying linkage in D3D Created with: gclient setdep -r src/third_party/angle@90f466a6cfab The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I9c0f5acc04cbb6cea18a1010e836c3738d16a8db Reviewed-on: https://chromium-review.googlesource.com/1172243Reviewed-by:
-
Boris Sazonov authored
This CL disables Back button on the main consent bump screen. If SigninActivity is not in consent bump mode or there are entries in fragment manager back stack, Back button works as usual. Bug: 869426 Change-Id: Iec128e6cd01b9354f9da587da131a27776599c3d Reviewed-on: https://chromium-review.googlesource.com/1169605Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#582544}
-
Arthur Sonzogni authored
Currently, when a navigation is blocked by X-Frame-Options, the frame loads a blank page with an unique origin via the "data:," URL. Committing the real error page was not possible at that time. Mainly because of the interaction with the ChromeWebStore. See bug 622385. This CL removes the code preventing the renderer process to display the error page. Bug: 870815 Change-Id: I8d94f832791de019779679a7414371b6422e32fe Reviewed-on: https://chromium-review.googlesource.com/1163247 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#582543}
-
Fredrik Söderquist authored
These tests fail because of lack of support for references to general shapes from <textPath> and the 'side' attribute in <textPath>. crbug.com/366559 is the bug for supporting thos features, so redirect to it. Tests: external/wpt/svg/shapes/reftests/pathlength-003.svg external/wpt/svg/text/reftests/textpath-side-001.svg external/wpt/svg/text/reftests/textpath-shape-001.svg TBR=schenney@chromium.org BUG=366559,863355 Change-Id: Ia2fc56704fafd3ace0af949fceeaf2799f960fe7 Reviewed-on: https://chromium-review.googlesource.com/1172298Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582542}
-
Pavel Beloborodov authored
BUG=863008 Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9 R=bauerb@chromium.org,sky@chromium.org Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9 Reviewed-on: https://chromium-review.googlesource.com/1135137 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582541}
-
Rune Lillesveen authored
Was lost when introducing override in HTMLInputElement in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1072650 Bug: 871249 Change-Id: I9f33c88913dd00bf9f301b02fdb99bc43ecf82c6 Reviewed-on: https://chromium-review.googlesource.com/1172140Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#582540}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f4cf64ec0669..553b6f68e1dc git log f4cf64ec0669..553b6f68e1dc --date=short --no-merges --format='%ad %ae %s' 2018-08-13 buildbot@webrtc.org Roll chromium_revision f7e49bb7..690394a8 (582110:582511) Created with: gclient setdep -r src/third_party/webrtc@553b6f68e1dc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I526b9f0c1f8563f74e29eff9b79db812092aa7af Reviewed-on: https://chromium-review.googlesource.com/1172242Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582539}
-
Donna Wu authored
This CL moves the permission checking in UsbDevice implementation to WebUsbService by adjusting some mojo interfaces. BUG=699790 Change-Id: Ie5842f1a433a8b05275b06f31f25320bcc10a4d7 Reviewed-on: https://chromium-review.googlesource.com/1166592 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582538}
-
Vasilii Sukhanov authored
Bug: 791389 Change-Id: Iea3b6e0f2ec7899e099bd9d7e23017ac4c83e459 Reviewed-on: https://chromium-review.googlesource.com/1170908Reviewed-by:
-
Gauthier Ambard authored
This CL adds the animations for the presentation of the IdentityChooser. Bug: 873065 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id64905a5e11fcf64ed65860aabf988a01e17d837 Reviewed-on: https://chromium-review.googlesource.com/1170774 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582536}
-
Marc Treib authored
Sync would like to use one AccessTokenFetcher instance to fetch access tokens both for the primary account and for secondary accounts. For the primary account, they would like to wait for the refresh token to be available. In order to support this use case, AccessTokenFetcher needs a Mode parameter. This CL adds that Mode parameter. Note that this Mode parameter is *not identical* semantically to the Mode parameter of PrimaryAccountAccessTokenFetcher: the former's |kWaitUntilAvailable| mode makes an access token request once there is an account that is both (a) primary and (b) has a refresh token available, while the latter's new |kWaitUntilRefreshTokenAvailable| mode simply waits until there is a refresh token available for the given account (which may no longer be primary at that point, even if it was at the time of creating the AccessTokenFetcher). This semantic distinction is called out explicitly in the comments on PrimaryAccountAccessTokenFetcher::Mode. Sync has indicated that the AccessTokenFetcher semantics suffice for their use case. Bug: 840703, 729547 Change-Id: Iff39a24ef74945b3e9fa22ad961c3cd73a401e51 Reviewed-on: https://chromium-review.googlesource.com/1158831 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#582535}
-
Victor Costan authored
Switch from counting usage of the indexedDB property on the global object to counting indexedDB.open(). The former can get triggered by code that walks all global properties, while the latter is real IndexedDB usage. Change-Id: I36d003321ea0ca24a07034cbce89c33c39c67959 Reviewed-on: https://chromium-review.googlesource.com/1170392Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
Verifiy that all 'required' properties in a policy schema are actually existing in 'properties' as well. Bug: 856903 Test: components_unittests --gtest_filter=JSONSchemaValidator.* Change-Id: Ie8c3ff8ac82bcb3c436cfb580721070050b66b22 Reviewed-on: https://chromium-review.googlesource.com/1165361Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#582533}
-
Dominik Röttsches authored
Bug: 870379 Tbr: eae, behdad Change-Id: I89c78c4b5253706b5c8075576a53dd3791fcd4cf Reviewed-on: https://chromium-review.googlesource.com/1162229 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#582532}
-
Marcin Wiacek authored
Compilation settings: target_os="android" target_cpu="arm" enable_nacl=false symbol_level=0 remove_webcore_debug_symbols=true is_debug=false dcheck_always_on=false is_component_build=false use_jumbo_build=true Compilation error without patch: ./../../content/browser/font_unique_name_lookup/icu_fold_case_util.cc:7:19: error: using namespace directive in global context in header [-Werror,-Wheader-hygiene] using namespace ::icu_62; ^ Change-Id: Idd624fd0d5a14e49070c958a18a7e7136a14a659 Reviewed-on: https://chromium-review.googlesource.com/1172125 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: -
Gauthier Ambard authored
The Identity Chooser popup was using the MDC presentation style. It is not in line with the current style applied with UI Refresh. This CL creates the classes to be user to present the popup according to the new styling. For now, no animation or styling is done. Bug: 873065 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I73b93e0d47c7ebe2e2b5756faaf6fea32be63b3e Reviewed-on: https://chromium-review.googlesource.com/1169815Reviewed-by:
-
Gauthier Ambard authored
The ConsentBump should be displayed modally on iPhone+ landscape and iPad. Bug: 873128 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I96482c930ef1b6b94509e8aafd7b1691b76b2e28 Reviewed-on: https://chromium-review.googlesource.com/1170823Reviewed-by:
-
Makoto Shimazu authored
TBR=vitaliii@chromium.org NOTRY=true Bug: 873494 Change-Id: I1395c30a000ac7033b1e8711caac1132add2ad94 Reviewed-on: https://chromium-review.googlesource.com/1172265Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582528}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1a25c06cd15..87a737292804 git log f1a25c06cd15..87a737292804 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 7ae70d8fb360..a43d7306d87a (1 commits) Created with: gclient setdep -r src/third_party/skia@87a737292804 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I4e8aa819ddbb79f6ebecc336f11ceb6bdfee53f3 Reviewed-on: https://chromium-review.googlesource.com/1172107Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582527}
-
Ramin Halavati authored
A deprecated entry in annotations.xml is corrected. Change-Id: I8d77e73602c4050fbfdf3defd9a4b72f5fc705fa TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1172130Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582526}
-
Lutz Justen authored
During signin, the cryptohome migration flag is automatically set for Active Directory user accounts, which makes their cryptohome id switch from email to account id key. This is problematic for tests that populate policy before signin by sending policy to Session Manager since the policy is 'addressed' using the cryptohome id, see e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1145319/2/chrome/browser/chromeos/policy/affiliation_test_helper.cc#122 In a nutshell, policy is stored using the email address, but later loaded using the account id key. To resolve this, ACTIVE_DIRECTORY now always uses the account id key as cryptohome id. This fixes the issue and should make the code more robust. BUG=chromium:839352 TEST=Verified that the hack in the CL above isn't necessary anymore. Change-Id: I3ecb378aac08fc8dc5374e7bc170a9eb2c96741d Reviewed-on: https://chromium-review.googlesource.com/1055509Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#582525}
-
Kyoko Muto authored
As the first step of implementing "Imperative Shadow DOM Distribution API", this CL makes element.attachShadow take an optional parameter, |slotting|, which should be 'manual' or 'auto'. This CL also introduces new Runtime flag, ManualSlotting, to guard the new feature. BUG=869308 Change-Id: I71b115886c07c0090bef16b66da48c88e723a622 Reviewed-on: https://chromium-review.googlesource.com/1166767 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#582524}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/62dc9deeea75..8d8a9d7701bd git log 62dc9deeea75..8d8a9d7701bd --date=short --no-merges --format='%ad %ae %s' 2018-08-13 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8d8a9d7701bd The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I886dcabc2d0d391328bd566aa68c2f50615e1a24 Reviewed-on: https://chromium-review.googlesource.com/1172105Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582523}
-
Makoto Shimazu authored
This reverts commit fe36308d. Reason for revert: OfflinePageBridgeTest.testGetLoadUrlParamsForOpeningMhtmlFileUrl seems failing. This is the only CL relevant to offline pages, so let me revert this speculatively. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest%23testGetLoadUrlParamsForOpeningMhtmlFileUrl Original change's description: > Report different UMA enums when clicking async download notification > > Currently it is reported as "Download Home". We now add the logic > to separate it out, together with the case that clicking from progress > bar. > > Bug: 869692 > Change-Id: I9f2fcbbac20da9cf23176a00505fe10d04136b2f > Tbr: dgn@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/1157644 > Commit-Queue: Jian Li <jianli@chromium.org> > Reviewed-by: Dmitry Titov <dimich@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581930} TBR=peter@chromium.org,dimich@chromium.org,jianli@chromium.org,qinmin@chromium.org,dgn@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869692 Change-Id: Ifaee7de7a978f3795a6cf701d4420aa04736b169 Reviewed-on: https://chromium-review.googlesource.com/1172182Reviewed-by:
-
Koji Ishii authored
This patch rebaselines 2 text failures that look good from a manual review of build 8803, and 5 removal that match to their base expectations. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0efe930ada47e46163be831d7814c50a132ba195 Reviewed-on: https://chromium-review.googlesource.com/1172231 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
