GitLab

Only consider the bundle_data target that are defined in the same
toolchain as the create_bundle target in order to allow creation
of multi-arch build using different toolchain.

BUG=603180

Review-Url: https://codereview.chromium.org/2121793003
Cr-Commit-Position: refs/heads/master@{#403832}

This was causing StartNotifySession to hang randomly.

Also adds some logging to make sure we know what's happening.

BUG=624745

Review-Url: https://codereview.chromium.org/2115953002
Cr-Commit-Position: refs/heads/master@{#403831}

This patch applies the same heuristic fix as break-word to break-all.

Since the switch to the complex path, r385693 fixed the performance and
correctness issue of break-word and break-all in common cases. However,
it also introduced a performance regression when a word is really long,
such as minimized JS.

This can be fixed by taking over the ShapeResult to the next lines as
Gecko does, but it will require larger overhaul of the line breaker and
need more time to bake.

As an interim fix, r387974 introduced a heuristic fix for break-word.
This patch applies the same heuristic to break-all.

This patch also revealed that the fix for crbug.com/603679 was not
correct. MidWordBreak must be recomputed when floats pushed the line
down and available width changed. This patch includes the fix.

BUG=622810, 603679

Review-Url: https://codereview.chromium.org/2077313002
Cr-Commit-Position: refs/heads/master@{#403830}

BUG=614594
R=yfriedman
TBR=peter

Review-Url: https://codereview.chromium.org/2119273002
Cr-Commit-Position: refs/heads/master@{#403829}

Sticky position constraints were being computed relative to the current scroll position which led to incorrect constraints when updated after the ancestor scroller had been scrolled. This fixes that as well as updating descendant layer positions after scroll to fix 606732.

BUG=606732
TEST=fast/css/sticky/sticky-clip-rel-child.html

Review-Url: https://codereview.chromium.org/2020103002
Cr-Commit-Position: refs/heads/master@{#403828}

Two finger scrolling doesn't happen if neither of the pointers has exceeded their slop regions.
The checking is needed to avoid a two finger tap happening after a scroll within slop region.
For scrolling with more than two fingers, slop region check is skipped, because the tap option
is not valid in those cases.

BUG=492185
TEST=GestureProviderTest.SlopRegionCheckOnScroll

Review-Url: https://codereview.chromium.org/2058723003
Cr-Commit-Position: refs/heads/master@{#403827}

These are no longer logged by the code.

These are really old and originally migrated from internal
histograms.xml here: https://chromiumcodereview.appspot.com/18628005

I confirmed those two histograms don't get tagged with any of those
suffixes in the current code.

BUG=none

Review-Url: https://codereview.chromium.org/2123013002
Cr-Commit-Position: refs/heads/master@{#403826}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e8b07bd8..3414d38b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2123823002
Cr-Commit-Position: refs/heads/master@{#403825}

Changing this assert to a CHECK which will re-introduce crashes
related to bug 542857, but will result in crash reports that
will allow us to understand how the DrawingBuffer got into
a bad state.

CL to be reverted before next branch point.

BUG=542857
TBR=kbr@chromium.org

Review-Url: https://codereview.chromium.org/2126603004
Cr-Commit-Position: refs/heads/master@{#403824}

Enable pointer event finch experiment on waterfall.

BUG=624546
R=rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2126663002
Cr-Commit-Position: refs/heads/master@{#403823}

This information will be necessary for generating gradle projects for
Android Studio.

BUG=620034

Review-Url: https://codereview.chromium.org/2124663002
Cr-Commit-Position: refs/heads/master@{#403822}

Isolated L shape means neighbor pixels doesn't have any edges continuing
current two edge, as follows;
  _                                   _
  X|          X|         |X          |X
              ¯¯         ¯¯
We don't want to blur an open geometry.

This CL fixes 2 WebGL conformance tests
https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-size-change.html
https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/copy-tex-image-and-sub-image-2d.html

Yang Gu checked all WebGL conformance tests are passed with CMAA.

BUG=535198
TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders"
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2120293002
Cr-Commit-Position: refs/heads/master@{#403821}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2ebd9e2f..e8b07bd8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2122923004
Cr-Commit-Position: refs/heads/master@{#403820}

importScripts is a sync API that runs on main thread. Using it on CW
will block the compositor thread on main which can lead to deallock in
the current Blink compositing architecture. So we should avoid it for
now.

TODO:
 - Find a way to throw if importScripts is used in CW. Current failure is
   subtle
 - Provide and alternative to synchronous importScripts. Note that async
   resource loading in already possible in workers thanks to fetch so we
   may be a able to leverage that.

BUG=624651
TEST=virtual/threaded/fast/compositorworker

Review-Url: https://codereview.chromium.org/2119383002
Cr-Commit-Position: refs/heads/master@{#403819}

BUG=621770

Review-Url: https://codereview.chromium.org/2113233002
Cr-Commit-Position: refs/heads/master@{#403818}

BUG=625613
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2124593002
Cr-Commit-Position: refs/heads/master@{#403817}

This CL:
- Makes calls to WebApkValidator#queryWebApkPackage() and
  WebApkValidator#findWebApkPackage() call WebApkValidator#isValidWebApk().
- Removes WebApkValidator#queryWebApkPackage() call from
  NotificationPlatformBridge#dispatchNotificationEvent(). The check is
  unnecessary because
  org.chromium.chrome.browser.notifications.NotificationService is not
  exported.

BUG=613024

Review-Url: https://codereview.chromium.org/2109033002
Cr-Commit-Position: refs/heads/master@{#403816}

I didn't get the changes done in time and we will land it in m54. This
change is itended to update the mesage in M53 release.

BUG=625854

Review-Url: https://codereview.chromium.org/2125693002
Cr-Commit-Position: refs/heads/master@{#403815}

SVGFEConvolveMatrixElement's 'targetX' or 'targetY' attribute depend on
'order' for their initial value. When updating the target value of
an instantiated FEConvolveMatrix, order would however not be considered,
instead using the initial value of the attribute (zero.)

Refactor the code a bit to make it easy to consider the correct initial
value even when updating an existing FEConvolveMatrix, introducing
new methods matrixOrder() and targetPoint(). Clean up and simplify
as appropriate.

This fixes the following tests:

 svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html
 svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html
 svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html
 svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html

with https://codereview.chromium.org/2104943005 applied.

BUG=231560

Review-Url: https://codereview.chromium.org/2124583002
Cr-Commit-Position: refs/heads/master@{#403814}

BUG=618235
R=dgozman

Review-Url: https://codereview.chromium.org/2103323006
Cr-Commit-Position: refs/heads/master@{#403813}

Add input injection for the rest of web platform
pointerevent tests.

BUG=612924

Review-Url: https://codereview.chromium.org/2056333002
Cr-Commit-Position: refs/heads/master@{#403812}

Specifically removing hover effects, adding missing focus effect.

BUG=621444
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2116023002
Cr-Commit-Position: refs/heads/master@{#403811}

Reviewed under https://codereview.chromium.org/2120363002/ but
since mustaq@ is OOO and I can't upload a patch to a change owned
by another user I need to upload it as a separate patch.

BUG=624546
TBR=pfeldman@chromium.org, mustaq@chromium.org, rbyers@chromium.org, rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2125733002
Cr-Commit-Position: refs/heads/master@{#403810}

Namely, I intend to use this to genererate build.gradle files.

BUG=620034

Review-Url: https://codereview.chromium.org/2121883002
Cr-Commit-Position: refs/heads/master@{#403809}

https://codereview.chromium.org/2045313002/ fixed the bug with dx --incremental
causing the DexLoaderTests to fail on partial rebuilds of chrome_public_test_apk

BUG=617935

Review-Url: https://codereview.chromium.org/2117413002
Cr-Commit-Position: refs/heads/master@{#403808}

TBR=magjed_chromium
BUG=

Review-Url: https://codereview.chromium.org/2122903004
Cr-Commit-Position: refs/heads/master@{#403807}

In order to optimize performance, GPU-accelerated canvases should
permanently switch out of accalerated mode as soon as
getImageData is called.  The cost of getImageData on the GPU is
so prohibitively high that it almost always outways the benefit
of acceleration.

This is the first time we implement a SW/GPU switch that can happen
after the first frame was presented, which may result in a small one
time glitch due to rendering engine discrepancies. Let's see if we get
any complaints about this.  If there are complaint, we may inhibit
the switch based on what kind of content was rendered to the canvas.

BUG=606688

Review-Url: https://codereview.chromium.org/2123623002
Cr-Commit-Position: refs/heads/master@{#403806}

It is possible now to mock the clock used in ui/events so it is
no longer necessary to have these individual mock tick clocks
for events.

BUG=614409

Review-Url: https://codereview.chromium.org/2100453002
Cr-Commit-Position: refs/heads/master@{#403805}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c3e989de9c0b..b3e03f627f8f

$ git log c3e989de9..b3e03f627 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2126633002
Cr-Commit-Position: refs/heads/master@{#403804}

BUG=622533

Review-Url: https://codereview.chromium.org/2111643004
Cr-Commit-Position: refs/heads/master@{#403803}

Currently the NTP header displays when the first card reaches the top of the screen, this was good when we have snap scrolling which has now been removed. The heading height will now increase and show from under the peeking card at a percent of the scroll when the card is peeking, the card will peek at the balance of the scroll value until the header is at max height and normal scroll will resume.

videos: https://drive.google.com/open?id=0B1IgAIJ9cgizY3AwUGJfRC1RVWc

BUG=624439

Review-Url: https://codereview.chromium.org/2120283003
Cr-Commit-Position: refs/heads/master@{#403802}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a29ae611..2ebd9e2f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2125703002
Cr-Commit-Position: refs/heads/master@{#403801}

Revert of Certificate Transparency DNS log client (patchset #28 id:570001 of https://codereview.chromium.org/2066553002/ )

Reason for revert:
Causing Win build failure:

https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2184

Original issue's description:
> Certificate Transparency DNS log client
>
> This can query CT logs over DNS, as defined by:
> https://github.com/google/certificate-transparency-rfcs/blob/master/dns/draft-ct-over-dns.md
>
> This is required for obtaining audit proofs, which will allow Chrome to verify
> that SCTs it receives are trustworthy and that logs are behaving correctly.
>
> BUG=612439
>
> Committed: https://crrev.com/59b6ea2217dbc10400b6a9d433ad13c91bb6b7c2
> Cr-Commit-Position: refs/heads/master@{#403798}

TBR=eranm@chromium.org,mmenke@chromium.org,jam@chromium.org,robpercival@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612439

Review-Url: https://codereview.chromium.org/2124873002
Cr-Commit-Position: refs/heads/master@{#403800}

Currently, the macros used for testing when draw properties need
updates always rebuild property trees. However, in cases where we
depend on information in property trees in order to decide whether
a draw property update is needed, rebuilding property trees can cause
us to test the wrong thing. This CL removes the automatic rebuilding
and makes callers responsible for rebuilding when needed.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2123793002
Cr-Commit-Position: refs/heads/master@{#403799}

This can query CT logs over DNS, as defined by:
https://github.com/google/certificate-transparency-rfcs/blob/master/dns/draft-ct-over-dns.md

This is required for obtaining audit proofs, which will allow Chrome to verify
that SCTs it receives are trustworthy and that logs are behaving correctly.

BUG=612439

Review-Url: https://codereview.chromium.org/2066553002
Cr-Commit-Position: refs/heads/master@{#403798}

BUG=595176

Review-Url: https://codereview.chromium.org/2117363002
Cr-Commit-Position: refs/heads/master@{#403797}

Reset surface_ in ArcCustomNotificationView when the underlying
ArcCustomNotificationItem is gone or the notification surface is
removed.

BUG=625220

Review-Url: https://codereview.chromium.org/2120593002
Cr-Commit-Position: refs/heads/master@{#403796}

This unbreaks GCC builds after https://codereview.chromium.org/2036403002

BUG=587025
TBR=lfg@chromium.org, dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2121953003
Cr-Commit-Position: refs/heads/master@{#403795}

Only the last --gtest_filter arg in the command line is used
(any previous instances are ignored), so simply appending the
command line won't work. Just specify the entire correct filter
for now.

BUG=

Review-Url: https://codereview.chromium.org/2115003002
Cr-Commit-Position: refs/heads/master@{#403794}

Cleaning up video-source-[load|moved|removed].html tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2116293004
Cr-Commit-Position: refs/heads/master@{#403793}