- 05 Sep, 2018 40 commits
-
-
Matthew Cary authored
Use the base::UnsafeSharedMemoryRegion constructor which avoids a mojo dependency. Several media tests are built without mojo support. Bug: 795291 Change-Id: If754e6111189e8944997550f00e3ed7ef9fde1c3 Reviewed-on: https://chromium-review.googlesource.com/1190243Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#588808}
-
Mugdha Lakhani authored
This adds the following metrics: BackgroundFetch.HasTitle BackgroundFetch.NumIcons BackgroundFetch.DownloadTotal BackgroundFetch.NumRequestsInFetch BackgroundFetch.DeniedDueToPermissions Bug: 877512 Change-Id: I939ae4fc8e7e4abc1b322be8a9e09f00b168419a Reviewed-on: https://chromium-review.googlesource.com/1193896Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#588807}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/70783e3968e7..120318a2482f git log 70783e3968e7..120318a2482f --date=short --no-merges --format='%ad %ae %s' 2018-09-05 anthonyalridge@google.com Rotate tick labels on x axis for bar charts. Created with: gclient setdep -r src/third_party/catapult@120318a2482f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I750e16a094efb5899a30dd86e3a3ec1eab23a5a8 Reviewed-on: https://chromium-review.googlesource.com/1205620Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588806}
-
Mathias Bynens authored
The test runner is `run_web_tests.py` (and not `run_webkit_tests.py`). This patch also makes smaller tweaks and improvements to the doc. Change-Id: I559cf54e98135f1fe90986e1cf06d140ca911918 Reviewed-on: https://chromium-review.googlesource.com/1203991 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588805}
-
Eriko Kurimoto authored
Ax tree is stored in tree data structure to change output format easily. Tree dump function is called with ChromeVox+D>T (dump tree). TreeDumper is created only when ChromeVox+D>T is detected. Bug: 877381 Change-Id: I6078661e7cbaea02ef8a1faa0d3a5c3606247b7e Reviewed-on: https://chromium-review.googlesource.com/1187853 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#588804}
-
Yoichi Osato authored
SelectionState is now only used by LayoutSelection and LayoutObject. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9e4fc99ee69f13a6aab57cc69e201d04d2b04bc8 Reviewed-on: https://chromium-review.googlesource.com/1205807Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#588803}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f215ae6ed0ce..74fda7147c1b git log f215ae6ed0ce..74fda7147c1b --date=short --no-merges --format='%ad %ae %s' 2018-09-05 dcheng@chromium.org [owners.py] require stricter naming conventions for file: includes Created with: gclient setdep -r src/third_party/depot_tools@74fda7147c1b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:801315 TBR=agable@chromium.org Change-Id: I91dee5ab9d4c5b0d83f4ae6669a475689f265e01 Reviewed-on: https://chromium-review.googlesource.com/1205617Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588802}
-
Arthur Hemery authored
Remaining usage of pending_navigation_params_ in renderer initiated navigations where it is always false. Bug: 789577 Change-Id: Ie8c214b01922f96f9bf3f8b5f6e6be4e82273bed Reviewed-on: https://chromium-review.googlesource.com/1189804Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#588801}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/2c8e6279a7bf..9789c75b1a6f $ git log 2c8e6279a..9789c75b1 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 wl More '...' vs. `...` fixes in API documentation. 2018-09-04 wl Make `/****...' comments in public headers uniformly end on column 77. 2018-09-03 apodtele * docs/DEBUG: s/trace_//. 2018-09-03 ramakrishnan.nikhil [docwriter] Don't break code snippets accross lines. 2018-09-03 wl include/freettype/config:*.*: Convert comments to Markdown syntax. 2018-09-03 wl */*: s/PSNames/psnames/. 2018-09-03 wl [sfnt] Fix heap buffer overflow in CPAL handling. 2018-09-01 wl Remove `FT_Outline_{New,Done}_Internal'. 2018-08-31 apodtele * src/base/ftobjs.c (ft_glyphslot_preset_bitmap): Check glyph format. 2018-08-31 prince.cherusker [errors] Refine the macro logic surrounding `FT_Error_String'. 2018-08-31 wl Whitespace. 2018-08-31 wl * src/base/ftdebug.c (FT_Throw): Restore missing `FT_UNUSED' calls. 2018-08-31 wl * src/base/ftdebug.c (FT_Throw): Reduce chattiness. 2018-08-31 wl Minor comments. 2018-08-31 wl Whitespace. 2018-08-31 wl Add link to OpenType's composite glyph description. 2018-08-31 wl * src/autofit/afhints.c (af_glyph_hints_reload): Add initialization. 2018-08-30 apodtele Consolidate bitmap presetting and size assessment. 2018-08-30 apodtele * src/base/ftobjs.c (ft_glyphslot_preset_bitmap): Correct mono. 2018-08-30 prince.cherusker [errors] Introduce a macro to control `FT_Error_String'. 2018-08-30 prince.cherusker [errors] Introduce `FT_Error_String'. 2018-08-30 wl [autofit] Trace `before' and `after' edges of strong points. 2018-08-30 wl Minor. 2018-08-30 apodtele [base] Overflow-resistant bitmap presetting. 2018-08-29 wl Doc fix. 2018-08-29 prince.cherusker Fix numeric overflows. 2018-08-29 wl ftoption.h: s/precendence/precedence/ in documentation (#54586). 2018-08-29 wl [cff] Fix handling of `roll' op in old engine. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1145 Change-Id: I5b11c49ad02a0919ea2de1162145c73994c388d3 Reviewed-on: https://chromium-review.googlesource.com/1204272 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#588800}
-
Arthur Sonzogni authored
The browser process is the sole responsible for shutting down its renderer processes. Surprisingly, there was some logic in the renderer process to request self shutdown. Previous CL disabled renderer process initiated shutdown. This CL removes associated logic to increment/decrement the reference counter. Bug: 873541, 609963, 535246 Change-Id: I06bc6670d84dcad597bf98eea6c3e07242f341b6 Reviewed-on: https://chromium-review.googlesource.com/1177748Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#588799}
-
Thomas Tangl authored
The explanation line "Google Chrome may use web services..." is removed from the Privacy & Security settings section when Unified Consent is enabled. Bug: 869683 Change-Id: Ic189edcc55a0c2bfc306d815e90fc78e6e09d087 Reviewed-on: https://chromium-review.googlesource.com/1204230Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#588798}
-
Fredrik Söderquist authored
This CL introduces a mechanism for handling "initial values" for SVG properties. The initial value is stored in a new |initial_value_storage_| field in SVGAnimatedPropertyBase. Subclasses that need to store an initial value - for many cases a default initialized object is sufficient - define what is stored in the allotted number of bits (and thus indirectly how many bits that are required.) The SetInitial method needs to be overloaded on the SVGPropertyBase subclasses that the SVGAnimatedProperty holds, and is responsible for resetting the value of the property (after "decoding" the value.) This CL adds an implementation of the above for SVGAnimatedLength. For this type, the initial value is stored as an index into a table of values. The 'fx' and 'fy' properties on SVGRadialGradientElement are updated to have their initial values be 50% (matches Gecko.) Bug: 225807, 474523 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ida144d6bed2d1946186e8fb3b3a0b9695ca81789 Reviewed-on: https://chromium-review.googlesource.com/1193822Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#588797}
-
Olivier Robin authored
Rename OnFormActivity -> FormActivityRegistered Rename DidSubmitDocument -> DocumentSubmitted Bug: 823285 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4b02df2eb26e7af88e35dc92f24310220a2e57b6 Reviewed-on: https://chromium-review.googlesource.com/1193856Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#588796}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I966cadf2a56fe70ca042e6cd1827592b0a00f40b Reviewed-on: https://chromium-review.googlesource.com/1205603 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588795}
-
David Roger authored
In the main settings page, there was no visible difference between the "sync paused" state and sync unrecoverable errors. This CL adds the distinction between the two. In people handler, allow opening the Sync settings in all cases when UnifiedConsent is enabled. Otherwise, it is not possible to reauthenticate to fix an actionable Sync error (because the reauthentication requires opening the sync settings, but they would instantly autoclose). In the toolbar menu, the error was not removed on signout, because the code was only checking for the internal sync errors and not for the signin state. Bug: 879503 Change-Id: I247dc3ca3cbf20e49177e1343a5e4db38aeb257e Reviewed-on: https://chromium-review.googlesource.com/1199592Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#588794}
-
Kunihiko Sakamoto authored
Before this patch, devtools message for OCSP verification error was just two integer status codes (OCSPVerifyResult and OCSPRevocationStatus enum values). This patch converts these status codes to developer-friendly error messages. Bug: 815024 Change-Id: Ide3593c61698f0bebe87f8c5ef7a8c69f55afebf Reviewed-on: https://chromium-review.googlesource.com/1205915Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Hugo Holgersson authored
Previously we used the *layout* viewport's rectangle to determine if a certain node was visible or not. Let's use the *visual* viewport instead. Now: A visible node is a node that intersects the visual viewport. This logic is used by spatnav to rule out offscreen focus candidates and an offscreen activeElement. When activeElement is offscreen, spatnav doesn't use it as its search origin; the search will start at an edge of the visual viewport instead. For consistency, I replaced all other uses of LayoutViewport() with GetScrollableArea() - even though fixing HasOffscreenRect() was enough to fix Issue 823227. Bug: 823227 Change-Id: I8a89cfc98d896998b899a5246f2c38e23fe0171b Reviewed-on: https://chromium-review.googlesource.com/1204094 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#588792}
-
Matt Falkenhagen authored
This reverts commit 0ee23351. Reason for revert: Top crash in canary and blocks dev release per bug 880021. Original change's description: > Count number of active touches in TouchActionFilter > > Right now we have a active_touch_in_progress_ to indicate whether there > is an active touch or not. It is true when we receive ACK for touch > start and false at touch end. > > From the current crash report, we are seeing multiple consecutive ack > for touch end, without any ack for touch start in between. > > This CL changes the active_touch_in_progress_ to num_of_active_touches_. > It is increased by one when we receive ack for touch start and decrease > by one at touch end. At touch end, we only reset touch action when this > number is zero. > > In theory, touch start and associated touch end should arrive in pair. > This CL does a DumpWithoutCrashing if this number is ever larger than > one. > > Bug: 851644 > Change-Id: I584f1aad56bf5bc5c08e20e3ae4ca36d5f9e3586 > Reviewed-on: https://chromium-review.googlesource.com/1196696 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587813} TBR=dtapuska@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 851644, 880021 Change-Id: I265b573cef100ff6210683e7f5ec01dfcb28ea9f Reviewed-on: https://chromium-review.googlesource.com/1205923Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#588791}
-
Kent Tamura authored
https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout Bug: 877104, 877300, 698165 Change-Id: I994550295c15f9b42273abc7d1b11f47dc0bb0c7 Reviewed-on: https://chromium-review.googlesource.com/1205917 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#588790}
-
Yutaka Hirano authored
On 301/302/303 redirect, we may change the request method to "GET". While that is done by net/ logic, we need to reset the body manually in CORSURLLoader for some cases. Bug: 870173 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id864729a8adaa29af52bc4e7d8c3455b57e2528c Reviewed-on: https://chromium-review.googlesource.com/1205974 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#588789}
-
arthursonzogni authored
Cause of revert: =============== A few MediaLauncherActivityTest don't run on the CQ. They were waiting on SeparateTaskCustomTabActivity to finish, but it is no more used. Original description: ===================== Remove SeparateTaskcustomTabActivity for Android version > L. Make SeparateTaskcustomTabActivity to be used only for Android version pre L. The part used for Android version >= L is merged into CustomTabActivity. This is a prerequisite for skipping the ChromeLauncherActivity and directly launch the CustomTabActivity. TBR=tedchoc@chromium.org R=lizeb@chromium.org Bug: 681559 Change-Id: I121241a2f43f62c346a24adb153649bec3b80af3 Reviewed-on: https://chromium-review.googlesource.com/1201845Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#588788}
-
Yutaka Hirano authored
- send-redirect-bogus-sync.htm is not failing any more. Remove the entries. - send-authentication-existing-session-manual.htm and send-authentication-prompt-2-manual.htm are listed in NeverFixTests. Move the virtual/outoblink-cors[-ns] entries to the file as well. Bug: 870173 Change-Id: I6c94bb6b3559727133b94a1915f0b8cc89705525 Reviewed-on: https://chromium-review.googlesource.com/1206052 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Valeriya Sinevich authored
Change-Id: I32ea66dcd6d7466573c0ed143038d9edb241ac86 Reviewed-on: https://chromium-review.googlesource.com/1199763 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#588786}
-
Samuel Huang authored
This reverts commit bde179ef. Reason for revert: http://crrev.com/880583 : The ASan LSan problems disappeared even before the revert was included, and once revert was included there were no extra fix. Therefore relanding the CL. Original change's description: > Revert "Implement script and style attr/elem CSP directives" > > This reverts commit b691cab2. > > Reason for revert: http://crbug.com/880583 : ASan detected memory leaks, so speculatively reverting. > > Original change's description: > > Implement script and style attr/elem CSP directives > > > > The functionality is behind the > > ContentSecurityPolicyExperimentalFeaturesEnabled flag > > > > I2IS: Coming Soon > > > > Spec: > > https://w3c.github.io/webappsec-csp/#directive-script-src-elem > > https://w3c.github.io/webappsec-csp/#directive-script-src-attr > > https://w3c.github.io/webappsec-csp/#directive-style-src-elem > > https://w3c.github.io/webappsec-csp/#directive-style-src-attr > > > > Change-Id: Ic1638cac15c7ec488fcc7a4c9f6261b97502090a > > Reviewed-on: https://chromium-review.googlesource.com/1181050 > > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > > Reviewed-by: Mike West <mkwst@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#588534} > > TBR=mkwst@chromium.org,andypaicu@chromium.org > > Change-Id: I385cd9eae7190412199496b3625dbf94d1fa45a6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/1205392 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588674} TBR=huangs@chromium.org,mkwst@chromium.org,andypaicu@chromium.org Change-Id: Id0429ccdf59ec803077394f2300058051b0492c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1205478Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#588785}
-
Yutaka Hirano authored
ThreadableLoader re-creates the request on redirect for some cases. We need to remember whether we need notification for uploading. Bug: 870173 Change-Id: Ic7e4847c4d4c9facb57cd09cb85b04ca78ddfca7 Reviewed-on: https://chromium-review.googlesource.com/1206170Reviewed-by:
-
Richard Li authored
This CL aims to solve Issue 877341, which plans to replace content::ChangedVersionAttributesMask with a new mojom type: blink::mojom::ChangedVersionAttributesMask. Bug: 877341 Change-Id: I2670e5ad52fce4e01281567dd8a7e55165ece51e Reviewed-on: https://chromium-review.googlesource.com/1201350Reviewed-by:
-
Takashi Toyoshima authored
This makes CORSURLLoaderFactory use OriginAccessList to check the source origin and destination URL pairs in the allowed list. There is no caller in production code at this moment, but patch set to support the legacy path and NetworkService will follow respectively. Bug: 870172 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iba37beb1d955edf05148ad9ac15731e64e58de1e Reviewed-on: https://chromium-review.googlesource.com/1196702 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#588782}
-
Chris Hall authored
TBR=stevenjb@chromium.org Bug: 879943 Change-Id: I2f6168bc46c5c5e42e422c7acd7af35618a27ffc Reviewed-on: https://chromium-review.googlesource.com/1201623Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588781}
-
Han Leon authored
This CL removes the member |is_valid_| of blink::WebServiceWorkerInstalledScriptsManager::RawScriptData, which becomes easy to be replaced with blink::InstalledScriptsManager::ScriptStatus for the next step when we remove blink::WebServiceWorkerInstalledScriptsManager and move content::WebServiceWorkerInstalledScriptsManagerImpl into Blink. BUG=792778 Change-Id: I14fcdfbb276007fa87428b19a9029fb722b78647 Reviewed-on: https://chromium-review.googlesource.com/1200682 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
-
yoshiki iguchi authored
Previously all touch events were ignored on Chrome side on child notification. But that caused the issue on scrolling (see the issue). This CL changes the behabior to disable only top-level slide on child notifications so that scrolling is possible correctly even on them. Bug: 876430 Test: manual (observe no issue) Change-Id: Ieb88ad19a94f71612998039e3a9abe4e91fc3856 Reviewed-on: https://chromium-review.googlesource.com/1203757Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#588779}
-
Stuart Langley authored
Change-Id: Idb5857427ebb5134ec7c273f266e1f798322dbd2 Reviewed-on: https://chromium-review.googlesource.com/1205922 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588778}
-
Rune Lillesveen authored
Calling UpdatePlaceholderVisibility on StyleDidChange makes us mark style dirty in the middle of a layout tree rebuild. Bug: 868810 Change-Id: I070e9fd576e21768099297767f2eddaaf401068c Reviewed-on: https://chromium-review.googlesource.com/1205150Reviewed-by:
-
Chris Hall authored
Bug: 879943 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I66d8f9f539c27e908208a121882e5c5fb84eedc2 Reviewed-on: https://chromium-review.googlesource.com/1201504Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588776}
-
Wang Qing authored
Bug: 872560 Change-Id: I58fbd5b4252eb6eae69e13a81ac5638cd27a83ec R: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1189518Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: 汪 清 <wangqing-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#588775}
-
Makoto Shimazu authored
ServiceWorkerContextClient requests its termination when the worker gets idle. However, when the browser knows DevTools is attached to the service worker, the termination request is silently dropped. After that, even if ServiceWorkerSubresourceLoader tries to trigger fetch events, those requests will be queued indefinitely. This CL is to notify the renderer to run tasks again when DevTools is attached. Bug: 878667 Change-Id: Iefdc4382489b68aae28aab57b5a7c96520795d14 Reviewed-on: https://chromium-review.googlesource.com/1194820Reviewed-by:
-
Takashi Toyoshima authored
There are some tests that call testRunner.addOriginAccessAllowListEntry even in navigation and security test directories. They are expected to call it to bypass renderer-side security checks, but let me run them in our outofblink-cors(-ns) virtual environments just in case. Also the security directory seems to contain many relevant tests that rely on CORS check on ResourceFetcher. Bug: 870172, 870173, 879991 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_mojo Change-Id: I55c75b6766da6b98c7a2d816fbcfec555d181b68 Reviewed-on: https://chromium-review.googlesource.com/1193524Reviewed-by:
-
Tom Anderson authored
R=sky Change-Id: I3e922309a769c1a3f7c8d3aab8703652112bb3ac Reviewed-on: https://chromium-review.googlesource.com/1205720Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#588772}
-
Sam McNally authored
Bug: 877043 Change-Id: Iab18132a8c4750de0f7f96601f6232c41e3aaf54 Reviewed-on: https://chromium-review.googlesource.com/1194544Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588771}
-
Sam McNally authored
- Use DriveIntegrationService::GetMountPointPath() in GetDownloadLocationText() to get the Drive mount path. - Update the test to explicitly cover DriveFS-enabled and DriveFS-disabled cases. - Change DriveFsHost to return the expected mount path when unmounted. - Make test-only ProfileHelper methods public, making the list of friends mostly unnecessary. Bug: 879422 Change-Id: I162ef7e74d58b400d9242be599700c4491fba6c7 Reviewed-on: https://chromium-review.googlesource.com/1201632Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Eriko Kurimoto authored
ChromeVox+O>E to enable logging. ChromeVox+O>D to disable logging. Bug: 880004 Change-Id: I25e618e1bb986432722b59cb7669808006bea354 Reviewed-on: https://chromium-review.googlesource.com/1201515Reviewed-by:
-
