- 24 Feb, 2019 10 commits
-
-
mrefaat authored
Tab and tab model are heavily used inside this class. Use WebStateListObserver instead of tabModel observer for ActiveTabChange. Bug: 930816, 931852 Change-Id: Ib8cd6ded93077986439030631e42bea0590a4aec Reviewed-on: https://chromium-review.googlesource.com/c/1480826 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#634992}
-
Yuli Huang authored
1. Add capture-event to collect preferences' metrics for taking pictures. 2. Fix analytics.EventBuilder's dimension() method. BUG=b:117816926 TEST=Tested by taking pictures and checking GA dashboard. Change-Id: Ib1bd952d8d02a3742417d78f93265eb36b5cfe49 Reviewed-on: https://chromium-review.googlesource.com/c/1482358Reviewed-by:
Sheng-hao Tsao <shenghao@google.com> Commit-Queue: yuli <yuli@chromium.org> Cr-Commit-Position: refs/heads/master@{#634991}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ed90e152d47..33c1b315265c git log 2ed90e152d47..33c1b315265c --date=short --no-merges --format='%ad %ae %s' 2019-02-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@33c1b315265c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I58d381bb8efafec6d0c3ce76039623408dd43e16 Reviewed-on: https://chromium-review.googlesource.com/c/1484780Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634990}
-
Kristi Park authored
The test should be "Crash Pass" instead of "Failure Pass" Bug: 935027 No-try: True No-presubmit: True Change-Id: Icf1a8b79fac23ac72291eadcdc87b3d8377502e6 Reviewed-on: https://chromium-review.googlesource.com/c/1484981 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634989}
-
Eric Karl authored
Destroying surfaces has the potential to add other surfaces to the |surfaces_to_destroy_| set. This can cause problems when a surface is pending destruction (already pulled out of |surfaces_to_destroy_|) and is then re-added to the list, leading to a double deletion. This change makes deletion robust against this pattern, in order to have a merge-safe fix. A future change will make surface destruction idempotent, so we don't need to worry about these cases. Bug: 934674 Change-Id: Ie08505ef37d4a6e2ca48462372e3e09d3d49bc58 Reviewed-on: https://chromium-review.googlesource.com/c/1484354 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634988}
-
Kim Paulhamus authored
s/phsycial/physical Change-Id: I7b33982c1d3a624070d3410e4140387caf2b1e4d Reviewed-on: https://chromium-review.googlesource.com/c/1485233Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#634987}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I32972ce154e206f10bc5237869c12beaa6d19edd Reviewed-on: https://chromium-review.googlesource.com/c/1485059Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#634986}
-
Lakshmi Kumar Dabbiru authored
1) UKM-ifying form events. UMA metrics are heavily used and just getting that to UKM. Number of aspects are interesting to look at URL level also here. Form event proto for reference - https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_metrics.h?l=597 2) Deprecating few redundant methods. Will do more following clean up. 3) Enforcing *timestamp* where ever it makes sense and in a way across all as post processing pipelines uses it for multiple purposes. 4) Enforced *IsAutofillable" as check to log anything in FormEvents as all form events are only logged after form is detected. Will separate out logging for more recall improvement purposes for non IsAutofillable part in a later CL. Privacy review approved - https://docs.google.com/document/d/1-ukZzPZjjl6LO5bOpEzW_eUimzWTaL1Wn94S3BlpGuk/edit Followup -> Clean up of Autofill user happiness metrics as that is not useful that much. -> Few more UKM metrics (related to recall) Change-Id: I1b088cd0a7e496ae56e0ea6a240f776e05eca0ec Reviewed-on: https://chromium-review.googlesource.com/c/1400262Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Cr-Commit-Position: refs/heads/master@{#634985}
-
Eugene But authored
Notable changes: - SetUp method wraps it's code into @autoreleasepool, to make sure that CRWWebController never goes to autorelease pool. CRWWebController will go to autorelease pool when used as a delegate for CRWSessionController in crrev.com/1455658. CRWWebController should not outlive WebThreadBundle, hence should not go to autorelease pool. - Use public WebState API for web state creation. This way all requred changes inside WebState::Create don't have to be duplicated in the test, which used to create WebStateImpl object via constructor. Bug: 899827 Change-Id: I50d07c6a06c5affdab2aa0924d3c97f15b4c387e Reviewed-on: https://chromium-review.googlesource.com/c/1484819 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#634984}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/867da4b96e8e..2ed90e152d47 git log 867da4b96e8e..2ed90e152d47 --date=short --no-merges --format='%ad %ae %s' 2019-02-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2ed90e152d47 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I2c72ef067690e1fb6cc6482b2b9bf6ab670505ef Reviewed-on: https://chromium-review.googlesource.com/c/1484801Reviewed-by:
-
- 23 Feb, 2019 30 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12f1fecea947..867da4b96e8e git log 12f1fecea947..867da4b96e8e --date=short --no-merges --format='%ad %ae %s' 2019-02-23 kjlubick@google.com Allow system harfbuzz. Created with: gclient setdep -r src/third_party/skia@867da4b96e8e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Ib90f1023fb285ef498b3c6ba05dc37925ddd28f3 Reviewed-on: https://chromium-review.googlesource.com/c/1485119Reviewed-by:
-
Eric Karl authored
CC's latency recovery can lead to signficant jank in cases where latency can't effectively be recovered. This seems to happen in both OOP-D and non-OOP-D, but to minimize risk, disabling in OOP-D only for now. We should re-evaluate this feature and potentially rework or remove it. TBRing piman so that this change can begin baking over the weekend for potential merge. Discussed this approach with sunnyps previously. TBR=sunnyps TBR=piman Bug: 933846 Change-Id: Icbce2ef784d03adb3ce233e816b5fd1361191de4 Reviewed-on: https://chromium-review.googlesource.com/c/1485231 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#634981}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5585c87a78b7..95ea36ed7054 git log 5585c87a78b7..95ea36ed7054 --date=short --no-merges --format='%ad %ae %s' 2019-02-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@95ea36ed7054 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iba593881539f929e777a436e668ea00790424e23 Reviewed-on: https://chromium-review.googlesource.com/c/1485129Reviewed-by:
-
Eric Stevenson authored
Missed in https://crrev.com/c/1481019. Only causes errors when resource whitelisting is enabled. Tbr: agrieve@chromium.org Bug: 935088 Change-Id: Ide099850512681bc6494995310e6c63ac7441365 Reviewed-on: https://chromium-review.googlesource.com/c/1485232Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#634979}
-
Philip Chen authored
It turns out there is no easy way to overwrite the default directory of regulatory labels (i.e. /usr/share/chromeos-assets/regulatory_labels) without causing other problems (see the discussion in CL:1482597). So let's limit the scope of this flag and only use it to pass per-model 'regulatory-label' property from cros_config. Bug: 933173 Change-Id: I052a171bac74e02eb70e5c81c7027f6d15b7ad0b Reviewed-on: https://chromium-review.googlesource.com/c/1484494 Commit-Queue: Philip Chen <philipchen@chromium.org> Auto-Submit: Philip Chen <philipchen@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#634978}
-
Stephen Chenney authored
A previous re-factoring (https://crrev.com/e337262e101e86c301d78ffa4337311f7d2d9110) accidentally changed a call on content_layer_ to a call on CcLayer(). Fix it. R=chrishtr@chromium.org BUG=935002 Change-Id: Ia035921e28d9ad1c0a5518fb97110d20c1434b5f Reviewed-on: https://chromium-review.googlesource.com/c/1485123 Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634977}
-
Nico Weber authored
This reverts commit 8fc6db24. Reason for revert: https://crbug.com/935122 Original change's description: > [Cros SR] Add training for Arc App Shorcuts > > See here for context: > > https://docs.google.com/document/d/1GTQ3vvrszK4I1pDzmTFb6krmUzAXox0V9ZIqIi_GH1E/edit?usp=sharing > > We are expanding Roselle to re-rank the results returned when the user enters > a query. However, these results include Arc app shortcuts as well as apps > themselves, so they need to be ranked. This CL adds the training support for > Arc App Shortcuts and use Roselle score to update current relevance score. > > Bug: 931149 > Change-Id: I979ebd500504681c9b0c0e59aa0412b4cbd47315 > Reviewed-on: https://chromium-review.googlesource.com/c/1481176 > Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634881} TBR=xiyuan@chromium.org,jiameng@chromium.org,thanhdng@chromium.org Change-Id: I9846f900136f23578ee0bb67cc4761c22cff5b3b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931149 Reviewed-on: https://chromium-review.googlesource.com/c/1485057Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634976}
-
Nico Weber authored
This reverts commit 90990b60. Reason for revert: Probably caused https://crbug.com/935119 Original change's description: > Roll src-internal c38434481cae..c5cf3bf8f345 (7 commits) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c38434481cae..c5cf3bf8f345 > > > Created with: > gclient setdep -r src-internal@c5cf3bf8f345 > > The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > > BUG=chromium:932622 > TBR=mmoss@chromium.org > > Change-Id: I53ea3cf05c5f04c2048986cd4732c9c62e2f4458 > Reviewed-on: https://chromium-review.googlesource.com/c/1485112 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#634963} TBR=mmoss@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: I6a6c7ecf8b816dffba801c09899e6023d8ba6934 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:932622 Reviewed-on: https://chromium-review.googlesource.com/c/1485056Reviewed-by:
-
Nico Weber authored
This reverts commit 7b5bb344. Reason for revert: prerequisite for revert for https://crbug.com935119 Original change's description: > Roll src-internal c5cf3bf8f345..3cce0f215a41 (2 commits) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5cf3bf8f345..3cce0f215a41 > > > Created with: > gclient setdep -r src-internal@3cce0f215a41 > > The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=mmoss@chromium.org > > Change-Id: Ibedc6e4c5945311631e4e40fb3fec99cde12bbfb > Reviewed-on: https://chromium-review.googlesource.com/c/1485114 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#634964} TBR=mmoss@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: I024c4477dfdba96e943d65beae6f94d4ad52041e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1485055Reviewed-by:
-
Nico Weber authored
This reverts commit 91e43421. Reason for revert: prerequisite for revert for https://crbug.com935119 Original change's description: > Roll src-internal 3cce0f215a41..e5903cc1d593 (1 commits) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3cce0f215a41..e5903cc1d593 > > > Created with: > gclient setdep -r src-internal@e5903cc1d593 > > The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=mmoss@chromium.org > > Change-Id: Ib054a6261714bf7143ae16e9f153f941fdcf510a > Reviewed-on: https://chromium-review.googlesource.com/c/1485118 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#634968} TBR=mmoss@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: Ie91679dea7871c057cbb925bab823f16ca7f2ad5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1485054Reviewed-by:
-
Nico Weber authored
This reverts commit ff4a2e21. Reason for revert: prerequisite for revert for https://crbug.com935119 Original change's description: > Roll src-internal e5903cc1d593..dc52268b67a2 (1 commits) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5903cc1d593..dc52268b67a2 > > > Created with: > gclient setdep -r src-internal@dc52268b67a2 > > The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=mmoss@chromium.org > > Change-Id: Ia695939aeac4c0f1d731ebae761ee43420217c1d > Reviewed-on: https://chromium-review.googlesource.com/c/1485124 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#634971} TBR=mmoss@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: Ib17386593c8ec221a5999432b84a6147b531f4ff No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1485053Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5903cc1d593..dc52268b67a2 Created with: gclient setdep -r src-internal@dc52268b67a2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia695939aeac4c0f1d731ebae761ee43420217c1d Reviewed-on: https://chromium-review.googlesource.com/c/1485124Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634971}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e9d0a01b. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" 52cfb86f "[WPT] Move common.js from {referrer-policy,mixed-content} to common/security-features" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifb58eb7f73f3725e416e35394e5b466cfe5ea31f Reviewed-on: https://chromium-review.googlesource.com/c/1485121Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634970}
-
Siddhartha S authored
Update the name of shared database and metadata databases so that the metrics can be seen in UMA. BUG=870813 Change-Id: Ied559606464f81e797d3efcbb00ba277c7f858fe Reviewed-on: https://chromium-review.googlesource.com/c/1484827Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#634969}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3cce0f215a41..e5903cc1d593 Created with: gclient setdep -r src-internal@e5903cc1d593 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib054a6261714bf7143ae16e9f153f941fdcf510a Reviewed-on: https://chromium-review.googlesource.com/c/1485118Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 90990b60. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: msisov@igalia.com: external/wpt/webvtt NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0f2c5df583c7a99bae2fc4c8e53d9f68e4b06cb8 Reviewed-on: https://chromium-review.googlesource.com/c/1485116Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/72f6f044cc73..12f1fecea947 git log 72f6f044cc73..12f1fecea947 --date=short --no-merges --format='%ad %ae %s' 2019-02-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f78131dac076..c63d95525cde (1 commits) Created with: gclient setdep -r src/third_party/skia@12f1fecea947 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I51747b3fbfaedfa2a20398363ff8019dda324881 Reviewed-on: https://chromium-review.googlesource.com/c/1485115Reviewed-by:
-
Hiroshige Hayashizaki authored
- Moves {referrer-policy,mixed-content}/generic/common.js (which have been already the same) to common/security-features/resources/common.js and removes a TODO comment about moving/merging common.js. - Add common/security-features/README.md. - Rename paths mechanically (mostly by the generators). Bug: 906850 Change-Id: I3d60bffa5b230c04257f66b49717d5861accb979 Reviewed-on: https://chromium-review.googlesource.com/c/1476192 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#634965}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5cf3bf8f345..3cce0f215a41 Created with: gclient setdep -r src-internal@3cce0f215a41 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibedc6e4c5945311631e4e40fb3fec99cde12bbfb Reviewed-on: https://chromium-review.googlesource.com/c/1485114Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c38434481cae..c5cf3bf8f345 Created with: gclient setdep -r src-internal@c5cf3bf8f345 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:932622 TBR=mmoss@chromium.org Change-Id: I53ea3cf05c5f04c2048986cd4732c9c62e2f4458 Reviewed-on: https://chromium-review.googlesource.com/c/1485112Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 15f51e3e. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ibe7a613f442842d014b6757190e878d8b7886128 Reviewed-on: https://chromium-review.googlesource.com/c/1485111Reviewed-by:
-
Clemens Arbesser authored
Before: https://screenshot.googleplex.com/fjPBfRZ60vm.png After: https://screenshot.googleplex.com/KJr3uAbraJM.png Bug: 806868 Change-Id: If050ab6c36203b000b0103958f08ce30f46f22b1 Reviewed-on: https://chromium-review.googlesource.com/c/1482979Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#634961}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca69efadc6d9..c38434481cae Created with: gclient setdep -r src-internal@c38434481cae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If952d873435f4625135a1413aa41db57c183b069 Reviewed-on: https://chromium-review.googlesource.com/c/1485024Reviewed-by:
-
Abhishek Bhardwaj authored
This change adds a class that makes the wake up alarm D-Bus API on Chrome OS easy to use by clients. The D-Bus API was merged in aec92f8b. BUG=chromium:913318 TEST=Unit tests and end-to-end alarms via ARC++ applications. Change-Id: I045af2c6ffbf93b3d44ac09ca217159fcdae18fe Reviewed-on: https://chromium-review.googlesource.com/c/1372848 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
-
Naoki Fukino authored
This adds an integration test to check that DocumentsProvider implementation correctly interact with ARC-related services in Chrome side by marking ARC as available for testing and mocking FileSystemInstance (Mojo interface to interact with ARC container). Bug: 923991 Test: Run browset_tests --gtest_filter=QuickView/FilesAppBrowserTest.Test/openQuickView* Change-Id: I72cf99449880aea0acc33cc7f679656ea4e396f8 Reviewed-on: https://chromium-review.googlesource.com/c/1483697 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634958}
-
Hirokazu Honda authored
VaapiVideoDecodeAccelerator doesn't propagate profile change in a video stream to driver. Rockchip and Intel driver apparently handles the profile change inside of the drivers, while AMD driver doesn't. This casues video corruption in some sites on AMD device. This is the workaround for the issue. MojoVideoDecoderService calls Initialize() if profile change is detected, but VdaVideoDecoder doesn't support reinitialization as a VideoDecodeAccelerator doesn't. This change enables VdaVideoDecoder to re-initialize by destroying currently using VideoDecodeAccelerator and creating a new one. This reinitialization is triggered only if profile changes for performance and VideoDecodeAccelerator is VaapiVideoDecodeAccelerator for safety. Bug: 929565 Test: no video corruption on some issued sites on grunt and eve Change-Id: Ic6f75809fce6db08965cf0554e7d989d635d3f54 Reviewed-on: https://chromium-review.googlesource.com/c/1482357 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#634957}
-
David Trainor authored
Add safety checks to the following classes to make sure they work better during destroy: - ThumbnailProviderImpl - Cancel all requests after destroy and do not use any results given. - BitmapCache - Do not add bitmaps to the cache after destroy (real exception). - ThumbnailDiskStorage - Do not take requests after destroy and do not return results after destroy. Bug: 934515 Change-Id: Id2bbac832fd4b9c81ae81ee806f66494eda59e16 Reviewed-on: https://chromium-review.googlesource.com/c/1482590 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Joonghun Park authored
https://www.w3.org/TR/css-values-4/#calc-type-checking spec says that calc() function that resolve to <number> can be used in any place that only accepts <integer>. This change makes calc() function's behavior to comply with the spec. Bug: 931216 Change-Id: Iac9ad21d664bb60538d40ab42cbb8153de6db89f Reviewed-on: https://chromium-review.googlesource.com/c/1478852Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#634955}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b99086fcf5e..72f6f044cc73 git log 5b99086fcf5e..72f6f044cc73 --date=short --no-merges --format='%ad %ae %s' 2019-02-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@72f6f044cc73 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I65c6666594b174e077b1d4bcdd563510f24b24f8 Reviewed-on: https://chromium-review.googlesource.com/c/1485025Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6b0fdfce..2f408608 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib5c144e841c841c0842fbdf9af11f7ecaccc6472 Reviewed-on: https://chromium-review.googlesource.com/c/1485023Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634953}
-
