- 03 Feb, 2020 40 commits
-
-
Avi Drissman authored
It's possible that there's a newer Chrome already installed on the target Mac. In that case, the installer will skip the Chrome app installation, and the postinstall script won't know what brand code to write. Therefore, bake the brand code into the postinstall script. Bug: 1048228 Change-Id: I57857bf5f43804fa4cfb3a552cb3a131e9ee94fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036255Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737978}
-
Regan Hsu authored
* Remove AddWebContentStrings from Browser settings * Move AddWebContentStrings to AddAppearanceStrings * Delete unused IDS_SETTINGS_WEB_CONTENT, IDS_SETTINGS_LOREM_IPSUM, IDS_SETTINGS_LOADING * Move strings in AddWebContentStrings that are shared between different components to AddCommonStrings * Copy strings used by OS settings to OS settings string provider Bug: 967888 Change-Id: I4ff81ab4d6e363e8771748c48ac9802e6b8bc719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013862 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737977}
-
Henrique Ferreiro authored
The different Cursor and CursorInfo objects may hold a custom image and hotspot when their type is ui::CursorType::kCustom. This CL makes changes in several places to ignore those values for non-custom cursors. Bug: 1040499 Change-Id: I504ef36f45bd771c80a2f8b81b828e16eeca0074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035412Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#737976}
-
Takuto Ikuta authored
This was added in crrev.com/b274e87c But I think we can use BQ to do this kind of analysis now. Bug: 984869 Change-Id: Ic4feb37897a6b6fdcac36039aba8d24ae7b3a987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032557 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#737975}
-
Tom Anderson authored
R=sky Bug: None Change-Id: I680cafd25935e59a280e3b2baac754d3d5f13a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036553 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Removed the overridden color definition in the Preview Tab progress bar. By default, the given style sets the color right both in light and dark mode. Bug: 1047887 Change-Id: I9a5473f9e1f3bf58c83c1f264a4e2ea697b44a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032657Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#737973}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6da434932c2e..8f2b5ba75973 git log 6da434932c2e..8f2b5ba75973 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 treehugger-gerrit@google.com Merge "traced_probes: supply shmem size hints when connecting" 2020-02-03 treehugger-gerrit@google.com Merge "Re-enable service worker" Created with: gclient setdep -r src/third_party/perfetto@8f2b5ba75973 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id41c9a56f5c4cea586d0e16aa7e97808a8e669e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737972}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-4028.0-1580121249-benchmark-81.0.4044.0-r1 to 81-4028.0-1580727432-benchmark-81.0.4044.4-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I31bc9a824ea9bca6abd0b2c4eaeb17924ee1467b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036777Reviewed-by:
-
Michael Crouse authored
This change adds an earlier check for whether a model is included in the PredictionModel proto before validating it. This should resolve the prediction model validation histogram being recording as invalid when the model is not provided by the remote optimization guide as there is not a newer one. Bug: 1046848 Change-Id: I0a974b45883f5940a1a63f77876c615ae420d8dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035050 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#737970}
-
Noel Gordon authored
QuickViewParams does not define the |hasTask| property, so the Closure compile can't type-check its value. Define the |hasTask| property. Tbr: alex Bug: 803259 Change-Id: I62e6ad46ca7176298a4d9cd0d5cc466b326d0b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035634Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737969}
-
Mohamed Heikal authored
android-binary-size's 'ForTest' check which looks for symbols in the production apk with 'ForTest' in the name is currently lacking in that it does not track inlined symbols. This change fixes that by having the script parse the proguard mapping file and use that instead of using just the final list of symbols. Bug: 1012373 Change-Id: Ic2752ddc792150f426fb6beac8c9d6553799f6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993623 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#737968}
-
Noel Gordon authored
Tbr: alex Bug: 803259 Change-Id: Ib0872eea67e4d28fc01056c946b48bde04eb5159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035635Reviewed-by:
-
Noel Gordon authored
Change its closure tag to @private. Minor: nix an unneeded extra line. Tbr: alex Bug: 803259 Change-Id: I8b103f26cfa7c8de1e40216b80be3dc47d6d0026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035492Reviewed-by:
-
Noel Gordon authored
Style: do not abbreviate names. Change elems => toolTipElements, being the elements on the quick view toolbar that [has-tooltip]. No need for the |toolTip| intermediate: addTargets(toolTipElements) to the <files-tooltip> handler in one call. Tbr: Alex Bug: 803259 Change-Id: Ic12db7d98ebe95fd07d4d512dd7c657858dc7a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035636Reviewed-by:
-
Charlie Reis authored
SiteInstance and BrowsingInstance should not depend on details of the classes that rely on them (e.g., frame_host/, web_contents/). Bug: 1015882 Change-Id: Ie28ead50ed6c69755d1060330ae3c189ac38dbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029608 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737964}
-
Anand K. Mistry authored
The output of 'lsblk' and 'blkid' are to be added to feedback logs. However, UUIDs from blkid don't necessarily follow the expected UUID pattern. Also, external media can contain user-defined volume labels. Bug: 1045239 Change-Id: I972f1281755a204b0e6e9a554841f1a799c59a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016773Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#737963}
-
Collin Baker authored
InsertIntoFocusOrderAfter inadvertently created focus cycles in some cases. This fixes the implementation and adds DCHECK coverage for the future. Fixed: 942478 Bug: 928905 Change-Id: Ie0d1ceceb56ec07e6d7e2442f925b328607584f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809062 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#737962}
-
Lijin Shen authored
1. rename text styles. Most of them are prefixed by "White". 2. add new text styles. Dark text styles are missing in styles.xml. For more info, see go/clanktext. Bug: 775198 Change-Id: I0f4679d022a671a5080d0a587fef8d4c35f05c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033724 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#737961}
-
John Budorick authored
Bug: 959436 Change-Id: I13d8c704a8f8bf3b0d8c66b8cc55a6dc06793d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032714 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#737960}
-
Marijn Kruisselbrink authored
(or vice versa.) We don't want to re-use the existing permission grant especially in the file->directory case to avoid giving a website access to an entire directory while we only told the user about a single file. However in our logic to guard against this we left the old permission grant dangling, which would result in a DCHECK when it was eventually destroyed. This CL changes the logic in these cases to deny the old permission grants, and updates the DCHECK to make sure it only triggers for non-DENIED grants. Bug: 1047588 Change-Id: I8275d7b3b66ad9b687ca16e4129dba2323f5645e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032236Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#737959}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba64534cd9d9..7a968e640c5c Created with: gclient setdep -r src-internal@7a968e640c5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:936275 Tbr: jbudorick@google.com Change-Id: Ide936dc11b949a7a282d3fadd44e367f64d227fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737958}
-
Matt Menke authored
Sometimes the write-to-file tests timeout on the bots. Since the other write to file tests all pass (though they write less), and there have been no reports of the code hanging in the wild, seems likely an issue with bot performance, rather than a bug in production code. Just reduce the amount of data the tests write to disk in the write-to-file case. Bug: 1035127 Change-Id: I1199d22c5b65110f070f7c000881a564c8a44649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036630 Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737957}
-
Lukasz Anforowicz authored
When an extension message is received, we check `MessageSender.id` to disallow requests from unknown clients. Unfortunately, `MessageSender.id` is currently not trustworthy (issue 982361) and therefore this CL switches to using `MessageSender.origin` instead. Bug: 10321587 Change-Id: I76f65921e9a4832f6dd187d967c1225ac1994af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035865Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737956}
-
Ben Pastene authored
Moves all the values of xcode into a shareable location. Will upgrade bots to the newer path in a follow-up, in case it gets reverted. Bug: 1048301 Change-Id: I18e2aebb67fd2bff879b24159d4f7210801d9f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036495 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
danakj authored
This removes the remaining TODOs pointing to bug 419087, 583347, and 912193 when they are about RenderWidget and not RenderWidgetHost. TODOs about the RenderWidgetHost are clarified to explain that RenderWidget is destroyed now. R=avi@chromium.org Bug: 419087, 583347, 912193 Change-Id: Ia491d2644997bac9d93bd319fb2ca0133997d86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006209Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#737954}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/852d4aa1ba41..69bb8bef75ff git log 852d4aa1ba41..69bb8bef75ff --date=short --first-parent --format='%ad %ae %s' 2020-02-03 ehmaldonado@google.com presubmit_support: Support getting and adding footers. Created with: gclient setdep -r src/third_party/depot_tools@69bb8bef75ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324 Tbr: agable@chromium.org Change-Id: I0822f36f40bca1cc9b01031e13525743b27ecb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036344Reviewed-by:
-
Manu Cornet authored
After the recently added getters for shelf components (nav widget, hotseat, status area) on the |Shelf| object itself (to make it clearer that they play a similar role to the |ShelfWidget|, reduce the chain of accessors to get those instances in a bunch of cases. Change-Id: Iabdbef446b3c3a70046eea957858a0cb0b323bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036651Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#737952}
-
yilkal authored
This CL ensures that chrome and web apps have a shared time limit against which to count their time usage. Bug: 1034551 Change-Id: Ia6b647dc8e5151dd95ddeeb96b29c9791ba1ce1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033848 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#737951}
-
Justin Cohen authored
2fd16e339294 Reformat all gn files 6c0f5ccaa872 Add NewReport::Reader to read back new reports 23a2da5e9558 [fuchsia] Only add fdio config if it's not already present 77baffaf931b Add iOS gn configs f36f46d1ec95 Roll crashpad/third_party/mini_chromium/mini_chromium/ 0512d4269..f58366399 (1 commit) 915862984c1e [log minidump] add option to log minidump in handler_main 75ea787a80c7 Adds plumbing for xcuitests with a placeholder test 3b007333a0fa Roll crashpad/third_party/mini_chromium/mini_chromium/ f58366399..0a3a80b04 (2 commits) 39116ab7230c Adds support for running iOS unittests via XCTest 46ad005e9265 Updates run_tests.py to support testing on iOS e386d703d60d Fix typo in handler_main 39a319d6a7a9 Roll buildtools/ 3e50219fc..62f9eb0d6 (8 commits) 56ec176fda7f Fix Chromium checkperms.py has shebang but not executable bit error Change-Id: Ib34dbb8f7ad08f7dcd122551b93d820fc74fb668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036398Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737950}
-
mark a. foltz authored
https://chromium.googlesource.com/media_router.git/+log/29324b698ccd..7835fcd45668 $ git log 29324b698..7835fcd45 --date=short --no-merges --format='%ad %ae %s' 2020-02-03 mfoltz [Cast Extension] Update files.gni. 2020-01-31 mfoltz [Media Router] Convert external_message_listener to use sender.origin. 2020-01-13 mfoltz Remove DIAL MRP 2020-01-07 mfoltz [MR extension] Lower the severity of provideSinks(): provider not found error 2020-01-06 mfoltz Add explicit '!' for non-null types as required by http://go/js-nullability 2019-12-04 mfoltz Delete invalid goog.provide'd namespace initialization 2019-11-27 mfoltz Don't load disabled extension MediaRouteProviders 2019-10-29 mfoltz Fix typo in unit_test_utils.js. 2019-10-09 mfoltz Fix or suppress upcoming JSCompiler type errors 2019-09-09 mfoltz Removed obsolete "cloud on" setting. 2019-09-05 mfoltz Removed log spam related to Weave being unavailable. 2019-09-05 mfoltz Re-ran genjsdeps. 2019-07-25 mfoltz [Media Router] Log finch experiments to feedback PSDs 2019-07-12 mfoltz Modify route creation metrics in extension DIAL MRP 2019-06-28 mfoltz [Mirroring Service] Remove audio checkbox from desktop picker 2019-06-21 mfoltz Make Media Router component extension tests support Jasmine 3 2019-06-18 mfoltz [MR extension] Don't call chooseDesktopMedia() with a tab ID 2019-06-10 mfoltz [Media Router component extension] Log feature states in feedback logs 2019-05-25 mfoltz [Media Router] Revise capture resolution selection algorithm. 2019-05-14 mfoltz Record MediaRouter.Dial.ParseMessage in DialProviderWrapper 2019-05-02 mfoltz Update metrics collection in DIAL MRP 2019-05-02 mfoltz Fix MirrorMediaStream test failure where mediaDevices is not defined 2019-04-18 mfoltz Fix a crash in mr.mirror.Session's constructor 2019-04-17 mfoltz Disable Adaptive Latency for Cast Mirroring. There are audio bugs caused by this feature. 2019-04-15 mfoltz Set route description in the ctor of mr.mirror.Session 2019-02-22 mfoltz Ads classes for the Web Sender 2019-01-08 mfoltz Fixes various potential XSS vulnerabilities in the MR extension. Created with: roll-dep src/chrome/browser/resources/media_router/extension/src R=takumif@chromium.org Bug: 1047285 Change-Id: Ic02e060e44323be3b44a86fcc3a84f7e43b60683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036436Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737949}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I4c8779a19ca85b78dd378ef3afb999c414ecf493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036439Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737948}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/23e2ad174cfa..bf3087f65d6a git log 23e2ad174cfa..bf3087f65d6a --date=short --first-parent --format='%ad %ae %s' 2020-02-03 reed@google.com add skvm for tablecolorfilter 2020-02-03 mtklein@google.com impl gather8/gather16 with gather32 2020-02-03 bsalomon@google.com Choose a less evil scale factor texel_subset_nearest_upscale decal tests 2020-02-03 fmalita@chromium.org [skottie] Cleanup: finalize adapter conversion 2020-02-03 mtklein@google.com test premul/unpremul are no-ops when a==1.0f Created with: gclient setdep -r src/third_party/skia@bf3087f65d6a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I0b405fd78d342e8db87fa0af21bbd8dcb26d6747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036343Reviewed-by:
-
Andrew Grieve authored
Advantages to having it live under //android_deps: * Maven version constraints are checked when resolving deps * Consistency / ease of future updates Bug: None Change-Id: I715f0a00b88268556ff533e89ffa42ec6ebfb66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035868 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#737946}
-
Andres Calderon Jaramillo authored
This CL creates a fuzzer for media::VaapiJpegDecoder. This component exposes an interface that takes raw JPEG data and uses libva to decode it using the hardware. Unfortunately, this interface is too simple: most fuzzing inputs will probably be invalid because they will fail at the parsing stage even before getting to libva. This is not useful because we already have a fuzzer for the media::JpegParser. Instead, we make this fuzzer more structure-aware so that we can inject more diverse inputs into the driver and exercise more code paths. The rationale is that the driver should fail cleanly on invalid inputs. To accomplish this, this CL: 1) Extracts the libva-poking functionality of the VaapiJpegDecoder into two private methods: MaybeCreateSurface() and SubmitBuffers(). 2) Defines a protobuf that mirrors the structure of the parameters of these two methods. 3) Uses libprotobuf-mutator to generate structured data that can be directly converted into the input for the two methods above. Bug: 1028051,1034357 Test: ./vaapi_jpeg_decoder_fuzzertest pixel-1280x720.textproto on sarien Change-Id: I9a1c957558d05343bdc0f371cd68adb2975ad7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967203Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#737945}
-
Mugdha Lakhani authored
UrlBarControllerImpl will now call into the native counterpart to get the formatted URL to be displayed. This reuses Omnibox code from //components Bug: 1025607 Change-Id: I57005c4940b5deec0d92f094ee65e36f6dc6851b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023787Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#737944}
-
Peng Huang authored
With low end device mode, the android surface control should be disabled. Fix the problem by following GpuPreferences to enable or disable android surface control with Vulkan. Bug: 1033170 Change-Id: I1887be2cac0d17b3213c9271893b68b8bdfe35b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036403 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#737943}
-
yilkal authored
This is a reland of db4b7168 Original change's description: > Adds WebTimeActivityProvider. > > This CL adds WebTimeActivityProvider which is > BrowserListObserver, a TabStripModelObserver, > AppServiceWrapper::EventListener, and > WebTimeNavigationObserver::EventListener. It is hosted > in AppTimeController. > > The instance of this class observes > the TabStripModel of each Browser in BrowserList. It also > observes the WebTimeNavigationObserver instances of each WebContent > hosted in each Browser window. The instance also observes > AppServiceWrapper to learn about the activation/deactivation of > chrome application windows. > > WebTimeActivityProvider informs its observers when Chrome becomes > Active, Active with whitelisted content or inactive. > > Bug: 1034551 > Change-Id: I7d7dd3624ea4fb764c13e35f0ef542759cee8933 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020522 > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737492} Bug: 1034551 Change-Id: I2109b4df2600f9796b593767a2ea5f3e197393a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035863Reviewed-by:
-
Matt Menke authored
Bug: 1035887 Change-Id: If99ff578ad31f6dbd180041fe8b1b0623ef26569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033571Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737941}
-
Tao Bai authored
Bug: 1042048 Change-Id: I73ce0bbbc10eb54a9e602ff638e1c3ec49421715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033844 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
In some scenarios (e.g. http range requests for linearized PDFs) the PDF plugin may need to initiate requests on behalf of the PDF's origin. Such requests are currently proxied by the renderer process hosting the plugin (i.e. the renderer hosting the PDF extension - mhjfbmdgcfjbbpaeojofohoefgiehjai) and therefore go through URLLoaderFactory that is locked via request_initiator_site_lock to a different origin (i.e. the origin of the PDF extension, rather than the origin of the website that hosts the PDF file). Before this CL, such requests would be classified by CorsURLLoaderFactory::IsSane and VerifyRequestInitiatorLockWithPluginCheck as incorrect and possibly malicious. After this CL, the request_initiator checks are relaxed by PluginServiceImpl::FindOrStartPpapiPluginProcess using a new mechanism similar to AddCorbExceptionForPlugin exemption available for Flash. We don't want to relax request_initiator_site_lock checks for renderer processes hosting arbitrary origins from the web, so as a defense-in-depth the CL adds a CHECK to FindOrStartPpapiPluginProcess that verifies the origin lock of the renderer process that is granted the extra capabilities. Relevant tests: - ChromeFindRequestManagerTest.FindInChunkedPDF (tests that range request do not result in a request initiator lock mismatch) - PDFExtensionTest.EnsureInternalPluginDisabled (tests that the PDF plugin may only be embedded in trustworthy contexts) - PDFExtensionTest.RedirectsFailInPlugin (the 'noRedirectsSucceed' testcase tests non-range requests initiated by the PDF plugin) Bug: 1027173b Tbr: creis@chromium.org Tbr: nasko@chromium.org Tbr: yhirano@chromium.org Change-Id: I9a8f284a8927b1230c5088f8c46aca118e934c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036558Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737939}
-
