- 24 Feb, 2018 6 commits
-
-
danakj authored
When a renderer or other viz client shuts down, the CompositorFrameSink may not have been notified about all the SharedBitmapIds being deleted. In that case the shared memory would stay in the display compositor's ServerSharedBitmapManager forever, leaking that memory space. So have each CompositorFrameSink implementation remember what SharedBitmapIds it has told the display compositor about, and remove them all when the implementation is destroyed. R=kylechar@chromium.org NOTRY=true Bug: 730660 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia1aff6f9035b4713ece787f49ceb1d6c0f839c15 Reviewed-on: https://chromium-review.googlesource.com/929989 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#538957}
-
Andrii Shyshkalov authored
Only documentation and global/refs.cfg file are new here. Configs are pure copy-pasta. No-Try: True Bug: 815072 Change-Id: I7863b95323b2ba6a05d1d56f60e9b67808fa36b8 Reviewed-on: https://chromium-review.googlesource.com/935582 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#538956}
-
Tarun Bansal authored
Add more checks to the test to aid in debugging on the bots. Note that the test passes on the local machine. Bug: 813599 Change-Id: Ie9617b5604bdabe76bc41ed7bf7d42a0a63aeaba Reviewed-on: https://chromium-review.googlesource.com/935302Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#538955}
-
https://pdfium.googlesource.com/pdfium.git/+log/3760afa05acd..26820b474343 $ git log 3760afa05..26820b474 --date=short --no-merges --format='%ad %ae %s' 2018-02-23 rharrison Setup testing XFA using .in files Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0998bcc30ab92c4fe47f6d87e17c7041a21da753 Reviewed-on: https://chromium-review.googlesource.com/935500 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538954}
-
Peter Kasting authored
This changes the form of DoNothing() from a simple no-arg function to a class that produces callbacks via templated operator(). This allows callers to replace base::Bind(&base::DoNothing) with base::DoNothing() for a small boilerplate reduction; more importantly, it allows using DoNothing() to replace existing no-op functions/lambdas that took more than zero args, and thus had to be manually declared. This removes dozens of such functions and around 600 LOC total. In a few places, DoNothing() can't be used directly, and this change also adds explicit callback-generating Once<>() and Repeatedly<>() members that will produce a callback with a specific signature. BUG=811554 TEST=none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I37f87b35c6c079a6a8c03ff18ec3a54e1237f126 Reviewed-on: https://chromium-review.googlesource.com/903416 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#538953}
-
Yuichiro Hanada authored
This CL fixes the issue when connecting an external keyboard that has a Caps-Lock key. The issue happening when mapping Search key to Caps-Lock key on the internal keyboard will be addressed later. Bug: 747823 Test: Manual. Confirm that Caps-Lock + Q generates @ and Caps-Lock is not enabled after that. Change-Id: I96c378d85ca85ce0d78bbc1ebd57bd44fb5f1a5f Reviewed-on: https://chromium-review.googlesource.com/933667Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#538952}
-
- 23 Feb, 2018 34 commits
-
-
Sergey Ulanov authored
Enabling layout tests on Fuchsia bots. Only smoke tests are currently enabled. For most tests output matches Linux. Added new expectations for the cases when the results are different from Linux (in such cases they often match Android). Bug: 778467 Change-Id: Id26f7de9ec397cca46a83fae9937f7c3f6d6ce60 Reviewed-on: https://chromium-review.googlesource.com/917188 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#538951}
-
Jia authored
base::Time could go backwards, while TimeTicks does not increment when system is suspended. In this cl, we implement a BootClock that only increases and does not stand still when system is suspended. Bug: 802942 Change-Id: Id5127758ecf8c443c936b8e62f8ef6ae07cb1735 Reviewed-on: https://chromium-review.googlesource.com/928044Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#538950}
-
Matt Mueller authored
Change-Id: Ic44c20f5dcb25ab86b90ad2df75b8a91dfa253b1 Reviewed-on: https://chromium-review.googlesource.com/933704 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#538949}
-
Emircan Uysaler authored
This CL moves GMBVFP usage inside WebMediaPlayerMS. Since MediaStream no longer passes frames through main thread, earlier blocker for the bugs have been resolved. Uploading to GMBs in the WebMediaPlayerMS section where we pass on IO thread makes more sense as we can track hidden or backgrounded state there. Bug: 653200 Change-Id: I95a9ca1cfa52d94e9001b4a499cc3ab71c2c71a3 Reviewed-on: https://chromium-review.googlesource.com/927707Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#538948}
-
Nico Weber authored
https://chromium-review.googlesource.com/c/chromium/src/+/933862 added chromium_linux_clang_and_gl_gtests to the UBSanVptr Linux bot, while the ToT bot only runs chromium_linux_clang_gtests -- and gl_unittests doesn't run under ubsan yet (see blockers of crbug.com/815183). So switch UBSanVptr Linux to chromium_linux_clang_gtests instead. Many of the tests that were run on UBSanVptr Linux do pass, so run those on ToTLinuxUBSanVptr too. Namely, aura_unittests, capture_unittests, chromedriver_unittests, components_browsertests, compositor_unittests, dbus_unittests, events_unittests, gin_unittests, media_unittests, mojo_common_unittests, mojo_unittests, nacl_loader_unittests, ui_touch_selection_unittests, and wm_unittests now run on the ToT bot. Generally check that if a test is disabled on ToTLinuxUBSanVptr it's disabled for UBSanVptr Linux too (notably, interactive_ui_tests no longer runs on the non-tot bot, which also doesn't pass. But services_unittests now does run, like on the tot bot). Bug: 814099, 815183 Change-Id: Icef0bd597f740774351a112df1d2c891ee371d24 Reviewed-on: https://chromium-review.googlesource.com/934424Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538947}
-
Cherie Shi authored
as there is no reports indicating any connection closed with visitor nulled. Bug: 546668 Change-Id: I21522e3786d3e9fabd2e2786ddc8929227bcd5ab Reviewed-on: https://chromium-review.googlesource.com/935300Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#538946}
-
John Williams authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9b006ee2b566712ac2f62f8c0599054176f9bafc Reviewed-on: https://chromium-review.googlesource.com/917307Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#538945}
-
Reilly Grant authored
This reverts commit c70d2d70. Reason for revert: <INSERT REASONING HERE> Original change's description: > Clean up chrome_switches.{h,cc} and move to lib "non_code_constants" > > This CL consists of the following changes: > 1) Remove function PowerOverlayEnabled() which is not used. > 2) Remove function ExtensionsDisabled() which is not used. > 3) Move ExtensionsDisabled(base::CommandLine) to chrome_extensions_browser_client.cc, > which is the only call site. > 4) Move chrome_switches.{h,cc} to lib "non_code_constants", as they don't contain any > functions now. > > After this change, including "chrome_switches.h" (and "chrome_constants.h") > only requires a dependence on lib "non_code_constants", rather than lib > "constants" which is overkill. > > This applies to notification_helper which only includes "chrome_switches.h" > and "chrome_constants.h" under chrome/common. > > Bug: 734095 > Change-Id: I3be5ffff70e9f594989c2058dca0ef109eabf085 > Reviewed-on: https://chromium-review.googlesource.com/930368 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Xi Cheng <chengx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538941} TBR=sky@chromium.org,chengx@chromium.org Change-Id: If9a6c26836432e7b857ec350abc9370fac810f7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734095 Reviewed-on: https://chromium-review.googlesource.com/935758Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#538944}
-
rbpotter authored
This function is used outside of cloud print (in webui/print_preview) and will be needed by the print backend service in future. Split from https://crrev.com/c/902668 Bug: 809738 Change-Id: I00a668db965e1b179dd87ee19b2d6e37faeba44b Reviewed-on: https://chromium-review.googlesource.com/912274 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#538943}
-
Peter Boström authored
Changing "Edit..." to "Advanced" caused layout problems, so moving to the shorter "More..." as "Edit..." conflicts with the "Edit bookmarks" title of the dialog. Bug: chromium:812362, chromium:814668 Change-Id: Id11a7c463c20c5a6508c863882a6f0be8d9f2b8d Reviewed-on: https://chromium-review.googlesource.com/935626Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#538942}
-
Xi Cheng authored
This CL consists of the following changes: 1) Remove function PowerOverlayEnabled() which is not used. 2) Remove function ExtensionsDisabled() which is not used. 3) Move ExtensionsDisabled(base::CommandLine) to chrome_extensions_browser_client.cc, which is the only call site. 4) Move chrome_switches.{h,cc} to lib "non_code_constants", as they don't contain any functions now. After this change, including "chrome_switches.h" (and "chrome_constants.h") only requires a dependence on lib "non_code_constants", rather than lib "constants" which is overkill. This applies to notification_helper which only includes "chrome_switches.h" and "chrome_constants.h" under chrome/common. Bug: 734095 Change-Id: I3be5ffff70e9f594989c2058dca0ef109eabf085 Reviewed-on: https://chromium-review.googlesource.com/930368Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#538941}
-
Becky Zhou authored
+ Change the globe icon for both modern and non-modern + Change padding to vertically align the close icon to the menu icon Bug: 812924 Change-Id: I60312acf2ea561c92bdd2779c1540b65c8f4695f Reviewed-on: https://chromium-review.googlesource.com/927691Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#538940}
-
Jian Li authored
When a saved page is opened from Android Downloads or 3rd party app, we need to query the Offline Pages DB based on the size and digest of the MHTML content in order to find out if there is a trusted offline page assoicated with it. Bug: 758690 Change-Id: I732a9a41e367310231436c5701377d38516849a6 Reviewed-on: https://chromium-review.googlesource.com/932744 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#538939}
-
erikchen authored
It's possible for no request to exist if the client process is unregistered around the same time that the MemoryDumpResponse is comes in. Change-Id: Ib68dd98e076047ddbd6cc7efef58951746c8ad9b TBR: primiano@chromium.org Reviewed-on: https://chromium-review.googlesource.com/935321Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#538938}
-
Eve Martin-Jones authored
Update the definition of the Import class in //mojo/public/tools/bindings/pylib/mojom/parse/ast.py to have an attribute list. Update the grammar in //mojo/public/tools/bindings/pylib/mojo/parse/parser.py so that imports are now preceded by an attribute_section. Update existing tests in parser_unittests.py and add a unit test for Imports with attributes to conditional_features_unittest.py Bug: 676224 Change-Id: If347ef41f9149d3587db1f79abba84ccf552dbc2 Reviewed-on: https://chromium-review.googlesource.com/934004 Commit-Queue: Eve Martin-Jones <evem@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#538937}
-
James Cook authored
We're trying to eliminate //ui/chromeos, since all high-level chromeos UI lives in //ash. This file only exists because of a DEPS-ban on //ui in //chromeos. Allowing one gfx::Vector3dF dependency in //chromeos/accelerometer allows this file to be eliminated and all functionality consolidated in AccelerometerUpdate. TBR=danakj@chromium.org Bug: none Test: ash_unittests, chromeos_unittests Change-Id: Iff03d52073920c9ed6dfbed3c550e98dc02ed335 Reviewed-on: https://chromium-review.googlesource.com/933082 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#538936}
-
Weiliang Chen authored
Copy out GLRenderer's implementation of SyncQuery to be shared with SkiaRenderer. R=enne Bug: 644851 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iab621087534fc608d0fd9d319255a44335ac9ce4 Reviewed-on: https://chromium-review.googlesource.com/933705Reviewed-by:
enne <enne@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#538935}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb18-03.html BUG=412078 TBR=jschuh@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3a2211a113b4b01a58c13f9ce3448e905631ca7a Reviewed-on: https://chromium-review.googlesource.com/935478 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#538934}
-
Ovidio Henriquez authored
This change updates a couple of write value to characteristic tests to use the new test API. This will allow the tests to be migrated into the wpt/ directory. BUG=509038 Change-Id: I6202aca3ac8b6c37cb9e97eb4c02fe707c19e4f8 Reviewed-on: https://chromium-review.googlesource.com/814596Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#538933}
-
https://webrtc.googlesource.com/src.git/+log/f35c6667d6f7..88f6decad796 $ git log f35c6667d..88f6decad --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I47587fa880cfe4489a3e27149b7abcf3fd884464 Reviewed-on: https://chromium-review.googlesource.com/935466Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538932}
-
Kyle Horimoto authored
When combined with https://chromium-review.googlesource.com/c/chromium/src/+/929867, this CL will cause a notification to appear when unlocking a device if a Tether host is nearby and the device is not connected to the Internet. Bug: 813838, 672263 Change-Id: I9c0cd3b047c46dacba0f3acc84d03e2f0abf452c Reviewed-on: https://chromium-review.googlesource.com/935476Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#538931}
-
Nasko Oskov authored
The testCrossDomainNavigationDoNotLoseImportance test case is using invalid URLs, which result in failed navigations, where it expects successful ones. This CL fixes the URLs so they successfully navigate. Change-Id: Iacab88e36c1a2d501ec9a38a1adfe486db170107 Reviewed-on: https://chromium-review.googlesource.com/935488Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#538930}
-
Daniel Cheng authored
Bug: 676588, 711127 Change-Id: I4ee8c447379f924c55410805ebc9fbc219fc7864 Reviewed-on: https://chromium-review.googlesource.com/924651Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#538929}
-
Aleks Totic authored
Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib1ac35999c1f971a9396242a4eba609932468b17 Reviewed-on: https://chromium-review.googlesource.com/933585 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#538928}
-
edchin authored
Improves GridViewController with: - uses GridLayout, a custom layout object. - implements GridConsumer. - calls GridCommands. - enables selection and closing items. - enables image retrieval. - light and dark themes. Bug: 804496, 804526 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I41ef66f3d9efbe7d4f6a6bfe97db2123c0108880 Reviewed-on: https://chromium-review.googlesource.com/933582 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#538927}
-
Yash Malik authored
Bug: 811494 Change-Id: I4db9912240ac54e1883259d1981e6254b3600818 Reviewed-on: https://chromium-review.googlesource.com/935472Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#538926}
-
Kurt Horimoto authored
This CL also renames UpdateFullscreenWebViewProxyForReplacedScrollView() to MoveContentBelowHeader(), as it is used in additional places other than just for replaced scroll views. Bug: 769379 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I330e20e33501429140a8ea3dfd9e8afa34d47fcf Reviewed-on: https://chromium-review.googlesource.com/933921 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#538925}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ide1a10ca457407f642177c0ce7deae80699b2b9b Reviewed-on: https://chromium-review.googlesource.com/935621Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538924}
-
Adrienne Walker authored
All of these workarounds here are listed in json but there's no implementation for them in the code anymore. Remove them. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0f9f0d4c8633b3b825b81eabb46782d1229a2250 Reviewed-on: https://chromium-review.googlesource.com/935292Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#538923}
-
Martin Sramek authored
Prefixed CSS properties should be listed before the standard ones. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I558a257e8fffe0571ab5fbc5183dc6a678e26721 Reviewed-on: https://chromium-review.googlesource.com/929762Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#538922}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I281b42923000c8fac38de82620a5c65cba9f3010 Reviewed-on: https://chromium-review.googlesource.com/935701Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#538921}
-
Xiaoqian Dai authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I544a25a000f2f6ca262c23ffbee3088845776833 Reviewed-on: https://chromium-review.googlesource.com/935027Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#538920}
-
Brad Lassey authored
R=bnc@google.com Change-Id: I95e25ff305b7eb59d13003e8aba726729f80dac2 Reviewed-on: https://chromium-review.googlesource.com/905352 Commit-Queue: Brad Lassey <lassey@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#538919}
-
Becky Zhou authored
Moved the initialization for params to be only in the static create() method. Discussed here: https://chromium-review.googlesource.com/915105 Bug: 687010 Change-Id: I1b8da988ab9879d3d4fe9f4567ef2d809a32c4ee Reviewed-on: https://chromium-review.googlesource.com/917624Reviewed-by:
Joy Ming <jming@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#538918}
-