- 15 Oct, 2019 40 commits
-
-
Benoît Lizé authored
In PartitionAlloc, the freelist entries are encoded (except for the head). The encoding process is symmetric, meaning that there was a single "Transform()" function. This is confusing and error-prone. This adds a type for an encoded freelist entry, making the difference clearer. Note that this fixes a bug of PartitionAlloc on big endian platforms. In PartitionPurgePage(), the tail of the freelist had an un-encoded nullptr value. This is incorrect, as the code using it would decode the value, and get the wrong one as a consequence. This does not trigger on little-endian platforms, as the transformation we use is such that Encode(nullptr) == nullptr, but on big endian ones Encode(ptr) = ~ptr, meaning that this would lead to a crash. It seems that Chrome does not ship on big endian platforms though (and that no chromium-based project uses PartitionAlloc on big endian platforms), as otherwise this would crash the renderer very quickly. The issue is eliminated with the new types. There is no behavior change in this CL on little endian, and should not impact performance either. Bug: 998048, 787153 Change-Id: I67798659202156360aeddc6e71c5d330f5daa163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857328 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#705884}
-
Kuo Jen Wei authored
Preferred default fps range for photo mode preview. Preferred maximal constant fps for video mode preview. Bug: 976602 Test: Verify the fps range chosen by CCA in both video mode and photo mode are correct. Change-Id: Iefe209fe4596d69d29a135ebdc246de04e148015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861435 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#705883}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/68bfe0b550df..61d3d4b0bd55 git log 68bfe0b550df..61d3d4b0bd55 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 machenbach@chromium.org Revert "depot_tools: Run recipe scripts using vpython." Created with: gclient setdep -r src/third_party/depot_tools@61d3d4b0bd55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I958d510480dc1ceefceefe52a995b3f038006de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862236Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705882}
-
Bo Liu authored
ChildProcessLauncherHelperImpl assumes onConnectionEstablished and onConnectionLost are paired when in reality they might not be. Former is called after setupConnection is completed (when child sends its pid), and the latter is called from onServiceDisconnected (and posted once). It is possible that the child dies after onServiceConnected, but before setupConnection is complete. It should not be possible for onConnectionEstablished to come after onServiceDisconnected however. Add a check in onConnectionLost for this case and skip the rest of clean up if needed. Bug: 1013667 Change-Id: I56d83863be440810238d743083250c72c48160c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860036Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705881}
-
Bo Liu authored
Low rate crash from first failure calling bindServiceAsUser. Inclue the reflection failure in the exception. Bug: 994961 Change-Id: Iedff1cd231341d2ecb69663d8bc5d8eddbf6e176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860596Reviewed-by:
-
Jia authored
The model will only export a curve if it's changed and the error is small, which is defined by a tolerance threshold. Export means it's saved to disk and notified to observers. Bug: 881215 Change-Id: Ib8881771dcdb46803b90922a37f73fcb6ef640e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846212Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#705879}
-
Gyuyoung Kim authored
This is a reland of d7213e95 The change of replacing vr_service.mojom-blink.h with vr_service.mojom-blink-forward.h in third_party/blink/renderer/modules/xr/type_converters.h had caused the build break. This re-land CL restores vr_service.mojom-blink.h in type_converters.h. Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 13 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: I42c62234c64878d23057366df8823eb94a8a5e6e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852354 > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705021} Bug: 1001360 Change-Id: I8d85c338de234922dbce52c8802688e2ae3888fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855550 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#705878}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2276e59788ea..1b6fd37fa6f9 git log 2276e59788ea..1b6fd37fa6f9 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 afdx@google.com spirv-fuzz: Refactor 'split blocks' to identify instructions differently (#2961) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1b6fd37fa6f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Bug: None Change-Id: Iaa81bd450f089961289c9d461e2674506381ae55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862254Reviewed-by:
-
Eric Seckler authored
We should also set timestamp_clock_id when we set a TracePacket's timestamp (since chrome isn't usually using perfetto's default CLOCK_BOOTTIME). Change-Id: Idb7970b0567e1466a741180b4e15d96ffbc8f7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859791 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#705876}
-
Henrik Boström authored
This unblocks https://webrtc-review.googlesource.com/c/src/+/156084. TBR=nisse@chromium.org NOTRY=True Bug: webrtc:10525 Change-Id: I9ca14f4c5c6d38b8a71b77c2393e842f2e6966c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862437Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705875}
-
Marina Ciocea authored
Bug: 977050 Change-Id: If80c2effee45b1bcc3c80f45014f0b9474641aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862434Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#705874}
-
Roman Sorokin authored
TBR=alemate@chromium.org Bug: 1011753, 1001458 Change-Id: If4ae6081e3a76d5c55764b898e6d617709f2956e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848379 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#705873}
-
Darren Shen authored
On Chrome OS, there are certain languages that are implemented using "rule-based engines". For example, typing "a" then "s" in Vietnamese (Telex) activates a rule that transforms the input into "á". These rules are implemented using very complicated regex patterns, string manipulation and array indexing, so it seems like a great target for fuzzing. We also add some test data from existing unit tests. The seed corpus seems to help: cov starts at ~6000 instead of ~4000. Bug: 1014260 Change-Id: I06f069ee6a842d9df29ddfb825a89f15a7fabd84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860195Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#705872}
-
Miyoung Shin authored
This CL converts DnsConfigChangeManagerClient{Ptr, Request} in chrome and services to the new Mojo type, and uses pending_remote<DnsConfigChangeManagerClient> in host_resolver.mojom. Bug: 955171 Change-Id: If8038bf601d99eb11c6f62f250872919fa6338f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859655 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#705871}
-
Luciano Pacheco authored
The issue for what these logs were added hasn't recurred for a while. Bug: 904658 Change-Id: Ia07cb37f70a07b02b6b3a80e129c6d24910b68c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860199 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705870}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/407cb5ca3318..b833f0b3b78e git log 407cb5ca3318..b833f0b3b78e --date=short --no-merges --format='%ad %ae %s' 2019-10-15 treehugger-gerrit@google.com Merge "processor: Translate track & chrome event timestamps to trace time" Created with: gclient setdep -r src/third_party/perfetto@b833f0b3b78e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib8948ae768fe9f2fbfc5e74dc48ba7f0d5ac2ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861736Reviewed-by:
-
Yuki Shiino authored
The revert at https://crrev.com/c/1856618 is incomplete, and there is a leftover file. This patch removes the file. The leftover file is causing an error at: third_party/blink/tools/run_bindings_tests.py Original change's description: > WebGPU: Add GPUProgrammablePassEncoder interface > > This is a spec match-up with[1] > > [1] https://github.com/gpuweb/gpuweb/pull/459 > > Bug: 877147 > Change-Id: I080324cbb083160ae84aa109623e311f24a875cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845132 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Jinho Bang <jinho.bang@samsung.com> > Cr-Commit-Position: refs/heads/master@{#704061} Bug: 1013649, 877147 Change-Id: Id25d2a16fa1dc2f1b569ea982412591f39660f33 Tbr: jinho.bang@samsung.com Tbr: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862138Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#705868}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c6512213a7b7..68bfe0b550df git log c6512213a7b7..68bfe0b550df --date=short --no-merges --format='%ad %ae %s' 2019-10-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@68bfe0b550df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I223adce848eb8838341729fe0ab42d1d6abe6934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861737Reviewed-by:
-
Christian Dullweber authored
We don't need to enable the kImprovedCookieControls flag anymore to make these tests pass. Bug: 967668 Change-Id: Ic0858e9b48756fbd644a0d506c674df87e1e1dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859779 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#705866}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie2733b72f33fd299794800e8a113803e66c87994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861734Reviewed-by:
-
Sushanth Rajasankar authored
With cc: Add solid color analyzer to replace AnalysisCanvas, https://chromium-review.googlesource.com/c/chromium/src/+/538974/ Solid color analysis is run directly on a paint op buffer instead of rasterizing to a skia::AnalysisCanvas. This change hence removes stale comment that refers to optimizing AnalysisCanvas. Change-Id: Ic87d6e056596713b85882abadbd278bf866ab3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860675Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#705864}
-
Sara Kato authored
Name computation in crrev/1786363 results in an extra space being added to name, when only one of text/content_description/label/pane_title has been set. This CL adds a check before setting the name value. Bug: b:140316122 Test: AXTreeSourceArcTest.AccessibleNameComputationTextField Test: arc.accessibilityTree Change-Id: Ic330fcaa8a46975c2b7bdd5d5d74426fa3a083d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855324 Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#705863}
-
Austin Tankiang authored
Extensions install successfully now even if they are downloaded to the Drive directory, so remove the check. Bug: 1003238 Change-Id: Id8ae36aecd2e7d2c937e4e76fdca8920e00835c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846623Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#705862}
-
Abhijeet Kandalkar authored
This CL converts |RecorderRequest| to |mojo::PendingReceiver<mojom::Recorder>| to use new mojo types. Bug: 955171, 978694 Change-Id: I26271b88c7742600e7c5d8dac934829681c1798d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838771Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: Ida19b233a4b78d1fe5876c1689ebed57b09e0066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861634 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Hsin-Yu Chao authored
Bluetooth narrow band mic type wasn't included in the recent change that create the device type list. It's okay to insert this new type because we started record this data just recently. Patch that adds the new type CL:1828977 Bug: 1000576 Change-Id: I2d7a64e9fa203e5574881f64675361e5c4053d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849533 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Auto-Submit: Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#705859}
-
Hiroki Nakagawa authored
|URLSecurityOriginMap* g_url_origin_map| in security_origin.cc is used only for keeping pairs of blob URLs and origins serialized to "null" (i.e. opaque origins, or origins of file URLs). To clarify it, this CL renames class/variable names, adds implementation comments, and puts some DCHECKs. Change-Id: Ifbc27caa90f9696d6d2db490157e12824d4fb113 Bug: 987130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772933 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ee61d3d5a3ba..55f9cba6e2e7 git log ee61d3d5a3ba..55f9cba6e2e7 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fede5cb664d9..2d0e5b554d4f (4 commits) 2019-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1c462ebc904c..a27dfcf868bf (3 commits) Created with: gclient setdep -r src/third_party/skia@55f9cba6e2e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None,chromium:None Change-Id: Ie656dbe8a4421cf76073c157106b62aaca6980b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860293Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d57f1fca. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." 0583f458 "Fetch Metadata: split up `document` destination." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: emilio@chromium.org: external/wpt/css/css-display NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I50631f0cea5c4b1324fcaebc54a4cee68ecfda46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860783Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705856}
-
Simon Zünd authored
nosnapshot builds were deprecated in V8 v7.4 and are now removed. To be able to remove "v8_use_snapshot" upstream, we first need to remove the single use-site in Chromium. Corresponding V8 CL: https://crrev.com/c/1784282. Bug: v8:8531 Change-Id: Id0f393220f88e77b78b42e2a6314b8dea5d96b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796325Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#705855}
-
Sara Kato authored
This CL ensures that placeholder text will be read out by ChromeVox. placeholder text. Test: manual, follow bug repro steps. ChromeVox will read Test: TODO write tast test Bug: b/130369098 Change-Id: I491811d9ba6e951ef365eed137768a12a8150222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855621Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts NetworkService from network_service.mojom to new Mojo types using PendingRemote, PendingReceiver, Remote, and Receiver. Bug: 955171 Change-Id: I5ea352f8fd5a62beb92fa96b6fe2ffda3e3aa2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847595Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#705853}
-
Yoshifumi Inoue authored
This patch makes |NGInlineCursor| to support culled inline box to repalce |NGInlineFragmentTraversal::SelfFragmentsOf()| with |NGInlineCursor| for preparation of migrating |NGFragmentItem|. Bug: 982194 Change-Id: I86d90dac19780af31defddebc09393a5ae836a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855618 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705852}
-
Alan Cutter authored
This is a simple refactor CL that replaces the WebappInstallSource parameter in WebAppDataRetriever with WebAppIconDownloader::Histogram. This removes the strong dependency on install_source in preparation for update install tasks that don't have an install_source: https://chromium-review.googlesource.com/c/chromium/src/+/1811402 Bug: 926083 Change-Id: I239d5094f545a5d86d2d282ed53185de935caa22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837573 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#705851}
-
Darren Shen authored
Currently we record key event latency as measured as the time between a pending key event was added to when the pending event was resolved. However, this "pending key event" code path is only used by extensions based input engines. We are planning to add a native engine that doesn't use the pending key event dictionary approach. So those key events would not be recorded right now. A more robust way is to encode the latency measurements as part of the key event callback. That way, as long as the key event is handled in some way, we will record it correctly. The metric was added recently and currently has no data, so this doesn't invalidate our metrics. Bug: 1009903 Change-Id: I747420bd7e143965f6f15c74fa81d55b6783b548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860197 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#705850}
-
Adam Rice authored
Count use of the constructors of CompressionStream and DecompressionStream. BUG=999091 Change-Id: I5581425016d270f173d189c980cbf5cbca4c40e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855549Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#705849}
-
Koji Ishii authored
This patch allows atomic inlines to stay on the line even when it appears after the line overflowed, if its negative margins can bring the position back to inside of the line. This is not a well-defined behavior in the CSS spec, but legacy/WebKit/Gecko do this at some levels, though not really interoperable. Bug: 1001000 Change-Id: If8cfc5d51de14c8de6a9caa78fa10abaf6f1b5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859424 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705848}
-
Nikita Podguzov authored
This CL gets rid of RepeatingTimer used in PrintJobHistoryCleaner before. Instead it introduces lazy way to clean expired print jobs. This will also resolve an issue when print jobs are cleared with delay. This was caused by the fact that we run timer only once a day. Bug: 992889 Change-Id: I18404c795c2308c892d228e37cc6ff34240b1794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853204Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#705847}
-
Raul Tambre authored
* cgi.escape() has been removed in Python 3.8. Use html.escape() in Python 3. Note that this causes quotes to be escaped in Python 3. This doesn't seem to be an issue. * Read the licence in text mode, so we can use it with html.escape(), which excepts strings not bytes. Still works with Python 2. Fixed backtraces: Traceback (most recent call last): File "../../tools/licenses.py", line 810, in <module> sys.exit(main()) File "../../tools/licenses.py", line 792, in main if not GenerateCredits(args.file_template, args.entry_template, File "../../tools/licenses.py", line 662, in GenerateCredits entries.append(MetadataToTemplateEntry(chromium_license_metadata, File "../../tools/licenses.py", line 632, in MetadataToTemplateEntry 'content': EvaluateTemplate(entry_template, env), File "../../tools/licenses.py", line 620, in EvaluateTemplate val = cgi.escape(val) AttributeError: module 'cgi' has no attribute 'escape' Traceback (most recent call last): File "../../tools/licenses.py", line 809, in <module> sys.exit(main()) File "../../tools/licenses.py", line 791, in main if not GenerateCredits(args.file_template, args.entry_template, File "../../tools/licenses.py", line 661, in GenerateCredits entries.append(MetadataToTemplateEntry(chromium_license_metadata, File "../../tools/licenses.py", line 631, in MetadataToTemplateEntry 'content': EvaluateTemplate(entry_template, env), File "../../tools/licenses.py", line 619, in EvaluateTemplate val = html.escape(val) File "C:\Program Files\Python38\lib\html\__init__.py", line 19, in escape s = s.replace("&", "&") # Must be done first! TypeError: a bytes-like object is required, not 'str' Bug: 941669 Change-Id: If203c49a425db733825df1867e65bef7a20060fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857321 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by: -
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/858cf233ef71..ee61d3d5a3ba git log 858cf233ef71..ee61d3d5a3ba --date=short --no-merges --format='%ad %ae %s' 2019-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src e034419f..083c52f7 (362 commits) Created with: gclient setdep -r src/third_party/skia@ee61d3d5a3ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None Change-Id: I35818bb47a46140e3f2467f1c4b1d3580213eccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860291Reviewed-by:
-
