- 03 May, 2019 40 commits
-
-
Xiaoqian Dai authored
It's no longer used. Clean it up. Bug: None Change-Id: I845bef3903af5ff4f765bb2878f2bbc9ea8c5334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592691Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#656391}
-
Nico Weber authored
/FORCE:MultipleRes makes duplicate resources emit a warning instead of an error, but /WX converts all warnings into errors. TBR=hans Bug: 958955 Change-Id: I0764edbcd9f13f7412e160075985ce611675dc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594701 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#656390}
-
Adithya Srinivasan authored
Uses portal/portalHost.postMessage instead of broadcast channels in the following tests: - portals-cross-origin-load.html - portals-host-exposure.html - portals-rendering.html Change-Id: I1c2a74f07d3566d7046e48d2355508c5f0e6149e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591876Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#656389}
-
Robert Ogden authored
This is failing because assertPreviewShownViaHistogram needs to check browser histograms. Also cleaned up the test while I was at it. Bug: 959036 Change-Id: Ie634d8be4268b73661f3e06ffc496d399d3ad1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593508 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#656388}
-
Polina Bondarenko authored
Rename Diagnosticsd mojo and D-Bus interfaces to WilcoDtcSupportd. Since the renamed code is meant only for wilco_dtc_supportd usage and is not used for pure diagnostics purposes, the name is confusing. It is a final CL for the wilco_dtc_supportd rename. BUG=b:124423615 TEST=build,unit_tests Change-Id: I2447d6db96eea8c0e54be399aae7c0b178adfdd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565984 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#656387}
-
James Cook authored
This removes the implementation of the mojom::AXHost interface and the interface itself. TBR=rmrossi@chromium.org Bug: 958187 Change-Id: I68f9eec4e7004a623579f90bf22bdc7e7e9473f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592847Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#656386}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9a23d151..8b263bbf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iecf8e47c6587ab6bc99ade346fa07739256b83d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592386Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656385}
-
Tibor Goldschwendt authored
Bug: 951492 Change-Id: Ie993974ea7bb5779bf396921a3931020d90e7f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564554 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#656384}
-
Dan Zhang authored
Add SimpleLinkedHashMap and its platform impl's. Deprecate net::linked_hash_map and replace it with the new class. R=rch@chromium.org Change-Id: I326fbe373d9e036c2c7cd30dd378f44e5055ef21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590616Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#656383}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a5d3e861c684..29afe3e4c351 git log a5d3e861c684..29afe3e4c351 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 saklein@chromium.org chroot_lib: New class to begin handling chroot logic 2019-05-03 mikenichols@chromium.org upload_symbols: Refactor error handling for duplicates Created with: gclient setdep -r src/third_party/chromite@29afe3e4c351 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I5cde2dcf6a2f00b6e4040dcc99b9648d5adfe583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594098Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656382}
-
Vadim Bendebury authored
A lot of new boards and Cr50 versions have been released since these enums were introduced. The intergers reported by UMA were converted to 4 byte ASCII and looked up in the RLZ database. All released Cr50 versions were taken through the same hash generating process used before. BUG=none TEST=none Change-Id: I9a756c766301b6662cc04ab59b87e973dad29831 Signed-off-by:
Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592346Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#656381}
-
Elly Fong-Jones authored
So far the linked bug has resisted reproduction outside of the bots; unconditionally log more state to help debug. Bug: 922068 Change-Id: Ia2d93a1cfc03c1ea2fb1055d3b9cfea764a85217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592682 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#656380}
-
Leon Scroggins III authored
On a 32 bit machine, an extra large chunk length can result in overflow when added to other small numbers. Check for that overflow in Parse/ParseSize and mark the decoder as failed if it occurs. DCHECK that the length is valid in Decode methods, since it has already been checked by Parse. In ParseSize, check for length > PNG_UINT_31_MAX. This matches Parse, and the PNG spec (https://www.w3.org/TR/PNG/), which demands that all four byte integers are <= PNG_UINT_31_MAX. Bug: 954983 Change-Id: I86d92c2ce1db54b2326188d41d378f3c172bf67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588943Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Madeleine Barowsky <mbarowsky@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#656379}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/670c6ec66ef9..6ad5289ea4b3 git log 670c6ec66ef9..6ad5289ea4b3 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 ethannicholas@google.com Revert "Child fragment processors are now written as separate functions" Created with: gclient setdep -r src/third_party/skia@6ad5289ea4b3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ifeea0036ea8c15c0907e2e53a953b749b58fe5bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593505Reviewed-by:
-
Anthony Vallee-Dubois authored
Bug: 940464 Change-Id: Ie14355660637a485f6af546f9e784d9a2d65d208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526403Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#656377}
-
Koji Ishii authored
TBR=jfernandez@igalia.com Bug: 952254, 956469 Change-Id: I2a049cbe50995d1f7fb111943c728ddcad2e3b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589088Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#656376}
-
henrika authored
Given recent work in https://bugs.chromium.org/p/chromium/issues/detail?id=938938 it was found that the code related to loopback support on Windows could contain parts where it was not clear if the device role was taken into account properly. This change is an attempt to clean up parts code where usage of a loopback device might be broken. Basically, the change is an attempt to make the code more readable. BUG=956526 Change-Id: Ia4f4ea177f3cd50805677790dbf0bdbd743561b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583708 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#656375}
-
Koji Ishii authored
Following bot results are included. 18846 18853 18857 18858 18859 18863 18867 18871 18880 18887 18905 18912 18915 18920 18923 18926 18933 18944 18978 18984 18988 18992 18995 19004 19017 19026 19036 19037 19039 19043 19046 19049 19060 19070 19085 19089 19092 19093 19098 1 lines were removed and 5 lines were deflaked by consecutive results since 19037. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I9f170cc1c42b5d2dbd7b5cd12dd2e872821fb9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584533Reviewed-by:
-
Julian Pastarmov authored
This flag allows BYOD users to also continue using the deprecated feature of creating popups during page unload. It's life time is bound to the lifetime of the AllowPopupsDuringPageUnload policy. See https://crbug.com/937569 BUG=958419 TEST=unit_tests Change-Id: I895f16879571d7e92fed975fc626a9a6a062ca10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593261Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#656373}
-
Daniel Bratell authored
In jumbo builds many files are compiled together in the same translation unit, and there share the same anonymous namespace. By copying functions from gl_image_dxgi.cc into gl_image_gxgi_swap_chain.cc without changing the function names jumbo builds got collisions between two HasAlpha and two SupportedBindFormat. Since they are also slightly modified, reusing the function is not a direction option so this renames the new set of functions by adding a SwapChain prefix. TBR=piman@chromium.org,ashithasantosh@google.com Bug: 939655 Change-Id: I3190aa8cbb3c87b0be8be821298a67906be0abd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594581Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#656372}
-
Mike West authored
We should have shipped this along with the violation events. It was an oversight to leave the flag in the IDL file. Oops! We shipped the event before we had Intents to Anything: https://groups.google.com/a/chromium.org/d/msg/blink-dev/VYhixsNgEHM/SilKZTYOAwAJ is the closest thing I can find, which exposed the event in Workers ~2.5 years ago. Bug: 956690 Change-Id: I83adf4898f34ef1b7016ece7f032ab741c11dd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588381Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#656371}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4815de28b2b5..3b670120619c Created with: gclient setdep -r src-internal@3b670120619c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: I80c165a4a84a21701a39a6767f80861473e1a348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593504Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656370}
-
Antonio Gomes authored
This CL is first out of n CLs that migrate third_party/blink/renderer/modules/mediastream/ from using banned base functions (namely base::Bind{Once,Repeating}) in favor of their Blink counter part. Note that less trivial occurrences within this same class will be migrated on a follow up CL. R=haraken@chromium.org BUG=923394 Change-Id: I0919319c11a72190c788109ae054c11c72504e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593996Reviewed-by:Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#656369}
-
Nicolás Peña Moreno authored
Per the spec change, the entry should be dispatched when |duration| is at least 104. This aligns better with the RAIL guideline of responding to user input within 100 ms. Bug: 823744 Change-Id: I7230c04bb7962b5e6403a56cd2b53a56b7a27bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592705Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#656368}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/97b690b06..3f28356e440b $ git log 7bf7c3c35..3f28356e4 --date=short --no-merges --format='%ad %ae %s' 2019-05-02 nharper Fix check for QuicFramer detecting old header format with new version 2019-05-02 nharper Harden QuicFramer::DecryptPayload to avoid dereferencing bad EncryptionLevels 2019-05-02 nharper gfe-relnote: Remove no-op std::move from QuicFramer::DecryptPayload. Protected by reloadable flag quic_v44_disable_trial_decryption. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Bug: 958633, 958665, 958752 Change-Id: I36d580529f200712daf0b22d72faa6e15b06b2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593909 Commit-Queue: Bence Béky <bnc@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
-
Mustaq Ahmed authored
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/dFAIZHeNpSs/4WO6f-tcDQAJ Bug: 951898 Change-Id: Id748ba57f420f0e4b59cef8e23c63e6fdfec370c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585970Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#656366}
-
rajendrant authored
Some histograms only show up when enabled via a different JS interface. This CL tries to load histograms via both the JS interfaces when SleepUntilHistogramHasEntry() is called. Bug: 959041 Change-Id: Ib86ba7db792e093915ff40304c6a60de8ba4026d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592725 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#656365}
-
Nico Weber authored
Reduces time to download orderfiles from 23.2s to 7.5s. Min-of-3 before: $ rm src/chrome/build/*.orderfile $ time /usr/bin/python src/third_party/depot_tools/download_from_google_storage.py -t 4 --no_resume --no_auth --bucket chromium-browser-clang/orderfiles -d src/chrome/build 0> Downloading src/chrome/build/chrome.x64.orderfile... 0> Downloading src/chrome/build/chrome.x86.orderfile... 0> Downloading src/chrome/build/chrome_child.x64.orderfile... 0> Downloading src/chrome/build/chrome_child.x86.orderfile... Downloading 4 files took 21.731848 second(s) real 0m23.196s user 0m13.216s sys 0m5.091s Min-of-3 after: $ rm src/chrome/build/*.orderfile $ time /usr/bin/python src/third_party/depot_tools/download_from_google_storage.py -t 4 --no_resume --no_auth --bucket chromium-browser-clang/orderfiles -d src/chrome/build 1> Downloading src/chrome/build/chrome.x64.orderfile... 2> Downloading src/chrome/build/chrome_child.x64.orderfile... 3> Downloading src/chrome/build/chrome_child.x86.orderfile... 0> Downloading src/chrome/build/chrome.x86.orderfile... Downloading 4 files took 6.042539 second(s) real 0m7.503s user 0m14.284s sys 0m5.801s Bug: 959151 Change-Id: Ic5c2a75f79ed1823f3f9e4a731f108b7b96f2af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594616 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#656364}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e89d5754..9a23d151 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e0ec20d559cf93863e22ec42f7f78796c4b2f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593951Reviewed-by:
-
Dominik Röttsches authored
No-Try: true Bug: 959168 Tbr: drott Change-Id: I990738bd0b8601bb4edae2d5464dfc316af6558b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594527Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#656362}
-
Nico Weber authored
Makes the download about 10% faster. The files are unzipped after transit, so nothing changes on the client side other than the download is a bit faster. Server-side, we need 90% less storage (but the files are tiny, so that doesn't really matter either.) Bug: 959151 Change-Id: I271c05b0446c279222c42c7c0457f32eac413135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594615 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Jeremy Roman authored
Add tests for them, as well as the recently added load event (which should have one for all HTML attributes, so comes for free). Bug: 914120 Change-Id: I8ae57e48e87434122a19cf02b86e0fec0cf578c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594052Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#656360}
-
Mihai Sardarescu authored
This CL add a DCHECK to make it clear that signing in to Chrome requires OAuth client ID and client secret to be configured. Bug: 931903 Change-Id: I2cbbeb857d5ea96b1a7dfed28c20987009f1acc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576569 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#656359}
-
Caleb Rouleau authored
This is a reland of d3107b1f My fix here went through: https://chromium-review.googlesource.com/c/catapult/+/1592813 TBR=dalecurtis@chromium.org NOTRY=True Original change's description: > [Telemetry] Re-enable media stories to try speculative fix. > > I have a speculative fix at https://chromium-review.googlesource.com/c/catapult/+/1592032 > > NOTRY=true > TBR=sullivan@chromium.org > > Bug: 957977 > Change-Id: Ib753d6a060ee366c9f9e1e3bcd2b9e92aeacfc4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592053 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#655621} Bug: 957977 Change-Id: I12063860fb0cc5c92e6220e1f49d5f7520721b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594617Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#656358}
-
Henrique Grandinetti authored
Other relevant changes in this cl are: -Removal of policy_config_source, which is unnecessary, making the code a little simpler. -Change parent access service delegate into an observer. I wanted to do this on a follow up, when I start to remove the callback parameter, however I did it here because it would make testing easier. -Converted unit test to browser test. It is hard to test the new parent access service with an unit test, also the new browser tests gives more coverage. Bug: 951242 Change-Id: I10f56919db264a1ab5cf0132973ee97523dff5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562892 Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#656357}
-
Xida Chen authored
It appears that most of the crash in off-thread paint worklet is due to the paint_record is null in the ImageProvider::ScopedResult. The reason is that at PaintWorkletImageCache::PaintImageInTask, the Record from painter_->Paint could be null because the Paint function eventually calls CSSPaintDefinition::Paint and that could return nullptr. This CL ensures that all the entries in the records_ have non-null PaintRecord. Bug: 957458 Change-Id: I6ce22d3c754cc3daac4c8285554cfaecf2eb654d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588360 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#656356}
-
Bruno Santos authored
When available, use internal version of main.html and resources file. Bug: 957205 Change-Id: I3d7c7f381bf42e51685d553f90fe0d4c994fc1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590646Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
Leon Scroggins III authored
Fail on an fdAT that is too small to have a sequence number. This prevents an underflow in ProcessFdatChunkAsIdat. In addition, rename fd_at to fdat. This variable got renamed in the automatic conversion to Chromium coding style. "fdat" is more clear and consistent with other variables (e.g. idat). Change-Id: I4045fc13e7ef9e916d78db124720fe80bc817567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593852Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd105f1b76a7..670c6ec66ef9 git log fd105f1b76a7..670c6ec66ef9 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 reed@google.com Revert "SkShaper JSON output with cluster visualization" Created with: gclient setdep -r src/third_party/skia@670c6ec66ef9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I347307aed33490218e234198e68230afcac7fc2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593502Reviewed-by:
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Ia66d4a6635c7f8cbfc84fbe012244b711821764b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591553 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#656352}
-
