GitLab

Add a ctor for creating a CommandLine for carrying arguments;
convert all the users to either that or the FilePath version.

BUG=24672

Review URL: http://codereview.chromium.org/329017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25862
TEST=The About box
Review URL: http://codereview.chromium.org/330023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=green


Review URL: http://codereview.chromium.org/339011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25308
TEST=go to gmail, pin the tab, select another tab. Have someone IM you
     and make sure your gmail tab throbs.

Review URL: http://codereview.chromium.org/329021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25656
TEST=Mac UI valgrind bots

Review URL: http://codereview.chromium.org/330022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30112 0039d316-1c4b-4281-b951-d872f2087c98

This will allow lower-level targets to change their desired optimization level.  In particular, the ffmpeg build requires this because it has problems compiling with -O0.

BUG=22307
TEST=none

Review URL: http://codereview.chromium.org/334018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/334008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30109 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25849
TEST=none
Review URL: http://codereview.chromium.org/335032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30108 0039d316-1c4b-4281-b951-d872f2087c98

version, legal block, and update icon (if present) should all line up.

BUG=25582
TEST=Look at it.  Come over here and look at it.
Review URL: http://codereview.chromium.org/334031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30107 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/338008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30106 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=18020

Review URL: http://codereview.chromium.org/329013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30105 0039d316-1c4b-4281-b951-d872f2087c98

layout test dashboard. Also, if a path does not match any failing
tests, then assume it's a full path so we can still show it's expectations.
Review URL: http://codereview.chromium.org/334030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30104 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/333019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30102 0039d316-1c4b-4281-b951-d872f2087c98

a new update check even when an existing update check or installation attempt
is in progress.

Remove the check that validates that the Update button is disabled after
being clicked.  This test has become very fragile now that the Update button
reliably enables itself as soon as an update installation attempt fails.

BUG=13165
TEST=Get the About box to offer you the opportunity to install an update.
     Click "Install Now".  Close the About box and quickly reopen it.  The
     update status should be "Installing new version..." and not "Checking
     for updates..."
Review URL: http://codereview.chromium.org/339010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30100 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/297015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30099 0039d316-1c4b-4281-b951-d872f2087c98

BookmarkBubbleController has been made an NSWindowController instead of the
view controller that it used to be, and now loads its window from the nib instead
of creating it on the fly. Also cleans up fullscreen mode so that the window
referenced from browser_window_controller stays constant instead of having
[self window] and window_ potentially pointing at two different windows.

BookmarkBubble.xib has been modified so that it instantiates a window containing
a bubble view instead of just instantiating a view.

BUG=25054
TEST=Try going in and out of full screen mode. Try bringing up a bookmark bubble by clicking on the star. Try creating a pile of windows and then quitting,
Review URL: http://codereview.chromium.org/333017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30095 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/330020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=18120
TEST=Open google.com, type Ctrl+F, type in garbage. Erase one letter at a time and there should be no beeping while you erase. Try it again, but this time use shift-delete to cut a few letters off the end. It should not ding. Now Copy the whole find string, press Esc, open Find again and on Paste it should not ding.

Review URL: http://codereview.chromium.org/338005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30092 0039d316-1c4b-4281-b951-d872f2087c98

o Adds Cocoa implementation of the extension installation prompt.
o Added new cross-platform implementations of the extension install error prompt.
o Got rid of unused extension install strings from early implementations.
o Added a string to display as the header of the error dialog, since it was inline English.

Patch by Andrew Bonventre <andybons@gmail.com>

BUG=19654
TEST=Install an extension on any platform, observe consistent visual behavior and messaging.
Review URL: http://codereview.chromium.org/333015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30091 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ojan

Review URL: http://codereview.chromium.org/335033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30089 0039d316-1c4b-4281-b951-d872f2087c98

This also cleans up some of the InfoBubbleGtk code a bit.

BUG=23373
TEST=tested LTR and RTL under metacity

Review URL: http://codereview.chromium.org/332022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30088 0039d316-1c4b-4281-b951-d872f2087c98

BookmarkHTMLWriterTest.Test (suspected resource flakiness)
LoginPromptTest.TestTwoAuths

TEST=none
BUG=17592, 25794

Review URL: http://codereview.chromium.org/332024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30087 0039d316-1c4b-4281-b951-d872f2087c98

BUT=24145
Review URL: http://codereview.chromium.org/338024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30086 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ojan

Review URL: http://codereview.chromium.org/337029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25823
TEST=HostCacheTest.KeyComparator

Review URL: http://codereview.chromium.org/338023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30084 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=gspencer

Review URL: http://codereview.chromium.org/337028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30083 0039d316-1c4b-4281-b951-d872f2087c98

 * Swapped the positions of entry field and navigation buttons.
 * Hide navigation buttions when the entry field gains focus.
   - To implement this, I added OnKillFocus in AutocompleteEditController, and updated
     corresponding files.
 * Added accelerator (shift-ctrl-0) to toggle compact navigation bar
Changes to BrowserExtender
 * Made all virtual methods in BrowserExtender pure virtual.
 * Added HideToolbar method to control visibility of toolbar from Extender.

Review URL: http://codereview.chromium.org/329009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30082 0039d316-1c4b-4281-b951-d872f2087c98

TEST=build test_shell_tests only and run.
BUG=none
Review URL: http://codereview.chromium.org/335030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30081 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow

Review URL: http://codereview.chromium.org/332028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30080 0039d316-1c4b-4281-b951-d872f2087c98

Fixes cmd-c, cmd-v, cmd-x, cmd-a.

The menu blinking is worth the extra IPC hop.

BUG=25254
TEST=Select text, hit cmd-c. "Edit" menu should blink. Hit cmd-v. "Edit" menu should blink again, correct text should be pasted.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30045
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=30046

Review URL: http://codereview.chromium.org/330014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30079 0039d316-1c4b-4281-b951-d872f2087c98

The About box now knows how to check to see if updates have been installed
in the background without anyone having to click the Update button in the box.

The About box no longer gets stuck in the "installed" state.  Even if an
update has been installed, the About box will still check for new updates when
reopened.

BUG=13165, 20488
TEST=Play with the about box and auto-update a whole lot
Review URL: http://codereview.chromium.org/338012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30078 0039d316-1c4b-4281-b951-d872f2087c98

Adjusted timeouts for a couple failing tests; switched from umount to hdiutil detach to solve some unmounting problems seen on Tiger.
Review URL: http://codereview.chromium.org/332030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/329020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/307030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30074 0039d316-1c4b-4281-b951-d872f2087c98

* added member vars for main menu and compact navbar
* show/hide main menu/compact navbar/status area upon fullscreen mode change.

I'll work on linux_views as well.

BUG=22805
TEST=Create new window from compact navbar menu, and toggle full screen mode

Review URL: http://codereview.chromium.org/332027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30073 0039d316-1c4b-4281-b951-d872f2087c98

When creating the canvas, take cues from the image we
just loaded and don't hard code it to 19x19. This way
we can have smaller than 19x19 icons that show up
centered within the browser icon button.

This doesn't attempt to deal with scaling down images
that are too large to fit the 19x19 canvas, but we
haven't decided how to handle those anyway.

BUG=25487
TEST=Load the api_test/browser_action_tab_specific_state
extension and click on the browser action. The red
square within the button should not grow in size as you
click.

Review URL: http://codereview.chromium.org/337026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30072 0039d316-1c4b-4281-b951-d872f2087c98

This does not fix undo, it just makes the implementation break it
less.

BUG=18084
TEST=Omnibox should continue to work.

Review URL: http://codereview.chromium.org/337027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30071 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/330015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30070 0039d316-1c4b-4281-b951-d872f2087c98

This can happen legitmately if the icon has been moved or
corrupted on disk.

I think we are hitting it too frequently for that to be the
whole explanation, but since this code is moving around a
lot shortly, it seems prudent to put in the quick fix and
worry about what's really going on post-refactor.

BUG=25601
TEST=Remove an extension's page action icon from its folder after installation. Should not crash when attempting to show page action.

Review URL: http://codereview.chromium.org/339005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30069 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/338022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30068 0039d316-1c4b-4281-b951-d872f2087c98