- 14 Jun, 2019 40 commits
-
-
Yuwei Huang authored
ChromeOS builders build Chrome with CFI cast check enabled, so using reinterpret_cast on invalid/uninitialized pointer will crash Chrome. This is what happened in grpc_core::InlinedVector, which tries to use reinterpret_cast before initializing the storage. While the proper fix should be calling the placement-new operator directly on the raw (void*) pointer, the easiest and safest fix for M76 is just to disable CFI cast checks when building the gRPC library. I've verified that the crash was reproducible with ftl_signaling_strategy if I add `is_cfi=true` (and other required arguments) to GN args, and the crash goes away once I've added these compiler flag. Bug: 972108 Change-Id: Idf874a028af002fafe3a4905d70a3bca71777e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660194 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#669203}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/84cadff4..9d6e3fed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I61295e6a81af8b2df4717f1214f1715d73db1a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660090Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669202}
-
Henrique Ferreiro authored
This CL changes LegacySetPrimaryAccount() to call PrimaAccountManager::SignIn() rather than SetAuthenticatedAccountInfo(). This is part of a series of CLs to port ChromeOS to use PrimaryAccountMutator, to unify its behaviour with the other platforms, as described in https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto Bug: 814787, 944012 Change-Id: Idf67c8238dfef3991e6245018c0bc1f2b244f6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651732 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#669201}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/a98fad02c421..848dfb7e1d7b $ git log a98fad02c..848dfb7e1 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 junyer Don't let DFA execution bail when slow for RE2::Set. 2019-06-13 junyer Expose FilteredRE2::GetRE2() as public. 2019-05-22 junyer Add GCC 9.x to the Travis CI matrix. 2019-05-05 junyer Fix the bug in Regexp::ToString() that emitted [^]. 2019-04-19 junyer Set an ALIAS and a NAMESPACE in the CMake configuration. 2019-04-18 junyer Configure CMake to install the re2Config "export". 2019-04-17 junyer Address some clang-tidy gripes. 2019-04-11 jbw Update Consume's method comment re: empty matches. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: If8e2a986fc61d83691faa5c797a48a91c8894f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660111Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#669200}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9e25f74faab6..ad82e8e1a685 git log 9e25f74faab6..ad82e8e1a685 --date=short --no-merges --format='%ad %ae %s' 2019-06-14 titovartem@webrtc.org Fix: restore disabling PC smoke test on iOS 2019-06-14 nisse@webrtc.org Refactor WavWriter to use FileWrapper rather than PlatformFile 2019-06-14 philipel@webrtc.org Revert "Populate the GFD-00 for H264 and generic codecs." 2019-06-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 96eca2d4..f165a6d5 (668951:669076) 2019-06-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 22f062d6..96eca2d4 (668845:668951) 2019-06-13 hta@webrtc.org Remove DataContentDescription shim 2019-06-13 titovartem@webrtc.org Add support for simulcast with Vp8 from caller into PC level quality tests. 2019-06-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b08bd9b6..22f062d6 (668716:668845) 2019-06-13 philipel@webrtc.org Populate the GFD-00 for H264 and generic codecs. Created with: gclient setdep -r src/third_party/webrtc@ad82e8e1a685 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none,chromium:None,chromium:None,chromium:None,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib980e86620aae9af610af5634b13d60c42f2072d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669199}
-
Morten Stenshorne authored
Only test with single-thread. Multi-thread is flaky. Reproduced locally. TBR=loyso@chromium.org Bug: 974193 Change-Id: I97926cd7ba4fff054da8e69ef3893b0878cea5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660438Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#669198}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e180b0a9ba35..9e77d1e7e6c4 Created with: gclient setdep -r src-internal@9e77d1e7e6c4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mmentovai@google.com,aboxhall@google.com,mstensho@google.com,oksamyt@google.com Change-Id: Id7a6e15df59753983699a2729249e1fdcd9e47d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660195Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669197}
-
Morten Stenshorne authored
All tested locally, and found to be flaky. Example from bot run: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/81090 TBR=toyoshim@chromium.org Change-Id: I27642002b553e9b153619f09e305c9403e1bc1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660558Reviewed-by:
-
Sergio Villar Senin authored
After removing ScopedMockClock in crrev.com/c/1593257, the last user of SetTimeFunctionsForTesting() is gone so we are safe now to completely remove it from the tree. This means that global time overrides are gone now. We cannot remove Blink's wtf/time.h though because there are still a few utility functions there which are widely used in the source tree. They will be removed in follow up patches. Bug: 919383 Change-Id: Ic592138c772cfc7f2626c7426f177fd9c7fccaee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593372 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
-
Morten Stenshorne authored
This reverts commit df9f21ad. Reason for revert: AppShimInteractiveTest.ShowWindow fails https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/12440 Original change's description: > MacPWAs: Only recreate shims for bookmark apps > > Because PWAs (and anything using RemoteCocoa) need an app shim to be > running to get anything on-screen, we added code to re-create an app > shim if one cannot be launched. > > But this re-creation wasn't guarded on being a PWA, and as a consequence > platform apps would go and create app shims that nobody expected to > exist. So let's not do that. > > Some tests were inappropriately relying on this behavior. Update > WebAppShortcutCreator to be more explicit about where it creates and > updates its shortcuts. > > Also, re-enable tests in component build (that was fixed a while ago > in crrev.com/619648). > > Bug: 941160 > Change-Id: I5fb233f346095116d28ddbbfa9e23aca1bb1eab3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657522 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669111} TBR=raymes@chromium.org,ccameron@chromium.org,dominickn@chromium.org Change-Id: Iaad4883732a1c60d820454c262277f1cc364ae41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660562Reviewed-by:
-
Hugo Holgersson authored
Background: Some web apps use one "catch all"-click handler, often put on <body> or a container <div>, to react on clicks within certain areas of the page. These web pages expect clicks (or touches) and are not designed with key[board] users in mind (they lack tabindex). These pages' clickables, for example <div>s that look like buttons, are often styled with {cursor: pointer}. Problem: These web pages are inaccessible for keyboard-only users. Solution: Enable SpatNav on these web apps by adding {cursor: pointer} sub trees' tip to the list of navigation candidates. Spec discussion: https://github.com/w3c/csswg-drafts/issues/3395 Note: snav-imagemap-area-not-focusable.html found a bug in Chrome's UA CSS. We used to style *all* <area>s as clickables, with {cursor: pointer}, even those without a href-attribute. I fixed this in crrev.com/c/1653009. Bug: None Change-Id: I7baa2ba6f5f36ebc23b072d677edc66acfb2a70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632231 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#669193}
-
Dave Tapuska authored
Pass the CSP and feature policy headers into the navigation context. This allows the normal flow to occur and we don't need to call internal methods to adjust the security origin or sandbox flags after the document is constructed. BUG=970360 Change-Id: I9c936534be22e97c5d8b1e7e5913b2d18ca559f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656455Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#669192}
-
Mattias Nissler authored
This checks whether the legacy U2F feature is enabled and notifies the user about a security vulnerability. BUG=chromium:967396 TEST=Manual Change-Id: I24a227a40ececa2ba533dd6d825e521422bb6fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634706 Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#669191}
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. Bug: 959157 Change-Id: I3f40532f997e5a6b31989fa8c1fa64f4213a0e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653015Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#669190}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/765b75c294d2..f20f2183e4f4 git log 765b75c294d2..f20f2183e4f4 --date=short --no-merges --format='%ad %ae %s' 2019-06-14 primiano@google.com Don't pull sqlite and zlib in embedder builds Created with: gclient setdep -r src/third_party/perfetto@f20f2183e4f4 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:974157 TBR=perfetto-bugs@google.com Change-Id: Ie9a48a19e9fc96d42f7cc0a0c00ffe2db9b9540b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659962Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I41180f17a08cc1ae457942d420b0061476a90333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659963Reviewed-by:
-
Morten Stenshorne authored
This reverts commit cc865b09. Reason for revert: Causes content_browsertests flakiness https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/39038 Original change's description: > Expose State::kIgnored and Serialize Line Breaking Objects > > ~~~ > Note that this change has a very large file and edit count, but only > because there are a lot of tests that needed to be remastered due to > the new ignored nodes in the tree. > > Of the (+/-) ~11k edits, only ~300 were actual code across ~30 files. > > Files reviewers will find the most interesting (not in any particular order) : > content/browser/accessibility/browser_accessibility.cc > content/browser/accessibility/browser_accessibility_com_win.cc > content/browser/accessibility/browser_accessibility_manager_win.cc > content/renderer/accessibility/render_accessibility_impl.cc > third_party/blink/renderer/modules/accessibility/ax_layout_object.cc > third_party/blink/renderer/modules/accessibility/ax_object.cc > third_party/blink/renderer/modules/accessibility/ax_position.cc > ui/accessibility/ax_assistant_structure.cc > ui/accessibility/ax_tree_serializer.h > ~~~ > > Purpose of this change: > > In order to implement AX Paragraph navigation > i.e. ITextRangeProvider::MoveEndpointByUnit [TextUnit_Paragraph], > we need to know where Line Breaking Objects are in order to determine > where paragraph boundaries are. > This is the first change that will allow State::kIgnored nodes to be > serialized. > > More notable changes : > > 1. AXTreeSerializer needs to be aware of Ignored nodes during > invalidation (SerializeChangedNodes). The ignored state is cached > on the AXObject, but not in an easily notifiable manner. > Firing an event, or marking an object dirty from > |AXObject::UpdateCachedAttributeValuesIfNeeded| does not seem to be > a reliable solution, since the notification can happen during > serialization, so handling the event *may* come a frame too late > for tests. Caching this state on the ClientTreeNode as well makes > invalidating on the ignored state change easier and more > predictable. > > 2. Moved EVENT_OBJECT_NAMECHANGE out of browser_accessibility_com_win, > now in response to AXEventGenerator::Event::NAME_CHANGED. > > 3. Add AXEventGenerator::Event::IGNORED_CHANGED. This is special in > that the browser process will ignore ALL other events when the > ignored state has changed on Windows, since this is handled as a > SHOW / HIDE event. For example, it wouldn't make sense to fire > a NAME_CHANGED along side a HIDE / SHOW event, since the node > is either new or "removed" from the tree exposed to ATs. > > 4. Updating RenderAccessibilityImpl::SendPendingAccessibilityEvents, > if an event is fired from an ignored node, this would previously > walk up to the unignored parent and fire it on that node instead. > Unfortunately, that means that all ignored nodes between were not > being invalidated. For example, if you changed text of a leaf node, > and it had ignored ancestors that are NameFrom::kContents, these > would not be invalidated, only the unignored parent would be. > There were similar issues with the kChildrenChanged event not > invalidating ignored ancestors, leaving the tree in a bad state. > Now invalidating all ignored nodes that are included in the tree > during the walk up. > > 5. Adding BoolAttribute::kIsLineBreakingObject, and serializing all > ignored "Line Breaking" nodes in the tree. > > Bug: 651614, 847971 > Change-Id: I92dfe0baa526e1ac4116ef1941ebad7d033ca11c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611021 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#668859} TBR=kinuko@chromium.org,nektar@chromium.org,hnakashima@chromium.org,kbabbitt@microsoft.com,iapres@microsoft.com,adettenb@microsoft.com Change-Id: Ibbf80ab29e140b39685599456cc674313d9dfe51 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 651614, 847971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660498Reviewed-by:
-
Morten Stenshorne authored
Fixes: * fast/canvas/canvas-composite-video-shadow.html * fast/canvas/canvas-composite-video.html * fast/canvas/canvas-drawImage-video.html * media/alpha-video-playback.html * media/video-canvas-alpha.html * virtual/gpu/fast/canvas/canvas-composite-video-shadow.html * virtual/gpu/fast/canvas/canvas-composite-video.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/39051 Problems introduced between b1df796c and c0d704ab Maybe this one? https://chromium-review.googlesource.com/c/chromium/src/+/1658775 TBR=juanmihd@chromium.org Change-Id: I7ff00503448e7fcdd9d4c1f3478eb73b3a3f455b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660428Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/152de7c37fc5..e180b0a9ba35 Created with: gclient setdep -r src-internal@e180b0a9ba35 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mmentovai@google.com,aboxhall@google.com,mstensho@google.com,oksamyt@google.com Change-Id: I013bf03a06d3606ed383258f38d865b6d44ca593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660060Reviewed-by:
-
Morten Stenshorne authored
This reverts commit 15109503. Reason for revert: Doesn't compile on Windows. https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder/72866 Original change's description: > [ribbon] Generate all CSSProperty subclasses in longhands/shorthands.h. > > This removes the need to manually update core/BUILD.gn as well as > longhands/shorthands_custom.cc when adding a new property. Adding a new > property will still not be frictionless, but this improves the situation > somewhat. > > This also enables us to make some nice cleanups, since we can always > assume that a .cc file exists for a given property (that was not the > case before). > > * style_builder_functions don't have to support generating Apply > functions in headers. > * We can remove the logic that figures out whether to put Apply functions > in the header or not. > * We can remove the preposterous code that tries to optimize #includes > based on aspects of the property. > * Remove lots of code that figures out the names of all the .h and .cc > files. > > In addition, this CL does some other cleanups, just because: > > * CSSPropertiesWriter must not inherit behavior from > CSSPropertyBaseWriter. This just makes it harder to understand what > is happening. Prefer composition, and use css_properties.CSSProperties > directly. > * CSSPropertyBaseWriter is actually the generator for the property > instance files, so rename it. > * Make generation of Flags nicer, without crazy formatting in the result. > * Remove kSupportsPercentage. (Unused). > > Change-Id: Ib9e241d363008ef39d2fdbe04bc98ae037654d2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657893 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669179} TBR=futhark@chromium.org,andruud@chromium.org Change-Id: I2b1f71aa50da5371a302f7ece54548116c098ade No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660552Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/853ebacf99a4..9520a2464c65 git log 853ebacf99a4..9520a2464c65 --date=short --no-merges --format='%ad %ae %s' 2019-06-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 9866ad9195ce..96ee92f09b7c (1 commits) Created with: gclient setdep -r src/third_party/angle@9520a2464c65 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Change-Id: Ib005abf2961cc03246a9c25a6ef444a17f8c62bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660059Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/df69f2482462..55ab6aacacb1 git log df69f2482462..55ab6aacacb1 --date=short --no-merges --format='%ad %ae %s' 2019-06-14 cwallez@chromium.org Fix compilation of the GL backend on Windows Created with: gclient setdep -r src/third_party/dawn@55ab6aacacb1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I6e1539ed9a4d1cd22d25482ec5d1bfc75a6c9416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659957Reviewed-by:
-
Robbie Gibson authored
Similar to CL 1596434, the root cause of the crash is a difference between the width of the shortcuts collection view and the width the shortcuts collection view is using to calculate its insets. Here, after the device is rotated back to portrait mode, the width of the collection view is still the landscape width, while it's using the portrait width to calculate insets. To fix this, this CL uses a different method. Instead of the collection view centering itself, instead the popup view controller takes care of that. It can then respond to the rotation and cell appearance events and center the shortcuts view correctly. In omnibox_popup_presenter, the [popup layoutIfNeeded] line was causing issues because the popup would get laid out too early, causing it to have the wrong safe area insets. Layout out the superview will also cause the popup to layout, so explicitly layout out the popup shouldn't be necessary. Bug: 961775 Change-Id: I9ff65ce2f42f11cac5b45b59a8f9df2bc5bb3d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658010 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#669181}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/608c4a9c..84cadff4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I31582630f060c4c55a891b4e903cc5dd7f1fb6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660172 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Anders Hartvoll Ruud authored
This removes the need to manually update core/BUILD.gn as well as longhands/shorthands_custom.cc when adding a new property. Adding a new property will still not be frictionless, but this improves the situation somewhat. This also enables us to make some nice cleanups, since we can always assume that a .cc file exists for a given property (that was not the case before). * style_builder_functions don't have to support generating Apply functions in headers. * We can remove the logic that figures out whether to put Apply functions in the header or not. * We can remove the preposterous code that tries to optimize #includes based on aspects of the property. * Remove lots of code that figures out the names of all the .h and .cc files. In addition, this CL does some other cleanups, just because: * CSSPropertiesWriter must not inherit behavior from CSSPropertyBaseWriter. This just makes it harder to understand what is happening. Prefer composition, and use css_properties.CSSProperties directly. * CSSPropertyBaseWriter is actually the generator for the property instance files, so rename it. * Make generation of Flags nicer, without crazy formatting in the result. * Remove kSupportsPercentage. (Unused). Change-Id: Ib9e241d363008ef39d2fdbe04bc98ae037654d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657893Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#669179}
-
Sergio Villar Senin authored
This is the last step of the work started in crrev.com/c/1518518. After replacing all the usages of ScopedMockClock by TestMockTimeTaskRunner we can safely remove the former. The reason why the latter is preferred is because it does not need to globally override the time functions, and thus removes the dependency with Blink's wtf/time.h header. Bug: 919383 Change-Id: I1c6c1954182f8dcdc86657fd1b8373336d07282b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593257 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#669178}
-
Morten Stenshorne authored
This reverts commit 46639e93. Reason for revert: Compile error. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/3334 Original change's description: > Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..ad464887b (53 commits) > > This CL is necessary to fix the gcc 4.8 build: > https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/ad464887b93526235ce06bbf97cd396ed6232b9a > > Wanted for this CL, which improves the debugging experience: > https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+/78822a68537b5941eb86e11a5066aa549c30998f > > https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+log/5938e0582bac..ad464887b935 > > $ git log 5938e0582..ad464887b --date=short --no-merges --format='%ad %ae %s' > 2019-06-13 thomasanderson [libc++] Fix build with gcc 4.8 > 2019-06-13 ldionne [libc++] Add missing #include in <cwchar> tests > 2019-06-13 eric Make GCC in C++03 Unsupported > 2019-06-12 ldionne [libcxx] XFAIL set/multiset CTAD tests on Apple Clang 10 > 2019-06-12 ldionne [libcxx] XFAIL some CTAD tests on AppleClang 10 > 2019-06-12 eric Apply [[nodebug]] to typedefs throughout the STL. > 2019-06-11 eric Move libc++ specific tests for std::function out of the std directory > 2019-06-11 eric Add documentation and tests for Clangs C++11 extensions in C++03. > 2019-06-11 ldionne [libcxx] Mark CTAD tests for set and multiset as unsupported on older Apple Clangs > 2019-06-11 mclow.lists Mark CTAD fail tests for set/multiset as XFAIL for older compilers that give different error messages > 2019-06-11 mclow.lists XFAIL a couple of tests on apple-clang-9.1, which is a compiler that I didn't know existed > 2019-06-11 eric Check in test that demonstrates ABI break for std::function. > 2019-06-11 ldionne [libc++] Implement deduction guides for <set> > 2019-06-11 ldionne [libcxx] Make std::tuple<> trivially constructible > 2019-06-11 ldionne [libcxx] Slightly improved policy for handling experimental features > 2019-06-11 mclow.lists Add a test for is_base_of and incomplete types. Because this trait uses a compiler intrinsic which was broken in many clangs, have lots of XFAILs. > 2019-06-11 mclow.lists XFAIL a couple of CTAD tests on clang-6; it gives different error messages than clang 7/8/9 > 2019-06-10 mclow.lists Recommit r362649, which was reverted in r262680 because of bugs in std::to_chars (which have now been fixed). Speedup to_string and to_wstring for integers using stack buffer and SSO > 2019-06-10 mclow.lists Implement deduction guides for map/multimap. Reviewed as https://reviews.llvm.org/D58587. Thanks to Quuxplusone for the submission. > 2019-06-10 zy [libc++] Fix leading zeros in std::to_chars > 2019-06-08 eric update debugging docs to be less out of date > 2019-06-08 eric Substantially reduce instantiations and debug size of std::function > 2019-06-08 eric Fix some incorrect std::function tests > 2019-06-06 vlad Revert "Speedup to_string and to_wstring for integers using stack buffer and SSO." > 2019-06-05 ldionne [libcxx][test] Include test_workarounds.h where needed > 2019-06-05 mclow.lists Update issue statuses. Reviewed as https://reviews.llvm.org/D62932 > 2019-06-05 mclow.lists Speedup to_string and to_wstring for integers using stack buffer and SSO. Reviewed as https://reviews.llvm.org/D59178 Thanks to ivafanas for all his work on this patch. > 2019-06-04 ldionne [libcxx] Add test to check min/max requirement to regular expression > 2019-06-04 mclow.lists No longer reject inputs when using a locale that has grouping information _and_ the input has no grouping characters at all. We continue to reject cases when the input has grouping characters in the wrong place. Fixes PR#28704 > 2019-06-04 mclow.lists We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM) now require GCC 5.1, so that's not a problem any more. Re-enable the assertion. Fixes PR#36863 > 2019-06-02 phosek [libcxx] Use libtool when merging archives on Apple platforms > 2019-05-31 mclow.lists Add include for 'test_macros.h' to all the tests that were missing them. Thanks to Zoe for the (big, but simple) patch. NFC intended. > 2019-05-30 ldionne [libcxx] Add regex test cases from PR40904 > 2019-05-30 jryans [Docs] Modernize references to macOS > 2019-05-30 phosek [runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files > 2019-05-30 phosek [libcxx][libcxxabi] Remove the unused CMake checks > 2019-05-30 phosek [runtimes] Use -Wunknown-pragmas for the pragma check > 2019-05-30 phosek [runtimes] Check if pragma comment(lib, ...) is supported first > 2019-05-30 phosek [runtimes] Support ELF dependent libraries feature > 2019-05-29 ldionne [NFC][libcxx] Remove trailing whitespace > 2019-05-29 mclow.lists Add additional constraints on midpoint(pointer, pointer). Fixes PR#42037. > 2019-05-29 eric Fix build breakage on 32-bit machines > 2019-05-29 eric Rework std::type_info definition to support systems without fully merged type info names. > 2019-05-28 mclow.lists Fix test that used raw string literals. Doesn't work in C++03 > 2019-05-28 mclow.lists Fix an incorrect 'Throws' in the regex code. Add a test for the new behavior. Reviewed as https://reviews.llvm.org/D61828. Thanks to Mark for the catch and the fix. > 2019-05-24 eric fix test for older clang versions > 2019-05-24 eric fix destroying delete test with older apple compilers > 2019-05-24 eric Update C++2a status for destroying delete > 2019-05-23 eric P0722R3: Implement library support for destroying delete > 2019-05-23 chris.bieneman [CMake] Copy C++ headers before configuring runtimes build > 2019-05-23 ldionne [libcxx][tests] Fix order checking in unordered_multiset tests. > 2019-05-22 phosek [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++ > 2019-05-22 ldionne [libcxx][test] Fix order checking in some more unordered_multimap tests > > Created with: > roll-dep src/buildtools/third_party/libc++/trunk > > BUG=None > R=thakis > > Change-Id: Iaa0f8a7d6d8bec28f6026fbb71b620eac6c0188c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658438 > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669112} TBR=thakis@chromium.org,thomasanderson@chromium.org Change-Id: I38cdf788a36801753b29325309ffbd3b0501a7fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660551Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9c0830133b07..42830e5a68c3 git log 9c0830133b07..42830e5a68c3 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 afdx@google.com Add replayer tool for spirv-fuzz. (#2664) 2019-06-13 33432579+alan-baker@users.noreply.github.com Add validation for Subgroup builtins (#2637) Also rolling transitive DEPS: src/third_party/spirv-headers/src de99d4d834ae..8b911bd2ba37 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@42830e5a68c3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Id6df05fe8a5cb653496f404bf441c484daabe19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660115Reviewed-by:
-
Jordan Demeulenaere authored
Change-Id: I3e337db32861e4de28eee6705e9c43d5a543c40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660431Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#669175}
-
Julie Jeongeun Kim authored
This CL is the 1st CL to separate access token management from Oauth2TokenService. It creates OAuth2AccessTokenManager and moves |token_cache_| with RegisterTokenResponse() and GetCachedTokenResponse() which are not dependent on other data in OAuth2TokenService. After this CL, each functionality related to access token management will be moved to OAuth2AccessTokenManager. Bug: 950159 Change-Id: I9558dc5253d73bf34326c280f742052bec9138b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655212 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
Noel Gordon authored
onFileSelectionChanged_ calls setSelectedEntry on the Quick View model and then calls display_(). But display_() calls updateQuickView_ which also calls setSelectedEntry on the Quick View model again, on the same file entry! Since setSelectedEntry causes metadata fetch and draw "now two draws have you" ... Result: setSelectedEntry async fetches and draws entry metadata in the Quick View metadata box. If you call it twice, it fetches/draws twice, (async) and worse, it clears the metadata box HTML content between the calls. Some users notice the UI re-draw flash. Fix this: call updateQuickView_ directly and let it handle setting the Quick View model selection, which minimizes UI flash potential by only fetching and rendering the entry metadata once. Test: browser_tests --gtest_filter="QuickView/FilesAppBrowserTest*" Tbr: lumult@ Bug: 965370, 973397 Change-Id: I89af82346e9d76754c6fe81edc71364e8d052595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657861Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669173}
-
Henrik Grunell authored
Bug: 874784 Change-Id: Ie556fab3edba08e9e05a1a4b4ea754b63df3148d No-Try: true Change-Id: Ie556fab3edba08e9e05a1a4b4ea754b63df3148d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655439 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#669172}
-
Yoshifumi Inoue authored
This patch changes |FrameSelection::Selected{Text,HTML}ForClipboard()| not to use |VisibleSelection| to avoid editing boundary adjustment. Because of selection editing boundary adjustment should be applied for selection set by scripts. This patch is a follow-up of CL[1] which does editing boundary adjustment correctly. Note: This patch changes |selection_test()| to access test window to use selection in test window in <iframe>. [1] http://crrev.com/c/1102157 Avoid crossing editing boundaries selection. Bug: 928726 Change-Id: I7b9716679764f2b8821289c202e8c2c56d94ce06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647651 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#669171}
-
Koji Ishii authored
This patch fixes two problems that can fail to mark destroyed |LayoutObject| in |NGPaintFragment|, the mechanism added in r667421 (crrev.com/c/1642495). The first problem was that because |CollectInlines| clears |FirstInlineFragment|, objects destroyed between |CollectInlines| and |Layout| are not marked. We used to clear |LayoutObject| flags in |CollectInlines| but they were moved to |NGInlineLayoutAlgorithm|. This was a left over. Although the above was a problem, no objects should be destroyed between |CollectInlines| and |Layout|. This occurred, because |SetChildNeedsCollectInlines| marked excessively to grand parents in some cases. This happened before for |LayoutSVGRoot| in crbug.com/966699, but r663760 did not cover out-of-flow |LayoutButton|, when |position: absolute| resets |IsAtomicInlineLevel|. This patch changes "when to stop" to "when to continue" to avoid possible further edge cases. While either fix can prevent the reported crashes, this patch fixes both problems in case the other one may hit for other reasons. Bug: 972413, 972816 Change-Id: I1942afad3091baf7412e3b69681b3503cb0c65d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654755 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#669170}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/87e885038893..c3252a04b377 git log 87e885038893..c3252a04b377 --date=short --no-merges --format='%ad %ae %s' 2019-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 85fef1bc62f8..853ebacf99a4 (14 commits) 2019-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f6ed3144..a2197be6 (428 commits) 2019-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader df84b9466cfd..8c12f564113c (5 commits) Created with: gclient setdep -r src/third_party/skia@c3252a04b377 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@google.com Change-Id: I70bedb5f9ce39478023d2218c29ef2dd5533768f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660173Reviewed-by:
-
Takashi Toyoshima authored
Bug: 773295 Change-Id: I37fd708a0224d82a460204e9b8f5617c34200e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657387 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#669168}
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. Bug: 959157 Change-Id: I6f43a0ba28f7eefaa954482ccad638c3fe4c46e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655450Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#669167}
-
Pauline Leitao authored
Bug: 919926 Change-Id: I3e701d52889fc87e9d2ca734d1091f9092633e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655434Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Pauline Leitao <psivieroleitao@google.com> Cr-Commit-Position: refs/heads/master@{#669166}
-
Morten Stenshorne authored
This reverts commit b47670a1. Reason for revert: Caused content_browsertests failure. https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/23929 Original change's description: > Migrate aec_dump_messages.h to Mojo > > A nice side-effect of this change is that it moves complexity out of > RenderProcessHostImpl. > > Bug: 967834 > Change-Id: I39e93344e1db84668ef11b535447160ee3ab54cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654238 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Darin Fisher <darin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#668864} TBR=jam@chromium.org,darin@chromium.org,tsepez@chromium.org Change-Id: I07567f80a6596510cb0bcf123e37d87158406647 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660492Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 04d43cf5. Reason for revert: This is culprit of https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel?limit=200 Original change's description: > [WebSocket] Add --websocket-renderer-receive-quota-max command line flag. > > This patch adds the flag that overrides default threshold value > that the renderer calls AddReceiveFlowControlQuota() to the browser per > receiving this amount of data so that the browser can continue sending > remaining data to the renderer. > Default value is 32k Bytes. > > The more the value is, browser tends the less stop sending packets > and then consumes more memory. > > This flag will be used to investigate the performance issue. > You can use this flag both on chrome and content_shell: > $ ./chrome.exe --websocket-renderer-receive-quota-max=3000000 > This flag sets the threshold 3M Bytes. > > Implementation detail: > This patch moves the default value constant from blink to > net/websockets/websocket_channel.h so that we can pass the command line > flag to the renderer. > This change also enables us to modify the value while considering sent buffer > from a server later on for further optimization. > > Bug: 865001 > Change-Id: Ib0f9638ece24fbc0523b94345d09a4382e9cf6a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642850 > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669123} TBR=kinuko@chromium.org,ricea@chromium.org,yhirano@chromium.org,yoichio@chromium.org,karandeepb@chromium.org Change-Id: Ie05433698213a42e86d27c94d1d995f93ff8c549 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660391Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#669164}
-
