GitLab

Partial rollback of
https://chromiumcodereview.appspot.com/10543015/

TBR=sail@chromium.org
BUG=95425
TEST=browser_tests --gtest_filter=WebUIBidiCheckerBrowserTestRTL.TestSettingsPage (ASAN)

Review URL: https://chromiumcodereview.appspot.com/10540134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141794 0039d316-1c4b-4281-b951-d872f2087c98

Mac 10.6, v8_benchmark: Unclear regression. Probably just slight increase in noise
http://build.chromium.org/f/chromium/perf/mac-release-10.6/v8_benchmark/report.html?history=350&rev=141737

TBR=cmp

Review URL: https://chromiumcodereview.appspot.com/10545145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141793 0039d316-1c4b-4281-b951-d872f2087c98

This makes RequestMediaAccessPermission a part of WebContentsDelegate instead
of ContentBrowserClient. The request UI (or lack thereof) needs to be
controlled by the WebContentsDelegate so that platform apps can grant permission
differently than a normal browser. This also seems appropriate because
each request is made on behalf of a particular web contents.

BUG=130216
TEST=navigator.webkitGetUserMedia still works for normal web pages

Review URL: https://chromiumcodereview.appspot.com/10542092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141792 0039d316-1c4b-4281-b951-d872f2087c98

Reorder functions in AutocompleteActionPredictor so that if A calls B calls C, they're listed A, B, C.  (The existing order seemed kind of random.)

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10548015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141791 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141790 0039d316-1c4b-4281-b951-d872f2087c98

Avoids link error:

[14->2/16 ~0] LINK(DLL) initial\chrome.dll
FAILED: python gyp-win-tool link-wrapper "c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\link.exe" /nologo /IMPLIB:initial\chrome.dll.lib /DLL /OUT:initial\chrome.dll /PDB:initial\chrome.dll.pdb @initial\chrome.dll.rsp
browser.balloon_collection_impl_ash.obj : error LNK2019: unresolved external symbol "public: bool __thiscall chromeos::BalloonViewHost::AddWebUIMessageCallback(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::Callback<void __cdecl(class base::ListValue const *)> const &)" (?AddWebUIMessageCallback@BalloonViewHost@chromeos@@QAE_NABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABV?$Callback@$$A6AXPBVListValue@base@@@Z@base@@@Z) referenced in function
"public: bool __thiscall BalloonCollectionImplAsh::AddWebUIMessageCallback(class Notification const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::Callback<void __cdecl(class base::ListValue const *)>
const &)" (?AddWebUIMessageCallback@BalloonCollectionImplAsh@@QAE_NABVNotification@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABV?$Callback@$$A6AXPBVListValue@base@@@Z@base@@@Z)
initial\chrome.dll : fatal error LNK1120: 1 unresolved externals


R=ben@chromium.org,cpu@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10540128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141789 0039d316-1c4b-4281-b951-d872f2087c98

https://chromiumcodereview.appspot.com/10548003/

Review URL: https://chromiumcodereview.appspot.com/10533109

TBR=robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/10543126

TBR=cpu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10536133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141788 0039d316-1c4b-4281-b951-d872f2087c98

For UMA opted-in users, record the typed_counts of users that show up as omnibox suggestions.

This has been approved by the privacy folks.

BUG=
TEST=using VLOG in the appropriate place in metrics_base.cc


Review URL: https://chromiumcodereview.appspot.com/10544114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141787 0039d316-1c4b-4281-b951-d872f2087c98

CID=104112, 104110, 104109
BUG=None
TEST=
R=jeremya@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10443075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141785 0039d316-1c4b-4281-b951-d872f2087c98

ProxyConfig keeps track of the source of proxy settings. During proxy resolution ProxyService tags the resulting ProxyInfo with the same source information.

BUG=none
TEST=net_unittests


Review URL: https://chromiumcodereview.appspot.com/10310179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131699
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10541121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141783 0039d316-1c4b-4281-b951-d872f2087c98

Previously, Chrome Endure tests would check to ensure that the current
platform is supported by the Deep Memory Profiler (i.e., is Linux) whether
or not Deep Memory Profiling is enabled.  This prevented the endurance
tests from running on other platforms, even if not using the Deep Memory
Profiler.

This CL moves the supported platform check into a codepath that is only
executed if the Deep Memory Profiler is requested.

BUG=None
TEST=None
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10540131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141782 0039d316-1c4b-4281-b951-d872f2087c98

These tests are newly enabled.
I've filed bugs and alerted the test authors.

BUG=132337,132340

R=dennisjeffrey@chromium.org
TEST=
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10544120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141781 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionPrefs for persisting alarm state to disk.

More to come:
- context menus
- omnibox
- declarative webRequest

TBR=brettw
BUG=123366
TEST=extension alarms are still remembered after chrome restart

Change since last time: Fall back to a FailingValueStore if ValueStoreFrontend
can't open the database.

Review URL: https://chromiumcodereview.appspot.com/10545128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141780 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127538
TEST=aura_shell_unittests --gtest_filter="AcceleratorControllerTest.GlobalAccelerator"


Review URL: https://chromiumcodereview.appspot.com/10541127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141779 0039d316-1c4b-4281-b951-d872f2087c98

No idea why these stopped working

TEST=they compile and run
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10532111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141778 0039d316-1c4b-4281-b951-d872f2087c98

  This will be changed to set the wallpaper on all root windows.

BUG=123160
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10545142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141777 0039d316-1c4b-4281-b951-d872f2087c98

On Android, files have to be created in the application directory.

BUG=125059

TEST=


Review URL: https://chromiumcodereview.appspot.com/10543118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141776 0039d316-1c4b-4281-b951-d872f2087c98

ReleaseMouseMoves can be called from a deep stack, possibly while already
dispatching an event. Most of these code paths don't expect another event to be
dispatched from there, so post a task to delay it. Ordering is still ensured
from the existing mechanisms.

BUG=131875
TEST=manual (see bug), also RootWindowTest.HoldMouseMove

Review URL: https://chromiumcodereview.appspot.com/10545129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141775 0039d316-1c4b-4281-b951-d872f2087c98

I renumbered some command IDs in r141609 but neglected to
update the references to them in the NIB file.

BUG=132322
TEST=none (grep for renumbered IDs in chrome/app/nibs and checked that they're correct)


Review URL: https://chromiumcodereview.appspot.com/10533117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141774 0039d316-1c4b-4281-b951-d872f2087c98

These tests seem to be failing on the main waterfall.

BUG=132348
TEST=
TBR:rogerta@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10539120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141773 0039d316-1c4b-4281-b951-d872f2087c98

Also, changes type of SkiaTextRenderer::SetTextSize() to SkScalar to match the underlying Skia type, which is needed for future RenderTextMac implementation.

BUG=126506, 125664, 105550
TEST=Eyeball underlined text in views_examples' text style example.

Review URL: https://chromiumcodereview.appspot.com/10520017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141772 0039d316-1c4b-4281-b951-d872f2087c98

WebstoreInstaller is RefCounted, so there's no reason to make it base::Unretained, which just opens up a deletion race, or appears to.
controller_ may be NULL. NavigationController::GetActiveEntry() may be NULL.

This crash has persisted at a low, not quite dismissible frequency for a long time.

BUG=126013

Review URL: https://chromiumcodereview.appspot.com/10453039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141771 0039d316-1c4b-4281-b951-d872f2087c98

Wait some time.
We are still stopping/closing the stream, as (1) it is better for battery life,
and (2) some people can hear active device even when it is playing silence.

That increased audio startup latency, especially on Windows, because we are using 3
buffers on Windows. To fix that I changed the code to use 2 buffers on presumable
good Windows boxes -- i.e. running non-Vista and having more than single core.

Changed unit tests as well.

That CL finishes work on browser-side audio mixer. Not sure how important it is,
though -- hopefully it will provide some time while implementing renderer-side mixer.

Also moved code for crash Mac OS X into audio mixer, because problem can manifest
itself if Close() called immediately after Stop().

That CL also fixes bug 131720. Looks that it was caused by timing change, and starting
stream earlier causes less dropped frames. (I still cannot understand why on modern
system we should have even single dropped frame, and why slight timing change
caused us to drop frame, but that is different question...)

BUG=129190
BUG=131720
BUG=131720
BUG=102395

TEST=Should not be noticeable difference in behavior. Run tests on Win7 and XP myself.
TEST=Mac crashes on seeks should go away, too.

Review URL: https://chromiumcodereview.appspot.com/10540034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141770 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10532113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141769 0039d316-1c4b-4281-b951-d872f2087c98

Moves the data definitions into content/common and the serialization code
into content/renderer.

There are no code changes here, this is just a refactoring.

BUG=132129
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10544099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141768 0039d316-1c4b-4281-b951-d872f2087c98

We weren't able to successfully return results until overlaps etc. were properly computed in SourceBufferStream::Append().  That's fixed now (http://crbug.com/125072), so let's start returning!

BUG=132314
TEST=media_unittests


Review URL: https://chromiumcodereview.appspot.com/10542128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141767 0039d316-1c4b-4281-b951-d872f2087c98

TBR=acolwell@chromium.org
BUG=129072
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10539117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141766 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132104
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10537113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141765 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10541110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141764 0039d316-1c4b-4281-b951-d872f2087c98

I'm not able to reproduce these failures locally or on trybots, so I want to see if they still happen.

BUG=115979


Review URL: https://chromiumcodereview.appspot.com/10532041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141763 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141761 0039d316-1c4b-4281-b951-d872f2087c98

https://chromiumcodereview.appspot.com/10548003/

Review URL: https://chromiumcodereview.appspot.com/10533109

TBR=robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/10543126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141760 0039d316-1c4b-4281-b951-d872f2087c98

Removes special handling in dip_util because mac didn't support gfx::Screen::GetMonitorNearestWindow

Bug=129409
Test=Compiles
TBR=thakis

Review URL: https://chromiumcodereview.appspot.com/10546132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141758 0039d316-1c4b-4281-b951-d872f2087c98

Binary files from this CL:
http://codereview.chromium.org/10544117/

BUG=132333
TEST=

Review URL: https://chromiumcodereview.appspot.com/10543124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141755 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
NOTRY=true
TEST=
BUG=


Review URL: https://chromiumcodereview.appspot.com/10545098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141754 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131697
TEST=None.


Review URL: https://chromiumcodereview.appspot.com/10546129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141753 0039d316-1c4b-4281-b951-d872f2087c98

After enable GetMimeTypeFromExtension with JNI implementation, need to disable these tests firstly
and can enable them after switch to APK test runner. 

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10533103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141752 0039d316-1c4b-4281-b951-d872f2087c98

To debug failures that dont seem to happen locally.

BUG=130788
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10546103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141751 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141750 0039d316-1c4b-4281-b951-d872f2087c98