- 11 Dec, 2017 40 commits
-
-
Theresa Wellington authored
Creates a new ChromeHomeIphBubbleController that contains the logic for showing help bubbles. BottomSheet still exposes help bubble methods, but these are simple pass-through methods now. BUG=793403 Change-Id: If65105821157f53dd1792bba1a66743848e69778 Reviewed-on: https://chromium-review.googlesource.com/817894 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#523122}
-
Daniel Bratell authored
X11 headers pollute the global namespace with macros with common words like None, Status, False. To avoid problems because of that we now wrap X11 includes in ui/gfx/x/x11.h and move all problematic words to the x11 namespace. Bug: 782184 Change-Id: I81859c8aabae677c40614d3c26036c5d4d1e715a Reviewed-on: https://chromium-review.googlesource.com/819731Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#523121}
-
Francois Doray authored
Callers don't need to know the number of capturers. This change is a prerequisite to expose IsBeingCaptured() on RenderWidgetHostDelegate, to let RenderWidgetHostViews determine by themselves whether they need to render content. Bug: 788827 Change-Id: If1f7d6b51901bf845d3ec3c8bb93a16f48fefaf1 Reviewed-on: https://chromium-review.googlesource.com/796932 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523120}
-
Eugene But authored
DidStartNavigation is called more often than webDidUpdateSessionForLoadWithURL, which is not a problem in practice. OmniboxGeolocationController checks every navigation item for update eligibility, so this CL does not cause any functional changes. Bug: 674991 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I49a23342e41463766791adc2a7d7edafba2b1575 Reviewed-on: https://chromium-review.googlesource.com/818082 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#523119}
-
kylechar authored
When a mouse button is pressed an EnterNotify / LeaveNotify XEvent is generated for the nested XWindow used by the GPU process. The EnterNotify ends up becoming a ET_MOUSE_DRAGGED event which is wrong. In general, we want to just ignore the EnterNotify / LeaveNotify events for nested XWindows. Bug: 792322 Change-Id: I59af57199c0567001256026332823350b4a45d9e Reviewed-on: https://chromium-review.googlesource.com/819595Reviewed-by:
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: none Change-Id: Ic61c7eabd922c0c5c542c382ad7fd11ba8750f40 Reviewed-on: https://chromium-review.googlesource.com/818729 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#523117}
-
Daniel Bratell authored
Many files define their own STATIC_ASSERT_ENUM macro. When those files, in a jumbo build, end up in the same translation unit, there will be clashes. For macros that clash, the simplest fix is to undef them after use to reduce the scope where the symbol is available. Bug: 746953 Change-Id: Id0d22ed46663c79ce5a43e5f09420b1758bf1d88 Reviewed-on: https://chromium-review.googlesource.com/819633 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523116}
-
Gauthier Ambard authored
The ContentSuggestions UI target should have been named content_suggestions_ui. The content_suggestion target is the one for the coordinator layer. For now the coordinator/mediator are living in the ios/chrome/browser folder. They will be moved in a future CL. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3d2444a4b4caa7897886f69c65774a1b07c8eaa0 Reviewed-on: https://chromium-review.googlesource.com/813755Reviewed-by:
-
Dan Zhang authored
Limit quic stream length to be 2^62. Protected by FLAGS_quic_reloadable_flag_quic_stream_too_long. Close connection with error when: 1. The stream length reaches max limit during sending. 2. An endpoint receives stream frame and RST frame with offset larger than the limit. Fix chromium bug crbug.com/696887 Merge internal change: 178165587 https://chromium-review.googlesource.com/c/817388/ Use GetQuic{Reloadable,Restart}Flag for feature flag accesses in QUIC. Merge internal change: 178158996, 178177777 https://chromium-review.googlesource.com/c/818712 Fix QUIC server cert-chain compression bug and resulting bug where server does not drop client cached certs in 2RTT. Protected by FLAGS_quic_reloadable_flag_quic_2rtt_drop_client_cached_certs. Fix for crbug.com/723604. Fixes a typo in QuicCryptoServerConfig::CompressChain() where incorrect params are passed to CertCompressor::CompressChain(). This fix exposes a bug with QUIC 2RTT: if a client sends its first CHLO with cached cert hashes and sends its second CHLO without cached cert hashes, the server now replies to the second CHLO with a REJ containing cached cert hashes when it shouldn't. This incorrect behavior is not present without fixing the aforementioned typo due to lucky coincidence. This CL fixes both the typo and the bug where the server isn't dropping client cached certs after the second CHLO. Merge internal change: 178117979 https://chromium-review.googlesource.com/c/818747/ Finish QuicTransportVersion -> ParsedQuicVersion refactor Merge internal change: 178031031 https://chromium-review.googlesource.com/c/817338 Deprecate FLAGS_quic_reloadable_flag_quic_truncate_long_details Merge internal change: 177911369 https://chromium-review.googlesource.com/c/817588 Refactor QuicFramer to use ParsedQuicVersion Merge internal change: 177885369 https://chromium-review.googlesource.com/c/817587/ Clean up dead code. Merge internal change: 177834407 https://chromium-review.googlesource.com/c/817336/ (n/a) Harden ack handling for QUIC, protected by FLAGS_quic_reloadable_flag_quic_strict_ack_handling. If FLAGS_quic_reloadable_flag_quic_strict_ack_handling is true: - At sender, avoid sending empty acks. - At receiver, close connection when an ack frame's first block length is 0, unless the ack is empty. An ack is empty iff largest_observed, first_block_length, num_ack_blocks are all 0. Verified with clusterfuzz that this fixes http://crbug/786655. There are many tests sending empty acks(some doing so directly, not via ScopedPacketFlusher), and setting expectations based on that. That's why I am still allowing empty acks to be received in this CL. Merge internal change: 177753687 https://chromium-review.googlesource.com/c/818708/ QUIC - add flag count for FLAGS_quic_reloadable_flag_quic_enable_hq_deframer. Needed to verify the new quic/http fork. n/a (no functional change) Merge internal change: 177665632 https://chromium-review.googlesource.com/c/817633/ Set NSTP option on Quartc QUIC connections to suppress STOP_WAITING frames. STOP_WAITING frames are going away anyway. Merge internal change: 177659629 https://chromium-review.googlesource.com/c/818707/ Add code to QUIC TlsHandshakers to create SSL_CTXs changes to unused TLS code in QUIC Merge internal change: 177629057 https://chromium-review.googlesource.com/c/817583/ Set encrypters/decrypters when TLS handshake finishes changes to unused TLS code in QUIC Merge internal change: 177614234 https://chromium-review.googlesource.com/c/817955/ Deprecate FLAGS_quic_reloadable_flag_quic_enable_version_41. Merge internal change: 177505836 https://chromium-review.googlesource.com/c/817480/ Add QUIC_PEER_BUG for logging alarming peer behavior. These behave identically to DLOG(ERROR). Merge internal change: 177502844 https://chromium-review.googlesource.com/c/818117/ Add key/IV size accessors to QUIC crypters Merge internal change: 177501208 https://chromium-review.googlesource.com/c/817692/ Use peer class to access QuicConnection’s private member in PacketSavingConnection instead of declaring friend. Merge internal change: 177497133 https://chromium-review.googlesource.com/c/818055/ Deprecate FLAGS_quic_reloadable_flag_quic_enable_version_38 and gfe2_reloadable_flag_quic_enable_version_39. Merge internal change: 177359603 https://chromium-review.googlesource.com/c/817476/ deprecate FLAGS_quic_reloadable_flag_quic_use_net_byte_order_version_label Merge internal change: 177350890 https://chromium-review.googlesource.com/c/817689/ Remove 4 booleans and the code they were used in from QUIC's Cubic code because they were always true. n/a (Remove always true booleans) Merge internal change: 177319308 https://chromium-review.googlesource.com/c/817688/ Deprecate FLAGS_quic_reloadable_flag_quic_use_tls13_cipher_suites Merge internal change: 177236310 https://chromium-review.googlesource.com/c/817549/ Move includes/dependencies to where needed. n/a (build only) Merge internal change: 177064880 https://chromium-review.googlesource.com/c/817548/ Deprecate FLAGS_quic_reloadable_flag_quic_enable_cubic_fixes. Also deprecates the associated connection options, because they are now useless. n/a (Flag deprecation) Merge internal change: 177058367 https://chromium-review.googlesource.com/c/817680/ Deprecate FLAGS_quic_reloadable_flag_quic_send_reset_token_in_shlo. Merge internal change: 177012460 https://chromium-review.googlesource.com/c/817578/ R=rch@chromium.org Bug: 786655,723604,696887 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I590980fa64d89d37717fa14546b5c8631f6a2b65 Reviewed-on: https://chromium-review.googlesource.com/817496Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#523114}
-
yusukes authored
Currently, each test manually calls its testee's factory's SetTestingFactoryAndUse() with convoluted parameters, but it's a bit too much. This CL moves the calls to the factory class to make it easier for ARC developers to write tests for their mojom host implementations. BUG=None TEST=try Change-Id: I2f0d64c2e4f1edb8f24cbef7ca566f44c23a6b3c Reviewed-on: https://chromium-review.googlesource.com/818477 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#523113}
-
Gauthier Ambard authored
When the frame of the toolbar changes, the alpha of the buttons is updated. But the new alpha value is computed with only the y value of the frame. So instead of comparing the whole frame to see if it changed, this CL only compares the y value of the origins. Bug: 793011 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie10d2f6d4639edb040999e71794d0b30347cf4be Reviewed-on: https://chromium-review.googlesource.com/817285 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523112}
-
Raphael Kubo da Costa authored
Instead of initializing TestImporter's |rebaselined_tests| and |new_test_expectations| to None, initialize them to the types that ImportNotifier expects (an iterable and a dict, respectively). Using None causes the notification mechanisms to fail when a WPT import does not require any rebaseline changes, as TestImporter.fetch_new_expecations_and_baselines() is not called and we end up passing None to ImportNotifier.find_changed_baselines_of_tests() and ImportNotifier.examine_new_test_expectations(). From https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7427: Traceback (most recent call last): File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 25, in <module> main() File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in main host.exit(importer.main()) File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 168, in main if not self.send_notifications(local_wpt): File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 631, in send_notifications issue, patchset) File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py", line 60, in main changed_test_baselines = self.find_changed_baselines_of_tests(rebaselined_tests) File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py", line 78, in find_changed_baselines_of_tests for test_name in rebaselined_tests: TypeError: 'NoneType' object is not iterable Bug: 765334 Change-Id: I36195763226cd393312e80c8819aac546c7daef9 Reviewed-on: https://chromium-review.googlesource.com/819410Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#523111}
-
Becca Hughes authored
Add a three arrows animation either side when the user double taps on the video to jump. If the user jumps multiple times the animations will show for how many times the user jumped. BUG=779989 Change-Id: I528db78449e008075df8702304560a0126ec568b Reviewed-on: https://chromium-review.googlesource.com/766435 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#523110}
-
Andrew Grieve authored
This introduces a dedicated template for defining and Annotation Processor: java_annotation_processor(). Libraries can use them via: annotation_processor_deps = [":processor_target"] We now explicitly pass a --processorpath to javac, and always path both --interface-classpath and --classpath to javac.py. The interface-classpath is always written to the depfile, but the normal classpath is passed to javac when one or more annotation processors are enabled. Due to the added build_config complexity this brings, android_apk's build_config is now written by java_library_impl(), and no more override_build_config support exists. Bug: 792170 Change-Id: Ieebfa943615b9495010900c0a7be2b1ed9839a98 Reviewed-on: https://chromium-review.googlesource.com/817617 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523109}
-
Fady Samuel authored
Prior to this patch we would try to set the fallback surface ID to a non-existant SurfaceLayer in DelegatedFrameHost. This results in a crash. This can occur if a resize is initiated when a view is hidden. The primary surface will not be embedded and hence a fallback surface cannot be embedded. This CL skips the fallback surface if the primary is not available and drops its temporary reference. Bug: 672962, 793782 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I7806b87de59c3f8dfa95631db0980172216feac4 Reviewed-on: https://chromium-review.googlesource.com/819151 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#523108}
-
Daniel Bratell authored
Depending on whether certain headers had been included, GetMessage was a macro that expanded to GetMessageW. This caused later linker errors in jumbo builds. This patch renames the function GetIpcMessage to avoid any confusion. Alternatives are: * #undef the macro (can cause problems with later code) * Make sure that everyone that includes dwrite_font_fake_sender_win.h also has Windows.h included so that the macro is always there. Bug: 746953 Change-Id: Ia172ee74dc430c5fb25d676f018695dc001f3470 Reviewed-on: https://chromium-review.googlesource.com/819552 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Becca Hughes authored
Add a tool to generate preload data in DAFSA format and add a MediaEngagementPreloadedList class to read it. Includes fix for bots with a different python setup. BUG=787464 TBR=dpranke@chromium.org Change-Id: I82340fd77617679afe2ebfe81d4a49e343e9a6f3 Reviewed-on: https://chromium-review.googlesource.com/813735Reviewed-by:
-
Tibor Goldschwendt authored
Bug: 793389 Change-Id: I82fe6000a5a16b5a44c9c383b041ab602fad2527 Reviewed-on: https://chromium-review.googlesource.com/817958Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523105}
-
Marc Treib authored
This adds a "data_push_epoch" field to the iframe URLs for interactive Doodles, and a "launch_interactive_behavior" field. Bug: none Change-Id: I29f5447dfc5dd6d050d252a1261f6a9896c6cc9b Reviewed-on: https://chromium-review.googlesource.com/819411Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#523104}
-
Peter Wen authored
Rather than create the output directory in apkbuilder.py, add it to the gn target's output for gn to create it automatically. Bug: 792534 Change-Id: I3de087be4839e917b4308c38016da3b783668a96 Reviewed-on: https://chromium-review.googlesource.com/815355Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523103}
-
rhalavati@google.com authored
Extends annotations.xml to include incomplete annotations, file paths, and the list of fields in the incomplete annotations. Bug: 656607 Bug: 788035 Change-Id: Ibabbbd91fa8d618571d3fe00dc32fd0aec0277ed Reviewed-on: https://chromium-review.googlesource.com/817749 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523102}
-
Mathieu Perreault authored
Allows the bubble to be dismissed when the web contents is clicked, even if the bubble has not been interacted with. Bug: 793081, 624560 Change-Id: I9597bd8162db2fdc82a821621d28a301165fa7a1 Reviewed-on: https://chromium-review.googlesource.com/816394Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#523101}
-
Dave Tapuska authored
A property was misspelled in a synthetic injection test correct its name. BUG=793765 Change-Id: Iaa41840b0fe27d01b2729d1f46c57d7b6f7c4ac4 Reviewed-on: https://chromium-review.googlesource.com/819490Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#523100}
-
Gauthier Ambard authored
PrerenderTestCase.testTapPrerenderSuggestions was flaky because the suggestions displayed by the omnibox are displayed inside a TableView. The TableView rows are not removed from the view hierarchy when the corresponding suggestions should not be displayed, they are hidden. So the test see multiple elements for the matcher even if only one of them is visible on the screen. This CL fixes it by checking that the suggestion displayed is the first one, which is a prerequisite to have the prerenderer loading it. Bug: 793802 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I44f24c4b542ac6d27a6fa0ca0b0b1759c7a7c80a Reviewed-on: https://chromium-review.googlesource.com/819470Reviewed-by:
-
Peter Wen authored
Currently .so and .pak files are parsed and tracked. Group all other files in .other section for now so we at least track them too. Bug: 793014 Change-Id: I7237c0e329e9e6b06ec08ff15d3b5395f56a65e7 Reviewed-on: https://chromium-review.googlesource.com/815357 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Daniel Bratell authored
Windows headers define a macro named NO_ERROR so it is best to avoid that name. This renames the new NO_ERROR enum value to CBOR_NO_ERROR, similar to GL_NO_ERROR. Bug: 780504 Change-Id: I83aa3b83b9239659c296687a9109f255b272a1ce Reviewed-on: https://chromium-review.googlesource.com/819251Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#523097}
-
Mathieu Perreault authored
On Views, there is no arrow draw if the bubble shows up on a user gesture. For consistency, an arrow is now drawn on Mac, pre Material Design. Bug: 793077 Test: visual Change-Id: Ic73856c6b07cdc3b5821fec918d44cd458847d04 Reviewed-on: https://chromium-review.googlesource.com/818154 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Charlie Harrison authored
This reverts commit 81f70917. Reason for revert: NavigationThrottle can be destructed by JNI call. Original change's description: > Replace Nav.Intercept.WillStart histogram in favor of main/subframe breakouts > > The initial data looks heavily multi-modal, which I suspect is from the > split. > > Bug: 792524 > Change-Id: Icd40c722aa5505f4b3eb69c4283b9aca211c9dc4 > Reviewed-on: https://chromium-review.googlesource.com/814216 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522544} TBR=michaelbai@chromium.org,asvitkine@chromium.org,csharrison@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 792524, 793719 Change-Id: Ib6e4deab8bc20ba96428ea21c0b84acb97084606 Reviewed-on: https://chromium-review.googlesource.com/819330 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#523095}
-
Lalit Maganti authored
This struct is essentially only an implementation detail of the memory instrumentation coordinator and does not need to be exposed in base. Bug: 776726 Change-Id: I67336eb99d5677e9b18ae30213486927d12079d3 Reviewed-on: https://chromium-review.googlesource.com/813836Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Hector Dearman <hjd@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Commit-Queue: Lalit Maganti <lalitm@chromium.org> Cr-Commit-Position: refs/heads/master@{#523094}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/93e913442275..650a2e1adeb2 $ git log 93e913442..650a2e1ad --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6a8ee7523296e37be69e4842479bae718d8160f4 Reviewed-on: https://chromium-review.googlesource.com/819310Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523093}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/917ba969..b987e09a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3b7efe42ac54b1ce3d9ae023e5695f88b7e983e1 Reviewed-on: https://chromium-review.googlesource.com/818713Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523092}
-
Gauthier Ambard authored
The location bar has a shadow below it. This shadow should only be displayed when the omnibox is contracted. Bug: 793736 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9bea295e3635f29802aa598c76700a753511641b Reviewed-on: https://chromium-review.googlesource.com/817284Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523091}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f7f5e61f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7428 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2e490022614e2f0fecb913e0b38accefeb122f00 Reviewed-on: https://chromium-review.googlesource.com/818714 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523090}
-
Yuki Shiino authored
Converts NFC's MessageCallback to callback function type due to NFC spec. As NFC::OnWatch needs special argument construction, i.e. needs to create a JSON object, which is out of scope of Web IDL type conversions, NFC::OnWatch needs a ScriptState of callback function's argument's context. Thus, this patch makes CallbackFunctionBase::CallbackRelevantScriptState() public. CallbackInterfaceBase::CallbackRelevantScriptState() is made public, too, just in order to be symmetric. Bug: 569301, 658073 Change-Id: Ieebbf3c8d317a70b7d5045494fed9360fe41070c Reviewed-on: https://chromium-review.googlesource.com/818867Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#523089}
-
Tobias Sargeant authored
NetworkSecurityPolicy.isCleartextTrafficPermitted can throw an IllegalArgumentException, which is uncaught and returned to native code, causing any WebView application that has declared a network security config to crash. Bug: 792482 Change-Id: Ide2c0293d7cebad68109a4af5bcea127c83ee96c Reviewed-on: https://chromium-review.googlesource.com/810969 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#523088}
-
Maxim Kolosovskiy authored
TBR=robertma@chromium.org Bug: 793792 Change-Id: I213dc2cee10082216585195392273db767804929 Reviewed-on: https://chromium-review.googlesource.com/819210 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#523087}
-
jdoerrie authored
This change introduces a U2F BLE connection abstraction. Given an device address it attempts to connect to the device, checking if expected services and characteristics are present. Furthermore it provides APIs to read from and write to the device. Bug: 763303 Change-Id: I586f0b2150d676959e119b0ce3c775b47a20c003 Reviewed-on: https://chromium-review.googlesource.com/774742 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#523086}
-
Alex Clarke authored
For determinism Virtual Time needed to be blocked when the background parser was running on the background thread. That thread no longer exists (it now runs on the main thread) so we can remove the WebScopedVirtualTimePauser. Bug: 777763 Change-Id: I0c5f31fcb8c7dbd45ac922be831951143f1c48a9 Reviewed-on: https://chromium-review.googlesource.com/817747 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/a1d0f2731001..93e913442275 $ git log a1d0f2731..93e913442 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If747242a3af1d414bb2b1d4b7290114e3cfff4b0 Reviewed-on: https://chromium-review.googlesource.com/819030Reviewed-by:
-
Justin Cohen authored
Although the omnibox popup itself honors safe are in the table view, the width of the omnibox pop text can be too wide. This is a second attempt after crrev/d4774195 only accounted for RTL keyboards, not a full RTL layout. Bug: 787164 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icd668c45ae32b8ff5520d1e54c85292d66c4c7ee Reviewed-on: https://chromium-review.googlesource.com/817383 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523083}
-
