GitLab

Revert of Clean up WebMediaPlayerAndroid needs_establish_peer_ (patchset #7 id:120001 of https://codereview.chromium.org/557593002/)

Reason for revert:
Suspected to break tough_video_cases. See crbug.com/412897 for details.

BUG=412897

Original issue's description:
> Clean up WebMediaPlayerAndroid needs_establish_peer_
>
> needs_establish_peer_ has been used to skip actual estalishing a surface
> texture peer based on many conditions. Not all places that modify
> actually checks all these conditions so there are bound to be some bugs.
>
> This CL aims to tease out all these different conditions and put them in
> a single function EstablishSurfaceTexturePeerIfNeeded. This function
> should be called any time these conditions are changed. Makes for much
> saner reading.
>
> BUG=412578
>
> Committed: https://crrev.com/701cb640efb326aa107b5b0c25dcf91766fe765f
> Cr-Commit-Position: refs/heads/master@{#294068}

TBR=qinmin@chromium.org,avayvod@chromium.org,ycheo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=412578

Review URL: https://codereview.chromium.org/562803002

Cr-Commit-Position: refs/heads/master@{#294271}

Revert of -fno-exceptions only on .cc files (patchset #1 id:1 of https://codereview.chromium.org/560873003/)

Reason for revert:
Causes ASAN LSAN Linux bot to fail (not in the CQ/try set):

[191/22134 | 8.047] CC obj/third_party/speex/libspeex/libspeex.filters.o
FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_new_delete.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated  -c ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_new_delete.o
../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:50:13: error: cannot use 'throw' with exceptions disabled
            throw std::bad_alloc();
            ^
../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:77:5: error: cannot use 'try' with exceptions disabled
    try
    ^
../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:118:5: error: cannot use 'try' with exceptions disabled
    try
    ^
3 errors generated.
FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_aux_runtime.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated  -c ../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_aux_runtime.o
../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp:24:5: error: cannot use 'throw' with exceptions disabled
    throw std::bad_cast();
    ^
../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp:29:5: error: cannot use 'throw' with exceptions disabled
    throw std::bad_typeid();
    ^
2 errors generated.
FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_personality.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated  -c ../../third_party/libc++abi/trunk/src/cxa_personality.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_personality.o
../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1269:21: error: cannot use 'throw' with exceptions disabled
                    throw;
                    ^
../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1290:17: error: cannot use 'throw' with exceptions disabled
                throw be;
                ^
../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1203:5: error: cannot use 'try' with exceptions disabled
    try
    ^
3 errors generated.
ninja: build stopped: subcommand failed.

I'm not quite sure what the actual problem is, but revert for now.

Original issue's description:
> -fno-exceptions only on .cc files
>
> R=thakis@chromium.org
> BUG=335824
>
> Committed: https://crrev.com/fad91907037b2616fe446bfbb880f8c19418de43
> Cr-Commit-Position: refs/heads/master@{#294266}

TBR=thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=335824

Review URL: https://codereview.chromium.org/564493003

Cr-Commit-Position: refs/heads/master@{#294270}

Followup to CL 478153003 which added a lambda expression even
though we haven't officially switched to c++11 yet.

Review URL: https://codereview.chromium.org/565443002

Cr-Commit-Position: refs/heads/master@{#294269}

The goal is to run gpu_unittests on the GPU bots, starting with the
FYI bots.

BUG=391895

Review URL: https://codereview.chromium.org/562733003

Cr-Commit-Position: refs/heads/master@{#294268}

Apply bump scroll to the entire client-plugin-render hierarchy, not just
the plugin, which doesn't handle rendering when MediaSource is enabled.

BUG=411996

Review URL: https://codereview.chromium.org/558283002

Cr-Commit-Position: refs/heads/master@{#294267}

R=thakis@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/560873003

Cr-Commit-Position: refs/heads/master@{#294266}

Revert of Mac: Fix rounded corners on browser windows on retina display. (patchset #4 id:80001 of https://codereview.chromium.org/463263002/)

Reason for revert:
When the download bar is present, the rounded corners are on the wrong view.

https://code.google.com/p/chromium/issues/detail?id=412580

Original issue's description:
> Mac: Fix rounded corners on browser windows on retina display.
>
> When a window's bottom corner is covered by a layer on a retina display, the
> corner is incorrectly rounded. I added a layer mask to do the corner rounding
> ourselves.
>
> BUG=396264
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289811

TBR=andresantoso@chromium.org,ccameron@chromium.org,shess@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=396264

Review URL: https://codereview.chromium.org/560913004

Cr-Commit-Position: refs/heads/master@{#294265}

This pulls in the following Native Client changes:

r13711: (mseaborn) Move syscall definitions to pure C code, replacing nacl_syscall_handlers_gen.py
r13712: (dbrazdil) Fixed signatures of _Unwind_* stubs in PNaCl support library
r13713: (uekawa) Minor consistency style fixes.
r13714: (dschuff) Move REV file to metadata package and include all repos
r13715: (mseaborn) Remove the old "SecureRandom" service, formerly used by get_random_bytes()
r13716: (dyen) Unify the way irt_ext libc how tests are declared and defined.
r13717: (dyen) Asserts used by irt_ext are now done through error_report.c.
r13718: (dschuff) Update revision for PNaCl r13696->r13714
r13719: (dschuff) Build host libc++ and host tools with clang on Linux and Mac
r13720: (bradnelson) Switching pnacl download script to use gsutil for download too.
r13721: (dyen) In IRT Extension API, added file stat support and tests.
r13722: (dbrazdil) Add MinSFI loader
r13723: (bradnelson) Vary build settings on fastbuild + configuration + buildtype (reland).
r13724: (dbrazdil) Update signature of MinSFI's entry point

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/553323002

Cr-Commit-Position: refs/heads/master@{#294264}

TBR=brettw@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/560143002

Cr-Commit-Position: refs/heads/master@{#294263}

Currently, blink creates its own isolates. We want to always use an
IsolateHolder to create the isolates. To be able to do this, I introduce
an Initialize method that setups V8. The new IsolateHolder ctor now
doesn't take any parameters but just creates new isolates according to
the configuration.

All non-blink gin users are cut over to the new API

BUG=none
R=abarth@chromium.org,andrewhayden@chromium.org,eroman@chromium.org

Review URL: https://codereview.chromium.org/553903003

Cr-Commit-Position: refs/heads/master@{#294262}

BUG=

Review URL: https://codereview.chromium.org/560923002

Cr-Commit-Position: refs/heads/master@{#294261}

It is useful for linking the BeginFrame sent from browser side and
the BeginFrame received in renderer side. Often, the BeginFrame IPC
message gets delayed and it becomes hard to track the BeginFrame
received in renderer side is from which browser VSync. By dumping the
frame_time, we can then do the cross-reference.

BUG=406112
TEST=RenderWidgetHostViewAndroid::SendBeginFrame now shows frame_time.

Review URL: https://codereview.chromium.org/561883003

Cr-Commit-Position: refs/heads/master@{#294260}

Patch updated after a revert. Original patch:
https://codereview.chromium.org/544363002/

1) When the status is ADDING (adding message is sent), the token is refreshed.
2) When the status is REMOVING (removing message is sent), the token is added
again.
3) updating multiple account mappings

BUG=374969
R=jianli@chromium.org

Review URL: https://codereview.chromium.org/560563003

Cr-Commit-Position: refs/heads/master@{#294259}

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/559063002

Cr-Commit-Position: refs/heads/master@{#294258}

The last NDK roll (r10c-rc1) lost the ability of generating functional
executables. This is a temporary workaround and should go away by the
time r10c-rd3 NDK is rolled.

BUG=

Review URL: https://codereview.chromium.org/556313003

Cr-Commit-Position: refs/heads/master@{#294257}

Currently context menu for page is shown when right clicked
on links in the pdf. This happens because an empty string is
returned as url to ContextMenuClientImpl::showContextMenu()
from plugin.

The reason for above is that GetLinkAtPosition() isn't passing
a point in page coordinates to GetCharIndex() and GetCharIndex()
expects the point to be in page coordinate. This means that when
the document is zoomed or scrolled and right click is done then
it doesn't work.

This patch updates the point passed to GetCharIndex() to be in
page coordinates by factoring in current position and zoom level.

BUG=148665

Review URL: https://codereview.chromium.org/553453002

Cr-Commit-Position: refs/heads/master@{#294256}

This CL is a part of the effort to move mock URLRequestJob files
from content/test/net to net/test/url_request/. The reason for this
refactoring is that Cronet will need to use these classes for testing,
so it will be nice if they can be in net/test, as the dependency can
work out nicely.

BUG=

Review URL: https://codereview.chromium.org/541743002

Cr-Commit-Position: refs/heads/master@{#294255}

openssl key, as is currently supported for NSS.

Change-Id: I36c848884273fe8e23451259655680b6b7d46a98

BUG=412427

R=davidben@chromium.org

Review URL: https://codereview.chromium.org/559623002

Cr-Commit-Position: refs/heads/master@{#294254}

This will need to be merged back to M38.

No trybots because this only affects the NaCl SDK build.

BUG=none
R=bradnelson@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/559233002

Cr-Commit-Position: refs/heads/master@{#294253}

Adds a mechanism by which a net/ embedder can add headers to
a HTTP CONNECT tunnel request.

BUG=400872

Review URL: https://codereview.chromium.org/517693002

Cr-Commit-Position: refs/heads/master@{#294252}

Prevent hardware keyboard events from hiding text handles if the events
are not dispatched to an editable region. This allows seamless arrow key
navigation of the page while a (non-editable) selection is active.

BUG=409778

Review URL: https://codereview.chromium.org/560963002

Cr-Commit-Position: refs/heads/master@{#294251}

This field will soon be removed entirely, instead replaced by the
|WebTouchEvent.touches| field as the global container for all touches
offered to embedders. Use that field to populate Pepper's
changed and target touch lists, eliminating Pepper's dependency on
|WebTouchEvent.changedTouches| and |WebTouchEvent.targetTouches|.

This is part 1 of a 4-sided patch simplifying WebTouchEvent:
1) This change
2) https://codereview.chromium.org/558773002/
3) https://codereview.chromium.org/559693003/
4) https://codereview.chromium.org/560493003/

BUG=358132

Review URL: https://codereview.chromium.org/557863002

Cr-Commit-Position: refs/heads/master@{#294250}

Remove RootView::DispatchGestureEvent() and instead
call up to the unified event processing logic in
EventProcessor::OnEventFromSource(). This CL
also introduces the virtual method
EventProcessor::OnEventProcessingFinished(),
which is called when the processing of an
event is finished.

BUG=404234
TEST=EventProcessorTest.OnEventProcessingFinished

Review URL: https://codereview.chromium.org/533323004

Cr-Commit-Position: refs/heads/master@{#294249}

BUG=412713
TEST=bots

Review URL: https://codereview.chromium.org/546633005

Cr-Commit-Position: refs/heads/master@{#294248}

This enables all blink targets and nearly all content targets in the
android build. This produces a content shell APK, but not a fully
operational one yet. This also flips on a bunch of other targets pulled
in by deps.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/561623002

Cr-Commit-Position: refs/heads/master@{#294247}

Now that NT_PAGE is gone, rewrite the function to be single-return and add
a comment pointing out that what the function is doing is incomplete.

No intended behavior change, should fix 2 clang warnings of the form
..\..\sandbox\win\src\sandbox_nt_util.cc(560,3) :  warning(clang): 'operator new' should not return a null pointer unless it is declared 'throw()' or 'noexcept' [-Wnew-returns-null]
  return NULL;
  ^
BUG=82385
R=rvargas@chromium.org

Review URL: https://codereview.chromium.org/556293002

Cr-Commit-Position: refs/heads/master@{#294246}

Also fix the formatting of chrome_elf/OWNERS

Review URL: https://codereview.chromium.org/546733002

Cr-Commit-Position: refs/heads/master@{#294245}

The current code floors, which means we may not paint enough, an in
fact you can see this in views at certain scales.

BUG=none
TEST=none
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/557953004

Cr-Commit-Position: refs/heads/master@{#294244}

Currently the password manager only controls uploads of ACCOUNT_CREATION_PASSWORD
but uploads of PASSWORD happen during the normal Autofill form submit process.
This is problematic in that there are different criteria for triggering
uploading between the two, which makes the ratio of votes difficult to judge.
Two such cases include that Autofill doesn't trigger uploads on XHR
form submits, and that Autofill will surpress uploading if the user has no
saved Autofill state.

By pulling uploading of these types into the same code path, the ratio
of uploads should be much more stable. This does also change what the expected
ratio will be, since now we only upload PASSWORD when the user actually saves
the password instead of just submitting the form. There is still some
uncertainty in the  numbers (i.e. uploads will not complete when user is
Incognito) but for well behaving sites there should be approximately as many
ACCOUNT_CREATION_PASSWORD labels as PASSWORD labels.

BUG=408829

Review URL: https://codereview.chromium.org/543283002

Cr-Commit-Position: refs/heads/master@{#294243}

The previous increase in r293993 didn't help anything; make the timeout really
large to make sure that things aren't just slow. (Once this hasn't helped
either, we're going to remove this win/asan special case.)

BUG=412471
TBR=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/557333007

Cr-Commit-Position: refs/heads/master@{#294242}

Somewhat cleaner without having to pass around half-constructed EVP_PKEY
objects everywhere.

BUG=none

Review URL: https://codereview.chromium.org/553223002

Cr-Commit-Position: refs/heads/master@{#294241}

Add back auto recede, and hasten the recession upon explicit release.

BUG=389744

Review URL: https://codereview.chromium.org/543123002

Cr-Commit-Position: refs/heads/master@{#294240}

There was an issue with outputting Chart JSON that came down to a typo and was
not caught by unittests. This patch fixes the bug and adds a unittest to make
sure it won't crop up again.

R=nednguyen,sullivan

Review URL: https://codereview.chromium.org/551293003

Cr-Commit-Position: refs/heads/master@{#294239}

The line endings were wrong and this is preventing the trybots and CQ from applying a patch. This has to be landed manually.

No functional changes here.

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/556413002

Cr-Commit-Position: refs/heads/master@{#294238}

Revert of Switch Mac over to BoringSSL from NSS. (patchset #1 id:1 of https://codereview.chromium.org/539163002/)

Reason for revert:
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/10583

Original issue's description:
> Switch Mac over to BoringSSL from NSS.
>
> This is a much much larger change than the diff suggests. If it breaks
> something, please revert first and ask questions later.
>
> BUG=338885
>
> Committed: https://crrev.com/dd7edfa679492a6feb3ef2e1630f05da82a1b31f
> Cr-Commit-Position: refs/heads/master@{#294233}

TBR=rsleevi@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=338885

Review URL: https://codereview.chromium.org/565473002

Cr-Commit-Position: refs/heads/master@{#294237}

Revert of Add logspam to help diagnose flaky tests (patchset #2 id:20001 of https://codereview.chromium.org/485843002/)

Reason for revert:
No longer needed since AutomationApiTests have been running for some time without flaking.

Original issue's description:
> Add logspam to help diagnose flaky tests
>
> BUG=391279,385701,353039,379927,384673

TBR=kalman@chromium.org,aboxhall@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391279,385701,353039,379927,384673

Review URL: https://codereview.chromium.org/561923002

Cr-Commit-Position: refs/heads/master@{#294236}

BUG=407659

Review URL: https://codereview.chromium.org/558203002

Cr-Commit-Position: refs/heads/master@{#294235}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/546713003

Cr-Commit-Position: refs/heads/master@{#294234}

This is a much much larger change than the diff suggests. If it breaks
something, please revert first and ask questions later.

BUG=338885

Review URL: https://codereview.chromium.org/539163002

Cr-Commit-Position: refs/heads/master@{#294233}

BUG=381007

Review URL: https://codereview.chromium.org/547503002

Cr-Commit-Position: refs/heads/master@{#294232}