- 30 Oct, 2020 40 commits
-
-
Fredrik Söderqvist authored
This provides a more succinct way to express a potentially missing value, and allows dropping the separate HasIntrinsic{Width,Height}. For the usage in SVGSVGElement::CurrentViewBoxRect, just drop the use of IntrinsicWidth/Height() since we resolve percentages against the current viewport - which matches what a plain SVGLengthContext resolve does in this case. Change-Id: I0f6b36e4f34e3ef42adc374100d6a82647301c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509853Reviewed-by:Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#822661}
-
Fredrik Söderqvist authored
This is just an alias for documentElement(), which should preferably only be used by the SVGDocument (DOM) property. Change-Id: I2bae17b4efd30b5be6488166d511879eaa0196b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509577 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Nico Weber authored
https://reviews.llvm.org/rL356148 landed 1.5 years ago, it's hopefully available in Xcode now. Also, we no longer support use_system_xcode builds in chromium/ios. Bug: 926235 Change-Id: I50e77e1b4c2e7419ab6be40fc00eb62b44548c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510190 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#822659}
-
Anton Bikineev authored
This also makes PartitionRoot::total_size_of_*_pages atomic. Since there are no side effects around reading/writing them (other than the invariant check), using the relaxed semantics should be safe. Bug: 11297512 Change-Id: Ibeb74484f25ba915a1b31659f3c2d6e13560f83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506441Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#822658}
-
Fredrik Söderqvist authored
This moves all code that has direct dependencies on a Parent() being available to the end of the functions and adds a common early-out. Calls to the parent class' StyleDidChange() is moved first. Bug: 1028061, 1028063 Change-Id: Ibd0b9d710128eff6383d3b48223bf838a553bacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509751 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Kyle Williams authored
Create a feature trial parameter to support enabling telemetry through encrypted reporting pipeline on cfm specific devices. Create helper function to easily query CfmMojoServices feature flag. BUG=chromium:1105567,b:137780359 TEST='Ensure feature parameter is enabled through command line' Change-Id: I607a1d153811d6847b1fed5429c4146387853c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506264 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#822656}
-
Koji Ishii authored
Also removes one use of |ContainingBlockFlowFragment|, which calls |CurrentFragment|. One more use of |ContainingBlockFlowFragment| is left, only in |NGPaintFragment| codepath. There should be no behavior changes. Bug: 1061423 Change-Id: I47cafd9ed0f1d04bd9cb886ebf8d9a2bb17f6282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509154Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#822655}
-
dpapad authored
This is in preparation of removing <include src="assert.js"> and flattenhtml="true" from js/util.js and js/cr/ui/array_data_model.js, which in turn is necessary to auto-generate grd entries for ui/webui/resources/js/cr/ui/. Bug: 1143194 Change-Id: I9d69b9597ee228aacdc186e2e158d8ebea25558c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508355 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#822654}
-
Vasiliy Telezhnikov authored
This is a reland of 483ed255 Changes from the original: * Removed glPolygonMode -- it's not gles state. * Changed blending for ExternalStencil, sometimes WebView contents doesn't cover the whole scissor rect. Original change's description: > aw: Add missed GL state restoration > > SkiaRenderer (especially when we remove ES2 downgrade) changes more > state then before. This CL adds missed state tracking to > ScopedAppGLStateRestorer and AwGLSurfaceExternalStencil. > > Bug: 1136975 > Change-Id: I55be2bec69c18bff33a3cb18a313a93da10ba088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506116 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822211} Bug: 1136975, 1143984 Change-Id: I1077e3f7753d9010a8660d8d3b54f771939717b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508756 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822653}
-
Peng Huang authored
Bug: 1135112 Change-Id: I59ed3e3c52244f808a951ad0ecaa3125a5ceb2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508976 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#822652}
-
Vladimir Levin authored
This patch refactors some items from the PrewalkSurface function into its own function. These items declare the given and used resources from the surface to the display resource provider. I also added my comments from the understanding of what it is doing. R=weiliangc@chromium.org, kylechar@chromium.org Change-Id: I1a5643a2f8003631a29b452d7eae135356b128ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508442Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#822651}
-
David Bienvenu authored
Also fix a few lint errors; no functional changes. Bug: 1010217 Change-Id: Ie5c783ef4a900931aa40c5e030036b3c1fa4c950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508313Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822650}
-
Kent Tamura authored
- Hold ruby_text_child as NGBlockNode instead of NGLayoutInputNode - Rename LayoutRubyText to HandleRubyText for consistency with other function members - Pass a NGBlockNode instance to HandleRubyTest. We don't need to pass it via a pointer. This CL has no behavior changes. Change-Id: Ic2c2dd48a9996ac5f91255a2b13eebfc26a2e140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509152 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#822649}
-
Koji Ishii authored
After recent removals of calls to |LayoutBlockFlow:: FragmentItems|, only unsed test code was left. This patch removes it along with the function itself. Bug: 1061423 Change-Id: I84edecc0cd742269df04067dec5741c75c0a66c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507414Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604037316-5e92166f122bfd61a727a711ba5668734a1ff275.profdata to chrome-mac-master-1604059108-cc1e9f40825b0164b708aba4465bfece5e57e39b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic8b179012aa9b65871f68b587c35606b7f69468d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510123Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e96b7cfe71db..7060721b4ec0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mastiz@google.com,pmonette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:897470 Tbr: mastiz@google.com,pmonette@google.com Change-Id: I8658776232ec4ee9a436e41a43ec703dfe4b39c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822646}
-
Guillaume Jenkins authored
Adds a simple unit test case for the ReportGeneratorIOS class. The test generates a full report and checks that the values in the proto make sense. Bug: 1114853 Change-Id: Ic1ad0979b2adfa41adf93c7ba9298102c23bd830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508553Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#822645}
-
Nico Weber authored
Bug: 1143700 Change-Id: If1110313fda223d83d17db5600f2041c3e1f6f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510229 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Mark Yacoub authored
Refactor: Move finding a primary plane for Test Modeset or Commit Modeset early on so the plane args could be extended and manipulated in tests, and test would fail quick on failure to find a plane. BUG: 979736 TEST: Test & Commit succeeds. Change-Id: I88de210a59dba67912227a94f542ccff7f771e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505938Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#822643}
-
Nate Fischer authored
No change to logic, only docs. This changes the "Android 10" section to be "Android 10 and later" since Trichrome still applies in R (and will continue to be the format for the foreseeable future). Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia3fc77f32a778be7845ef3afba1215d5d5d5fe75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508317 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
-
Rainhard Findling authored
Bug: 1087263 Change-Id: Ia59d2a208d9fcbf371ad8fd2ed59e5cdb865df64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507690Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#822641}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c21902c0d3cc..9615bcf71f2a 2020-10-30 johnstiles@google.com Revert "Moved SkSL data back into node classes" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I821185422830b55d0300198a9cbd2d3fa80effd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510122Reviewed-by:
-
Chris Sharp authored
Change-Id: I6141c37d1a380aa354c6fac7310564a86bfc0b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509991Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#822639}
-
Esmael El-Moslimany authored
When a user chooses to hide shortcuts, the most-visited element should have zero height and width. Bug: 1144029 Change-Id: I3cd1b1e02c6d283229ae058e08ca7ca557cbeac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508880 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822638}
-
sandromaggi authored
This refactors |WebController::GetElementRect| to take an |ElementFinder::Result| instead of a |Selector|. Bug: b/168107066 Change-Id: I0cbe7b12c95a92dac14c992017e41e3b0301f5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505650 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#822637}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604037316-5cbbc085308516b08a183c882c2ebb61cfb969d4.profdata to chrome-linux-master-1604059108-a438e57d21f2dfad804e970e84edcffc08a2b95c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I40d145981440379d1f3ca7d1e8a1f63c9109815f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510309Reviewed-by:
-
Michele Mancina authored
Scripted delay time, active processing time and passive wait time are now recorded and sent back to the backend. Bug: b/170722915 Change-Id: I057e53e559767a575a2ffda12f835cee75f8462c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489885 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#822635}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f5e8f808975b..e184bf1e5f83 2020-10-30 yangguo@chromium.org [ts] Typecheck LayerViewHost.js 2020-10-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-30 janscheffler@chromium.org [TypeScript] Move DebuggerPlugin.js to TypeScript 2020-10-30 alexrudenko@chromium.org Enable TypeScript for SoftContextMenu.js [part 1] 2020-10-30 changhaohan@chromium.org Move CSSAngle-related files from elements/ to inline_editor/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1126178 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I706e0981a9ef33d4e3e7ff0483d6185cb8989d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510117Reviewed-by:
-
Clemens Arbesser authored
New protos as per the design doc linked in the bug. Bug: b/171776026 Change-Id: I50cfdfe790d0d37f206bca1166d6597b749af79d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502201 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Alex Rudenko authored
This CL adds the possibility to disable image formats (AVIF and WebP) in order to test fallback scenarios. Design doc: https://goo.gle/devtools-image-fallback Frontend CL: crrev.com/c/2505785 Test command: `third_party/blink/tools/run_web_tests.py http/tests/inspector-protocol/emulation/emulation-set-disabled-image-types*` Bug: 1130556 Change-Id: If442365212750995d10cb5a5d9650738ed44fddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470663 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822632}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: If158a4378ff6ce28c3d95824e15c30c2a0ed4f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510109Reviewed-by:
-
Jan Scheffler authored
Bug: chromium:1144127 Change-Id: I2fc34e51d9f6f36b3fa71f64e745b1d30bec2c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509579 Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#822630}
-
Matt Menke authored
This allows signed exchange certificate transparency checks to look up information learned from previously observed Expect-CT headers. Bug: 1087091 Change-Id: Ie1675dad10a89d751797786dbb31d65b0a177dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500562 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#822629}
-
Matt Menke authored
This prevents cross-site leaks when a failed CT check uploads a report. It also means we'll actually be able to check Expect-CT headers using the correct key - without this, we'd only send a report if we've seen an Expect-CT header when using an empty NIK, which isn't terribly likely (or if there's a match in the static global CT tables). Bug: 1087091 Change-Id: I71199464f54110e5d09262edcf0a1dbaa79691e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462387 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Use common code for highlighting style of ::selection and ::target-text. Bug: 1136817 Change-Id: I42ba2a508f07c25e636c04c93c91d3e724151f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504309 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822627}
-
Bill Budge authored
- Removes tests that depended on the existence of the Flash plugin. Bug: chromium:1143546 Change-Id: Ib5dc2035f303cc3510db52d491813759123e7b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508009 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#822626}
-
Andrew Grieve authored
Bug: 1122182 Change-Id: I29b579cf7c5e7eb6d2528a6fad28562059698bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508342Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#822625}
-
Mikel Astiz authored
Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/60367 Bug: 1144142 TBR=nator@chromium.org Change-Id: I9acdc89728509c2af01f51d2071b3b7f3f909c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509513Reviewed-by:
-
Oriol Brufau authored
Both GridTrackSizingAlgorithm::ResolveIntrinsicTrackSizes and IndefiniteSizeStrategy::FindUsedFlexFraction have a vector of track indices and want to iterate the grid items in these tracks. But they only want to do the work once for each item, even if it spans multiple cells in one of these tracks, or it spans multiple of these tracks. What they used to do was to insert the items provided by NextGridItem into a HashSet, and check whether it was a new entry or it was already there. Instead, this patch modifies ListGridIterator::NextGridItem so that it skips items already processed in an earlier cell of that track, and adds a IterateGridItemsInTrackIndices helper function which takes care of creating the iterators, calls NextGridItem, and skips items already processed in an earlier track. The already processed items are detected looking at their indices, so the HashSet is no longer used in release builds. It's only kept in debug builds to ensure that the logic is solid. This should have no effect in practice, other than better performance: the nested-grid-lots-of-tracks perf test improves by ~26%, and the nested-grid, auto-grid-lots-of-data and auto-grid-lots-of-spanning-data improve by 5-7%. On the other hand, fixed-grid-lots-of-data and fixed-grid-lots-of-stretched-data worsen a bit by 2-3%. Change-Id: Ibedbfa48c8825cff129797ba759dc22cf6972017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508472Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#822623}
-
Nico Weber authored
Apparently git footers need to be in one paragraph. Bug: none Change-Id: I7048bf7fc21c5f52cd9d9ac31de08a0ad81d4dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510189 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
