GitLab

tools/grit/grit.py does not recognize "preprend" as a valid emit_type but
instead understand "prepend" which avoid the inclusion of atlres.h in the
generated file.

BUG=475514

Review URL: https://codereview.chromium.org/1113603003

Cr-Commit-Position: refs/heads/master@{#327323}

Review URL: https://codereview.chromium.org/897053003

Cr-Commit-Position: refs/heads/master@{#327322}

If add,remove or add,add (scanning for devices) events are delivered
fast enough, the remove/add event would be processed before the first
add event. In the first case the state would be incorrect while in the
second case it would cause the device to be opened multiple times
(causing permission errors in one of the events). To avoid this, use a
sequenced worker pool to properly order events. The device path is used
to group events for the same device.

This CL also keeps track of the active devices such that we can ignore
duplicate events (possible due to device scanning) and reduce the number
of display configurations performed.

BUG=477792,476728

Review URL: https://codereview.chromium.org/1072193008

Cr-Commit-Position: refs/heads/master@{#327321}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/438de49..50cb76b

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1110823003

Cr-Commit-Position: refs/heads/master@{#327320}

R=brianderson

Review URL: https://codereview.chromium.org/1108193003

Cr-Commit-Position: refs/heads/master@{#327319}

Revert of Add a slimming paint version of the r&r key silk case benchmark (patchset #1 id:1 of https://codereview.chromium.org/1106823003/)

Reason for revert:
Turns out, we really only care about the smoothness version of this benchmark. I'm going to revert this change and put up a new patch to enable the key silk cases smoothness benchmark with slimming paint enabled.

Original issue's description:
> Add a slimming paint version of the r&r key silk case benchmark
>
> This patch adds a version of rasterize and record on key silk cases with
> --enable-slimming-paint.
>
> BUG=464910
>
> Committed: https://crrev.com/da8b63007bd79a03f9d5429d75511db8b723a2ea
> Cr-Commit-Position: refs/heads/master@{#327162}

TBR=chrishtr@chromium.org,sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464910

Review URL: https://codereview.chromium.org/1110203002

Cr-Commit-Position: refs/heads/master@{#327318}

Properly ignore component extensions in InstalledLoader.

Review URL: https://codereview.chromium.org/1114583002

Cr-Commit-Position: refs/heads/master@{#327317}

Revert of Revert of Add CPP API for BLE advertisments. (patchset #1 id:1 of https://codereview.chromium.org/1111563002/)

Reason for revert:
Can't seem to find any bots this was failing on. Trybots on the original CL that had component=shared_library are working fine and locally it builds fine too.

Original issue's description:
> Revert of Add CPP API for BLE advertisments. (patchset #12 id:220001 of https://codereview.chromium.org/1054743003/)
>
> Reason for revert:
> Breaks component=shared_library build (missing export?)
>
> ../../device/bluetooth/bluetooth_adapter_chromeos.cc:321: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::BluetoothAdvertisementChromeOS(scoped_ptr<device::BluetoothAdvertisement::Data, base::DefaultDeleter<device::BluetoothAdvertisement::Data> >, scoped_refptr<chromeos::BluetoothAdapterChromeOS>)'
> ../../base/memory/scoped_ptr.h:128: error: undefined reference to 'device::BluetoothAdvertisement::Data::~Data()'
> ../../device/bluetooth/bluetooth_adapter_chromeos.cc:322: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)'
> obj/device/bluetooth/device_bluetooth.bluetooth_adapter_chromeos.o(.debug_addr+0x6f20): error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)'
>
> Original issue's description:
> > Add CPP API for BLE advertisments.
> >
> > This CL adds the new classes, changes to existing classes and tests for adding
> > the CPP API for LE advertisements. The design for this is available at
> > http://go/chrome-ble-advertising.
> >
> > R=armansito@chromium.org, jamuraa@chromium.org
> > BUG=466375
> >
> > Committed: https://crrev.com/c96da18077ef4b5ab28cb8b2684cd84386075e5a
> > Cr-Commit-Position: refs/heads/master@{#327128}
>
> TBR=armansito@chromium.org,jamuraa@chromium.org,scheib@chromium.org,rkc@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=466375
>
> Committed: https://crrev.com/28bc6bec94e67f23a6a9a16490e6bdf721cf6b27
> Cr-Commit-Position: refs/heads/master@{#327155}

TBR=armansito@chromium.org,jamuraa@chromium.org,scheib@chromium.org,spang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466375

Review URL: https://codereview.chromium.org/1108403002

Cr-Commit-Position: refs/heads/master@{#327316}

This allows us to select which ANGLE back-end to use more flexibly,
and controls the selection process entirely in Chrome.

The logic for when to try a backup renderer is a bit more complex
because we query the display extensions in the static binding
init code.

BUG=457325

Review URL: https://codereview.chromium.org/1051253008

Cr-Commit-Position: refs/heads/master@{#327315}

The hack is no longer needed.

BUG=310172

Review URL: https://codereview.chromium.org/1113643002

Cr-Commit-Position: refs/heads/master@{#327314}

BUG=481855

Review URL: https://codereview.chromium.org/1113473004

Cr-Commit-Position: refs/heads/master@{#327313}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1056633004

Cr-Commit-Position: refs/heads/master@{#327312}

BUG=479904

Review URL: https://codereview.chromium.org/1112623002

Cr-Commit-Position: refs/heads/master@{#327311}

Up until now the API surface of the MemoryAllocatorDump has been
strongly typed, enforcing three basic counters (physical_size,
allocated_objects_count and allocated_objects_size) + arbitrary
extra attributes.
This CL simplifies the MAD interface as follows:
- Remove the two argument (allocator_name, heap_name) in favor of
  a simpler and single argument absolute_name (e.g.,
  CreateAllocatorDump("v8/isolate1/heap2") instead of
  CreateAllocatorDump("v8", "isolate1/heap2"))
- Remove the storngly typed properties in favor of a generic
  Add(attribute_name, type, units, value) method.
- Add helper methods MAD.AddScalar() and AddString().
- Rewrite the existing dumpers to use the new simpler API.
- Fix the tests.

BUG=466141

Review URL: https://codereview.chromium.org/1105143003

Cr-Commit-Position: refs/heads/master@{#327310}

BUG=450977

Review URL: https://codereview.chromium.org/1115443002

Cr-Commit-Position: refs/heads/master@{#327309}

Tests will appear in a future CL.

BUG=NONE

Review URL: https://codereview.chromium.org/961993007

Cr-Commit-Position: refs/heads/master@{#327308}

Profile chooser on mac was passing wrong value to signin error controller.  At the same time, I noticed another case where an infinite spinner could happen on any platform, see fix in inline_login_handler_impl.cc.

Fixed MutableProfileOAuth2TokenService to canonicalize the primary account id given to it in order to properly support loading older profiles.  This could cause chrome to show an auth error even after a successful reauth.

Refactored auth error providers to provide only the account id.
Signin error controller should no longer care about username.

BUG=476739

Review URL: https://codereview.chromium.org/1094103005

Cr-Commit-Position: refs/heads/master@{#327307}

BUG=

Review URL: https://codereview.chromium.org/1104853002

Cr-Commit-Position: refs/heads/master@{#327306}

- instantiate ImportController only when the Files.app type is PAGE_FULL.
- remove unused flag 'importEnabled_'.

BUG=454148
TEST=manual test

Review URL: https://codereview.chromium.org/1109073002

Cr-Commit-Position: refs/heads/master@{#327305}

This function grabs locks in different orders depending on the order
of the layers being drawn. But they are all released before being any
are grabbed again, and more than one lock grab only occurs on the
compositor thread.

R=pbos@chromium.org,earthdok
BUG=476529

Review URL: https://codereview.chromium.org/1081103009

Cr-Commit-Position: refs/heads/master@{#327304}

CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship
and the indirection is no longer necessary. This CL moves the rest of the stuff
to the dispatcher, and removes the listener.

1st CL: https://codereview.chromium.org/1111713002/

BUG=474233
TEST=content_unittests --gtest_filter=CacheStorage*
TEST=run-webkit-tests http/tests/cachestorage/

Review URL: https://codereview.chromium.org/1107293002

Cr-Commit-Position: refs/heads/master@{#327303}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f4219dd..438de49

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1110113003

Cr-Commit-Position: refs/heads/master@{#327302}

BUG=482002
TBR=rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1103143004

Cr-Commit-Position: refs/heads/master@{#327301}

BUG=476496
TBR=jochen

Review URL: https://codereview.chromium.org/1114503002

Cr-Commit-Position: refs/heads/master@{#327300}

The tag provided to the log functions is now directly used. Getting
the full tag from the group tag should now be done once at class
initialization, which will allow catching long tag errors earlier.

Replaced the "chromium" base tag by "cr"

Added convenience functions to make it easier to call
isLoggable(tag, level)

BUG=472152,469807

Review URL: https://codereview.chromium.org/1113563004

Cr-Commit-Position: refs/heads/master@{#327299}

Log connection attempts in {Transport,SSL}ConnectJob and copy them into the ClientSocketHandle. Form there, copy them up the stack through the HttpStreamRequest (on job completion) to the HttpNetworkTransaction (on stream creation or failure).

SPDY is covered by this change -- sockets for new SPDY sessions are connected on the same path as sockets for HTTP connections, and then passed off to the SPDY code.

QUIC is not covered by this change -- sockets for new QUIC sessions are created in the QUIC code, and Chrome's current QUIC behavior does not let us see those results easily. My current plan is to log those *in* the QUIC code and then grab them on the next request that would use that QUIC session. I still need to see if this is actually practical.

BUG=480565

Review URL: https://codereview.chromium.org/1006643002

Cr-Commit-Position: refs/heads/master@{#327298}

The allocator shimming doesn't work on the 2015 CRT and we are hoping
to be able to remove it if an additional feature lands in the 2015 CRT
API. For now, don't shim and revisit once VS2015 is RTM.

R=wfh@chromium.org
BUG=481611

Review URL: https://codereview.chromium.org/1105213002

Cr-Commit-Position: refs/heads/master@{#327297}

http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/622/steps/compile/logs/stdio

This fixes the following kind or warnings:

warning(clang): [chromium-style] Complex constructor has an inlined body.
warning(clang): [chromium-style] Complex destructor has an inline body.

BUG=467287
R=thakis@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/1103323004

Cr-Commit-Position: refs/heads/master@{#327296}

Also add two older values to dllhash.

BUG=

Review URL: https://codereview.chromium.org/1110123002

Cr-Commit-Position: refs/heads/master@{#327295}

This is to bring in some sanity, and to facilitate extracting common
test code to be used by both ContentShellTests and AwShellTests.

BUG=476880

Review URL: https://codereview.chromium.org/1102753002

Cr-Commit-Position: refs/heads/master@{#327294}

Verify that the certificate presented by the alternative server is valid for the
origin when using HTTP/2, both when opening a new connection or when pooling to
an existing one.

Patch Set 1:
 * Enable hopping to a different host for HTTP/2 (not for QUIC).
 * Add unittests for both new connection and pooling cases.  Note in trybot
   output that *Valid tests pass and *Invalid tests fail.

Patch Set 2 and up:
 * Verify certificate validity in HttpStreamFactoryImpl::Job.

BUG=474217

Review URL: https://codereview.chromium.org/1074193003

Cr-Commit-Position: refs/heads/master@{#327293}

BUG=428727

Review URL: https://codereview.chromium.org/1104273002

Cr-Commit-Position: refs/heads/master@{#327292}

BUG=476589

Review URL: https://codereview.chromium.org/1088553004

Cr-Commit-Position: refs/heads/master@{#327291}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c541d594..901c4c6d

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1114523003

Cr-Commit-Position: refs/heads/master@{#327290}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/714fdfc..2d6802a

TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1110963002

Cr-Commit-Position: refs/heads/master@{#327289}

This CL updates the list of disbled tests on the Browser Side Navigation Linux
FYI bot.

BUG=475027

Review URL: https://codereview.chromium.org/1113473005

Cr-Commit-Position: refs/heads/master@{#327288}

BUG=466799

Review URL: https://codereview.chromium.org/1110743002

Cr-Commit-Position: refs/heads/master@{#327287}

BUG=474828
TES=Verified on local linux box.

Review URL: https://codereview.chromium.org/1108733002

Cr-Commit-Position: refs/heads/master@{#327286}

The receiving window as known and obeyed by the peer is
|unacked_recv_window_bytes_| less than |recv_window_size_|, this should be
reflected in the check in DecreaseRecvWindowSize().  Otherwise
|DCHECK_GE(recv_window_size_, unacked_recv_window_bytes_)| might fail in
IncreaseRecvWindowSize().

This CL fixes that in both SpdySession and SpdyStream.

BUG=478836

Review URL: https://codereview.chromium.org/1051213006

Cr-Commit-Position: refs/heads/master@{#327285}

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/1081003002

Cr-Commit-Position: refs/heads/master@{#327284}