- 06 Dec, 2017 40 commits
-
-
Pavel Feldman authored
Change-Id: I856dbeb0da04d6242dc5eb02722aed95a56b5d03 Reviewed-on: https://chromium-review.googlesource.com/809948Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522028}
-
Sadrul Habib Chowdhury authored
Send the AcceleratedWidget to the client on init, so that the compositor can be correctly initialized. BUG=786453 Change-Id: Iad74feb8d669abf2470702fad890f33c2fe11f91 Reviewed-on: https://chromium-review.googlesource.com/810210 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#522027}
-
Daniele Castagna authored
'content-image-texture-target' command line parameter was added to communicate from the browser to the renderer the texture targets to use when binding a texture given a pair usage/format. The map was fully populated (every combination of usage/format), and with time the command line parameter grew to a string that is now more than 1k: --content-image-texture-target=0,0,3553;0,1,3553;0,2,3553;0,3,3553;0,4,3553;0,5,3553;0,6,3553;0,7,3553;0,8,3553;0,9,3553;0,10,3553;0,11,3553;0,12,3553;0,13,3553;0,14,3553;0,15,3553;0,16,3553;0,17,3553;1,0,3553;1,1,3553;1,2,3553;1,3,3553;1,4,3553;1,5,3553;1,6,3553;1,7,3553;1,8,3553;1,9,3553;1,10,3553;1,11,3553;1,12,3553;1,13,3553;1,14,3553;1,15,3553;1,16,3553;1,17,3553;2,0,3553;2,1,3553;2,2,3553;2,3,3553;2,4,3553;2,5,3553;2,6,3553;2,7,3553;2,8,3553;2,9,3553;2,10,3553;2,11,3553;2,12,3553;2,13,3553;2,14,3553;2,15,3553;2,16,3553;2,17,3553;3,0,3553;3,1,3553;3,2,3553;3,3,3553;3,4,3553;3,5,3553;3,6,3553;3,7,3553;3,8,3553;3,9,3553;3,10,3553;3,11,3553;3,12,3553;3,13,3553;3,14,3553;3,15,3553;3,16,3553;3,17,3553;4,0,3553;4,1,3553;4,2,3553;4,3,3553;4,4,3553;4,5,3553;4,6,3553;4,7,3553;4,8,3553;4,9,3553;4,10,3553;4,11,3553;4,12,3553;4,13,3553;4,14,3553;4,15,3553;4,16,3553;4,17,3553;5,0,3553;5,1,3553;5,2,3553;5,3,3553;5,4,3553;5,5,3553;5,6,3553;5,7,3553;5,8,3553;5,9,3553;5,10,3553;5,11,3553;5,12,3553;5,13,3553;5,14,3553;5,15,3553;5,16,3553;5,17,3553;6,0,3553;6,1,3553;6,2,3553;6,3,3553;6,4,3553;6,5,3553;6,6,3553;6,7,3553;6,8,3553;6,9,3553;6,10,3553;6,11,3553;6,12,3553;6,13,3553;6,14,3553;6,15,3553;6,16,3553;6,17,3553 Most entries are just GL_TEXTURE_2D (3553). Since we have only one texture target per platform that is not the standard TEXTURE_2D, this CL changes the full map, to a list containing only usage/format that should be used with the platform specific texture target, omitting the pairs that should use TEXTURE_2D, significantly reducing the command line size. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id6c289465a24e0d76c50db9d2befd4053ef440c3 Reviewed-on: https://chromium-review.googlesource.com/783255Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#522026}
-
Giovanni Ortuño Urquidi authored
This new histogram allows us to know why a navigation ended up being intercept or why it didn't. It'll help us understand how often users get into apps as well as how often users get into websites for which they have an app installed. Bug: 785661 Change-Id: I2668f34421958b88885f53113b82a391777d9f36 Reviewed-on: https://chromium-review.googlesource.com/798250 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#522025}
-
Christopher Cameron authored
This is currently passed GPU to browser via IPC. Add support for mojo. In practice, none of the paramters are read on non-macOS platforms. Remove the ifdef guards from everything but the mach port, because of preprocessor guards aren't present in mojo. Bug: 772576 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icae234c7969ff26a337b025b6ae325e3abc92314 Reviewed-on: https://chromium-review.googlesource.com/809541Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#522024}
-
tanvir.rizvi authored
InsertParagraphSeperator gets DCHECK(IsEditablePosition) when checking for leading white speace position. This happens on a unusual HTML having, webkit-appearance style applied. Since the layoutBlock in this scenario has a logical height because of appearance property, and layout for table elements like colgroup is LayoutBlockFlow, therefore the visuallyEquivalentAlgorithm considers it as a EditablePosition, and the command for InsertParagraph is executed. Bug: 777378 Change-Id: I2abce4d09e2526f081cd810fc663aec61cfb24bf Reviewed-on: https://chromium-review.googlesource.com/781331Reviewed-by:
yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#522023}
-
Lei Zhang authored
Change-Id: I18cbf052d93c11ab857f0253f6e4ce099e3ea2bc Reviewed-on: https://chromium-review.googlesource.com/805174 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#522022}
-
Stephen McGruer authored
Previously nullable values in the animations code were tracked by storing nulls as quiet_NaN() and using std::isnan as a null-detector. It is much more explicit to store such values using WTF::Optional, which forces code to consider whether or not the offset exists. Bug: 791086 Change-Id: I4db0457b593d6be61dedb5c13a9daf8b671206b0 Reviewed-on: https://chromium-review.googlesource.com/804116Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#522021}
-
Xiaochu Liu authored
To avoid path conflicts, we install chrome os components (only) to dedicated path naming space (cros_components/[component name]). Since the components currently used are small (printer drivers), the cost to migrate it small. It's a good idea to migrate now. BUG=chromium:789726 TEST=update (ignore old locations)/install printer driver component on device. Change-Id: I3276f73eaab50ec562d247d06eedb5c96ba183bf Reviewed-on: https://chromium-review.googlesource.com/798225 Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#522020}
-
Kunihiko Sakamoto authored
This reverts commit 6ae6cf7e. Reason for revert: Speculative revert for ash_unittests-mus failure on chromium.chromiumos/linux-chromeos-rel, started here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-rel/builds/3239 This is the only mus related CL in the regression range. Original change's description: > mus/aura: Wait for the real AcceleratedWidget. > > When mus does not host viz, aura handles the real AcceleratedWidget. So > in such cases, WindowTreeHostMus needs to wait for the widget to be > avaiable, which is still created by mus and sent to aura over mojom. > > BUG=786453, 791619 > > Change-Id: I335365bfe4793c8fafb8d08eaa45c09c50e17a59 > Reviewed-on: https://chromium-review.googlesource.com/807887 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521903} TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org Change-Id: I9b15d1ad8fc36e6a4b4864e1f7bfd6df2b3745a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 786453, 791619 Reviewed-on: https://chromium-review.googlesource.com/810404Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#522019}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/6eda94d78313..4bd2ad8cf901 $ git log 6eda94d78..4bd2ad8cf --date=short --no-merges --format='%ad %ae %s' 2017-12-06 dsinclair Move V8 helper methods to their own class. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I824417a15e29eb8ad87ee6f19af8c9288b6a5ca1 Reviewed-on: https://chromium-review.googlesource.com/810265 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522018}
-
mck.giri authored
Observers performing constructive activities like trying to establish a connection to a server should only do so when the |type != CONNECTION_NONE|. Without checking |type| reconnect attempts may waste resources and get terminated with ERR_NETWORK_CHANGED. Bug: 780469 Change-Id: Iba5b734a007a58de93571f67004614788df0e393 Reviewed-on: https://chromium-review.googlesource.com/808547 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#522017}
-
Charles Reis authored
When using --isolate-origins=... or --site-per-process, some or all sites will be given dedicated processes. Documents (HTML, XML, and some text files) and other opaque formats (JSON) from such sites should not be delivered to cross-site pages in the renderer process unless they are made available via CORS or another exception. This CL adds a ResourceHandler to enforce this restriction in the browser process. The handler inspects the response headers and decides whether to block it from reaching the renderer process. It also sniffs the content to confirm the response is labeled correctly, to avoid blocking things like JavaScript mislabeled as HTML or JSON. Blocked responses are sent back as empty response bodies rather than as a network error, to ensure existing behavior does not change. Other cross-site responses (e.g., images, scripts, etc) are still allowed. Note that the current approach assumes the renderer process is not compromised and will not lie about the initiating origin, etc. The need for assumption will be removed in future work, for bug 268640. For more details, see: http://www.chromium.org/developers/design-documents/blocking-cross-site-documents BUG=786505 Change-Id: Idc2be65fc869604738dc1607c5e7fee191443b9b Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/783826 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#522016}
-
zhuoyu.qian authored
Move media_router_ui_service(.h|.cc), media_router_ui_service_factory(.h|.cc) and media_router_ui_service_factory_unittest.cc from chrome/browser/media/router/ to chrome/browser/ui/webui/media_router/ BUG=646627 Signed-off-by:
zhuoyu.qian <zhuoyu.qian@samsung.com> Change-Id: I4bb61a4f09a1806ca1f3658fc19747c6c669c284 Reviewed-on: https://chromium-review.googlesource.com/786950Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#522015}
-
Alice Boxhall authored
Bug: 514674 Change-Id: Ia14ef320b9e6f9cfd25ee5f5114a5f71ba185559 Reviewed-on: https://chromium-review.googlesource.com/807751 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522014}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f85ab8f6. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6953 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org: external/wpt/streams jrummell@chromium.org: external/wpt/encrypted-media TBR=robertma No-Export: true Change-Id: Ib6c292752d25010f7fa0474e51c2d59216954061 Reviewed-on: https://chromium-review.googlesource.com/810033 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522013}
-
Dominick Ng authored
http://crrev.com/c/768312 addresses a URL spoofing risk in permission prompts by eliding display origins in prompts from the HEAD. This means that the most significant part of the origin will be displayed if the entire origin is too long. http://crrev.com/c/677983 replaces the extension URL with the extension title when extensions request web permissions. These two CLs mean that extensions with long names have their titles elided, which is undesirable. This CL addresses the issue by not eliding the display origin if it isn't a URL. This requires a minor API change to PermissionPrompt::GetDisplayOrigin, making it return a small struct containing the display origin string and a bool indicating whether or not the string is a URL. The struct is neccesary to ensure that the bool state is calculated at the same time as the display origin. BUG=790958 TBR=tapted@chromium.org Change-Id: Icdf37feae4448f1fdd7044c7bbe690989f118023 Reviewed-on: https://chromium-review.googlesource.com/807606 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#522012}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9c02a833e207..0afcd104300d $ git log 9c02a833e..0afcd1043 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 maruel Revert "[led] Update led to the latest version" Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I8a9c7e4aff1e7489bf014b9016c351403f987ad5 Reviewed-on: https://chromium-review.googlesource.com/810206Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522011}
-
Maks Orlovich authored
In SimpleCache, when we are deleting an entry, new entry creations[1] and opens are deferred until the doom completes. This is particularly relevant in case of eviction, as that actually does it for an entire batch of entries, and getting them all deleted may... take a while. This was a performance blind spot: there is no metric measuring how long this takes, and all the metrics for various ops happen after this step has resolved, so this adds some rudimentary histograms to see if there is a problem. [1] Except I've recently changed some creates to succeed optimistically, which may have some weird interactions with this and cache locks, as the delay may express itself at different spots in the state machine; this may have had something to do with recent volatility of EntryLockWait in the canary... Change-Id: I2f022a29a471b8f00f80a94d0389326879df84af Reviewed-on: https://chromium-review.googlesource.com/802016 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#522010}
-
Ryan Landay authored
I added a helper method, SelectionTemplate::ComputeRange() in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/806439 This CL migrates some callers over to using this new method. Change-Id: I44557d6fb5b401d1e3ca066612b11ad57be27d82 Reviewed-on: https://chromium-review.googlesource.com/808753Reviewed-by:
yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#522009}
-
Andrew Grieve authored
Change-Id: I5a23b4e29605cc35dbf47cd91b2853f7c9efaadd Reviewed-on: https://chromium-review.googlesource.com/809649Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#522008}
-
Lev Rumyantsev authored
We will record it for UMA as the next step. BUG=b:63134383 TEST=Debug print and check the received value. Change-Id: If7590ceacfed4328ccead78922d44976ac29d9ff Reviewed-on: https://chromium-review.googlesource.com/802998 Commit-Queue: Lev Rumyantsev <levarum@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#522007}
-
shahriar rostami authored
When non-default content settings changed to default, they should be kept in Page Info because user might need to change them again. If the navigation or refresh happens, content settings with default value should not be shown in Page Info anymore. Bug: 777275 Change-Id: Ica986ee6646b833bf47da05fb39abb786ce2259a Reviewed-on: https://chromium-review.googlesource.com/792790 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#522006}
-
David Reveman authored
geo1.png: Landing geo2.png: Lunar geo3.png: Dots geo4.png: Spin geo5.png: Grids Bug: b/68491286 Change-Id: Ic117736aabe8581222cf4ca57eae7cf312559dda Reviewed-on: https://chromium-review.googlesource.com/810144 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#522005}
-
Tetsui Ohkubo authored
As new style notification is launched in M62, and IsNewStyleNotificationEnabled() returns true by default on Chrome OS, we no longer have to check IsNewStyleNotificaitonEnabled(). This CL makes following changes. - Remove IsNewStyleNotificationEnabled checks under chrome/browser/chromeos. (*.cc) - Remove UI strings that are no longer used. (*.grdp) - Remove icons that are no longer used. (*.png, *.icon) Icons that are not removed are referenced in somewhere. BUG=757703 Change-Id: I46e52295115c3e0a619d1eeefb02321034ce5117 Reviewed-on: https://chromium-review.googlesource.com/802601Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#522004}
-
Zhenyao Mo authored
BUG=774174 TEST=https://github.com/KhronosGroup/WebGL/pull/2555 R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4f4e7636314502451104730501a5048a5d7b9f3f Reviewed-on: https://chromium-review.googlesource.com/808665 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#522003}
-
Peiyong Lin authored
We want to plumb frame visibility change to GRC. Before that, we want to understand the volume of IPC. This patch adds histogram to record the frame visibility when it's changed. BUG=790680 Change-Id: Ib798308bf18473c1432cbe651ac9217714115b9a Reviewed-on: https://chromium-review.googlesource.com/807351Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522002}
-
Bugs Nash authored
Changed custom applyValue code for border-image-source and -webkit-mask-box-image-source to be hand written instead of generated with a custom template as the savings on code duplication aren't large enough to warrant the added code complexity. These hand written custom methods will be moved to property classes after all the generated methods are moved. Bug: 751354 Change-Id: Ie983aa0b3a13bddc3c0435faf40e0960e2d2dac5 Reviewed-on: https://chromium-review.googlesource.com/810245Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#522001}
-
Tatsuhisa Yamaguchi authored
appWindow object doesn't have reload() method ready until the window is loaded. This is a quick fix to avoid crashing the background script by user operation. Test: manually verified as noted in the bug Bug: 789226 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie2266792d8ca62bd0bae74ff2824b72221acbdb7 Reviewed-on: https://chromium-review.googlesource.com/800910Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#522000}
-
Miguel Casas-Sanchez authored
This CL sorts out a few points to clear the way for crrev.com/c/784330 to be landed again; these changes are, in a nutshell using NumTextures() ISO NumPlanes() where appropriate, and rewriting the service function NumGpuMemoryBuffers() for clarity and to allow for removing FinalVideoFormat(). TEST=all unittests working as before, Video playback in all platforms and with/without video deco acceleration running as on ToT. Bug: 791676 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic8f0a646a7a0d9271d7233681cb0383e3f6f64ba Reviewed-on: https://chromium-review.googlesource.com/807366 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#521999}
-
Dominic Mazzoni authored
The second argument to NotifyAccessibilityEvent is whether we should fire a native event, otherwise just a Chrome OS event is fired. This should almost always be true. Changing this one case from false to true fixes the linked bug where the combobox in the bookmarks popup didn't announce when changing. Bug: 779302 Change-Id: Ida63037d8a7a01e43150e7e3e2398a965d8405eb Reviewed-on: https://chromium-review.googlesource.com/809728Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#521998}
-
chrome-release-bot authored
TBR=mmoss@chromium.org Change-Id: I3cf9c1cfaf12d1ee381806276cc3c01aaad5ef74 Reviewed-on: https://chromium-review.googlesource.com/810273Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#521997}
-
Philip Rogers authored
This patch ensures the scrolling contents layer is repainted when the background color is changed with the inspector protocol. Bug: 781428 Change-Id: Ia7ba3e7acdf55bf557e42cd9fab62d08f2ce3a0c Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/805006 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#521996}
-
Deepanjan Roy authored
We are experimentally enabling some of the histograms of the new cpu time metric on the perf dashboard so we can evaluate the noise level and discover any other existing issues of the metric. Bug=catapult:#3325 Change-Id: I292d7228bde22dafa7f2daf1689896a0729b2631 Reviewed-on: https://chromium-review.googlesource.com/809202Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Deepanjan Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521995}
-
Ryan Landay authored
We have several call sites that construct an EphemeralRange from a SelectionTemplate by calling EphemeralRange(selection.ComputeStartPosition(), selection.ComputeEndPosition()). This CL adds a helper method so these callsites can just do selection.ComputeRange(). Change-Id: Iaf9a8d1fa461e45f3070204bc4fd28b2b5793169 Reviewed-on: https://chromium-review.googlesource.com/806439 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521994}
-
David Dorwin authored
Bug: 788768 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I205ec4c543c26f42e41d124981a9a258faa7c594 Reviewed-on: https://chromium-review.googlesource.com/798632 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521993}
-
Dominic Mazzoni authored
Bug: 791634 Change-Id: I1204aa60160afe95c21c27b693283133ea33fd80 Reviewed-on: https://chromium-review.googlesource.com/806878Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#521992}
-
Peng Huang authored
And this CL also fixes an issue to make sure ppapi plugin will request the discardable memory interface from ui service instead of browser when the browser is launched with --mus flag. Bug: 791119 Change-Id: I1ce2b256c2280fe02c364aff8d199ab4c43618f0 Reviewed-on: https://chromium-review.googlesource.com/806482Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521991}
-
Kevin Marshall authored
This reverts commit 0f06f8fd. Reason for revert: CIPD doesn't allow multiple .ensure files to coexist, crbug.com/789809 Original change's description: > Fuchsia: use CIPD to check out arch-specific QEMU binaries. > > These binaries allow us to run QEMU on ARM; the current deployment > in the Fuchsia SDK folder is x86-64 only. > > The "qemu" folder can safely be removed from the Fuchsia SDK > once this CL lands and the trybots are confirmed to still be in > working order. > > Also modify the runner script to use arch-specific QEMU binaries. > > > Bug: 786193 > Change-Id: I1515bdf330f496ff47f88ba3b131629d4e24fea3 > Reviewed-on: https://chromium-review.googlesource.com/783699 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519536} TBR=dpranke@chromium.org,kmarshall@chromium.org,scottmg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 786193 Change-Id: I320cf80f222c337b38e91e0f10ef2a3479f45f9d Reviewed-on: https://chromium-review.googlesource.com/810088 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#521990}
-
Tatsuhisa Yamaguchi authored
VolumeReaderJavaScriptStream::Seek() doesn't return error even when the file is not readable. Also the error in Read() was not handled before. This was causing infinite loop when the archive became inaccessible, such as when the archive was deleted by the user. This change adds error handling on Read(). Bug: 791924 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2774e53ed25eea50e6abe62ec7c52f4237c24c25 Reviewed-on: https://chromium-review.googlesource.com/808524 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#521989}
-