GitLab

Currently, they only run when the network service is disabled.  This CL
will both make it easier to enable them for SafeBrowsing once
SafeBrowsing correctly sets up its tests with the network service
enabled, and protects against regressions in the legacy in-process path
in the meantime.

Bug: 789640
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5d33acbe7c3ee918a2fe5335c60c7c2b7bb0721a
Reviewed-on: https://chromium-review.googlesource.com/1042888Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556887}

Bug: 840480
Change-Id: Ia92ed5a05d23ce25d577f5ab822527b7a25fa915
Reviewed-on: https://chromium-review.googlesource.com/1048063Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556886}

This CL introduces HeapTracer which a single concept to track interesting
garbage collection numbers across garbage collections.

This allows for unit testing measurements and unifying the histogram
logic into a single place.

Bug: chromium:840789
Change-Id: Ie36d6f9cc973f0dec28a3305b2d0def59bafe135
Reviewed-on: https://chromium-review.googlesource.com/1046647
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556885}

We gather the library dependencies of the executable, to include them
in the manifest, by running 'readelf' on it, then iterating over each
library in turn to add its dependencies, and so-on.

'readelf' can accept multiple filenames on the command-line, so rather
then invoking it once per-file, run it on a batch of all the not-yet-
processed dependencies, at each iteration.

Bug: 798851, 796779
Change-Id: If1ff5be592bfea120b93d16b09eb53c651d6c50f
Reviewed-on: https://chromium-review.googlesource.com/1049174
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556884}

Remove the last remaining monolithic texture-based element. Now, all
element are composed of basic rectangle, text and icon elements.

A follow-on change can move text helper code out of UiTexture, into the
Text class.

BUG=783788

Prompt testing

R=tiborg

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Ida9a2a91e47199445acd97d9bdf22dc84c6cfcf5
Reviewed-on: https://chromium-review.googlesource.com/1048322
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556883}

Currently fidlgen uses the namespace that's specified in the .fidl file.
As result the generated code may collide with other code in
chromium. This CL implements a temporary workaround for this problem:
generated code is updated to use a namespaces nested in fuchsia::
namespace. The script won't be necessary after FIDL-160 is resolved.

Bug: 831384
Change-Id: I3648f89f44a8e0148b1cc6b58d6f3a8de82a684e
Reviewed-on: https://chromium-review.googlesource.com/1045257Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556882}

This CL re-lands r555640 that was reverted since it was breaking
headless clients. The breakage is addressed separately:

https://chromium-review.googlesource.com/c/chromium/src/+/1048725

TBR=sky, dgozman, alexclarke, caseq

Bug: 836272
Change-Id: I9bf7e13f07ebdb7ffe1cfa52e1e000a336f43541
Reviewed-on: https://chromium-review.googlesource.com/1048838
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556881}

Positioning floats when we're going to abort layout is just waste of
time and cause of noise when debugging.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I0409330dec04d7fcc7902387f4d4ac2a1a410651
Reviewed-on: https://chromium-review.googlesource.com/1049968Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556880}

It looks like only under TSAN, String("1") and String("1234567890")
share the memory address, but the test assumes they are at the
different memory.

This patch fixes by using the string literal address directly.

Bug: 830648
Change-Id: I804f44e301d3a8f5e13da9acd985e33103cae8a5
Reviewed-on: https://chromium-review.googlesource.com/1050047Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556879}

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug: 836416
Change-Id: If44f30dd222572fea1c030a804507f67a1b54e17
Reviewed-on: https://chromium-review.googlesource.com/1033967Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556878}

Part of ongoing effort to get automation tree working
in chromecast. Duplicated code will be refactored
into common /extensions later.

PS 1 is baseline for copied files.  Modifications on top
of that in PS >= 2.

Bug: 73383411
Test: None
Change-Id: I53808c6928f40b4d7eac7fada76a3fbca4c622e0
Reviewed-on: https://chromium-review.googlesource.com/1044295Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556877}

Fix WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement flake on Windows with network service.

This passes all the time on Linux with network service, but fails most of the time on Windows. The problem is that due to timing differences with network service, |webview| is torn down while it still has its navigation in-progress. WebViewGuest::DidFinishNavigation then synthesizes a LoadAbort called and (I'm not sure why) onNewWindow gets called a second time.

Bug: 598073
Change-Id: I7ca2acd5e4ec7ddbfc25f94184d83e1abdb25545
Reviewed-on: https://chromium-review.googlesource.com/1049011Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556876}

I introduced a typo when landing:
https://chromium-review.googlesource.com/c/chromium/src/+/1041218.
This CL fixes that typo.

Bug: 840398
Change-Id: I69d638e7e0e3284518dd198bb2ad455417c7cc2a
Reviewed-on: https://chromium-review.googlesource.com/1048171Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556875}

This is a reland of a6889a09 now that crrev.com/c/1044502 crrev.com/c/1043259 and crrev.com/c/1043283 fix the previously discovered issues.

Original change's description:
> [CFI] Enable cfi-icall for official Linux x64 builds
>
> The measured size impact is 1.5% and perf impact is ~1%.
>
> Bug: 701919
> Change-Id: I541242711bc85cc124ff3a2680171577e75475bd
> Reviewed-on: https://chromium-review.googlesource.com/1033918
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554828}

Bug: 701919
Change-Id: I1a518d356cc6f3599545e594204ce360b4e0360a
Reviewed-on: https://chromium-review.googlesource.com/1045565Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556874}

Bug: 840097
Change-Id: I113585a3bac4f8c6d6d8c76d6dfaa62683393643
Reviewed-on: https://chromium-review.googlesource.com/1049058Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556873}

Bug: 825901
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I83f7d79a3bf5a75945a9f3546468804249fe95a0
Reviewed-on: https://chromium-review.googlesource.com/1050365Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556872}

Replace with a paired cc::TextureLayer directly in blink, and a WebLayer
to wrap it and be returned as the PlatformLayer.

R=pdr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie44ed6254c35b281e5c0f75733779a3c9ff81e7b
Reviewed-on: https://chromium-review.googlesource.com/1047968
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556871}

Old method, with RTPFragmentationHeader argument, has been deprecated,
and will be deleted with webrtc cl
https://webrtc-review.googlesource.com/c/src/+/75180.

Bug: webrtc:6471
Change-Id: I63460bdd6e65a4254e914a2e70be97df63001761
Reviewed-on: https://chromium-review.googlesource.com/1050247
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556870}

Bug: 840435
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8b8e51220cf7c83d87762c6c62c68878777098bc
Reviewed-on: https://chromium-review.googlesource.com/1047952
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556869}

https://skia.googlesource.com/skia.git/+log/e7df0bb900ec..75ce242a4662

$ git log e7df0bb90..75ce242a4 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 skcms-skia-autoroll Roll skia/third_party/skcms ba83c97..289cedc (1 commits)
2018-05-08 skcms-skia-autoroll Roll skia/third_party/skcms 215ecb4..ba83c97 (1 commits)
2018-05-07 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur (take 3)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I574ed29c0cb69a069b065862f24e1571d964b477
Reviewed-on: https://chromium-review.googlesource.com/1050368
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556868}

This CL ports the WifiStausMonitor to the mirroring service, which
periodically query the ChromeCast receiver for status updates.

Bug: 734672
Change-Id: Ieab87b05b1eed310e29524cb63ce5f54babd2e45
Reviewed-on: https://chromium-review.googlesource.com/1045496
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556867}

When destroying the UsbServiceImpl its reference to the libusb_context
object is released before the list of UsbDeviceImpls owned by its parent
class. Each UsbDeviceImpl has both a reference to the libusb_context and
an individual libusb_device but because of the order in which these are
declared the libusb_context reference is released first. This patch
reverses the order of these fields so that the libusb_context outlives
all libusb_device references.

Bug: 838947
Change-Id: Ife26033b30bcba164ade30a66cc3e153faa7c876
Reviewed-on: https://chromium-review.googlesource.com/1048610Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556866}

This reverts commit e481b7b5.

Reason for revert: Caused issues with codesearch

Bug: b/79389644

Original change's description:
> Avoid searching the compilation database for every file.
> 
> The compilation database for chromium is ~180MB of JSON. The current
> implementation of "run_tool.py --all" reads the whole database, pulls out
> only the filenames, and then has the tool rescan the compilation
> database for the flags. We can instead extract the flags as well, and
> pass them directly to the tool, to avoid the rescanning.
> 
> A local run of translation_unit over the whole repository took 44m15s
> before this change, and 17m23s after.
> 
> Change-Id: I373238980654a5586e32f5a516f0953a4eec03c3
> Reviewed-on: https://chromium-review.googlesource.com/1039203
> Commit-Queue: Owen Rodley <orodley@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556653}

TBR=dcheng@chromium.org,jsca@chromium.org,orodley@chromium.org

Change-Id: Ifc131260c52175269fc6ae2912bbc53433e67b40
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1050546Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556865}

Allow native lib placeholders to be specified for both ABIs, not just
the primary, to allow APKs that don't contain real native code to
present to Android as if they were still multiarch.

Change-Id: I497db19dd2dffbdd816615d9a5905ae4a77a687b
Reviewed-on: https://chromium-review.googlesource.com/1048525Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556864}

This defines a build flag to suppress a change in Skia
(https://review.skia.org/126615) which will require rebaselining a number
of text shadows.

Change-Id: Idfeee0a582a084d4a50eb295d7ff1a479e867132
Reviewed-on: https://chromium-review.googlesource.com/1050466Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556863}

This adds in a new function, PartitionRellocGenericFlags, which allows
invoking realloc with passed in flags. This in turn allows for
controlling behaviours like if the call should return null or OOM when
unable to satisfy a request. The existing method
PartitionRootGeneric::Realloc has been refactored to use this new
function with no flags, so there only needs to be one implementation.

BUG=chromium:783022

Change-Id: Iee783874b16b56efdaa1ad0bd0dd8f0b485c68f3
Reviewed-on: https://chromium-review.googlesource.com/1044971
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556862}

Change-Id: I8bafe64117d7247b7806e1d64d6e7e793078877c
Reviewed-on: https://chromium-review.googlesource.com/1028452Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556861}

For mustash we are building the window service code into ash as a
library. Remove the switch that ran the window service code as a
separate mojo service.

Bug: 838597
Test: bots
Change-Id: Ibf76fc2616a221a04776a955ef134b43a1b90bfe
Reviewed-on: https://chromium-review.googlesource.com/1048945Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556860}

This CL logs the Windows.PostOperationState.DeleteFile.* and
Windows.FileSystemError.DeleteFile.* histograms to shed some light on
when and why deletes fail on Windows. These will help inform subsequent
changes to our delete strategy to be sure that we don't make things
worse.

BUG=599084

Change-Id: Ieefdd6a98a7d6636f7cfb2cffd4685e32bf00283
Reviewed-on: https://chromium-review.googlesource.com/1044193
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556859}

This patch adds unit tests to record the current behavior of bidi
adjustment in hit testing.

Test cases generated by https://jsfiddle.net/zxdavu94/8/
Baselines matched by https://jsfiddle.net/fyj66tn9/

Bug: 811502
Change-Id: I334adc887794fa5dc3d5bf57b2fd5c47518f40a1
Reviewed-on: https://chromium-review.googlesource.com/1049268
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556858}

This adds more startup traces inside WebViewChromium.init, with the goal
of identifying what is responsible for the 8 ms chunk of unaccounted
work.

Because there is no obvious suspect for such a long duration of time,
this adds a couple different logs:

 * Invoking createWebViewContentsClientAdapter (intentionally logged
   outside the body of the method, to measure Class loading)
 * checkThread

Bug: 838702
Test: N/A
Change-Id: Ic3029d897f66ddad09cf0c41d49689fdf7833d5a
Reviewed-on: https://chromium-review.googlesource.com/1048485
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556857}

Java adjustSelectionByCharacterOffset() will be triggered if
|TextClassifier| API thinks we should adjust previous selection, the
renderer FrameInputHandlerImpl::AdjustSelectionByCharacterOffset() is
called with the need to show context menu later.

Eventually it will call EventHanlder::ShowNonLocatedContextMenu(),
which will give us the left selection bound's middle point as the new
point for MouseEvent.

In ContextMenuController#ShowContextMenu() there is another hit test
based on this point. In some cases, this point is under other HTML
element, so we won't get current selection text based on the hit test
result.

Later in SelectionPopupController::ShowSelectionMenu() we checked that
if the selection text is empty and this is non-editable element, we
won't call Java side SelectionPopupControllerImpl#showSelectionMenu().

Users are expecting context menu, but there won't be one.

In this CL, we set |data.selected_text| when |source_type| is
|kMenuSourceAdjustSelection|. Hit test isn't needed in this case.

Bug: 840007, b/78631924
Change-Id: I9631773655300b2fc1dc5f84faa161093fae900f
Reviewed-on: https://chromium-review.googlesource.com/1045510Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556856}

In addition, we also now activate the widget on Show.

Bug: b:79375309
Change-Id: I7054d12edbcc94064fccd8a13ff0c507eda9c9d6
Reviewed-on: https://chromium-review.googlesource.com/1048805Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#556855}

Dismissing the touch handles is redundant since clearing the selection
already hides them.

Change-Id: I0a9d6fc59cec6b00a6e9aa5d1c6e716f91976872
Reviewed-on: https://chromium-review.googlesource.com/1036201Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556854}

The standard got updated to invalidate the internal slot after
a setParameters() call to enforce having a single matching
getParameters() call.

Bug: 803494
Change-Id: Ia6b1483b908c3ef29c31fdcf2fb8014735cea322
Reviewed-on: https://chromium-review.googlesource.com/1047426
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556853}

Bug: 812051
Change-Id: I32375672b2fef31603c2eefdd13fd60a12a40206
Reviewed-on: https://chromium-review.googlesource.com/1050435Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556852}

This CL moves GPU related code in SkiaOutputSurfaceImpl into a new class
SkiaOutputSurfaceImplOnGpu. This new class is created, used and destroyed
on the GPU thread.

Bug: 824382
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ib5809b1b42b73e296344be4459058b52b36fee6a
Reviewed-on: https://chromium-review.googlesource.com/1017237
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556851}

Before this CL, if the list of configured proxies to use as Data
Reduction Proxies changes while a request to a previously configured
Data Reduction Proxy server is in-progress, then DRP-specific bypass
logic and metrics wouldn't be applied to that response since its proxy
server doesn't match the currently configured proxies.

To solve this, this CL changes Chrome to keep track of the two most
recent previous proxy configurations, such that it treats any proxy that
matches the current configuration or these old configurations as a Data
Reduction Proxy.

This CL also includes some clean up and minor miscellaneous
refactoring/optimizations.

Bug: 839140
Change-Id: I93ea5c45723aabea2f6a2a4960ad72132f5c30b9
Reviewed-on: https://chromium-review.googlesource.com/1045025Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556850}

This helps system administrators notice when compromised renderer
processes are trying to access cross-site data.

BUG=780106

Change-Id: Ib5b2581376d11ead1947bc385410ddf387dbc1a1
Reviewed-on: https://chromium-review.googlesource.com/989654Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556849}

This should fix the problem with sending 2 requests to iTunes servers
with cases of StoreKit handling.

Bug: 838359
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I14ef3b3053391187d34885be939d598827e7bb6d
Reviewed-on: https://chromium-review.googlesource.com/1043648Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556848}