- 14 Jan, 2021 40 commits
-
-
Sami Kyostila authored
Rewrite a trace event to use the TRACE_DISABLED_BY_DEFAULT macro instead of manually spelling out the disabled category prefix string. Bug: 1006541 Change-Id: I2759162549bcb4c562b0f86a62f8e4340092f68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627861 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#843709}
-
Dave Tapuska authored
FrameHostMsg_DidDeleteInProcessInstance becomes a message on the PepperIOHost. BUG=1157519 Change-Id: I05cd8c0faf86ddb27a9b9ac77a09239ff1e7fae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625999 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#843708}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610625483-a0e2f95e7a919a4bc7e74f0638f605fdfadfc75f.profdata to chrome-mac-master-1610647094-3e6a9456ec2a4877d37636e99663c09557aba29f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id8cf6e1e000232d6b13f34f038fe8d062721813a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626530Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843707}
-
Andrew Xu authored
:) Change-Id: I0839f1dae395b051d912e97e107a2d9fb8a89eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629662 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843706}
-
danakj authored
If there is an active sync setup when then PeopleHandler shuts down, it will CloseSyncSetup() which drops the SyncSetupInProgressHandle. When destroyed, the SyncSetupInProgressHandle ends up notifying the prefs service which then calls back to the PeopleHandler mid-destruction if it has a subscription to the syncer::SyncService. This will then cause a crash because the PeopleHandler tries to talk to the RenderFrameHost and RenderFrame, which are also being shutdown and the RenderFrame has already been destroyed. R=dpapad@chromium.org Bug: 1158869 Change-Id: I24ed8fb8699cdcea30845df01a5996910fb71d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627994 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#843705}
-
Mark Yacoub authored
Perform 1 drm commit consisting of all displays being modeset/disabled together. This guarantees that the kernel is aware of the states of all displays at the same time, especially in case of inter-dependency. ScreenManagerTest.{CheckForSecondValidController,CheckMultipleControllersAfterBeingDisabled} BUG: b/172069469, b/168753412 TEST: modesetting kohaku with external display, Change-Id: I4bb5b253eda793cc5807ab0000cc5e14854dc3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551490Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#843704}
-
Sky Malice authored
TBR: dominickn@chromium.org Bug: 1166410 Change-Id: Ie498f6051ce491cce14e9f99977827a2646e9913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629909Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#843703}
-
Sky Malice authored
This reverts commit 7452904e. Reason for revert: AwAutofillTest failures, see https://ci.chromium.org/ui/p/chromium/builders/ci/android-pie-x86-rel/3610/overview Original change's description: > Autofill: Add fieldtrail testing for AndroidAutofillQueryServerFieldTypes > > Bug: 1151542 > Change-Id: I25545f36d588ca926ce1de9514ae919f3f441a64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628040 > Commit-Queue: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Weilun Shi <sweilun@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843427} TBR=michaelbai@chromium.org,sweilun@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id31bb7d9a0b420315d729b802c6634e5e9c59e71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1151542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629971Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/65c824b5adc9..786a9e746bcb 2021-01-14 andoli@chromium.org [module.json extensions] Add support for ViewLocationResolver 2021-01-14 tvanderlippe@chromium.org Fix issues with localization presubmits 2021-01-14 jacktfranklin@chromium.org Create a helper for setting CSS props inside custom element If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1166108 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaf1e3cee5cf37d1857ce255c04007fbb87b1065f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627337Reviewed-by:
-
Dominic Mazzoni authored
The box-shadow property isn't shown in forced colors mode, so give the realbox dropdown a real border instead. In addition, the color used to highlight a dropdown item when focused or hovered is ignored in forced-colors mode, so set it to specific system colors that are respected in that mode. See bug for before/after screenshots. Bug: 1166383 Change-Id: I537cd4dcf7be8b9539517cc9783295a29519f55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627820Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#843700}
-
Yuheng Huang authored
Rename benchmark to desktop_ui in order to let more features use it. Stories from different features can be added to DesktopUIStorySet now. Bug: 1099917 Change-Id: I31ae8bbfd2f572c49e9a5057d686dcaf8ef3fda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625273Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843699}
-
Guillaume Jenkins authored
Stops setting the machine_name field in the DM API protos for iOS browsers. The machine name will instead be set by the backend by using the client ID, and fall back to the device model if needed. Bug: 1150847 Change-Id: I00345b07bce3b5f99fce3e19cd753207da4e6113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617465Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#843698}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/74ae09145aaf..e84d83393be4 $ git log 74ae09145..e84d83393 --date=short --no-merges --format='%ad %ae %s' 2021-01-13 wub Set SSL_OP_CIPHER_SERVER_PREFERENCE on QUIC TLS server's SSL_CTX. 2021-01-13 renjietang Handle stateless reset that's received from path validation. 2021-01-13 quiche-dev Internal QUICHE change 2021-01-13 danzh Send PATH_RESPONSE using the alternative socket if the PATH_CHALLENGE is received on that socket. 2021-01-13 fayang Internal QUICHE change 2021-01-13 haoyuewang Add methods that reads/writes connection ID in preferred_address transport parameter . 2021-01-13 haoyuewang Internal QUICHE change Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ica44198ce35862c4eb5c6469b20b6d8a239b78a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629427 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843697}
-
Sorin Jianu authored
This CL fixes two minor coding style issues. https://google.github.io/styleguide/cppguide.html#Rvalue_references According to the coding style, rvalue refs can only be used in a couple of scenarios, and they do not include the following: 1. base::OnceClosure&& done_cb The idiomatic way is to declare base::OnceClosure function parameters by value. 2. StateChangeTestEngine::StateChangeTestEngine( std::vector<StatePair>&& state_vec) : state_seq_(state_vec) {} This ctor is not one of the cases where overloads on rvalue ref are allowed. Also, the code on trunk has a minor bug: because move semantics are not passed through, std::move needs to be called even though `state_vec` is a rvalue reference. Otherwise, the member initialization is still going to be a copy instead of a move. Bug: 1164718 Change-Id: I3d63cb6bb837121e640381ce1ff0ae96ce08d161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619964Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843696}
-
Henrique Nakashima authored
This is the last class in the flags package in chrome_java. I considered moving it to a new metrics module, but the enums like ActivityType are core and used in a lot of places, and have meaning besides metrics, so I'm keeping these in flags and simply modularizing to unblock any code that uses them. Change-Id: I57c6accfaa2f1a18e230af2219b5e883919af49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625890Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#843695}
-
Xing Liu authored
Diff: 1. Remove test BookmarkBridgeTest.testAddToReadingList from this CL as @Batch is causing multiple times failure on official bots. The test will be added in a separate CL. 2. Add a logging in EmptyReadingListManager.Add. 3. Add a logging when failed to parse UTF16 in ReadingListManagerImpl::SyncToBookmark, this will help us to debug crbug/1163876. Bug: 1157808,1163225 Change-Id: I6b734ea67db192c1108f843699e7835c0e19a9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626075Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843694}
-
Adam Langley authored
This change adds support for version two QR codes, with “low” error correction. This configuration matches how other platforms generate eSIM QR codes. Additionally, since version two QR codes are smaller, their blocks can be displayed with more pixels each, so a lower level of error correction is reasonable. Change-Id: I7f42239835f3d5c6c981b9c73680247858cc0f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623842 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#843693}
-
Ana Salazar authored
For tote, users should be able to clear the selection by clicking or tapping on the bubble background. Bug: 1146145 Change-Id: Ibaabe09ae6f6b5dfb73581e1169d0a2d46651ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628075 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843692}
-
Nina Satragno authored
Chrome should not attempt to write a large blob that exceeds the maxSerializedLargeBlobArray reported by the authenticator. Fixed: 1143767 Change-Id: I2cc4f553c131655e75d7cd5380092d1747e09708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626412 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
-
Philipp Hancke authored
BUG=None Change-Id: I6941d9b5ecf5715297fe794717d6a649521e4b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627402Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#843690}
-
Daniel Rubery authored
This CL adds two new base::Features, SafeBrowsingEnterpriseCsd and SafeBrowsingDisableConsumerCsdForEnterprise to control whether using the Enterprise CSD server is enabled. It also makes two behavior changes depending on these flags. When enabled: - The consumer download ping is skipped - The |csd| field in the upload request is populated with the download metadata. Bug: 1165815 Change-Id: I00e3cc17ed56eff93803ab50232bb00497667afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626031 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843689}
-
Josh Nohle authored
Bug: 1157278, 1164572 Change-Id: I463c7c6fd65690f26004331a3475700ee0677351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629869 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843688}
-
David Black authored
Though the entire downloads section header is focusable and behaves as a single button, the focus ring is drawn as a circle around just the chevron. Screenshot: http://shortn/_yNqR9nC2Pk Bug: 1160011 Change-Id: Ie58083966e5bf1d01b09472cc7271b978741b91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628747 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Lachlan Ford authored
definition. https://github.com/immersive-web/webxr-input-profiles/blob/master/packages/registry/profiles/generic/generic-hand-select-grasp.json The grasp type exposes it as the correct button and does not trigger the squeeze events. Change-Id: I5041633e39f7f6b9bbc86bd379be64eeadc1055c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628888Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#843686}
-
Sinan Sahin authored
This CL delegates the Animator#start calls in MessageBannerMediator to WindowAndroid#startAnimationOverContent. Bug: 1159429 Change-Id: I865e62718efa46eae8e1bf733271854475edaa00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628497 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#843685}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/72c58a865b57..d392af02b749 2021-01-14 natsu@google.com Update roll AOSP scripts to reflect vulkan-deps subdirectory 2021-01-14 timvp@google.com Fix call to getImageFormatFeatureBits() in SurfaceVk.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: scripts/roll_aosp.sh && m ANGLE Change-Id: I96aa44f7caf98b92a2309a82c98ed50e60891ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628700Reviewed-by:
-
Francois Doray authored
This is a cleanup prior to fixing crbug.com/1164477. It improves readability by removing code that handles situations that never occur. Bug: 1164477 Change-Id: Ia9356857eb82e75d8d3527e278036c12dfdc636d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618183 Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843683}
-
Anders Hartvoll Ruud authored
This CL adds the StyleRecalcContext param to StyleForLayoutObject, OriginalStyleForLayoutObject, and all the CustomStyleForLayoutObject overrides. Bug: 1145970 Change-Id: Ib2453eb8920e2d478d8f1436c1b37f7e5ba55b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627388 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843682}
-
danakj authored
Step 5 for bug 1125106. This is a rework from part of the mega-patch in https://chromium-review.googlesource.com/c/chromium/src/+/2462248. Navigating on an error page should always be done as cross-document in order to attempt to reload the page. We should make this decision in the browser process directly instead of round-tripping through the renderer. This builds on the work of rakina@ in https://crrev.com/c/2581659 that did the same for history navigations. We use the same is_error_page() bool and also prevent same-document navigations from being attempted in non-history cases. The switch from same-document to cross-document is moved to a location that is shared between both code paths. A NOTREACHED() is added to the blink code that shows our navigation tests that navigate on an empty 404 page do not round-trip through the renderer anymore. This will become a CHECK() in the future as the RestartAsCrossDocument paths are removed. R=nasko@chromium.org, dcheng@chromium.org Bug: 1125106, 1147759 Change-Id: I2afaccf3de7764699aa6bb04c530d09f66f292b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626783 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Daniel Murphy authored
If the user starts chrome by launching the WebApp that is being migrated from, then Chrome crashed due to shutting down while the browser object is still being used by the migration code. This patch ensures that the browser doesn't exit during migration, and only keeps the browser alive during the migration itself. Note: This WebAppMover is not a permanent class, and will be removed after the Chat app is successfully migrated. Design Doc (Googlers only): https://docs.google.com/document/d/1GOek_Q4O_jTewHHx0MLnbYXvlTdEKT-KmkPZ5R0VJ3c/edit?resourcekey=0-K35fuzesohP36-qKSGbp0g Bug: 1165603 Change-Id: I3a38402513e3dacdd05b5d516b01f371043d5206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622584 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#843680}
-
Xianzhu Wang authored
This reverts commit 91c206e0. Reason for revert: The original CL accidentally removed some RuntimeEnabledFeatures::CompositeAfterPaintEnabled() guard. Fixed in this reland. Original change's description: > Revert "Add CullRect::ApplyPaintProperties()" > > This reverts commit 6f895b07. > > Reason for revert: The reverted CL is supposed not to affect > production, but it seems to cause crbug.com/1166540. > > Original change's description: > > Add CullRect::ApplyPaintProperties() > > > > It will be called to map a cull rect from parent space to local space > > in cull rect update during PrePaint. The purpose is to mark PaintLayers > > needing repaint on cull rect changes before paint, instead of checking > > interest rect / cull rect changes during paint, to avoid setting > > PaintLayer needing repaint unnecessarily, especially for CAP during > > composited scrolling. > > > > Besides the original features of CullRect::ApplyTransforms() which is > > used in cull rect mapping for CompositeAfterPaint, it also implements > > the following features to be on par with CompositedLayerMapping:: > > ReComputeInterestRect(): > > > > - Considering clips in additional to scroll clips, > > - Clipping expanded cull rect by scrolling contents rect for composited > > scroll translations, > > - Clamping extreme geometry values, > > - Adaptive expansion distance for composited transforms. > > > > The next steps are: > > 1. Add CullRectUpdater which updates cull rects during PrePaint when > > runtime feature CullRectUpdate is enabled. > > 2. Use the updated cull rect to replace interest rect in pre-CAP and > > cull rect in CAP and pre-CAP, still behind the runtime feature. > > 3. Enable CullRectUpdate for CAP > > 4. Enable CullRectUpdate for pre-CAP. > > 5. Remove old interest rect / cull rect code. > > > > Bug: 1046544 > > Change-Id: I6e7e9f85bc0b4640e67de1732744e647b6f7e230 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620090 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#843304} > > TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: Idc3374d3d426b9f571e417b1acbbc18227fdf274 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1046544, 1166540 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628021 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843592} TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 1046544 Bug: 1166540 Change-Id: Idb93eed1ab34750cfd1c0903551ba8fd66102354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628383Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843679}
-
Daniel Hosseinian authored
Bug: 93619 Change-Id: I6c63eb0381d2a005e224d83b3075fcae9fab9ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629671 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#843678}
-
Francois Doray authored
This is a cleanup prior to fixing crbug.com/1164477. It improves readability by removing code that handles situations that never occur. Bug: 1164477 Change-Id: I3251051a3f66283853bf551c29284595621bd759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616354 Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9513255f7c36..2a1c2dea7350 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1159788 Tbr: davidvc@google.com,adithyas@google.com Change-Id: Ia3a93a12e1a74a7e49e7f5cf018975840e5a0ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629787Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843676}
-
Caroline Rising authored
Bug: 1109316 Change-Id: I484e3e5519b7a483cdb2a3ae553529534d1265ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626006 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#843675}
-
Anthony Cui authored
On desktop, if the page has already been translated then the manual translate option in the context menu is disabled. Instead, keep the option enabled, and when selected re-surface the translate bubble UI without triggering a new translation. On Android, the menu option is enabled but does not perform any function. Instead, follow the same strategy and re-surface the UI without a new translation. Bug: 1024514 Change-Id: Ide42c3deead6ca5839ff03daff1c790084759a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622383Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#843674}
-
Ben Mason authored
R=benmason@chromium.org Change-Id: I6aa479830127ebba47dd306244a3889fa74de5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629570 Auto-Submit: Ben Mason <benmason@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#843673}
-
Robert Ogden authored
tbansal is histograms review for this project. Change-Id: I8de8ee4cc1ca106492c169156a03cb2f8daf01a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622428Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#843672}
-
Claude van der Merwe authored
Bug: 1106937 Change-Id: Ie4f3bf85e2dbddd232d4746e730a1e942f2587c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626604Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#843671}
-
Claude van der Merwe authored
Bug: 1117619 Change-Id: I1ce7cbfdd8da85fff0a584bd2f8254075ea305f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628209Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
-
