- 13 Jul, 2020 40 commits
-
-
Christopher Cameron authored
This makes SharedImageBackingGLImage work with WebGPU. After this, it will be possible to delete SharedImageBackingIOSurface. Merge all of the Client interfaces into a single SharedImageRepresentationGLTextureClient interface, now that they all came the same functions. Bug: 894929 Change-Id: I9990e66a438d97d411788485e244182b640fe9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293618 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787842}
-
nancylingwang@google.com authored
Modify unit tests to use AppServiceContextMenu and make fake extension apps. Unlike ExtensionAppContextMenu, AppServiceContextMenu only generates the enabled command, so the unit tests are modified to check the enabled items. BUG=1016159 Change-Id: I245ea01de0f5a5ef05cb2bb5575babd34d466add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280972Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787841}
-
Peter Wen authored
Turns out my initial implementation was not enough. Classes from the META-INF/TRANSITIVE directory of direct deps may also be needed: https://crrev.com/c/2289614 Let's say A depends on B. The META-INF/TRANSITIVE directory for B.turbine.jar contains superclasses that A needs to generate headers, and A *might* need them during compilation. This means that while compiling A, we should add the transitive classes for all of its direct dependencies (B, etc) to its classpath as well as the transitive classes in its own A.turbine.jar. This has a very small impact on build speed due to extracting a few more files from targets' dependencies. Ran: tools/android/build_speed/benchmark.py all_incremental Before: chrome_java_nosig: 38.0s avg (38.8s, 37.1s) chrome_java_sig: 39.2s avg (39.6s, 38.9s) chrome_java_res: 25.6s avg (25.7s, 25.6s) base_java_nosig: 40.4s avg (40.3s, 40.4s) base_java_sig: 94.4s avg (94.3s, 94.4s) After: chrome_java_nosig: 37.1s avg (36.7s, 37.5s) chrome_java_sig: 39.3s avg (39.5s, 39.0s) chrome_java_res: 25.5s avg (25.5s, 25.6s) base_java_nosig: 40.2s avg (40.1s, 40.3s) base_java_sig: 96.0s avg (96.1s, 96.0s) Bug: 1082904 Change-Id: Id942a35bdef4eaebab60991ba71d7bca99b42c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295321Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787840}
-
Dylan Cutler authored
This will add instrumentation to these APIs automatically via the bindings code. This CL intentionally excludes navigator.languages since our bindings instrumentation does not support arrays yet. I will add the label to this API in a follow-up CL. I also will annotate navigator.doNotTrack in a follow-up CL since it has a different owner in another timezone, and I do not want to block the rest of this CL on that. Bug: 973801 Change-Id: I4e4f024b20319b9f9d7da29490f15c0e71d69115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290052 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#787839}
-
Jeffrey Cohen authored
This also workarounds for the fact that the share code is not modularized (crbug.com/1022172) by adding a small build target with just one interface. Bug: 1093365 Change-Id: I8a7e23f90de190756e10ff37ce8a90340e3b565c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288076 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#787838}
-
Andrew Xu authored
Still not sure why the original test case failed. One possible reason is that the scroll distance in the previous code, which is 50, is not enough to scroll the shelf to the end. However, on my local device, it always works with the same gn args. This CL implements a function to get the maximum scroll distance of scrollable shelf. It ensures that the scroll distance in the test is large enough. Bug: 1100254 Change-Id: I99911faa6a51ada0fc827f740b019b2d20e18b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293468Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I35b419f120fd8e981ef64d43e2c183ea5f0686e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787836}
-
Jeffrey Cohen authored
TBR=tkent@chromium.org Bug: 1104910 Change-Id: Icb800cd0260a39cb6699fcdbd75ec27612c7afa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295919Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787835}
-
Haiyang Pan authored
This is a reland of b7a9b68b plus increasing the default timeout to make sure emulator starts successfully. Original change's description: > emulator: Disable the feature GLDMA. > > android emulator team points out that the exception is related to DMA. > Disable GLDMA temporarily to see if it can fix the timeout issue on MM > > Bug: 1093602 > Change-Id: I940b8111db48d8b542b47f350b949dab7448d1d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293279 > Auto-Submit: Haiyang Pan <hypan@google.com> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787433} Bug: 1093602 Change-Id: If4c1e60c0f45bd6c1e6be2444eafbf9b1550f209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295324Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#787834}
-
Renjie Tang authored
CloseStream() will be deprecated. The reason is that this method is not closing the stream silently. QUIC specifies that when a stream closes, it needs to send out a RESET_STREAM frame to indicate closure reason. The default error code in CloseStream() is QUIC_RST_ACKNOWLEDGEMENT, which is very uninformative. ResetStream(), however, allows applications to specify reasons of closure. Change-Id: Ie0633422ab3838abcaa7c31c4068db32ae11932a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292857Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787833}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95d932b7e987..ecc9f3494ee9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ftirelo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ftirelo@google.com Change-Id: I93886d48054d6f229218ce23ab93773a0d89fe26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295135Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787832}
-
Alison Maher authored
fast/css/css2-system-color.html is flaky on Windows. Mark the test as such in TestExpectations until a fix is identified. Bug: 1104697 Change-Id: I36d572cf463e6ed9e675ec7792363e5fd61e6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295405Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#787831}
-
John Lee authored
On line 89, the drag image has a padding and is translated up, which causes the drag image to peak up a bit while the group is being dragged. This is more noticeable when there's a scrollbar. Before and after: https://imgur.com/a/p6UH8e9 Change-Id: If75024d5b3dec3ceffa7a82bdaf6ab52172fa0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292860Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#787830}
-
Yulun Wu authored
Some metrics are missing for home to overview gesture. This CL adds metrics to HomeToOverviewController::HideNudge(). Bug: 1101105 Change-Id: I166cce0a489925f0e03ed61b0808044af35aaea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293459Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787829}
-
Anna Malova authored
The message does not indicate an error, but it causes confusion. The message appears when GetChromePolicyDetailsCallback returns null for the policy (see ConfigurationPolicyHandlerList::FilterOutUnsupportedPolicies). Use an empty callback instead. Bug: 1098245 Change-Id: Ifcf43a40ebae5bfd300721bcd69310ba3ebc0914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292523Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#787828}
-
ckitagawa authored
This CL moves bitmap request logic from PlayerFrameMediator to PlayerFrameBitmapState. This is mostly a mechanical change just moving code. Bug: 1099722 Change-Id: Iddedf83510bd715b18f3b5e393099721db33b69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292895 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787827}
-
Dr Alex Gouaillard authored
Bug: 1099855 Change-Id: I57368cf7bec54e97964fecb8da0dfe009d8f2968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270444 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#787826}
-
Nate Chapin authored
Several pieces of state (SecurityOrigin, ContentSecurityPolicy, and WebSandboxFlags) are set or calculated on DocumentInit, then transferred to SecurityContextInit, which is then passed to SecurityContext to complete initialization. All of this state comes from DocumentLoader (for main thread cases). Have DocumentLoader calculate the final state directly, then either pass it to SecurityContextInit (in the case of SecurityOrigin) or apply it directly to the SecurityContext for (CSP and sandbox flags). Change-Id: I40a0a6a7f68a043818eeb9eb2ccbab437e8448d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293175 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#787825}
-
Ben Kelly authored
When a new session is started, the timestamp is recorded and the session is saved as Sessions_[timestamp] or Tabs_[timestamp]. The existing session with the latest timestamp is chosen as the "last" session to restore from, and all older sessions are deleted. These new files were moved under a separate directory, to facilitate snapshotting. Snapshotting relies on static file names, so the entire folder is preserved rather than the (now dynamic) session files. The folder structure is as follows: [ProfileDir] | Sessions -----| Session_13233899802170163 | Session_13233899825256793 | Tabs_13233899802319101 | Tabs_13233899825404195 The code ensures than any new session created has a higher timestamp than any existing, in case of clock changes. If there is no older session in the new format, it falls back to the legacy files (as "Current Tabs" or "Current Session"), so current users should have no interruption in restore. Bug: 1056279,1067405 Change-Id: Ide4bc4a155e0a6de025c976ff520bc13b5edaa49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238885 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:Yann Dago <ydago@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#787824}
-
Glen Robertson authored
No functional change. Preparing to add icon_bitmaps_maskable in subsequent CL. Context: App icons are currently only those that have purpose:any. We will soon add purpose:maskable icons too, so this CL makes it explicit that these are "any" icons (suitable for any purpose). Bug: 1102701 Change-Id: Ie51004576828309ea532d791fed07d916baa2943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283030Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#787823}
-
Maksim Ivanov authored
Disable the SecurityTokenLoginTest.Basic test due to flakiness. Bug: 1105102,1033936 Tbr: antrim@chromium.org Change-Id: If60715c24add6623b1f8bfc14270144f5b2e0c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295959Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#787822}
-
Jordan Bayles authored
This patch updates the mirroring service to use openscreen's Answer message definition for mirror setting constraints. This necessitates a migration from base::Value to Json::Value as well, so this includes a refactor of the ReceiverResponse class as well. Other notes: 1. Previously, the ReceiverResponse struct didn't offer any type safety, which is worrisome since it is essentially a std::variant without any checking. This patch includes updates to the ReceiverResponse to ensure it is used correctly by callers, instead of relying on them to check everything. 2. Unit tests using the ReceiverResponse have been refactored to support the above changes, including the attempts at implementing some const-correctness. 3. Sender side letterboxing is now toggled from the ANSWER message. 4. The mirror settings have been updated to use the constraints from the ANSWER message, using libcast's new capture recommendations. Bug: 1002603, b/158030831, b/158032164, Change-Id: I8f633e9c41d70fdcfcce9f8be697acc1838cc8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245897 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#787821}
-
Adam Ettenberger authored
This CL Exposes UIA_AnnotationTypesAttributeId, specifically for : - AnnotationType_GrammarError - AnnotationType_SpellingError This allows ATs such as Narrator to announce when a word is misspelled or there are grammar errors when the user types or navigates through editable content. --- - In ax_platform_node_textrangeprovider_win_unittest.cc I collapsed these macros into EXPECT_UIA_SAFEARRAY_EQ - EXPECT_UIA_DOUBLE_SAFEARRAY_EQ - EXPECT_UIA_VT_UNKNOWN_SAFEARRAY_EQ - In ax_platform_node_textrangeprovider_win_unittest.cc I added a helper method, CreateTextRangeProviderWin, which handles creating the start and end AXNodePositions. - Internally passing a VariantVector* rather than a VARIANT* for getting attribute values for ITextRangeProvider::FindAttribute and ITextRangeProvider::GetAttributeValue. - This affects a few methods in ax_platform_node_win and ax_platform_node_textrangeprovider_win.cc - Added test cases to AXPlatformNodeTextRangeProviderTest.TestITextRangeProviderGetAttributeValue Bug: 928948 AX-Relnotes: Fixed an issue where Narrator was not announcing misspelled words. Change-Id: I0b5b4342f3bd78a1e84a8ba9d820458936822bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246918 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#787820}
-
Fredrik Söderqvist authored
Previously a synchronization could be pending when we got a frame callback, meaning that the animations would not be updated after the frame callback had run, but still require the synchronization timer to fire. Instead flush any pending synchronizations if we get a frame callback before the synchronization timer fires. This gives stronger guarantees about when to expect animation values to be updated. This could address the flakiness observed in the referenced bug. Bug: 1099657 Change-Id: Ieb90a4cd2b5bb5a3b3d1f0a0d86383f08ce0d3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292309Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#787819}
-
Alexander Cooper authored
Bug: 1007635 Change-Id: Ied6e6be95e5f903ca67ac14bea9de30a234129a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294574 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#787818}
-
Alex Newcomer authored
Change-Id: If443a9d7e73ee47af13e13fc4732255cedd86362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295519Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#787817}
-
Philip Rogers authored
Bug: 1104846 Change-Id: If40315351b29ba3b0ab9662932e261bf92d53fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294350 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787816}
-
Numfor Mbiziwo-Tiapo authored
This adds a simple putAll implementation that loops put. A basic web platform test is added as well. Change-Id: I8fcc25ffacb64d15855da921eb14f3770df28694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274217 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#787815}
-
Christopher Cameron authored
The GrContext used by SharedImageBackingFactory can be GL, Vulkan, Metal, or Dawn. SharedImageBackingFactory had started storing this as is_vulkan, is_metal, is_dawn, instead of a single switch. Update this to be a single switch. R=kylechar TBR=geofflang Bug: 894929 Change-Id: I44c6273ce0818244586b87c53f4f15da83e11239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292999 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#787814}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Idbc37012f45394eac1189024b9480dba88b1fa92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293278Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#787813}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Ie741f01d887c262139c0f4f951bc4c683444f415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292706Reviewed-by:
-
Anders Hartvoll Ruud authored
There was a bug in this test, but the fixed test has now been imported, so we can safely remove expectations. Bug: 1093622 Change-Id: Ice3da9052d863b320aeb0cd81602a8186860e02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292217Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#787811}
-
Guillaume Jenkins authored
Moves the core ProfileReportGenerator class from chrome/browser to components so it can be reused by iOS. The desktop implementation of the delegate is staying in chrome/browser. For easier reviewing, the core class still takes the concrete delegate as constructor argument, but in the following CL, this will be changed to use the reporting delegate factory. Bug: 1091936 Change-Id: I8f8ece003f24ba7c660f597562ae4448e737cc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288812Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#787810}
-
Liquan (Max) Gu authored
Context: PaymentRequestDelegateImpl is an internal class of PaymentRequestFactory. It was made non-static just to reuse PaymentRequestFactory#getWebContents. Since static internal class is generally a more preferable code practice than non-static internal class, we should refactor to make it static. Before: PaymentRequestDelegateImpl is not static. After: PaymentRequestDelegateImpl is static. Change-Id: Ic5a8b45cb66c0c729751b1b0222c5ba77133b1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295220Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#787809}
-
Marijn Kruisselbrink authored
Following changes in https://crrev.com/c/2290535 from isFile/isDirectory to kind, and following changes in http://crrev.com/c/2285670 from getFile/getDirectory to getFileHandle/getDirectoryHandle. Bug: 1103841, 1103022 Fixed: b/160828615 Change-Id: I9ca756c54a072e2049d1b176805138ccde8c17b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293177 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#787808}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Id440f7d672e39ab52511edd128f8cdc2662f4a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293004Reviewed-by:
-
Abhishek Kumar authored
Add connection failure metrics into histogram. This will be published for interface specific network connection failures. BUG=chromium:1085300 Cq-Depend: chromium:2277056 Change-Id: Ied6b33cb7420ea2574422d4f958d4adc585ab52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288764 Commit-Queue: Abhishek Kumar <kuabhs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#787806}
-
Lei Zhang authored
Change-Id: Icd8f0a84e6ae6fa9c68c4d34b91ad44fc5fff6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285749Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#787805}
-
Koji Ishii authored
Supports range-based for loop to get |NGPhysicalBoxFragment|. Bug: 829028 Change-Id: I8473172ea723c725f63637307e189ae8abc52f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291293 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787804}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85f14941793d..5f4c6e5b4c89 2020-07-13 patrick.brosset@microsoft.com Grid: Make line number labels consistently sized 2020-07-13 tvanderlippe@chromium.org Add @types/codemirror 2020-07-13 tvanderlippe@chromium.org Reset OWNERS of BUILD.gn to INFRA_OWNERS 2020-07-13 tvanderlippe@chromium.org Move devtools_module_entrypoints to separate gni file If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356,chromium:1097043,chromium:1098730 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3afc6f3357254d273bc9e1b87969848162011c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295138Reviewed-by:
-
