- 14 Jun, 2018 40 commits
-
-
Friedrich Horschig authored
This CL connects the TabLayout int the keyboard accessory with the ViewPager in the accessory sheet. This means the visibility of keyboard and tabs can be controlled by the ManualFillingCoordinator and is decoupled from the accessory. Bug: 828832, 811747 Change-Id: I01f225458d068e75fde19398fc352672779d23c0 Reviewed-on: https://chromium-review.googlesource.com/1091190 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567196}
-
Roman Sorokin authored
Fixes regression introduced in CL:1068184 Also added a browsertest to verify behaviour on user kerberos files changed D-Bus signal BUG=chromium:845829 TEST=ExistingUserControllerActiveDirectoryTest.UserKerberosFilesChangedSignalTriggersFileUpdate Change-Id: Ieeb800f85210c094f34c93a71b0e7502ceae3114 Reviewed-on: https://chromium-review.googlesource.com/1089060Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567195}
-
Mark Cogan authored
This CL updates the tab grid selector control assets, and removes the programatic scaling effect now that the assets are scaled. Tinting is also now done in code. Bug: 849645 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I48e9a3e72cad8609ad14a2940733a02140d89005 Reviewed-on: https://chromium-review.googlesource.com/1099070 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567194}
-
Joel Hockey authored
Bug: 845075 Change-Id: Id6667e02fcdd7be54d11e6ccec0074a475948754 Reviewed-on: https://chromium-review.googlesource.com/1100360Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#567193}
-
Mark Cogan authored
Per the attached bug, this CL changes the tab grid to not show the changed selection state when leaving the tab grid via a tap on a cell. Cell selection actually happened twice when a cell was tapped; once directly from the collection view, and a second time after the selection had round-tripped through the mediator. This CL cleans that up, and has the collection view decline all selection events, allowing them only to happen as a result of consumer calls. This CL adds a |showSelectionState| property to the grid view controller; when set to NO, the grid view controller will not update the selection state of the cells when the -selectWithItemID: consumer call is received. The ID of the selected item is maintained, however. This Cl also doesn't show the selection ring on the proxy cells animated for the transition. Bug: 849642 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibf8d2c91dc80c42dea55c7e457efe7232d234267 Reviewed-on: https://chromium-review.googlesource.com/1096763Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#567192}
-
Dominic Battre authored
This CL enables the spec fetching if you enable the ExperimentalUi. If you have to manually enable the feature, this probably means that you did not get a proper finch config, so a good default is set that exercises the new code. Bug: 846694 Change-Id: I072e7c3b1977bd654949e2244873a48fb5a551ee Reviewed-on: https://chromium-review.googlesource.com/1100458Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#567191}
-
Colin Blundell authored
The identity_test_utils.h methods that deal with refresh tokens promise that they block until the relevant operation is complete (as do their wrapper IdentityTestEnvironment methods). However, they don't actually do that. And that's really the most important part. This CL makes reality match the contracts. As part of this change, OneShotIdentityManagerObserver needs to be extended to have the information of which event it's waiting on, as a single signin can generate both a token updated and a primary account set event, and the one that's received first might not be the one that the client of the observer is actually intending to wait on. Note: The current production impl doesn't actually require this blocking as it is synchronous. However, it is a goal to change those interactions back to being asynchronous, which this blocking in the test code future-proofs for. Bug: 798699 Change-Id: Ib8b098b65411ef22a8a3ceed4a4f58dfcad1e931 Reviewed-on: https://chromium-review.googlesource.com/1098966 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567190}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28252da5cf0a..7d4d6b816c28 git log 28252da5cf0a..7d4d6b816c28 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@7d4d6b816c28 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: If22f28c901c95110abdb4cfcb66fca18adfb4b86 Reviewed-on: https://chromium-review.googlesource.com/1100695Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567189}
-
Nasko Oskov authored
Bug: none. Change-Id: I803b731a6418f02b2326b4e9a8cc9da7a572c92b Reviewed-on: https://chromium-review.googlesource.com/1100549Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#567188}
-
Sergiy Byelozyorov authored
TBR=dpranke@chromium.org Bug: 831171 Change-Id: Ida71a6072a3b25910bdda8fa4f15901349c7c8a0 Reviewed-on: https://chromium-review.googlesource.com/1100461Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567187}
-
Tetsui Ohkubo authored
This CL changes icon color and sub header text color in UnifiedSystemTray's detailed views. Screenshot: http://screen/224qsUVChRx TEST=manual BUG=850396 Change-Id: I48b512bd3d0e0cb4b7b42b3f6b2557fb637239af Reviewed-on: https://chromium-review.googlesource.com/1098857Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#567186}
-
Roman Sorokin authored
Shows network error message instead of an unknown error message BUG=842619 TEST=manual Change-Id: I5149fbed8282c44e9cf1960d3b4a6f013095f983 Reviewed-on: https://chromium-review.googlesource.com/1098693Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567185}
-
Tetsui Ohkubo authored
This CL adds audio detailed view (audio settings) to UnifiedSystemTray. Audio settings is only accessible when there are multiple audio inputs or outputs. TEST=manual BUG=847770 Change-Id: Ifee6be242c9c89bdb8012f3a6c905fca042aa1c6 Reviewed-on: https://chromium-review.googlesource.com/1098871Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#567184}
-
Friedrich Horschig authored
This CL replaces the duplicated @+id/keyboard_accessory used for the bottom sheet with @+id/keyboard_accessory_sheet. Furthermore, it adds some spacing, colors and dimensions that bring the whole appearance of the keyboard accessory and its bottom sheet closer to the intended outcome. Bug: 828832, 811747 Change-Id: I7e949b8e0f3f5825344f672a933e7b3e6bcd685a Reviewed-on: https://chromium-review.googlesource.com/1090921Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#567183}
-
Patti authored
Origins with only embargoed content settings are currently not included in the All Sites list. Fix. Bug: 835712 Change-Id: Ic413db891753e729f618097cca28c554cc02f1fc Reviewed-on: https://chromium-review.googlesource.com/1090596 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#567182}
-
Yoichi Osato authored
This patch rebases image expectations for - paint/markers/inline-spelling-markers-hidpi-composited.html - paint/markers/inline-spelling-markers-hidpi.html since they are scaled and only have 1px diff. Bug: 850448 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib5e68393d577a7ee493b31406d65dab60efb36ce Reviewed-on: https://chromium-review.googlesource.com/1100595Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#567181}
-
Mitsuru Oshima authored
BUG=b/74845106 TEST=covered by unittests Change-Id: I1dde9c2ab19d08945f7ad4d9d2038dc1d0ff3e54 Reviewed-on: https://chromium-review.googlesource.com/1093518Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#567180}
-
Hiroshige Hayashizaki authored
Instead of redirecting ModuleMap->Modulator->ModuleScriptLoader, this CL makes ModuleMap::FetchSingleModuleScript() to invoke ModuleScriptLoader directly, in order to: - Reduce indirection around Modulator, and - Remove Modulator::FetchNewSingleModule(). This CL moves ModuleScriptLoaderRegistry from ModulatorImplBase to ModuleMap, to make it accessible from ModuleMap. This shouldn't affect lifetime and semantics, because Modulator and ModuleMap correspond one-to-one. Previously, unit tests have overridden Modulator::FetchNewSingleModule() and put fake implementation there. After this CL, unit tests creates a fake ModuleScriptFetcher. Bug: 845285 Change-Id: If94d958c57e0e3e18622efd032863b2fbd8cc5c2 Reviewed-on: https://chromium-review.googlesource.com/1079963 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#567179}
-
Han Leon authored
ServiceWorkerGlobalScope#registration (WebServiceWorkerRegistrationImpl) can still be alive and handle incoming messages even the thread local pointer ServiceWorkerContextClient::ThreadSpecificInstance() has already been reset to nullptr by ServiceWorkerContextClient::WillDestroyWorkerContext(), thus, we need to add a guard logic into WebServiceWorkerRegistrationImpl to avoid accessing nullptr. BUG=852195 Change-Id: Ia07b88f40d195293db8690216bd46d1a22bd687a Reviewed-on: https://chromium-review.googlesource.com/1098563Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#567178}
-
François Beaufort authored
This makes sure Picture-in-Picture context menu does not show at all (instead of disabled) for video elements with audio track only (e.g. MediaDocument). It also shows audio related items such as "Open audio in new tab" insteaad of "Open video in new tab" for these cases. Screenshots: https://imgur.com/a/1d1UNrg Bug: 806249 Change-Id: I6341f476557389521ab2b6f21e53c2bd6a5df34d Reviewed-on: https://chromium-review.googlesource.com/1096759 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567177}
-
Ke He authored
Before moving //device/geolocation into //services, we have to make sure all the clients do not depend on //device/geolocation directly. Now the chrome/browser:browser depends on //device/geolocation, to remove that dependency, we have to change the geolocation target from "component" to "source_set". The reason is: When building libchrome.so, linker tries to find the symbol: "Java_org_chromium_device_geolocation_LocationProviderAdapter_nativeNew ErrorAvailable" as there are native functions being declared in LocationProviderAdapter.java. Without depending on "//device/geolocation" in chrome/browser:browser, linker will complain error that symbol cannot be found. Note that there is no *actual* dependency from //chrome to //device/geolocation, the Java code that is using the native function will be moved into Device Service as an internal implementation. So we change the "component" to "source_set" to let the symbols inside the //device/geolocation can be propagated up to target which builds the libchrome.so. At the same time, the geolocation_export.h is removed. Because the //device/geolocation will be moved into //services/device and be hidden, sooner or later it will be changed to type of source_set. BUG=800659 Change-Id: I3e581f9a0e5c492528a85a07e97e93af48ab7eb1 Reviewed-on: https://chromium-review.googlesource.com/1086490 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#567176}
-
edchin authored
This CL enables the user to: 1) See recently closed tabs in the tab grid. 2) Tap and open recently close tabs. This CL adds a method to UrlLoader protocol that restores a tab to the WebStateList based on SessionID. In BVC, the restored tab replaces the current WebState. In tab grid, the restored tab is added to the end of the WebStateList. Bug: 851219 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6dc6c22f43d746a9dc73d15b65d6fd5193899a25 Reviewed-on: https://chromium-review.googlesource.com/1094324 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567175}
-
Hiroki Nakagawa authored
This is a follow-up CL for the preview review comments: https://chromium-review.googlesource.com/c/chromium/src/+/1090592/4/third_party/blink/renderer/core/script/fetch_client_settings_object_snapshot.h#23 Bug: 845285 Change-Id: I69192292116ee9a5675aeb94cbb4e7381f01f7f7 Reviewed-on: https://chromium-review.googlesource.com/1098654 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#567174}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I95fb0bd3f737c7252bf0aa0d28909a4e9a720f03 Reviewed-on: https://chromium-review.googlesource.com/1100345Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567173}
-
edchin authored
History coordinator can now be started on top of the tab grid. This history coordinator was not properly being dismissed inside main_controller's |-dismissModalDialogsWithCompletion:|. As part of fixing dismissal, this CL also fixes a bookkeeping flaw in main_controller. Previously, main_controller conflated the existence of |self.currentBVC| with the BVC being presented and active. This CL changes that logic to use |-isTabSwitcherActive| instead. Bug : 852243 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I93d5efb33a2de8eaed7b0472fa2994c14603d11a Reviewed-on: https://chromium-review.googlesource.com/1098555 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567172}
-
Morten Stenshorne authored
Maintaining both a BFC offset and a container offset was a bit cumbersome and error-prone, and it turns out we don't need to store both. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I51ea857e979384d89fb7a97f68f1a243fad9e2a1 Reviewed-on: https://chromium-review.googlesource.com/1097756Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#567171}
-
Morten Stenshorne authored
This affects auto-positioned out-of-flow nodes that are handled as part of inline layout, and other things too. This fix will also make it possible to use the position of the last child fragment to calculate the block size of a block (which I happen to be working on). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie3f99d850de81bd349e89c624f86cce95b38eede Reviewed-on: https://chromium-review.googlesource.com/1098925 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567170}
-
Hiroshige Hayashizaki authored
To remove indirect layers around Modulator. Bug: 842553 Change-Id: Ie307c9f91ead00e260da156d6ae283131316d7eb Reviewed-on: https://chromium-review.googlesource.com/1080032 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#567169}
-
Oscar Johansson authored
In Jumbo build, the member NONE in the enum VerifyStatus in install_verifier.cc conflicts with the same member in the enum Transformation inactivity_log/activity_log.cc. This commit solves the issues by defining VerifyStatus as a strongly typed enum. Bug: 850484 Change-Id: Idc3cab01b96073b20adf6fcd87e01cdf9b02a739 Reviewed-on: https://chromium-review.googlesource.com/1098664Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#567168}
-
Oscar Johansson authored
When building using Jumbo, the using-declaration of api::webrtc_logging_private::RequestInfo results in a conflict, since a declaration of RequestInfo exists in both api/webrtc_logging_private.h and api/webrtc_audio_private.h. This commit solves the conflict by removing the using-declaration. Bug: 850484 Change-Id: I9bc25994cccdfd2e9ae19ecdacde06ed7780b1b2 Reviewed-on: https://chromium-review.googlesource.com/1098658Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#567167}
-
Oscar Johansson authored
The function g_shown is defined in every bubble delegate. When building using Jumbo those functions conflict with each other. This commit fixes this by renaming the functions to something more file specific. Bug: 850484 Change-Id: I9df3a8e90ed77e95649cdb734cc4d7364b5fc310 Reviewed-on: https://chromium-review.googlesource.com/1096945Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#567166}
-
Oscar Johansson authored
When using Jumbo build, there are conflicts between dashboard_private_api.cc and webstore_private_api.cc. The conflicts are the variable kUserCancelledError and the function WebstoreInstallHelperResultToApiResult. This commit solve the issues by renaming the variable and function to something more file specific. Bug: 850484 Change-Id: I600a036505ef731124ac6e4c3ea2f750a50ccad5 Reviewed-on: https://chromium-review.googlesource.com/1098958Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#567165}
-
Oscar Johansson authored
When using Jumbo build, the namespace alias Create in /api/context_menus/context_menus_api.cc conflicts with the function Create called from api/desktop_capture/desktop_capture_base.cc. This commits solves the issue by removing the namespace alias. It also removes the namespace aliases Update and Remove in the same file to avoid this issue in the future. Bug: 850484 Change-Id: Ibdb940e153a89b7120c670e806be34fc4e95ab90 Reviewed-on: https://chromium-review.googlesource.com/1099062Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#567164}
-
Allen Vicencio authored
Adds GetResolvedUrl to SmbShareFinder to resolve hosts found with NetworkScanner Bug: 757625 Change-Id: Ia9050358c8aba1bc0354f7f3a961d25f002673b2 Reviewed-on: https://chromium-review.googlesource.com/1091228 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#567163}
-
Becca Hughes authored
Notify the browser process when the frame owning the current fullscreen element is changed. Design: https://docs.google.com/document/d/1j3jqmGRXAHzpeKeS_tLlOo4C9DsrvPOf_-PMnFzTmeE/edit#heading=h.wozo6ynsdlp3 BUG=838400 Change-Id: I7771f7b58a8c1cdb7ec0b89b30db1de1fe708b32 Reviewed-on: https://chromium-review.googlesource.com/1054441Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567162}
-
Ramin Halavati authored
Another test is activated for win-annotator-rel bot. Bug: 844014 Change-Id: I5b7cc780fa88de7051324ac2e5585c90774c1ea3 TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1100456Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#567161}
-
Christopher Lam authored
This CL adds an Interface type for concrete implementations to @implement and makes the Mojo interface non-nullable to avoid needing an assert. Bug: 836128 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie2f1d07966f734a47c8bc724a11641d0cab67daf Reviewed-on: https://chromium-review.googlesource.com/1088355 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567160}
-
Yutaka Hirano authored
It has been enabled on the finch config. This CL enables the switch by default on the chromium src. resource_scheduler_unittests.cc is largely affected by the change. This CL removes some cases and modifies some cases to keep it green. Bug: 794073, 754918 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie49e5f0261a70f581ca766c3eeeae8a8f0e4e66b Reviewed-on: https://chromium-review.googlesource.com/1075916Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#567159}
-
Xianzhu Wang authored
The test was added in https://chromium-review.googlesource.com/1082931 for the bug, then was reverted. I forgot to add back the test in the new fix https://chromium-review.googlesource.com/1097558. TBR=trchen@chromium.org Bug: 848730 Change-Id: I3823a408819a2d8acdb7e41060d2fafd22fbb6de Reviewed-on: https://chromium-review.googlesource.com/1100486Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567158}
-
Chris Harrelson authored
Previously, we computed which paint layer was topmost (but not negative z-index) in CompositingLayerAssigner. This led to complications in invalidation, and makes it hard to optimize that class to avoid recursions. Now compute the same thing through smarter code in GraphicsLayerTreeBuilder and CompositingInputsUpdater. Bug:814439 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4c68e8622dde86be4870505696db6b453b4ab0e9 Reviewed-on: https://chromium-review.googlesource.com/1097559 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567157}
-