- 25 Sep, 2019 40 commits
-
-
Gauthier Ambard authored
When failing a provisional navigation, the context might be nil (probably a race condition in the callbacks of the WKWebView). This issue was handled in handleCancelledError:forNavigation: provisionalLoad: but wasn't in the other callbacks. This CL makes sure that we handle it. The workaround in crrev.com/c/1700054 was probably preventing the crash from happening. Bug: 1004634 Change-Id: I1f94812617c908a63124c16a18a3ca71d9902d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816575 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#699741}
-
Matthias Körber authored
Change-Id: I9a765517e989c259379c96ded5d2bdfe230100be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824885 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699740}
-
François Beaufort authored
This CL adds GPUObjectDescriptorBase dictionary as specified in https://gpuweb.github.io/gpuweb/#dictdef-gpuobjectdescriptorbase It will be used in upcoming CLs. Bug: 877147 Change-Id: Ib4e728309e01bb059ea91402fcc406ef577f9751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823860Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#699739}
-
Alex Ilin authored
This CL adds a new test DemoSignInTest::WebSignOut to the suite of live SignIn tests. The test does the following: - Sign in via settings menu - Accept Sync confirmation dialog - Check that Sync is enabled - Sign out on the web - Check that cookies are removed and tokens are in error state - Check that "Sync paused" UI is shown This CL also allows direct lookups for country-specific TLDs of "accounts.google.*" to make tests work correctly from different countries. Bug: 1006262 Change-Id: Ib4d94003bfbabec8dd9d2908c95715d2b1ecdc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822919 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699738}
-
Alex Clarke authored
We want to prioritize loading and compositing tasks until first first contentful paint, however that introduces some unintentional task re-ordering which breaks ChromeSitePerProcessBrowserPluginPDFTest.SendSyntheticTapGestureOOPIF. Changing BrowserPlugin::Initialize to post a loading task removes one source of reordering with the new scheduler policy, fixing the the browser test. Bug: 971191 Change-Id: I177d9189c980601893223425e36cd6657d058510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819254Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#699737}
-
Tim van der Lippe authored
This allows us to use more modern features like Object spread. Change-Id: I3a8a119443cf43b27e3ac9390e188408976d82e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823847Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#699736}
-
Sergey Poromov authored
Temporary allow Camera component app to be disabled by policy as it's widely used by enterprises. The proper long-term fix should be to introduce CameraEnabled policy and then remove this fix. Camera app id: hfhhnacclhffhdffklopdkcgdhifgngh Bug: 993418 Test: Manual, configured ExtensionInstallBlacklist policy to include Change-Id: I9af2d6303d023b61b1af461f51533ffb25b00422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789312 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699735}
-
Julie Jeongeun Kim authored
This CL converts MessageReceiverPtr, MessageReceiverRequest to new Mojo types using PendingRemote or Remote, PendingReceiver, and Receiver. It also updates OnConnection from secure_channel.mojom. Bug: 955171 Change-Id: Id630cb964ad03f439b696e93182bc29b13fa689d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820777 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#699734}
-
Ella Ge authored
Bug: 988784 Change-Id: I7c26682dd7f82bb5a6abf985f9991518ea100180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822503Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#699733}
-
Sebastien Marchand authored
The code that was emitting this histogram has already been removed. Bug: 995542 Change-Id: I36fbc89b33ba483ecfb3d8b93e54cbbfc8336173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823217 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Lowell Manners authored
NavigateInRenderer was using a non-standard method of waiting for navigations, (written in 2010). Now there is a much simpler way to do this. This cleanup has the pleasant side effect of fixing some test failures when BackForwardCache is enabled. Change-Id: I96b3d3d93fb9b58485cf0f7c7f33751a1abf55f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813350 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699731}
-
Xida Chen authored
In our current implementation, a custom property animation is composited regardless whether it is used by paint worklet or not. This CL makes changes such that a custom property animation is composited only when it may be used by off-thread paint worklet. Bug: 1002586 Change-Id: I305c1396495fb12477756c5e2d0e56404983a39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798889 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699730}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53bdbb292b71..0c127f488fdb git log 53bdbb292b71..0c127f488fdb --date=short --no-merges --format='%ad %ae %s' 2019-09-25 treehugger-gerrit@google.com Merge "Do not create variable for iterator we do not use." 2019-09-25 lalitm@google.com trace_processor: change RowMap::Select to return a RowMap Created with: gclient setdep -r src/third_party/perfetto@0c127f488fdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idbbc2d1966008fe2e07736199e45dcd67b2ff8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699729}
-
Paul Lewis authored
This CL converts the contents of the common/ folder over to ES modules from the current custom module system. It includes statements in each file that will pollute the global namespace, allowing the non-ESM code to continue working as before. Bug: 1006759 Change-Id: Ib591e49155000381f85999a5da6c467ad0160996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816563Reviewed-by:
-
Hajime Hoshi authored
This is a preparation to take the reason why the document is not cached and record it. Bug: 1004676 Change-Id: Ib87b4115566e227441b5b9d546722ef204f5c4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820404 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Christoph Schwering authored
Function isn't used. Change-Id: I8124be0ede96845bcc143d625d33690292ef4d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823838Reviewed-by:
-
Tomasz Moniuszko authored
Compiler complains about undefined DISALLOW_COPY_AND_ASSIGN if password_dialog_prompts.h is included from a file that doesn't include macros.h before. Change-Id: I58f161f325722591eb3ab3fbac38fc2862bb27dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821604Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#699725}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70bc753cc6c6..90d6efbd4eb4 git log 70bc753cc6c6..90d6efbd4eb4 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 ilnik@webrtc.org Revert "VP9 encoder: handle disabled layers correctly" 2019-09-25 gustaf@webrtc.org AEC3: Simplify use of SignalTransition 2019-09-25 srte@webrtc.org Moves contents of bitrate_controller to goog_cc 2019-09-25 ilnik@webrtc.org VP9 encoder: handle disabled layers correctly 2019-09-25 asapersson@webrtc.org Add unit tests for balanced degradation settings. Created with: gclient setdep -r src/third_party/webrtc@90d6efbd4eb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: Ie5c9b7239ed9e8c6f18dc0af68f7b2447bd83c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823888Reviewed-by:
-
Pavol Marko authored
The underlying issue that has been causing many flakes here (https://crbug.com/1005082) has been fixed, so re-enable the browsertest. Bug: 1005084 Change-Id: I0147578787ca11d8ddbfd49158dfc5eda5bf8a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821482Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#699723}
-
Armando Miraglia authored
This reverts commit fea48b7b. Reason for revert: while not visible, this broke webrtc tests the 20th of August (see https://ci.chromium.org/p/chromium/builders/webrtc/WebRTC%20Chromium%20Mac%20Tester/8622) Original change's description: > Speculatively re-enable TestVideoQualityH264. > > This was reported as flaky. I am unable to reproduce, which could mean > that the issue is fixed, or it could mean that it only flakes on certain > setups (OS, builds, hardware, etc). To aid investigation I am > speculatively re-enabling it; worst case it gets disabled again. > > Bug: 754684 > Change-Id: I866679464fce4facde927652751046e062ca1c81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761602 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688531} TBR=hbos@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 754684, 1007937 Change-Id: I3c6f8954b2a007e3a1ff3ac8db154c896a4cbebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823842 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699722}
-
Boris Sazonov authored
This CL removes a significant chunk of org.chromium.chrome.browser.invalidation Java package, as Chrome is now using FCM for invalidations. After https://crrev.com/c/1763755, ChromeInvalidationClientService is no longer created and can be safely removed. Bug: 1002894 Change-Id: Ia2c2e4613c2c40b456cef97a83cff93c7f21fc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821784Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699721}
-
Finnur Thorarinsson authored
This reverts commit 3594437b. Reason for revert: One or more of these tests have been consistently failing on the android-asan bot, since build 2270 (https://ci.chromium.org/p/chromium/builders/ci/android-asan/2270): PooledSharedImageVideoProviderTest.RequestImageRequestsMultipleImages PooledSharedImageVideoProviderTest.GenerationIdChangeEmptiesPool PooledSharedImageVideoProviderTest.RequestImageReusesReturnedImages PooledSharedImageVideoProviderTest.SizeChangeEmptiesPool ... with errors such as: [ RUN ] PooledSharedImageVideoProviderTest.RequestImageRequestsMultipleImages ================================================================= ==7769==ERROR: AddressSanitizer: heap-use-after-free on address 0x5ac43bfc at pc 0x94420df5 bp 0xbeb47190 sp 0xbeb4718c READ of size 4 at 0x5ac43bfc thread T0 (st:test_process) Original change's description: > Pool SharedImageVideo for MCVD. > > To reduce thread hops when generating VideoFrames, this CL adds > PooledSharedImageVideoProvider. It builds on the direct provider by > maintaining a pool of SharedImageVideo objects, which it hands out > on its own thread to clients. > > It also adds histograms to track VideoFrame creation time, so that > we can see which device(s) benefit from pooling. > > All of this is turned off by default; it must be switched on by > enabling UsePooledSharedImageVideoProvider. > > Change-Id: I4cfc03938dd4717252f3f527a3bcab0e7ae085a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699138 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: vikas soni <vikassoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698985} TBR=mpearson@chromium.org,sandersd@chromium.org,liberato@chromium.org,vikassoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic1d1b26dfa33eeabc49af497d58259b45607ee14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824081Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#699720}
-
Maksim Sisov authored
Wayland compositor provides supported format modifiers. Store them along with buffer formats and provide the WaylandBufferManagerGpu with them during initialization step. Then, GbmPixmapWayland can just use them if they are set. Bug: 1002463 Change-Id: I97f6367ad9315e3e22b0f9f37c8f1aec03df07a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795326Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#699719}
-
Sigurd Schneider authored
This CL enables the coverage model to keep polling the back-end for coverage data while performance tracing is enabled. Bug: chromium:1004203 Change-Id: I187afa45dadae3aac0d5012fa8a293eb26d438fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814825Reviewed-by:
-
Christian Dullweber authored
Add a FeatureParam to the ImprovedCookieControls experiment to control the value of the default setting. Bug: 967668 Change-Id: If695b80e2e4e0f48c180530c4e9682f7d2b4d882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824465Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#699717}
-
ckitagawa authored
Add data structures for tracking glyph usage. There are two variants sparse and dense and which one is used should depend on the font being subset, this can be done heuristically before starting tracking to minimize memory overhead. Part of landing: https://chromium-review.googlesource.com/c/chromium/src/+/1786583 Bug: 1006242 Change-Id: I251fae2270386ea0279268db4ffef8e98942e278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816440Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#699716}
-
Ioana Pandele authored
Bug: 986298 Change-Id: Iccb2f8722e09362f9c32ad496688876fe1141bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821723Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#699715}
-
Paul Irish authored
Change-Id: I31caa742e32727fcdd3c992fca0f815fefbf9740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818609 Auto-Submit: Paul Irish <paulirish@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/336bd791..87177fcb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42f93221a33e872d33df22a0628c53fde53cf41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824977Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699713}
-
Boris Sazonov authored
Activity instance was used before to check sign-in UI visibility and showing dialogs. These dialog have since been removed, so the Activity parameter can be removed to simplify the code. Bug: 1007332 Change-Id: I2e338a555dbd57b06a29697581b16f5ef4b7313d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823078 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Eric Stevenson authored
Previously, the "repackage_native" target was providing the GEN_JNI class. When there were multiple deps containing this class, zip.py would just choose the first one. This works right now because it grabs //base_java's GEN_JNI and the only dep of cronet using proxy natives is //base_java. To allow more deps to use proxy natives, this CL adds a couple sub-targets that are responsible for including the correct version of GEN_JNI. Bug: 929661, 1005836 Change-Id: Ifbcba3c012e7191be8ca410f4e8789ec791eac6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811974 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#699711}
-
Karolina Soltys authored
Bug: 968047 Change-Id: I0e48308bfdb555d34d0dcbff57ff82b30e29d8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742163 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. There are no intended behavioural changes. Bug: 941669 Change-Id: I4a423a71375fd4d8cfc8283dd2703855781ece6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818519 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#699709}
-
Jan Scheffler authored
Until now, selected but not focused items with a network error in the network pane where not distingushable from items without a network error. This patch fixes the problem by keeping the font red. Bug: chromium:843014 Change-Id: I66b3d1b6466120beb13ad4380c44a8e94971c0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821783Reviewed-by:
-
Mark Cogan authored
The tab grid contains a scroll view holding three view controllers (the incognito tabs, the regular tabs, and the recent tabs). By default, all of the contents of a scroll view can be read and navigated via VoiceOver. For the tab grid, only the view controller which is currently visible (the "current page view controller") should be exposed to VoiceOver. The logic to manage this is (prior to this CL) mostly in TabGridViewController's -setCurrentPage:animated: method. If one of the view controllers that's not visible in the scroll view has its contents focused with VoiceOver, the scroll view will show the focused content without triggering any of the other scrolling behavior. In the tab grid, this means that the page control will go out of sync with the page being displayed (which may lead to consistency DCHECKs or other problems). There were at least two bugs in this code. First, the first time the tab grid is entered, if the user navigates to the right (in LTR) in VoiceOver, they will focus the first line of text in the Recent Tabs view controller. As far as I can tell, this bug hasn't been reported. Second (crbug.com/980844), if a user is in the tab grid when they close the last incognito tab, they will switch to the regular tabs page, but the in- cognito tabs page will have its text focused and visible. Both bugs arise from the accessibilityElementsHidden property of the non- current view controller not being set to NO at the correct time. For the first bug, this is a matter of setting all non-current view con- trollers to be invisible as part of -viewDidLoad. For the second bug, the general pattern was to set the value of _currentPage and then set self.currentPageViewController.view.accessibilityElementsHidden to NO. However, when the scroll view is scrolled with animation, _currentPage is only set when the animation ends, and -setCurrentPage:animated was marking the current view as non-hidden immediately, not when the animation completed. This means that (in the case of this bug) the incognito view controller was re-marked as not-hidden, and the regular tabs view controller remained hidden. The fix in this CL is to replace direct writes to _currentPage with a property setter that always marks the prior page view controller as hidden-to-VoiceOver and always marks the new current page as unhidden. Since this setter used to induce scrolling (which itself needed to update the current page), scrolling has been pulled into an explicit -scrollToPage:animated: method. The currentPage property no longer scrolls implicitly, and is now usually set as a part of scrolling. Bug: 980844 Change-Id: I7ccb904442a55d791df95ab4c0c8c2795a6c74e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813332 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699707}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b27dd1ff740..53bdbb292b71 git log 0b27dd1ff740..53bdbb292b71 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 lalitm@google.com trace_processor: refactor tracks to reflect final design Created with: gclient setdep -r src/third_party/perfetto@53bdbb292b71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I1ff52381de3c2f38efbcd5ad7ac29d26aea8e5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824653Reviewed-by:
-
Jan Krcal authored
This CL adds back a test that was removed by crrev.com/699666. Bug: 881289 Change-Id: Iec9e4865a331ee5964c9855d5c648d9ca07fa0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824461 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3a762d54f649..527a689307a4 git log 3a762d54f649..527a689307a4 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 alanbaker@google.com Remove validate_datarules.cpp (#2911) 2019-09-24 stevenperron@google.com Handle extract with no indexes (#2910) 2019-09-24 ehsannas@gmail.com Add Bazel build configuration. (#2891) 2019-09-24 stevenperron@google.com Handle id overflow in convert local access chains (#2908) 2019-09-24 dsinclair@google.com Add OpCopyMemory test to SVA. (#2885) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@527a689307a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: I5dd3b40bb0559e40839e3f9de499fa28bce0872f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824652Reviewed-by:
-
Marc Treib authored
Sync.LocalDataFailedToLoad and Sync.LocalModelOutOfSync aren't needed anymore. Even though they were set up as per-data-type histograms, they were both only recorded for one data type (passwords and bookmarks, respectively). They were also only recorded for the old pre-USS implementation of the data types, which is not used anymore and will be removed soon. Bug: 935926 Change-Id: Ice9778906082acb1cccf46cecc04f2064a7a424e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824883Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#699703}
-
Julie Jeongeun Kim authored
This CL converts ChannelPtr, ChannelRequest, ChannelAssociatedPtr, and ChannelAssociatedRequest to new Mojo types using PendingRemote or Remote, PendingReceiver, Receiver, PendingAssociatedRemote or AssociatedRemote, PendingAssociatedReceiver and AssociatedReceiver. It also updates OnConnection from secure_channel.mojom. Bug: 955171 Change-Id: I6065f8208a2a79316f812e9f48af6b3b88240e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819288Reviewed-by:
-
