GitLab

Review-Url: https://codereview.chromium.org/2535853003
Cr-Commit-Position: refs/heads/master@{#434789}

This will be used by a CL for the "breadcrumbs" project that needs
to convert from a raw-memory pointer used by a class that knows
nothing about persistent memory, back to a reference.

BUG=620813

Review-Url: https://codereview.chromium.org/2534643002
Cr-Commit-Position: refs/heads/master@{#434788}

https://pdfium.googlesource.com/pdfium.git/+log/c92e26defaa6..3c0f366daafe

$ git log c92e26def..3c0f366da --date=short --no-merges --format='%ad %ae %s'
2016-11-28 npm Add some methods in CPDF_ImageRenderer
2016-11-28 npm Fix crash in CFDE_CSSSyntaxParser when parsing empty url
2016-11-28 npm Use unique pointers in CXFA_FMParse

BUG=659509

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2528293003
Cr-Commit-Position: refs/heads/master@{#434787}

BUG=668653
TEST=Manually clicking on the open download folder works,
running the test case from the bug report triggers NOTREACHED.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2535483003
Cr-Commit-Position: refs/heads/master@{#434786}

Refactoring https://crrev.com/2407303005 missed the action dismissing
text handles when exiting action mode. This CL fixes it.

BUG=666860, 668456

Review-Url: https://codereview.chromium.org/2523913004
Cr-Commit-Position: refs/heads/master@{#434785}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces first() with front(). There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2470233009
Cr-Commit-Position: refs/heads/master@{#434784}

This change adds more detailed information to tracing and UMA histograms about
the reason why a MHTML save operation has failed. This will help us understand
why some specific pages consistently fail and better handle these situations.

It introduces a new enum, MhtmlSaveStatus, that lists all tracked causes. Part
of the reasons are tracked by the browser and the others by the render process
but the reporting is centralized in the former. A few tests from
MHTMLGenerationTest were also changed to verify the MHTML failures they test for
are correctly reported.

BUG=645686,655723,655708
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2519273002
Cr-Commit-Position: refs/heads/master@{#434783}

(Harmonizes under-specified behavior with other platforms.)

BUG=410574

Review-Url: https://codereview.chromium.org/2521813002
Cr-Commit-Position: refs/heads/master@{#434782}

This change refactors IndexedDB observations that they are transmitted
through the same DatabaseCallbacks Mojo interface as other out-of-band
database events. This means we can delete a lot of code that existed
specifically to support observers in the Blink public API and remove
the last remaining legacy IPC messages from indexed_db_messages.h.

Note, indexed_db_messages.h remains after this change because removing
it causes a lot of unrelated code churn.

BUG=627484

Review-Url: https://codereview.chromium.org/2511403003
Cr-Commit-Position: refs/heads/master@{#434781}

BUG=667444

Review-Url: https://codereview.chromium.org/2533913003
Cr-Commit-Position: refs/heads/master@{#434780}

This is needed for metrics to know the time between read and deletion.

BUG=651041

Review-Url: https://codereview.chromium.org/2534903003
Cr-Commit-Position: refs/heads/master@{#434779}

BUG=663019
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2513163002
Cr-Commit-Position: refs/heads/master@{#434778}

More than one speech recognition object may exist at the same time,
all sharing a single MockWebSpeechRecognizer underneath when
running layout tests.

Overlapping uses of speech recognizer objects weren't something
the mock object was designed to gracefully handle, hence fuzzer
inputs would leave the mock object in an invalid state and crash,
when they attempted to do so.

Rather than try to ignore and prevent overlapping uses from going
ahed, we extend MockWebSpeechRecognizer with support for handling
them, queueing recognizer context switching tasks that will run
upon completion of the currently ongoing sequence of tasks that
a speech recognizer object expects.

R=
BUG=668019

Review-Url: https://codereview.chromium.org/2525933002
Cr-Commit-Position: refs/heads/master@{#434777}

No real functional change, but instead of lazy-loading AVFoundation, it's
now linked like all the other system frameworks and loaded by the dynamic
linker at program startup.  While unlikely, this might have an effect
on startup time.

BUG=579648
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2529493002
Cr-Commit-Position: refs/heads/master@{#434776}

This should no longer be necessary now that the scrollbar animations are
no longer driven by NSAnimation (https://codereview.chromium.org/529103002/).

BUG=306348,533537
R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2509273005
Cr-Commit-Position: refs/heads/master@{#434775}

BUG=none

Review-Url: https://codereview.chromium.org/2530893003
Cr-Commit-Position: refs/heads/master@{#434774}

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

The request handler for "/slow?" gets added to the server when
AddDefaultHandlers() is called[1], which already happens in
createAndStartServer(), so the additional call here isn't necessary.

[1] https://cs.chromium.org/chromium/src/net/test/embedded_test_server/embedded_test_server.cc?sq=package:chromium&dr=C&rcl=1480321223&l=295

BUG=546060

Review-Url: https://codereview.chromium.org/2524153002
Cr-Commit-Position: refs/heads/master@{#434773}

BUG=668384

Review-Url: https://codereview.chromium.org/2524293002
Cr-Commit-Position: refs/heads/master@{#434772}

There was an edge case here where we might get an arbitrary element as the
document.documentElement. In these cases, the element won't get a LayoutObject
as LayoutView will refuse to attach to it, but when we replace it a layout will
create a non-LayoutBox for it and when RootScroller tries to replace it as the
effective root scroller it needs to do some book keeping using the old root
scroller. It incorrectly assumed it must be a LayoutBox.

This patch now guards against this edge case.

BUG=668553

Review-Url: https://codereview.chromium.org/2531343002
Cr-Commit-Position: refs/heads/master@{#434771}

We have an experiment running that would disable parser-inserted usage
of 'chrome-extension://' URLs unless explicitly whitelisted. This breaks
the print preview page, which relies on the PDF extension URLs inside an
HTML import. So. This patch adds a mechanism for whitelisting that
extension URL for the print preview page.

BUG=667224
R=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2528903002
Cr-Commit-Position: refs/heads/master@{#434770}

 * Path building now can only complete synchronously
 * Access to trust store is done synchronously
 * The network dependencies (AIA fetching) will block the thread

BUG=649017

Review-Url: https://codereview.chromium.org/2453093004
Cr-Commit-Position: refs/heads/master@{#434769}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bced9de7..dade4fe3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2531373003
Cr-Commit-Position: refs/heads/master@{#434768}

BUG=664887

Review-Url: https://codereview.chromium.org/2533923002
Cr-Commit-Position: refs/heads/master@{#434767}

As requested by sgabriel@, this cl reduces the hover "glow" when mousing
over an incognito tab.

R=avi@chromium.org
BUG=632160

Review-Url: https://codereview.chromium.org/2506843002
Cr-Commit-Position: refs/heads/master@{#434766}

FileUtilProxy::DeleteFile() deletes a file on a TaskRunner and then
invokes a callback on the source thread. All call sites provide a null
callback. They might as well just post a base::DeleteFile() task to
the TaskRunner.

This is a prerequisite to stop allowing null callbacks in
base::PostTaskAndReplyWithResult().

BUG=162712

Review-Url: https://codereview.chromium.org/2528193002
Cr-Commit-Position: refs/heads/master@{#434765}

https://codereview.chromium.org/2491613004 failed TimerTest.OneShotTimer_CustomTaskRunner
with the old tests per lacking a TaskRunnerHandle instance. Fixing that
led to a bunch of cleanup. Decoupling from that CL to make it clear that the
new tests pass in the old world and that the new world then passes the tests
without tweaking them.

Mostly moving towards RunLoop/TaskRunners/WaitableEvents to ease a few things.

Also removed incorrect DCHECK in Timer::PostNewScheduledTask() which was tripped
by the new version of TimerTest.OneShotTimer_CustomTaskRunner

BUG=587199, 552633

Review-Url: https://codereview.chromium.org/2514293004
Cr-Commit-Position: refs/heads/master@{#434764}

Rename SyntheticPointer to SyntheticPointerDriver, SyntheticTouchPointer to
SyntheticTouchDriver, and SyntheticMousePointer to SyntheticMouseDriver,
because these classes do not represent the synthetic pointers. They actually create
synthetic pointers for each pointer types and their actions.

BUG=525187

Review-Url: https://codereview.chromium.org/2478423002
Cr-Commit-Position: refs/heads/master@{#434763}

This CL removes xdisplaycheck from xvfb.py.  Previously, we used
xdisplaycheck to block until Xvfb set up a display.  However, there's
a utility called xvfb-run that does this already, and it's included in
the xvfb package.

In future CLs, this will allow us to:
* Remove the /path/to/build_dir argument to xvfb.py since it was only
used determine the xdisplaycheck path.
* Remove xdisplaycheck from the tree

R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2526663002
Cr-Commit-Position: refs/heads/master@{#434762}

After we placed omnibox suggestion list as a child of
CompositorViewHolder, it no longer is able to scroll.

The investigation of this regression gave interesting result: if an
ACTION_MOVE is dispatched to a ListView or a ScrollView and the
ViewGroup intercepts it, the framework will generate an ACTION_CANCEL to
the ViewGroup's children. The behavior, however, will steal this cancel
event and send to the ViewGroup again, causing scroll to fail. Thus we
should specifically not catch ACTION_CANCEL in behavior.

BUG=648136

Review-Url: https://codereview.chromium.org/2526673004
Cr-Commit-Position: refs/heads/master@{#434761}

This patch wraps the process of getting requests in a simple task
in order to ensure that getting requests can be serialized with
other tasks to prevent race conditions.

BUG=651238

Review-Url: https://codereview.chromium.org/2517383008
Cr-Commit-Position: refs/heads/master@{#434760}

The goal is to reduce number of datatype controllers to simplify future
refactoring.

In this chagne:
- Removed UIDataTypeController
- All datatypes are switched to NonUIDataTypeController
- Removed model_safe_group method, in favor of DirectoryDataTypeController field
- Added backend_thread_ so that most of datatypes don't need to override
  PostTaskOnBackendThread

R=maxbogue@chromium.org
BUG=647505

TBR=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2511703004
Cr-Commit-Position: refs/heads/master@{#434759}

BUG=668001

Review-Url: https://codereview.chromium.org/2526713002
Cr-Commit-Position: refs/heads/master@{#434758}

The current module id length check excludes some third party modules
that are not as well behaved as expected. Remove it so we can transfer
profiles containing these modules.

BUG=659903

Review-Url: https://codereview.chromium.org/2532243002
Cr-Commit-Position: refs/heads/master@{#434757}

This function uses GURL::ReplaceComponents which triggers
canonicalization of the new URL. For the normal case where urls do not
have usernames, passwords, or ref parts, we can just return the original
URL.

ReplaceComponents takes around 13% of the time spent in
HttpCache::Transaction::Start with a SimpleCache backend on Linux, but
this method is used in a few different places.

BUG=664174

Review-Url: https://codereview.chromium.org/2498423004
Cr-Commit-Position: refs/heads/master@{#434756}

BUG=669076

Review-Url: https://codereview.chromium.org/2532193002
Cr-Commit-Position: refs/heads/master@{#434755}

Now DesktopEnvironmentOptions are passed to the desktop process in
StartSessionAgent IPC message. This will allow the network process
controll DesktopEnvironment configuration and particularly
DesktopCaptureOptions.

Review-Url: https://codereview.chromium.org/2529533003
Cr-Commit-Position: refs/heads/master@{#434754}

This patch is done on behalf of roisinmcl@chromium.org (original work in
https://codereview.chromium.org/2230053002/).

When a chromedrvier session is created with a flag for W3C compliance,
chromedriver will reference the element with a UUID in place of the
existing ID generation method.

Chromedriver wrapping/unwrapping functions have been changed to match
the new referencing when the W3C flag is true.

BUG=

Review-Url: https://codereview.chromium.org/2295443003
Cr-Commit-Position: refs/heads/master@{#434753}

DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).

Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.

Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.

(Also, rearrange destructor to satisfy the linter.)

BUG=664457

Review-Url: https://codereview.chromium.org/2533753003
Cr-Commit-Position: refs/heads/master@{#434752}

Small bug fix.

BUG=625382, 626752

Review-Url: https://codereview.chromium.org/2483573002
Cr-Commit-Position: refs/heads/master@{#434751}

BUG=542537

Review-Url: https://codereview.chromium.org/2528323002
Cr-Commit-Position: refs/heads/master@{#434750}