- 24 Jul, 2019 40 commits
-
-
Alexander Yashkin authored
Change-Id: Ib777e1293012c37b2622be97aca7a8e61ce66d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715272Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#680428}
-
Eric Roman authored
- Name parameter generator functions *Params() instead of *Callback() - Use test helper methods from test_net_util.h. Change-Id: Ibbfe129110ab45aa1de0a24ab1554a327dad2f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716008 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#680427}
-
Vladislav Kuzkokov authored
Use OS_CHROMEOS instead of CHROMEOS. Bug: none Change-Id: I4935e8577c03804621f21cebab99e2c59f788cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713562Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#680426}
-
Stephane Zermatten authored
Before this change, an element was scrolled into view before it was clicked. On website that use top or bottom bar, this means that the element could be under the bar, so the click would never succeed. This change attempts to increase the probability of an element to be fully uncovered, even if it's inside of a container, by moving it first to the center of the screen just before clicking. scrollIntoViewIfNeeded is still used afterwards, while waiting for the button position to become stable to avoid bad interactions with event listeners. Bug: b/135909926 Change-Id: Idea978b2c3407f41b53fee02feb92c86015122f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708080 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#680425}
-
Edvard Thörnros authored
Change the test to use Testharness.js, the test should still work the same (although I've changed it to make it a bit clearer). This is purely a refactor and code health commit. Bug: 986830 Change-Id: Ic26adf137097893d78c1b579fd26ef1b3b490c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713520 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#680424}
-
Gauthier Ambard authored
The accessibility label was overridden right after it was set. This CL removes the override. Bug: 987234 Change-Id: If30c3b9e2cbaf46b6fb607d69b917e5b8bf60f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715291 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#680423}
-
Brian White authored
Updates the expires_after attribute for 174 histograms that show frequent access in the past 90 days. This is the 10% most frequently used histograms over that time that do not already have a later expiry date. Change-Id: I4897697e7e33db8fca0645bd69a5453c617b3956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715848Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#680422}
-
Eric Stevenson authored
This CL introduces a build step for validating the output produced by R8 and dexsplitter for static library APKs. The class loaders used by static libraries cannot access classes located in the main APK, but R8/dexsplitter may produce dex files that include such illegal references. Also included is a new proguard config that avoids illegal dex references in trichrome_library_apk. Bug: 956839 Change-Id: I550a90af155a2e88444ae734ea31fadd410f8b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702809 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#680421}
-
Felipe Cerqueira authored
Bug: 927957 Change-Id: I87dbdbb240f41bd8e3ba90959db5dd802ee34e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715305 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#680420}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1cd1ed8976c4..f564f1515bde git log 1cd1ed8976c4..f564f1515bde --date=short --no-merges --format='%ad %ae %s' 2019-07-24 brianosman@google.com Move cpu_modules inside skia_enable_tools Created with: gclient setdep -r src/third_party/skia@f564f1515bde The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I2661cca622201146c4029531103756bd9ff36b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716925Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680419}
-
Felipe Cerqueira authored
methodId was not visible inside the anonymous functions. This was making messages arrive with methodId=undefined, which were then rejected by the client. Also fixed a function call that was followed by then(). When calling void functions, this was causing an error and stopping the protocol before sending the confirmation to the client. The actions were still being performed and there were no visible effects, but the client requests were timing out. Bug: 927957 Change-Id: Ie22a16c82ae1776d4529aa10fd3a1db791c1b5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709071 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It is a follow-up CL to https://crrev.com/c/1712560 and renames OAuth2TokenServiceDelegate and FakeOAuth2TokenServiceDelegate to ProfileOAuth2TokenServiceDelegate and FakeProfileOAuth2TokenServiceDelegate. Bug: 967598 Change-Id: Iffc9e674a3830975314f4b03f7e95f1e36e69832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715189Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#680417}
-
Lei Zhang authored
Since size_t variables are never negative, DCHECK_GE(size_t_var, 0U) will always be true. In the case of thread_group_impl.cc, they were suppose to be DCHECK_GT(size_t_var, 0U); Change-Id: I2e5cf4ec9e68b7a422b31062448f4463772ee0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714264 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#680416}
-
Maxim Kolosovskiy authored
TBR=npm@chromium.org,yoavweiss@chromium.org Bug: 987236 Change-Id: I1890d52f825c8a87713f902efb2bd2ba76bea91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715354Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#680415}
-
Monica Basta authored
This CL changes 'chrome://settings/content' page to display 'Cookies and site data' instead of 'Cookies'. It changes as well 'chrome://settings/content/cookies' to have 'Cookies and site data' as a title and 'Clear cookies and site data when you quit Chrome' instead of 'Keep local data only until you quit your browser'. Also, it changes the message displayed if the user is in sync paused state due to his cookie settings set to clear on exit to be 'You clear cookies when you quit Chrome. To keep syncing, change this settings.'. It adds a kill switch to disable showing this message. Bug: 942456 Change-Id: I5eea7680242fd485266bdbdb72e82360cf0ff8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712668 Commit-Queue: Monica Basta <msalama@google.com> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#680414}
-
Balazs Engedy authored
Bug: 975621 Change-Id: Id4431de0fc8400ee2c2e7a6350631deede2dc332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714592 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Bug: 987170 Change-Id: I9b4ecb4b55d312766b6a8c895026229a0e43caae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713634 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Harald Alvestrand authored
This has been announced as "will be removed in M70" for many versions. This CL actually removes them. Usage is negligible. Bug: 854385 Change-Id: I6af1279978de669e433fa5eb6e0b62dfd348b8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713539Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#680411}
-
Anders Hartvoll Ruud authored
Bug: 987224 Change-Id: I1b6420aa9f277ebf8d62845bb5838e57bdc8610d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715813 Auto-Submit: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e53b8284..3439373f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6542fd224845a9e08896d39b25a4593ddbe70eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715891Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680409}
-
Mike Reed authored
Bug: skia:4783 Change-Id: I26fc71792ed5fcb53253bda56f265dbf713b6d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713304Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#680408}
-
Michael Lippautz authored
Avoid including thread-termination GCs in performance profiles as their shutdown on benchmarks is not always deterministic across different versions. Bug: 948807 Change-Id: I45a8883b15bd5a1abbeb1f5db732249d0cba533b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715191 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#680407}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ad42169cb4d..1b42ca287673 Created with: gclient setdep -r src-internal@1b42ca287673 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: I0255b1794ed7a2e7e2adc97b3db0b9ead8b4c331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680406}
-
Mirko Bonadei authored
This is needed after [1]. [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1706506 Bug: 976348 Change-Id: I62ff634cf34a8358a28d9085c3b6adc7f48e3599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715290 Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#680405}
-
Vasilii Sukhanov authored
Also the CL lands the feature in the password manager. Bug: 986298 Change-Id: I8b7e38d5ec177edd9565d6207644edad99c34677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713192 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#680404}
-
Jun Cai authored
This CL adds site setting preference test for Bluetooth scanning on Android. Bug: 960962 Change-Id: I61d3b02e1de93df60fb5d03900e6f39d1087320c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709331Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#680403}
-
Balazs Engedy authored
The following histograms already proved useful for diagnostic purposes a number of times when the server-side backend experienced strange QPS patterns, so we want to keep them: PasswordManager.AffiliationFetcher.FetchResult PasswordManager.AffiliationFetcher.FetchErrorCode PasswordManager.AffiliationFetcher.FetchHttpResponseCode PasswordManager.AffiliationBackend.FirstFetchDelay PasswordManager.AffiliationBackend.SubsequentFetchDelay PasswordManager.AffiliationBackend.FetchSize On the other hand, mark PasswordManager.AffiliationDummyData.* histograms as obsolete: these are no longer recorded since 2015. Bug: 975244, 975213 Change-Id: I96fcde3b573827511b1ffc9ff11582b469042d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713530 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Nico Weber authored
Found by: git grep -l 'buildflag_header.gni' '*.gn' | xargs grep -L 'buildflag_header(' Bug: none Change-Id: I581f28f0d817547fb269dbf1486b9385a2800b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714945 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#680401}
-
Tim van der Lippe authored
This allows OWNERS of blink_devtools to differentiate e-mails sent for blink_devtools from the other devtools watchlist. Also update the blink_devtools definition to not include third_party/WebKit, as that folder has now been removed. Change-Id: I97a9bcecac53d0439d95d1493cc95bb396642693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715067 Auto-Submit: Tim van der Lippe <tvanderlippe@google.com> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
David Jean authored
There's no easy or solid way to detect iPad Pro (especially in simulator) so I just dynamically DISABLE the test is the code fails to undock and split. Bug: 987204 Change-Id: Id65881af22cb05af9c5787fd99cb3b40a11065d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715270Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit e557c49c. Reason for revert: I suspect this CL causes the following test failures: external/wpt/xhr/idlharness.any.html external/wpt/storage/idlharness.https.any.html external/wpt/background-fetch/idlharness.https.any.serviceworker.html The first failed build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/938 Original change's description: > Add datachannel.maxPacketLifeTime > > Delete nonstandard attribute maxRetransmitTime, and make both > maxPacketLifeTime and maxRetransmits nullable. > (Usage of both attributes has been measured to be negligible.) > > Bug: 696681 > Change-Id: If37e38114d4718b868413ea8ced9527c88510c15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710557 > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Florent Castelli <orphis@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Reviewed-by: Steve Anton <steveanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679965} TBR=hta@chromium.org,foolip@chromium.org,orphis@chromium.org,steveanton@chromium.org Change-Id: If70558e9730cd910f28baed15eef44ebd40f5ee7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 696681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715689Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8521257c. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6a6b173b "Add type option to showToast helper" a148378d "KV Storage: rename storage export to default" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib15629b2ac404f89e2851fe31891f6cc3c196d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716367Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680397}
-
Vincent Boisselle authored
Summary of changes: * Sync now handles all the logic of retrieving demographics, which includes deciding when and when not to provide demographics. * Added computation of the user age using the now time. * Added a check to not report demographics when user is not old enough. * Added age fuzzing. * Added more unittests for SyncPrefs::GetUserDemographics(). * Added demographic checks to make sure that provided demographics have low entropy to protect privacy. * Added more explanations about privacy protection. Bug: 983303 Change-Id: I4ef12059b0ad71a6dc656de0d59e8e9369ba6111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707109 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#680396}
-
Corentin Wallez authored
This flag controls the inclusion of Dawn and the availability of WebGPU which we want to keep limited to Canary for now. TBR=kbr@chromium.org BUG=chromium:985142 Change-Id: I979ae6c24087d4037d57ce95ea33f119c604e91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715271Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#680395}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fd3e53d52cec..a3928b19e384 git log fd3e53d52cec..a3928b19e384 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 primiano@google.com Merge "Fix android-on-mac build" Created with: gclient setdep -r src/third_party/perfetto@a3928b19e384 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I9aa64a8aefebb6b4de6ca4f7b503ba5f33fa7322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715336Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OAuth2AccessTokenManagerTest to test OAuth2AccessTokenManager. It has a basic test for OAuth2AccessTokenManager to test StartRequest. It's similar to ProfileOAuth2TokenService except refresh token. It doesn't check refresh token because it assumes it has already a valid refresh token. On follow-up CLs, tests will be rearranged between ProfileOAuth2TokenService and OAuth2AccessTokenManager. Bug: 967598 Change-Id: I10dfda0b3922bdcf6ac9e7abf7297f6e5de5bfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712945 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
Rayan Kanso authored
This reverts commit 885aa020. Reason for revert: Builders are failing again Bug: 987226 Original change's description: > Reland "ProGuard: Move -checkdiscard for Log.* into @RemovableInRelease annotation" > > Was reverted in: 54f75614. > > Reason for reland: Includes fix for downstream targets. > > Change-Id: I2a5f77cdbd40934ae206dd91b2e12e7b5e6553e1 > Bug: 986693, 986693 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715004 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680307} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I210a6fde9d3a37b8e2ea0f7766a127fd95e8616c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715492Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#680392}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ae30cc2e6e0..1cd1ed8976c4 git log 3ae30cc2e6e0..1cd1ed8976c4 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 robertphillips@google.com Stop using GrBackendSurface's pixel config Created with: gclient setdep -r src/third_party/skia@1cd1ed8976c4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I3b020acbbaaa8ac276a1d5a8d645cc49ef53a57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715338Reviewed-by:
-
Anders Hartvoll Ruud authored
When creating a CSSVariableReferenceValue with a reference to a variable which actually exists, we crash because CSSVariableReferenceValue objects created through Typed OM don't have a CSSParserContext. This was missed by our existing test suite, because we only covered a similar case where the referenced variable *didn't* exist, avoiding the broken code path. For now, fixed by using StrictCSSParserContext. Bug: 986710, 985028 Change-Id: If51e34a77e5433849e0602f297909027fc743798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713627 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/93c16af35dfb..0ad42169cb4d Created with: gclient setdep -r src-internal@0ad42169cb4d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: I16bf35453580949f2a8182830a9f5143b4db379e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715337Reviewed-by:
-
