GitLab

These were being flagged by gcc-4.6.0 using the Wmaybe-uninitialized warning.

BUG=none
TEST=trybot


Review URL: http://codereview.chromium.org/9309008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124619 0039d316-1c4b-4281-b951-d872f2087c98

https://bugs.webkit.org/show_bug.cgi?id=79954 is the webkit side.

BUG=116344
TEST=


Review URL: http://codereview.chromium.org/9557009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124618 0039d316-1c4b-4281-b951-d872f2087c98

Replace make function back now that not using goma (removed in http://chromiumcodereview.appspot.com/9570042)

TBR=maruel@chromium.org

BUG=None
TEST=

Review URL: https://chromiumcodereview.appspot.com/9585002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=

Review URL: https://chromiumcodereview.appspot.com/9584001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124612 0039d316-1c4b-4281-b951-d872f2087c98

displayed as '*', was implemented in NativeTextfieldViews
via TextfieldViewsModel::GetVisibleText() (issue 5857002),
but the refactoring into RenderText (issue 7265011) removed
all calls of that method.

I moved the password handling code into RenderText because I
think it's logically a visual style (although RenderText
also contains a lot of model-related stuff right now).
RenderText now has a password property (in earlier patchsets
it was an attribute in StyleRange).

BUG=105054
TEST=unit tests and manual testing of the wifi login dialog

Review URL: https://chromiumcodereview.appspot.com/8747001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124611 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124610 0039d316-1c4b-4281-b951-d872f2087c98

Only change in hunspell roll: https://chromiumcodereview.appspot.com/9568018

BUG=none
TEST=none
TBR=hans

Review URL: https://chromiumcodereview.appspot.com/9570054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124609 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124607 0039d316-1c4b-4281-b951-d872f2087c98

- Added new ErrorCode enum to pass error codes everywhere except between 
  the webapp and the plugin.
- Signaling timeout when connection now is interpreted as disconnect instead of
  error condition (see bug 112739).
- Fixed webapp to properly handle unknown error codes.

BUG=112739


Review URL: http://codereview.chromium.org/9567033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124606 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
TBR=dcheng
Review URL: https://chromiumcodereview.appspot.com/9581001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124605 0039d316-1c4b-4281-b951-d872f2087c98

The duplicate flush after the swapbuffers makes handling commands from other stubs difficult, so get rid of it.

BUG=112349
TEST=


Review URL: http://codereview.chromium.org/9567026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124604 0039d316-1c4b-4281-b951-d872f2087c98

Move the core drag&drop code for Windows to content\browser to match Mac/GTK. I've had to add temporary exceptions to DEPS which I'll remove in followup changes.

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9562049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113075
TEST=none, just committing so I can send tryjobs for the next patch
TBR=davemoore@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9569054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124602 0039d316-1c4b-4281-b951-d872f2087c98

This change removes executable flags from the files added by r124588 <http://crrev.com/124588>.

TBR=michaelbai
BUG=none
TEST=check_persm
Review URL: https://chromiumcodereview.appspot.com/9566049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116216
TEST=manually checked the three buttons

Review URL: https://chromiumcodereview.appspot.com/9536007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124598 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/116073
TEST=see unit tests

Review URL: http://codereview.chromium.org/9570037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124597 0039d316-1c4b-4281-b951-d872f2087c98

R=aa@chromium.org
BUG=109425
TEST=*Extension*


Review URL: http://codereview.chromium.org/9316102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116475
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9569053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124595 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for using compositor filters in Aura such as glass blur.

BUG=99528
TEST=


Review URL: http://codereview.chromium.org/9568042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114101
TEST=none


Review URL: http://codereview.chromium.org/9565025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124590 0039d316-1c4b-4281-b951-d872f2087c98

Some strings currently have a specific version for Android, but the
description attribute does not mention this.

This prefixes "Mobile: " for all Android strings where the same message
name is already in use, and Android just has a specific version of a
string for mobile.

BUG=114046
TEST=Verify that strings show up correctly in Android build.


Review URL: http://codereview.chromium.org/9567017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124589 0039d316-1c4b-4281-b951-d872f2087c98

Just like the history_types, this is Android corresponding one.

BUG=
TEST=


Review URL: http://codereview.chromium.org/9558015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124588 0039d316-1c4b-4281-b951-d872f2087c98

We want to count the number of searches from various access points in Chrome. To do this, we've added a new UMA enumerated histogram to track these values (GoogleSearch.AccessPoint). These are the necessary declarations for various search access points that will be added shortly.

We've also added a IsGoogleSearchUrl helper to google_util to identify search URLs.

BUG=
TEST=Ensure that unit tests GoogleUtilTest all succeed.


Review URL: http://codereview.chromium.org/9452039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111139
TEST=SessionStartupPrefTest.HomePageMigration
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9559002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124583 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116441
TEST=dialog doesn't resize itself

Review URL: https://chromiumcodereview.appspot.com/9566039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115603
Review URL: https://chromiumcodereview.appspot.com/9569035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124581 0039d316-1c4b-4281-b951-d872f2087c98

Removed calls to Entry.file() to read file sizes. We get this information from Entry.getMetadata() now.

BUG=chromium-os:27197
TEST=make sure that files and their correct sizes / dates show up for all data sources 
Review URL: https://chromiumcodereview.appspot.com/9562053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115501
TBR=yzshen@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9562051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124577 0039d316-1c4b-4281-b951-d872f2087c98

The problem was that in some case the client would destroy the channel before
it sends auth byte to the host, and the host would still try to connect the
channel indefinetly.

BUG=116431

Review URL: https://chromiumcodereview.appspot.com/9568041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124574 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110844

Review URL: https://chromiumcodereview.appspot.com/9564025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124573 0039d316-1c4b-4281-b951-d872f2087c98

This is a copy of the views CL that sets the initial and minimum window size of shell windows.

BUG=112651
TEST=


Review URL: http://codereview.chromium.org/9453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124572 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ygorshenin

BUG=116480
TEST=None

Review URL: https://chromiumcodereview.appspot.com/9565044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124571 0039d316-1c4b-4281-b951-d872f2087c98

This broke ComponentLoaderTest on chromeos.

TBR=antrim@chromium.org
BUG=116478
TEST=unit_test on trybot passes

Review URL: https://chromiumcodereview.appspot.com/9564046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115501
TBR=ronghuawu@chromium.org
TEST=Remoting host should work

Review URL: https://chromiumcodereview.appspot.com/9564045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124569 0039d316-1c4b-4281-b951-d872f2087c98

The power manager client receives signals from the session manager, 
which uses a different path for those signals. Create a proxy for
that object as well so we receive them, they were only receiving
them before because of a bug where the first object proxy would
get all signal messages.

BUG=chromium-os:27146
TEST=desktopui_ScreenLocker failed before, passes now

Change-Id: I4a8193d94e9a114d32aac79577b35a69043cbcf0


Review URL: http://codereview.chromium.org/9566018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124568 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124567 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r7867: (sehr) SelLdrLauncher refactoring.
r7868: (bradchen) Remove redundant defn and use of asm_HasCPUID().
r7869: (mcgrathr) Add test case for sleep function
r7870: (pdox) Move the sandboxed translator build to its own archive.
r7871: (pdox) Roll PNaCl toolchain DEPS to 7870, and commit second part of CL:
r7873: (pdox) Whitespace change to trigger rebuild
r7874: (pdox) Re-enable browser tests on the PNaCl Windows toolchain bots.
r7875: (jvoung) Halt pnacl test example animations when loaded
r7876: (dschuff) For sandboxed translation, use LLC-returned DT_NEEDED values instead of using
r7877: (thakis) Use whitespace instead of ',' to separate declaration modifiers.
r7878: (mcgrathr) Update glibc revision to 32d9fc1
r7879: (mseaborn) Exception handling: Add test for crashes inside trusted code
r7880: (mseaborn) Exception handling: Ensure exception_stack and exception_flag are uint32_t
r7881: (jvoung) Set 'chromium_code' to true in gyp files to get more compiler warnings (when building the nacl plugin in chrome).
r7882: (pasko) validator_ragel: cleanup: Move *.C -> *.cc
r7883: (pasko) validator_ragel: Fix easiest presubmit warnings in gen-decoder
r7884: (dschuff) Fix handle count assertion in NaClMainForChromium
r7885: (dschuff) Remove addition of unused IMC handles
r7886: (mcgrathr) Update gcc revision to c69a5b7
r7887: (mseaborn) Exception handling: Reorganise Windows implementation
r7888: (pdox) PNaCl: Remove library sym-links from the translator directories.
r7889: (jvoung) Bump pnacl binutils rev for tiny commandline change.
r7890: (pasko) validator_ragel: reporting x86-32 error offsets as in x86-64
r7891: (jvoung) Revert "Set 'chromium_code' to true in gyp files to get more compiler warnings
r7892: (kschimpf) Change NCPrintInst to NCPrintInstWithHex to conform with function
r7893: (mcgrathr) Update toolchains
r7895: (sehr) Correct the socket number that the startup information is transmitted on.
r7896: (bradchen) Revert r7893, which breaks appears to break SPEC perlbmk.
r7898: (bradchen) Fix 7896 to properly revert 7893
r7900: (pdox) Roll toolchain DEPS to 7898, and patch perlbmk run scripts to provide a symlink to the "lenums" datafile.
r7902: (bradchen) Re-enable sleep test.
r7903: (kschimpf) Move private test enuminsts into native client.
r7904: (mseaborn) Exception handling: Add support for x86-64 Windows
r7906: (mseaborn) Exception handling: Rename "debug_exception_handler_32.c" to remove "_32" suffix
r7907: (mseaborn) ARM: Remove mallopt() hack now that the bottom 1GB is reserved properly
r7908: (mseaborn) Exception handling: Remove code that exposes &nacl_user and &nap->exception_handler
r7909: (mseaborn) Exception handling: Move exception_stack/exception_flag to NaClAppThread
r7910: (pasko) validator_ragel: 32bit tests borrowed from the old validator
r7911: (jvoung) Bump chrome deps and change scons to use "pnacl-translate" for pnacl bitcode to match. Also use the pnacl-nmf generator by default to get hashes.
r7913: (mcgrathr) Build as PIE in Gyp build.
r7914: (mseaborn) Revert SelLdrLauncher refactoring: r7867, r7884, r7885, r7895
r7915: (mseaborn) Cleanup: Add a header for sel_main_chrome.c
r7916: (kschimpf) Don't report pre/post conditions if instruction wouldn't be valid anyway.
r7917: (kschimpf) Fix API calls to NaClGetExpKidIndex and NaClGetExpParentIndex to properly
r7918: (pdox) PNaCl Driver: Disable logging and multi-threaded I/O by default.
r7919: (mseaborn) Revert r7913: "Build as PIE in Gyp build."

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/9564018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=

Review URL: https://chromiumcodereview.appspot.com/9570042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113159,116438


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124346

Review URL: http://codereview.chromium.org/9509001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124562 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124561 0039d316-1c4b-4281-b951-d872f2087c98