GitLab

network::WebSocket should return immediately if the return value of
net::WebSocket::SendFrame is CHANNEL_DELETED. It was not doing so. Add
the necessary return statements.

Also add WARN_UNUSED_RESULT to SendFrame() to make sure it is checked in
future.

Tested manually. No unit tests for this change because
network::WebSocket has no unit tests.

BUG=1065704

Change-Id: I0c7e0cf57f3a98fc80461ec50df59513146eff89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123961Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754997}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/aface10e934e..1db568ebb1f0

git log aface10e934e..1db568ebb1f0 --date=short --first-parent --format='%ad %ae %s'
2020-03-31 dgkoch@users.noreply.github.com update glslang to SDK-Candidate-2 tag (#1027)

Created with:
  gclient setdep -r src/third_party/shaderc/src@1db568ebb1f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I05ccc4cf0325e5733febc00ad3a46d47143d79f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129856Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754996}

This is a mechanical change that only renames a method in the
MultiStorePasswordSaveManager for clarity.

Bug: 1012203
Change-Id: Ic46aa9ad60b753385f23769f26f2d589135fc762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129539
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754995}

Bug: 1066521
Change-Id: Ib591b5ee471f4bc55a8fbbec2a1cd0b4762e1b60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129990Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754994}

When an Assistant query has been submitted, you should not be able to
interact with the suggestion chips anymore.
Mouse clicks had always been disabled, but a bug still allowed the
user to submit queries using |TAB| and |ENTER|.

This CL also introduces some extra unittests that were missing.

Bug: b/151800188
Change-Id: Iaa132b836716c119656d39243895571af760f291
Tests: new ash_unittests with filter "AssistantPageViewTest.*"
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129047Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#754993}

Chrome OS notification was previously displaying the in progress UX for
downloads that were in the middle of scanning. This could be confusing
given that we may remain in this state for several minutes. Instead, we
should indicate to the user that the file is being scanned.
It also includes support for additional scan result states - safe,
warning and block.

Screenshots: https://docs.google.com/presentation/d/1V6etHX1rp3W5uiqR7WS8fdTGjPa_KeMSf5ZPtZp8tVU/edit#slide=id.p

Bug: 1062788
Change-Id: I1957b422bac2d56ed9ce86454c4884d7ebe0a799
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127707Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754992}

The force flag was used to ignore the gpu process capabilities and use
gpu raster anyways. The --enable-gpu-rasterization flag makes the gpu
process always report that it can use gpu rasterization, so this has
the same effect (outside of tests that were setting force only).

R=kylechar@chromium.org

Bug: 866140
Change-Id: I06d86ff8d74f0ecbbb59555e570822921196b765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127523
Commit-Queue: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754991}

SigninViewController is owned by a Browser object. The clients often
access it via `browser->signin_view_controller()`. However, all
SigninViewController methods also accept Browser* parameter that must
point to the same browser that owns this SigninViewController.

Browser and SigninViewController have 1:1 relationship, so it sounds
logical for SigninViewController to hold a pointer to Browser.

Adding a Browser* field to SigninViewController brings the following
- Eliminates risk of passing an incorrect Browser* to
  SigninViewController method.
- Reduces number of parameters in all SigninViewController methods.

benefits: 
Change-Id: Icda291a5a9baf9e6ea06c9afdc2eb6051f5434f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127030Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754990}

Deflake the use of onHidden in PaintPreviewTabService by treating the
WebContents as being in capture mode. This prevents the renderer from
going away until after the capture is completed.

Follow up work may be required to ensure the TabImpl#hide hiding the
WebContents prior to calling the observers doesn't cause rare races.
I've run 40 times locally without issue, but it could be an issue.

Bug: 1061190
Change-Id: I51b84e66b0b9e02d137f3780824c337c6384d642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118392Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754989}

The ready promise depends on the pending state, which in turn can be
impacted by a pending style change. Checking the pending state prior
to checking the ready promise fixes the problem.

The affected test still produces an unhandled rejection error presumably
due to missing the step of marking the promise as handled when resetting
pending promises.

Bug: 1064640
Change-Id: I25191dd26206368e497638ce9f73984b2e61cad4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118183
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754988}

The functionality is already implemented and even tested :-)
This CL is only add a comment to make the design decision more explicit!


Bug: 1012203
Change-Id: Ib62c51ab924e3172deffde7b8bc036f2ee824c48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127106
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754987}

Bug: 1066286
Change-Id: I5b747457251cd3dbef3ced3a3868ef8acbe316bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128767Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754986}

This change uses the native_theme_base controls properties to set
correct dark mode styling for progress bar controls.

Bug: 929098
Change-Id: I14afd7414cffba818b24a8e42d46f7d4a677a09c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126472Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#754985}

Remove adjusted_timeout from the renderer - browser pipe and use the
raw timeout on android instead, adjusting it on java. Add unit tests for
the adjustment.

This aligns the android and browser implementation and cleans up
leftover implementation from crrev.com/c/2084725

Fixed: 976428
Change-Id: I974dc8ec8852ba2216a3cb615c53b25c802f7b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128529
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754984}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0bc6f033ff5..ba238d8eed6d


Created with:
  gclient setdep -r src-internal@ba238d8eed6d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ie132c0baa1dea6d25f800fd3ab3354a5c3c5f042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129854Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754983}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a8735962f3e..3459bf5bf9c9

git log 9a8735962f3e..3459bf5bf9c9 --date=short --first-parent --format='%ad %ae %s'
2020-03-31 vapier@chromium.org remote_access: finish RunCommand->run rename
2020-03-31 chrome-bot@chromium.org Update config settings by config-updater.
2020-03-31 linxinan@chromium.org api: compile latest api for test_platform
2020-03-31 cjmcdonald@chromium.org pytest: Run in parallel by default
2020-03-31 cjmcdonald@chromium.org service/test: Use pytest wrapper instead of system pytest
2020-03-31 cjmcdonald@chromium.org toolchain_util_unittest: Use AbstractGSContextTest class
2020-03-31 oka@google.com fix file path for Tast secret variables
2020-03-30 vapier@chromium.org commandline: rename --log_format to --log-format
2020-03-30 chrome-bot@chromium.org Update config settings by config-updater.
2020-03-30 chrome-bot@chromium.org Update config settings by config-updater.
2020-03-30 cjmcdonald@chromium.org Add virtualenv_wrapper target for running pytest
2020-03-30 cjmcdonald@chromium.org Remove broken mock assertions
2020-03-30 cjmcdonald@chromium.org mock: Backport 'assert_called' and 'assert_not_called'
2020-03-30 cjmcdonald@chromium.org mock: Backport 'assert_called_once' to vendored copy
2020-03-30 mmortensen@google.com Refactor to use service/artifacts for BuildAutotestTarballsForHWTest.

Created with:
  gclient setdep -r src/third_party/chromite@3459bf5bf9c9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I14620a1d5db29210c0f98f21d830333b49e5f103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129852Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754982}

With Xcode 11.4, the arm64e slice of XCTRunner is removed from the
binary when creating the XCUITest runner application. Not doing it
may prevents running the application on a device, so replicate this.

Bug: none
Change-Id: I25925ac7ed20150bb2ef4cffa01e64f8ad9d4e1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127111
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754981}

. Add a 'NeedsBeginFrames' async-event to show the duration of a
  client's request for begin-frames.
. Add a flow-event for 'did not produce' frames.
. Add a trace-event for when a client is throttled (and include
  the reason for throttling).

BUG=none

Change-Id: I65e601b54a683bef54142b98f6faf037cc22308e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125618
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754980}

microseconds - kMicrosecondsPerMillisecond could cause an overflow if
microseconds is too small (close to INT64_MIN)

Bug: 1065504
Change-Id: I827dc3479eabbf1be5fdf964dbcb34bc48d7f401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129788Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Qijiang Fan <fqj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754979}

Minor fix to ensure that we don't log error messages when client adds
a video-only stream on an HTML tag.

Bug: 1017219
Change-Id: Id388e1ef67c5a71272557ccd62cb24a0d19cac1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128113Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754978}

Update compile_webkit_mac_minibrowser target to build release build.
WebKit folks recommended fuzzing release build to avoid hitting
assertions, which mostly indicate minor problems, which are not high
priority to fix.

Bug: 1064181
Change-Id: Ifdb22e20dc67b353b9ec237d63a40347dd7d7ecb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129086Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754977}

Refactor the current frame sink id hit test API and
reuse it to scroller target finding to be used in
compositor.
This will be used in the scroll targeting in
scroll unification project in the follow up CLs.
For more information look at:
https://docs.google.com/document/d/1smLAXs-DSLLmkEt4FIPP7PVglJXOcwRc7A5G0SEwxaY/edit#heading=h.hykhktoizkjj

Bug: 1047179
Change-Id: Ie7001e5342a99eff85dc078c65a958a4c65f1120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070383Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754976}

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/2123249

- Added LoadStreamFromStoreTask to read model data from the store.
- Update LoadStoreTask to try loading from the store first, via the new task.
- Save operations executed to persistent storage.

My primary goal when making this change was to save operations to persistent
storage as they are executed. Pulling this thread led to several changes.

We were saving a bit too much data in the single 'stream_data' record, which
meant we would have to re-serialize the whole model to save a single piece of
information. I went ahead and split 'stream structures' out into another record.
All stream structures for the stream now need to be read in at load time,
and they need to be sequenced appropriately.

In making that change, I wanted to verify we could actually load the data
back in. So I implemented loading a stream from storage as well.

Bug: 1044139
Tbr: iwells@chromium.org
Change-Id: Icf01f301488bc977f6f4ee2bf0f1c3332037176b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129775Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754975}

This change:
1) Introduces a new class, views::NamedWidgetShownWaiter, which wraps
   the common pattern of waiting for a widget of a specific name to be
   shown;
2) Moves AnyWidgetObserver::Passkey to its own top-level class,
   AnyWidgetPasskey, so that NamedWidgetShownWaiter can take an
   instance as well;
3) Adds tests for NamedWidgetShownWaiter;
4) Removes a bespoke RunLoop wait in ExtensionsMenuViewBrowserTest,
   replacing it with NamedWidgetShownWaiter.

Bug: None
Change-Id: I730ffc740649fcee8de077fbe78aa3d6fe0f9024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122474
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754974}

Also OobeSpokenFeedbackTest

TBR=aleventhal@chromium.org

Bug: 987587
Change-Id: Ib66052b1c52351edb6ba304cc1c6a1b82c8d9245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129707
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754973}

This CL updates proto received by dmserver for Web App kiosk, adding
title and icon_url. We are not using icon_url to fetch the actual icon,
but we will save it to fetch the icon in the future.


Bug: 1066496,b/150248201
Change-Id: I9bf45d936543c43c8cc93f56eea8801cf6eafaae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127826
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754972}

With this CL we are properly dialing the XPC connection and sending messages.
This also fixes the issues with the StateChangeCallback being sent over XPC.

Bug: 1055876
Change-Id: I81077476e49be486620ae4e2eb8cba022c3ae4de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124933
Commit-Queue: Mila Green <milagreen@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754971}

No behavior change is expected, this CL only goal is to have one .gni
file in absl in order to maintain it more easily.

Bug: None
Change-Id: I2694a1689755395a855cca94c49152477e5017f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128077Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754970}

This patch is analogous to the WebKit patch for a common issue:

https://trac.webkit.org/changeset/254800/webkit

When sanitizing the clipboard markup in a dummy document, we disable
scripting, and parse <noscript> in the script-disabled mode. Then we
parse the sanitized markup in script-enabled mode when inserting it into
the real document. This allows an XSS attack.

This patch introduces a new flag to page settings that allows it to
parse with the scripting flag enabled, while still disabling script
execution. It also renames the |HTMLParserOptions::script_enabled| flag
to |scripting_flag| to improve clarity and match the term in the HTML
spec (https://html.spec.whatwg.org/#scripting-flag).

Bug: 1065761
Change-Id: Ia4bd67a991b354eebd2cbfef6d3291230ddc1f6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128839Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754969}

This fix normalizes the current situation where we have these files:

  wpt/css/css-flexbox/flexbox-overflow-auto-001.html
  wpt/css/css-flexbox/flexbox-overflow-auto-002.html
  wpt/css/css-flexbox/overflow-auto-001.html
  wpt/css/css-flexbox/overflow-auto-002.html
  wpt/css/css-flexbox/overflow-auto-003.html
  wpt/css/css-flexbox/overflow-auto-004.html

...into a more consistent file naming scheme for this type of tests:

  wpt/css/css-flexbox/overflow-auto-001.html
  wpt/css/css-flexbox/overflow-auto-002.html
  wpt/css/css-flexbox/overflow-auto-003.html
  wpt/css/css-flexbox/overflow-auto-004.html
  wpt/css/css-flexbox/overflow-auto-005.html
  wpt/css/css-flexbox/overflow-auto-006.html

Bug: 1063749
Change-Id: I5d73bb4d54ee536a8a1894428cb557ea1be95f3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129531
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754968}

'assert_throws' has been deprecated in WPT, replaced by JS
and DOM-specific variants. http/tests/mojo should use the
JS variant, but that requires mojo.test.InputError to be a
real Error subclass.

Bug: 1051932
Change-Id: Icdc16cc69a856f3cfb65c0e6686f91d5bcf0eae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125949Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754967}

As well as the associated entries in XTB files.

Change-Id: I0ef1e01db82ed873557c67ca1908e8efcc04e5e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839633
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754966}

Change-Id: I1faa3b68726e1798c08d2d29b2fb8a2c81e23d06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128469Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754965}

Adjusting Managed Guest Session (MGS) permission warning flags according
to consensus between commercial and privacy teams.

Due to privacy concerns, removing whitelisting for permissions that
provide direct access to user data. Further, to reduce scope, removing
unnecessarry whitelisting for permissions of the following categories:
* private/internal
* lacking public documentation
* non-stable channel or otherwise experimental or deprecated
* inapplicable to MGS, e.g. kiosk-specific permissions

Bug: 1015378
Change-Id: Id677c8639d94cc1b6478d5bf9b469648d202ce04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124266
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754964}

https://chromium.googlesource.com/angle/angle.git/+log/9120bcae6c53..dbb23ec3589f

git log 9120bcae6c53..dbb23ec3589f --date=short --first-parent --format='%ad %ae %s'
2020-03-31 ancheng.qiao@arm.com Vulkan: Remove swiftshader mipmap3d test skip

Created with:
  gclient setdep -r src/third_party/angle@dbb23ec3589f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I47ca81d948f5ee957ed5cf99267f864ed2553053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129781Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754963}

This patch adds a flag to the ToolbarManager to check whether the
scrim was actually shown since the timing of the show request can
vary.

Bug: 1065480
Change-Id: I254d1425c58bfe05ae97a609097a2e75b6908933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129847Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754962}

This CL gets some simple fixes out of the while, found while prototyping
support for multiple input files.

Bug: 900259, 1040645
Change-Id: Ifc7ba4395108b356d754e13d468af7e6ca8f4cdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129785
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754961}

This CL disables image lazy loading for images in frames in which
scripting is disabled. The HTML Standard mandates that image lazy
loading be disabled in these cases, as a privacy-protection measure.
See [1].

[1]: https://html.spec.whatwg.org/multipage/images.html#will-lazy-load-image-steps

R=kinuko@chromium.org, sclittle@chromium.org

Bug: 1005881
Change-Id: Ib675b46ee1d9bb10119172893547cb80b0308ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127415
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754960}

Moves all logging into the user sign-in workflow and improves existing
tests for add account.

Bug: 971989
Change-Id: Id6804607c81eed23ade30863d9741f4302341052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116177
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754959}

https://android.googlesource.com/platform/external/perfetto.git/+log/bc44331c334d..937cfa8b7e10

git log bc44331c334d..937cfa8b7e10 --date=short --first-parent --format='%ad %ae %s'
2020-03-31 fmayer@google.com Merge "Check for build type, not debuggable, for extra guardrails test."
2020-03-31 treehugger-gerrit@google.com Merge "tp: fix import of systrace files with trailing newlines"

Created with:
  gclient setdep -r src/third_party/perfetto@937cfa8b7e10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I3af340fdc2985df0e545d359149117de2c2d19ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129849Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754958}