- 08 Jul, 2014 40 commits
-
-
reveman@chromium.org authored
This adds a soft memory limit to the discardable memory manager. Only allocations that haven't been used in specific amount of time are affected by this limit. This allows a client to use a much higher hard limit so temporary spikes in required usage can be handled efficiently without causing an increase in usage while idle. A "reduce memory usage" function is added to the discardable memory interface to allow the client to effectively trigger purging of memory that is affected by the soft limit when system reaches what would be considered an idle state. BUG=383361,372158 TEST=base_unittests --gtest_filter=DiscardableMemoryManagerTest.ReduceMemoryUsage Review URL: https://codereview.chromium.org/336273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281795 0039d316-1c4b-4281-b951-d872f2087c98
-
jbudorick@chromium.org authored
BUG=267773 Review URL: https://codereview.chromium.org/371813005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281794 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=389747 Review URL: https://codereview.chromium.org/361833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281793 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
Hah... cc_messages*.cc was more than just the unittest file, I forgot the perftest. R=piman@chromium.org Review URL: https://codereview.chromium.org/372803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281792 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=359420 Review URL: https://codereview.chromium.org/365463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281791 0039d316-1c4b-4281-b951-d872f2087c98
-
jww@chromium.org authored
Fixed a typo and added a clarification about the correct way to add an onclick handler to a button from a content script. R=kalman@chromium.org Review URL: https://codereview.chromium.org/376713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281790 0039d316-1c4b-4281-b951-d872f2087c98
-
stepco@chromium.org authored
BUG=388465 Review URL: https://codereview.chromium.org/355203007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281789 0039d316-1c4b-4281-b951-d872f2087c98
-
jbedley@chromium.org authored
Currently, the Tile class has one is_occluded bool. Give Tile two occluded bools, one for each tree, so that the same tile can have different occlusion on each tree. This patch is an alternative to https://codereview.chromium.org/343463004/ which also tracks occlusion per tree, but stores occlusion info on TilePriority rather than Tile. BUG=178971 Review URL: https://codereview.chromium.org/374653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281788 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
recovery_387868 is modified to have a specific form of corruption. BUG=387868 TBR=michaeln@chromium.org Review URL: https://codereview.chromium.org/372823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281787 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
R=danakj@chromium.org BUG=none Review URL: https://codereview.chromium.org/373603009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281786 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishtr@chromium.org authored
BUG=390799 Review URL: https://codereview.chromium.org/375623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281785 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
BUG=none TBR=fsamuel@chromium.org Review URL: https://codereview.chromium.org/368953004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281784 0039d316-1c4b-4281-b951-d872f2087c98
-
reed@google.com authored
BUG=skia:2706 Review URL: https://codereview.chromium.org/374633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281783 0039d316-1c4b-4281-b951-d872f2087c98
-
haitaol@chromium.org authored
BUG=387862 Review URL: https://codereview.chromium.org/344193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281782 0039d316-1c4b-4281-b951-d872f2087c98
-
qinmin@chromium.org authored
This is cloned from https://codereview.chromium.org/275163002/ The previous change will break webview because AwWebContentsDelegate::ToggleFullscreenModeForTab is not implemented. This change passes a runtime switch to blink to disable fullscreen for non-media elements for android webview. when AwWebContentsDelegate::ToggleFullscreenModeForTab is called, android webview will send a FullscreenChanged IPC to finish the will/DidEnterFullscreen event for the media element. blink side CL: https://codereview.chromium.org/290643005/ This CL only impacts android webview BUG=367346 Review URL: https://codereview.chromium.org/292573004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281781 0039d316-1c4b-4281-b951-d872f2087c98
-
lisayin@chromium.org authored
Register that gestures have been received by the touch_exploration_controller in Accessibility Mode. Swipe gestures are registered when the user begins a swipe and completes it before the time out period. If a swipe is successfully completed, the keyboard shortcut <shift>+<search>+direction will called. If the grace period has elapsed, then the mode changes to touch exploration. If an additional finger has been added before the grace period has elapsed, then the mode changes to passthrough. BUG= 387304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281614 Review URL: https://codereview.chromium.org/330763007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281780 0039d316-1c4b-4281-b951-d872f2087c98
-
mdempsky@chromium.org authored
R=jschuh@chromium.org Review URL: https://codereview.chromium.org/375873004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281779 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
Add a probability to Alternate-Protocol support. Can be enabled either via a field trial or a command line flag. Review URL: https://codereview.chromium.org/339663010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281777 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/349263004/maniscalco@chromium.org authored
Reason for revert: Suspected as cause of browser_tests failures on Mac10.7 Tests: http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/28572 ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #1): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [10963:519:0708/084058:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (780 ms) ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #2): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [12926:519:0708/084834:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (639 ms) ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #3): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [12935:519:0708/084836:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (551 ms) ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #4): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [12937:519:0708/084837:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (560 ms) Original issue's description: > Fix Windows logoff race by posting a sentinel task to each taskrunner used to save state, and blocking on the completion of all sentinels. > De-flake and re-enable ProfileBrowserTests, by not running the tasks queued to initialize Bookmarks. This caused test failures when the delayed initialization managed to run. > This depends on https://codereview.chromium.org/370323002/, which fixes a BookmarkStorage lifetime issue, and https://codereview.chromium.org/375683002/ which annotates a remaining leak. > > TBR=sky@chromium.org, brettw@chromium.org > > R=erikwright@chromium.org, gab=chromium.org, brettw@chromium.org > BUG=386126, 141141, 141517, 142787, 140882, 165760, 163713, 391508 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281746 TBR=siggi BUG=392186 NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/378863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281766 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
Revert of Revert of Disable yama on 3.2 kernels with 32bit userland and 64bit kernel. (https://codereview.chromium.org/374933002/) Reason for revert: [Sheriff] This was fixed already in 281762. Original issue's description: > Revert of Disable yama on 3.2 kernels with 32bit userland and 64bit kernel. (https://codereview.chromium.org/371113003/) > > Reason for revert: > Broke clang builders: > https://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20(dbg)/builds/61819/steps/compile/logs/stdio > > Original issue's description: > > Disable two yama tests on 3.2 kernels with 32bit userland and 64bit kernel. > > > > Disabling yama restrictions is broken there. > > > > BUG=391916 > > R=jorgelo@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281666 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281757 > > TBR=jorgelo@chromium.org,keescook@chromium.org,thakis@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=391916 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281763 TBR=jorgelo@chromium.org,keescook@chromium.org,thakis@chromium.org,eseidel@chromium.org NOTREECHECKS=true NOTRY=true BUG=391916 Review URL: https://codereview.chromium.org/374943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281764 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
Revert of Disable yama on 3.2 kernels with 32bit userland and 64bit kernel. (https://codereview.chromium.org/371113003/) Reason for revert: Broke clang builders: https://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20(dbg)/builds/61819/steps/compile/logs/stdio Original issue's description: > Disable two yama tests on 3.2 kernels with 32bit userland and 64bit kernel. > > Disabling yama restrictions is broken there. > > BUG=391916 > R=jorgelo@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281666 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281757 TBR=jorgelo@chromium.org,keescook@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=391916 Review URL: https://codereview.chromium.org/374933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281763 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
TBR=maniscalo@chromium.org Review URL: https://codereview.chromium.org/375913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281762 0039d316-1c4b-4281-b951-d872f2087c98
-
jbroman@chromium.org authored
In this case, simply giving the Chromium src root as the include path is unlikely to be helpful. We can get a pretty close approximation by getting the flags for an arbitrary Blink source file, which will have more reasonable include paths and defines for a Blink header. Review URL: https://codereview.chromium.org/368313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281759 0039d316-1c4b-4281-b951-d872f2087c98
-
sigbjornf@opera.com authored
When checking if a class needs a finalizer, allow some of its base classes to be ignored, even if they do have a declared destructor. This is done so as to handle WebCore::ScriptWrappable use better while in transition. i.e., WebCore::ScriptWrappable's destructor does not have to be invoked when sweeping, and when Oilpan will be on by default, ScriptWrappable will not define one. However, until that time, it still provides a user-defined destructor, and to allow the class to be used as base in conjunction with GarbageCollected<>, we will now look past it when checking the finalizer requirement. R=zerny@chromium.org BUG= Review URL: https://codereview.chromium.org/374593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281758 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Disabling yama restrictions is broken there. BUG=391916 R=jorgelo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281666 Review URL: https://codereview.chromium.org/371113003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281757 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
TBR=beng@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/374723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281756 0039d316-1c4b-4281-b951-d872f2087c98
-
kaznacheev@chromium.org authored
This is useful for debugging Screencast without an Android device. BUG=None Review URL: https://codereview.chromium.org/375873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281755 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
This CL ensures that the manifest documentation refers to the webview documentation for the webview section. BUG=362708 Review URL: https://codereview.chromium.org/376673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281754 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=94925 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/374743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281753 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=bruening@chromium.org BUG=none Review URL: https://codereview.chromium.org/375893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281752 0039d316-1c4b-4281-b951-d872f2087c98
-
caitkp@chromium.org authored
BUG=347295 Review URL: https://codereview.chromium.org/368873004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281751 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
clang warns: ..\..\win8\delegate_execute\delegate_execute.cc(97,39) : error(clang): cannot pass object of non-trivial type 'const base::string16' (aka 'const basic_string<wchar_t, char_traits<wchar_t>, allocator<wchar_t> >') through variadic function; call will abort at runtime [-Wnon-pod-varargs] operation.mutex().c_str(), operation.relaunch_flags()); ^ 1 error generated. How did this every work? My guess is that %s interpreted the size_ member variable at the start of string16 as C string, and since the size usually has a at least the upper byte set to 0, this ended up logging 1-2 garbage bytes. BUG=82385 NOTRY=true Review URL: https://codereview.chromium.org/370943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281750 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
Since root cause http://crbug.com/342478 has been fixed. BUG=363183 Review URL: https://codereview.chromium.org/371353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281749 0039d316-1c4b-4281-b951-d872f2087c98
-
ppi@chromium.org authored
This CL drops recording histogram suffixes for SpdyCwnd field trial from 2010. These are based on depracated timing information recorded in DocumentState and have no indicated owner. BUG=384330 R=isherman@chromium.org, tonyg@chromium.org Review URL: https://codereview.chromium.org/375503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281748 0039d316-1c4b-4281-b951-d872f2087c98
-
mostynb@opera.com authored
This ancient CL suggested a simplication in mapped_file_posix.cc: https://codereview.chromium.org/160288 After hitting this DCHECK on an embedded device where using a debugger is difficult, I decided to make the suggested change and add some useful logging while I was at it. BUG=391937 Review URL: https://codereview.chromium.org/372113003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281747 0039d316-1c4b-4281-b951-d872f2087c98
-
siggi@chromium.org authored
Fix Windows logoff race by posting a sentinel task to each taskrunner used to save state, and blocking on the completion of all sentinels. De-flake and re-enable ProfileBrowserTests, by not running the tasks queued to initialize Bookmarks. This caused test failures when the delayed initialization managed to run. This depends on https://codereview.chromium.org/370323002/, which fixes a BookmarkStorage lifetime issue, and https://codereview.chromium.org/375683002/ which annotates a remaining leak. TBR=sky@chromium.org, brettw@chromium.org R=erikwright@chromium.org, gab=chromium.org, brettw@chromium.org BUG=386126, 141141, 141517, 142787, 140882, 165760, 163713, 391508 Review URL: https://codereview.chromium.org/349263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281746 0039d316-1c4b-4281-b951-d872f2087c98
-
wfh@chromium.org authored
BUG=392035 Review URL: https://codereview.chromium.org/374043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281745 0039d316-1c4b-4281-b951-d872f2087c98
-
tommycli@chromium.org authored
Break some of the chrome/common dependencies in implementation by moving some paths and constants to the component. Design doc: https://docs.google.com/document/d/1F76yNZCnPnGzgNXhI-sCFKlXulwx_s_OKTGbJS5NhbA/edit?usp=sharing BUG=371463 Review URL: https://codereview.chromium.org/334783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281744 0039d316-1c4b-4281-b951-d872f2087c98
-
jmadill@chromium.org authored
BUG=389276 Review URL: https://codereview.chromium.org/373833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281743 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
This landed in revision 281638 (https://codereview.chromium.org/354693004/) BUG=388836 Review URL: https://codereview.chromium.org/372163007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281741 0039d316-1c4b-4281-b951-d872f2087c98
-