GitLab

Show vertical scroll bars on settings screens, matching the Material
style. These scroll bars appear briefly when the settings screen is
opened, and again whenever the user scrolls the page to show their
current scroll position.

This change only affects settings screens that extend
PreferenceFragmentCompat. Other custom setting screens will be addressed
in follow-up bugs (i.e. https://crbug.com/998609).

Bug: 1131073
Change-Id: Ie9c9a7f118e9a00d5f5439d285fb67958b83b1d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424506
Auto-Submit: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810022}

The existing documentation for where to put any artifacts produced by a
test wasn't completely clear, so this adds some additional text to
hopefully make it so. Namely, paths should be specified relative to the
location of the results file, which normally is in $ISOLATED_OUTDIR,
meaning that the paths will also be relative to $ISOLATED_OUTDIR).


Change-Id: I7f03b9f31e7141051a4c783c383547e9dd27d286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426975
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810021}

Accessibility code calls EnsureComputedStyle during layout. That is not
strictly a problem, but we lazily clear computed styles outside the flat
tree during EnsureComputedStyle when querying computed style outside the
flat tree. Since we use the style recalc code to clear ComputedStyle
objects from a subtree we got a lifecycle issue with going to style
recalc during layout.

It would be interesting to find out why we end up querying computed
style for an element outside the flat tree for accessibility, but
otherwise using style recalc traversal to clear the ComputedStyle
objects was a bit more complicated than necessary.

This CL introduces a separate traversal that just clears ComputedStyle
along with dirty bits instead of going through style recalc.

TEST=StyleEngineTest.*

Bug: 1130436
Change-Id: I22ce417c6bc133e0429ba794f555821d74d08512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424344Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810020}

Now modifiers are tracked in XkbTracker, so remove the cache from
exo::Keyboard.
Instead, it is cached in WaylandKeyboardDelegate for re-sending
purpose.

BUG=1123705
TEST=Ran exo_unittests locally.

Change-Id: I2800f507a030a938d2e0d58163e2e5005f1de299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426663Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810019}

Fixing accessibilityPrivate.on* names to only be used for events.

No functional changes - should be mechanical only.

AX-Relnotes: N/A
Change-Id: I9e6af36eff39a3fdee09b38ff1cec91c366ea14b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423058Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Josiah Krutz <josiahk@google.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Josiah Krutz <josiahk@google.com>
Cr-Commit-Position: refs/heads/master@{#810018}

This mode is currently at 1% stable and the data shows improvements in
scroll latency and smoothness.

R=sunnyps@chromium.org

Bug: 1080911
Change-Id: I3b8e2455eebcf05369758f120bc63cb209162c81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427347
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810017}

See crbug.com/1111436#c35 and #c36 for detail.

Bug: 1111436, 924194
Change-Id: Iacbe51efafbc521ac891f66e82ce89b78864d404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427028Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#810016}

The summary child in the histogram tag should not be empty.

Change-Id: I7030df527b7852bd36de9e37ab48d09fca600d51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422985
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810015}

This CL adds accessible names to the buttons on the sharesheet
for screen readers.

Bug: 1131296
Change-Id: I4182b3ed982e9f4da7800502ab530e458f91dc58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423646Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Melissa Zhang <melzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810014}

This reverts commit 4c93f79b.

Reason for revert: broke ash_unittests on linux-chromeos-dbg: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20568

2020-09-23T19:55:14.797906Z 17555455662 FATAL ash_unittests[27683:27683]: [gles2_implementation.cc(6920)] Check failed: mailbox.Verify(). CreateAndConsumeTextureCHROMIUM was passed a mailbox that was not generated by ProduceTextureDirectCHROMIUM.


Original change's description:
> desks: Add tests for RootWindowDeskSwitchAnimator.
> 
> Test: added
> Bug: 1111445
> Change-Id: I0f79be1c09d4ef0eeff276e3c50f491efbe56244
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380517
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809854}

TBR=afakhry@chromium.org,khushalsagar@chromium.org,sammiequon@chromium.org

Change-Id: I7803aa521023f1063f7cb584126bbffb5311c420
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1111445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427037Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810013}

This change adds a test that confirms the behavior of the
'Exit tutorial' button in the interactive tutorial. Clicking this
button should close the tutorial and return ChromeVox to the web
content.

Bug: 1127047
Change-Id: I12e348fed7e01cc73b54e204cc9447a95b73e86d
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416818
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810012}

Rather than setting the profile each each time directly, we inject a supplier that can be observed. This reduces the complexity of the interface and will let us constructor inject the supplier more easily in the future.

Change-Id: Ibd587e1a5496e5bca3d27eb7120aacbedb2ff138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419635
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810011}

The IPH_Bookmark feature is no longer in the code.

Bug: 1126640
Change-Id: I06773fe1440c046bb5138ec44a6c3ebd02ccb578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427348Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810010}

Bug: 1013082, 998048
Change-Id: I9b44c0da86f9fd93046a57fdd7f397122b90e3f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424218
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810009}

TBR=bling-team@google.com

Change-Id: I84ff78d0100606a1cbc69ecd5840a57f8776debd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426976Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810008}

This is the first of a series of CLs to improve performance and
flexibility of subsequence caching. The basic idea is to split a
previous monolithic PaintArtifact into segments which are the basic unit
of subsequence caching. A segment will be created when we start or end a
subsequence. It's either a leaf subsequence or the gap between two leaf
subsequences. When a subsequence can be cached, its segments will be
copied from the previous PaintArtifact with trivial cost.

The mechanism will work for both CAP and pre-CAP. In pre-CAP we'll also
use one PaintController for each local frame tree, and we'll also create
segments at GraphicsLayer boundaries. In this way, the difference in
painting of CAP and pre-CAP will be greatly reduced.

This CL prepares PaintArtifact and PaintChunkSubset for segmenting.
PaintChunkSubset supports iterating paint chunks in a PaintArtifact:
- for all paint chunks;
- for a subset of paint chunks, with a segment range, which will be for
  pre-CAP GraphicsLayers;
- for a subset of paint chunks, with an array of paint chunk indices
  which will be for CAP layerization algorithm, including CompositeSVG
  for SVGs.

Now we can also iterate the display items in a chunk with
PaintChunkIterator::DisplayItems(), so that a PaintChunkSubset (which
references the containing PaintArtifact) can represent all painted
result of a composited layer.

Bug: 917911
Change-Id: I5c894e105463e866ac38a17cdc9c5e43eca6a6e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407298Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810007}

This CL removes VaapiWrapper::SubmitVAEncMiscParamBuffer, pushing the
logic to its only client, VaVEA.

Bug: b/166646505
Change-Id: Ic671525e6936856ec370c3670f35665c4b185b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414565Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810006}

This CL addresses an issue with <div role="progressbar"> not
being interesting on Android.

With this CL, kProgressIndicator's are now set to interesting
by default, making it possible for a user to linearly
navigate to the node via a screenreader.

We have added a new method, IsSeekControl, to differentiate
progress indicators, which are range type nodes, from the
other range type nodes, such as sliders, which allow the user
to use seek control to set the value. A user should not have
the ability to seek control and change the progress of an
indicator.


AX-Relnotes: Progress indicators (role="progressbar") are interesting on Android
Bug: 1129688
Change-Id: Ifca9a4048d695e33eedbb1b0bd43e97fcb8d29ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424976Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#810005}

The feature "AutofillUseApi" is now enabled by default.
This CL removes it and starts removing dead code upon the removal of
this feature flag.

Follow up CLs will do more cleanup!
This is a reland of crrev.com/c/2401040
PatchSet 3 is the same as the original CL.

Bug: 1114655
Change-Id: Ib5ccce5545d5885d3e2659044a24f046d3b074fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424261Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810004}

It's flaky on all platforms.

Bug: 1131319
Change-Id: Ic04251bdb4b57b5b4fd656451262ca7fcd8f5f5b
Tbr: iopopesc@microsoft.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427436Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810003}

Introduces a concrete CrossThreadMediaSourceAttachment with minimum
implementation necessary to enable worker thread MediaSource object URL
creation. To enable registration of worker-thread MediaSource object
URLs, which is inherent in the createObjectURL implementation, updates
MediaSourceRegistryImpl to perform registration and unregistration while
holding a mutex in the singleton, main-thread-owned, registry instance.
Mutexes previously were thought unusable for this, but that was due to
the registry previously using an Oilpan HeapHashMap bound to the main
thread's Oilpan heap. The current registry now uses a non-Oilpan
HashMap, so any thread can update the singleton so long as such
accesses or updates are mutex-protected. Also, using cross-thread task
posting to perform these tasks led to complex races whose solution is
much simpler using the mutex approach herein. See
CrossThreadMediaSourceAttachment::Unregister() for more detail.

Includes a necessary update which makes both types of attachments manage
the registered media source in appropriate Oilpan type: the cross thread
attachment must hold that reference as CrossThreadPersistent. The URL
registry implementation already unregisters all entries created on an
execution context if that context is destroyed, so this
CrossThreadPersistent registry entry will not outlive the worker
thread's context. See PublicURLManager::ContextDestroyed() for where
that logic exists already. Rationale for not also making the
SameThreadMediaSourceAttachment use a CrossThreadPersistent type is that
such type introduces a new root in all Oilpan heaps, and resulting
performance hit can be avoided by just using regular Persistents for
same thread attachments' |registered_media_source_|.

Includes new web_tests that exercise basic worker context MediaSource
construction, object URL creation and revocation (with revocation of
worker MediaSource object URL also tested on main thread). Starting an
attachment to a worker MediaSource is also tested, but is currently
expected by the test to fail until upcoming
CrossThreadMediaSourceAttachment changes land.

BUG=878133

Change-Id: I367b6610da9aca3aca7c78f4a11f571e48afc6c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407075Reviewed-by: Will Cassella <cassew@google.com>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810002}

Secondary CTA was added in https://crrev.com/c/2401812. To not pollute
the Password compromise and Safe Browsing off metrics with the new
navigations, add separate metrics for them. These metrics will be
removed once SafetyCheck is no longer under active development.

Add three new values in SafetyCheckInteractions:
SAFETY_CHECK_PASSWORDS_MANAGE_THROUGH_CARET_NAVIGATION
SAFETY_CHECK_SAFE_BROWSING_MANAGE_THROUGH_CARET_NAVIGATION
SAFETY_CHECK_EXTENSIONS_REVIEW_THROUGH_CARET_NAVIGATION

Add three new user actions:
Settings.SafetyCheck.ManagePasswordsThroughCaretNavigation
Settings.SafetyCheck.ManageSafeBrowsingThroughCaretNavigation
Settings.SafetyCheck.ReviewExtensionsThroughCaretNavigation

Bug: 1103015
Change-Id: I451398e1bd8b34014145402526f6042c2ffbfe08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422254
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#810001}

https://android.googlesource.com/platform/external/perfetto.git/+log/637111bf309e..61c15b0ea08f

2020-09-23 fmayer@google.com Merge "Also deobfuscate frames from jit-cache."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I22c8154edb76af804507b2db3b3927f83eecfe2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427232Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810000}

Bug: 1131674
Change-Id: I63ca231ab1589ef043cf3acf18540356981483f5

TBR= maxlg@chromium.org

Change-Id: I63ca231ab1589ef043cf3acf18540356981483f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427214Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809999}

Description:
 remove "hr" tags from diagnostics_app and add
 styling to page header

Screenshots:
 - Diagnostics Page (before) http://shortn/_YdImFO55AY
 - Diagnostics Page (after) http://shortn/_k8NLMVtA6A

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I7dcf4d769f758ad79218f3487551fba2f02a1686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425384
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809998}

This change adds a new field to the network snapshot, signal strength.
It is populated with the signal strength of wireless network devices as
measured from the device. The value ranges from 0 - 100. This value is
also added to the network health summary UI and feedback reports.

Bug: chromium:1128460
Test: checked chrome://network for signal strength
Change-Id: I447d5753b16ca79d9383543bb16a669eb7b80184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412216
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809997}

There hasn't been any spikes in crashes in canary, so should be safe to
move this to dev/beta.

Bug: 1105096
Change-Id: I584c882013ed7f20b03461a654250d955253f2d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426145Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809996}

This is a reland of 0d88901a


Diff against patchset 1 for reland diff.

Added call to close widget and assert that the button is no
longer tracking.

Original change's description:
> Tab Search: Update TabSearchButton tests
>
> This CL creates a new file for TabSearchButton browser tests. These
> tests run for both the fixed and regular entrypoints.
>
> Existing tests for the TabSearchButton have been moved from the tab
> strip into the TabSearchButton browser tests.
>
> Bug: 1099917
> Change-Id: I0b1d57826768705316b9bed814dac7af96ce52e8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422730
> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809376}

Bug: 1099917
Change-Id: I327e68cebff1d62c9be75c971e28580b1e2dd789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425394
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809995}

https://pdfium.googlesource.com/pdfium.git/+log/2b2e1584ef6d..1d3378762d82

$ git log 2b2e1584e..1d3378762 --date=short --no-merges --format='%ad %ae %s'
2020-09-18 thestig Fix FPDFText_GetCharBox() returning excessively tall char boxes.

With the FPDFText_GetCharBox() change, some code in pdf/ need to be
adjusted, so PDFiumPageTextTests pass:

1) In TestHighlightTextRunInfo, a text run that only contains a space
   used to be 25 units tall. Now it is 14, which better matches the
   surrounding text runs and no longer sticks out.
2) In TestTextRunBounds, the leading space is now shorter, but the rect
   to pixel conversion rounds it down to 0. Change
   FloatPageRectToPixelRect() to change rect dimensions that would round
   down to 0 to round up to 1 instead.

Change-Id: I887e0567e8a9372690e5fcc0f82d96c4852df80a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425751
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809994}

Batched the tests into either UNIT_TESTS or a shared IME_BATCH batch.

Further performance improvements could be gained by reusing the content
shell across tests, but while that looks possible it's not trivial so
I'll leave that as a TODO.

Bug: 989569
Change-Id: Idea445a7338ad669078732ac9e9822f7122a84a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427067Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809993}

Given that we race on every navigation, it doesn't make sense to retry
the batch update hints fetching since we'll just fetch for any necessary
failures on navigation anyway.

Change-Id: I6d96d5d6ac34252e80f36ba8c7732fb1e1e3ff9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426972Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809992}

Given that DISALLOW_COPY_AND_ASSIGN is deprecated, using explicit
deletions instead.

Bug: 1043306
Change-Id: I1999fb65ef08d5ba89ce296f1a72504285b4c7b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424659
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Auto-Submit: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809991}

Roll Chrome Win64 PGO profile from chrome-win64-master-1600775907-3f1dcf02f5358f2c935175c2f1e643612d0cf1c1.profdata to chrome-win64-master-1600861496-1af5dbbac81d989efc59c83c56068ac6e2862c09.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I5bf7f31215a4315d94170f48c7675d75092bb267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426299Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809990}

Using wpt-import in Chromium a89290b0.
With Chromium commits locally applied on WPT:
20bd04b7 "Use allow attribute for delegation in WebUSB WPT"
8f02a380 "Use allow attribute for delegation in web serial WPT"
32afb795 "Fix <clipPath> descendant check for filter effects on SVG elements"
c7b06ab2 "[FragmentItem] Fix scroll overflow when inline box hangs"
b76e918d "Fix resolution of 'auto' in SVGLengthContext::ResolveLengthPair"
256b7f7c "Use allow attribute for delegation in generic sensor WPT"
ea72cb05 "Use allow attribute for delegation in wake-lock WPT"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
binji@chromium.org:
  external/wpt/wasm
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
chcunningham@chromium.org, wolenetz@chromium.org:
  external/wpt/media-source
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
dtapuska@chromium.org:
  external/wpt/uievents
emilio@chromium.org:
  external/wpt/css/css-display
eroman@chromium.org, rsleevi@chromium.org:
  external/wpt/WebCryptoAPI
foolip@chromium.org:
  external/wpt/compat
  external/wpt/fullscreen
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
garykac@chromium.org:
  external/wpt/keyboard-map
guidou@chromium.org, armax@chromium.org:
  external/wpt/mediacapture-streams
guidou@chromium.org, emircan@chromium.org, emircan@chromium.org:
  external/wpt/screen-capture
hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com:
  external/wpt/webrtc
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
igrigorik@chromium.org, yoavweiss@chromium.org:
  external/wpt/preload
jrummell@chromium.org:
  external/wpt/encrypted-media
jsbell@chromium.org:
  external/wpt/storage
ksakamoto@chromium.org, npm@chromium.org, yoavweiss@chromium.org:
  external/wpt/resource-timing
lanwei@chromium.org:
  external/wpt/infrastructure/testdriver/actions
meade@chromium.org:
  external/wpt/web-animations
mek@chromium.org:
  external/wpt/webmessaging
mkwst@chromium.org:
  external/wpt/trusted-types
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy
mustaq@chromium.org:
  external/wpt/html/user-activation
npm@chromium.org, yoavweiss@chromium.org:
  external/wpt/navigation-timing
nzolghadr@chromium.org:
  external/wpt/pointerlock
  external/wpt/touch-events
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents
panicker@chromium.org:
  external/wpt/page-visibility
pwnall@chromium.org, jsbell@chromium.org:
  external/wpt/cookie-store
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: I7454504d79c1dbf47ac35355d13b7f5e7f6194a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426866Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809989}

In https://crrev.com/0bb413bf71 WillHandleGestureEvent was no longer
needed on the public API.
In https://crrev.com//23748d4a10c7a DidHandleGestureScrollEvent was
no longer needed on the public API.

BUG=1097816

Change-Id: I5981bb76f875bde137aa50c88cb5516d12b7ea02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424503
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809988}

Adds checks to ensure early detection of API contract violations that
would lead to use-after-frees.

Bug: 1127466
Change-Id: Ic73b30f115f5206572a427ac44674ff6a9b9f249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425523
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809987}

Batch the Fido2CredentialRequestTest tests, which significantly speeds
up their runtime, but I can't compute exact speedups right now because
the bots on the CQ don't run them. They pass locally.

Bug: 989569
Change-Id: I61ebb40ae0a7dcb71a4745c5e9d9e8ec449cba9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427026
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809986}

Fixes the behavior of the "Saved Printers" search tag so it is
dynamically added/removed when the number of saved printers is greater
than 0.

Bug: 1116553
Change-Id: I37f2d3c1612ec58feb01a4dcdf426807fd442040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424518
Commit-Queue: Daniel Classon <dclasson@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809985}

Allow clients to provide a callback in

for now.

chromeos: :AccountManager::InitializeInEphemeralMode. Used only in tests
Change-Id: Ib1da37327d9d3c87865957b3286c59d6d48ed8a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421813
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809984}

https://chromium.googlesource.com/angle/angle.git/+log/edea3d95c996..6c3942200a20

2020-09-23 b.schade@samsung.com Vulkan: Fix bug in compressed texel block computation
2020-09-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 125b64241909 to 67525bded1de (4 revisions)
2020-09-23 m.maiya@samsung.com Allow GL_UNSIGNED_BYTE as a type for glColorPointer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: syoussefi@google.com
Test: Test: angle_end2end_test --gtest_filter=*ETC1CompressedImageNPOT*
Change-Id: Ib5a248374105eaccb63d69d15c722b4bd5c73877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426254Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809983}