You need to sign in or sign up before continuing.
- 09 Aug, 2019 40 commits
-
-
Robert Phillips authored
The bug fix will require some cc unit test rebaselines and some layout rebaselines. Here is the Skia CL in question: https://skia-review.googlesource.com/c/skia/+/233556/ (Fix exactify for explicit resource allocation (take 2)) Bug: b/138674523 Change-Id: Icc4507129198dbf327d0dff4a2e3fe04b8fd91a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745440 Commit-Queue: Robert Phillips <robertphillips@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#685551}
-
Javier Ernesto Flores Robles authored
UX approve stamped this green as the replacement for the old palette. Bug: 976675 Change-Id: Id9be807b8315d171678605b3aeda5061ff4fe18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746177 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#685550}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/34e00069a965..f3b064fc4807 git log 34e00069a965..f3b064fc4807 --date=short --no-merges --format='%ad %ae %s' 2019-08-09 skyostil@google.com Merge "gen_amalgamated: Move tests from gen_all to CI" Created with: gclient setdep -r src/third_party/perfetto@f3b064fc4807 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I7488909c6b3df9e644a0ccd9b7b772b7a25d1565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746298Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685549}
-
Maksim Ivanov authored
Pipe the authenticating user's AccountId down to the UI-related code that shows security token PIN dialogs, so that the UI layer has ability to correctly tie the PIN UI with the needed user. Before this CL, the UI code has to assume that the currently selected user is the one that for which the PIN request should be shown. However, this assumption is unreliable in general: for example, the user could have already clicked a different user pod before the PIN request arrived, and as a result the PIN dialog would be shown on a wrong user pod. This CL extracts the AccountId based on the AccountIdentifier information supplied by the cryptohomed to the org.chromium.CryptohomeKeyDelegateInterface D-Bus service exposed by the browser. Bug: 983103 Change-Id: I55999c64f3c9af29fa8c231210ad3282643da885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742172 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#685548}
-
Alexandre Frechette authored
Change-Id: I7b8dafb5a97f93104147f2482f3fbda0857d34ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744333Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#685547}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 968047 Change-Id: I48ea6b3d73e532cef45ce42a7601a2e02b3eb36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729155 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#685546}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. TBR=avi@chromium.org Bug: 968047 Change-Id: If81258c798697344b2a536dfc199e217a8eb1e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739706Reviewed-by:Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#685545}
-
Ramin Halavati authored
Traffic annotation auditor binary needs to be updated due to a recent updated of enterprise policies. TBR: nicolaso@chromium.org Change-Id: I9a636966235f1d9437f6c117ec0c2e1058a33cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746254Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#685544}
-
Vlad Tsyrklevich authored
I accidentally used the wrong parameters in this field trial testing config (it should sample processes half as often.) Bug: 973167 Change-Id: I0a26dd365e3a3cb5bbcc860ba9693295e1f912bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744688 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#685543}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/eb0479e245f0..e54c3e3aa01c git log eb0479e245f0..e54c3e3aa01c --date=short --no-merges --format='%ad %ae %s' 2019-08-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src b029d3697ea3..22ce39c8e1ec (5 commits) Created with: gclient setdep -r src/third_party/angle@e54c3e3aa01c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:None Change-Id: I19bfff4d79cf5fcdbcc1b74c882ef774170e275e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746192Reviewed-by:
-
Ivana Zuzic authored
The changes of password data are saved by clicking on the save button in PasswordentryEditor. After that, PasswordEntryEditor gets closed and the changes are visible in PasswordEntryViewer and on the list of passwords. Bug: 377410 Change-Id: Ia0e9707d508b6a6449fb97263e31e5747016a945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736685 Commit-Queue: Ivana Zuzic <izuzic@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#685541}
-
Mugdha Lakhani authored
This lives under the Service Worker section of the Application tab in Devtools and allows dispatching a periodicsync event with a given tag so that developers can test how they respond to it. Screenshots here: https://bugs.chromium.org/p/chromium/issues/detail?id=961238#c4 Bug: 961238 Change-Id: I2f5fe2c41ad9d2c50db99c44d873d8cc61964913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725893Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#685540}
-
Josh Nohle authored
Bug: 899080 Change-Id: I15c11a7f41f76d8f0c49a3580f70ebeeaa151d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737669Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#685539}
-
Yang Guo authored
When built using debug_devtools=true, allow using --custom-devtools-frontend command line flag to specify path to DevTools frontend resource files. Bug: 988990 Change-Id: I90e84ba797397af77477838030961ebd6f2f8cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741813Reviewed-by:
-
Friedrich Horschig authored
This is a reland of 3cd4817b The original CL was based on https://crrev.com/c/1729592 which was reverted. Once the reland https://crrev.com/c/1741916 is merged, this CL should work as intended. TBR=jdoerrie@chromium.org,ioanap@chromium.org Original change's description: > [Mfill Android] Render credit card warning in TextView > > This CL ensures that the unsafe origin warning is rendered as TextView > and that fields which are marked as disabled are actually disabled. > > Bug: 965500 > Change-Id: I2c0c66e86075b3152431dcd18b4922c1167786e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736355 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685112} Bug: 965500 Change-Id: I0cbe46c4d7e0a6d2fb936a1b0dcb99c657af2a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742236Reviewed-by:
-
Peter Marshall authored
Part of an ongoing cleanup to use Detach consistently. This CL is a mechanical renaming and should not change any logic. Bug: chromium:913887 Change-Id: I224b80b910bd84076880915063ee8b798ef91689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738697Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#685536}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39263da7. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic0f4f587e5b36811d31e6ee540f67fe9be8164ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745271Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685535}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2bd4849cc139..794dd735e4f8 Created with: gclient setdep -r src-internal@794dd735e4f8 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1eb438afd71e5170ea30effdaa702ad936851f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746295Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685534}
-
Marina Ciocea authored
Drive-by fix crash when the browser is closed while sharing a tab. Bug: 991896 Change-Id: I00fe5791cd6856f8258a279a7fa5f6e7d276237f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746169 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#685533}
-
Javier Ernesto Flores Robles authored
This CL updates most colors to their dynamic counterparts. Exceptions: Background Color of the Cells and grey trailing icons. Screenshots: https://drive.google.com/drive/folders/1FnJz38j2xyZAWURcujmqYuTrwrkYnUnR Bug: 976675 Change-Id: I8f622ad673c7e2cf7baf77011fe91d45655b0e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744489 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/46afc4f9..520e310f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d8e189781e9058f7b0015ac84a3ff365e45feef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745273Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685531}
-
Lowell Manners authored
This test is interested in the state of documents as they're deleted during navigation. Change-Id: I4db86fb97d45771aecf33f8a7afdc93c00602d21 Bug: 990354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733526 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#685530}
-
Rouslan Solomakhin authored
When a payment handler sends a "payment method change" event to the merchant, the developer tools can display this event and the corresponding price update from the merchant. Bug: 980249 Change-Id: Ia3f16215cadf54d0a3f44b6b5f471839ca498f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742207Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#685529}
-
Eric Lawrence authored
Save 28786 bytes of disk space by removing unneeded metadata from two PNG files. Bug: 991654 Change-Id: I6b29592501c2cd6737c392e146f0770464453855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742609Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/273e263d25b4..e4ba4ee837ac git log 273e263d25b4..e4ba4ee837ac --date=short --no-merges --format='%ad %ae %s' 2019-08-09 nisse@webrtc.org Delete placeholder file rtc_base/function_view.h 2019-08-09 nisse@webrtc.org Use StreamStatistician::BitrateReceived to produce total_bitrate_bps for GetStats. 2019-08-09 nisse@webrtc.org Delete rtc_base/gunit_prod.h 2019-08-09 nisse@webrtc.org Add missing AppKit dependency Created with: gclient setdep -r src/third_party/webrtc@e4ba4ee837ac The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I9f5c151715a1b5b6dc3e003d6aa65d7323056fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746291Reviewed-by:
-
Eric Seckler authored
We're seeing crashes within AddTraceEvent called from UpdateDuration when attempting to access the trace event's category pointer. The category pointer is nullptr in this case, which leads me to believe that UpdateDuration may attempt to access an uninitialized TraceEvent from the complete_event_stack_. One piece of code that looks suspicious to me is the update of current_stack_depth_ in UpdateDuration in case the handle's event_index and current_stack_depth_ mismatch for some reason. Provided the DCHECK holds, it still shouldn't cause an invalid TraceEvent to be accessed in later invocations of UpdateDuration, but this is an attempt to make the update a little safer nevertheless. Bug: 983307 Change-Id: I6c6e4dc02bdde5e5e324c65ffb6e5cfe1028c6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741919 Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/chromium/tools/build/+/1744467 the clang mac tot bots should have a system Xcode install that we want to use instead. Bug: 976593,985971 Change-Id: I1bf0aaacf4f6485352b4741e6a263cbfbe7d4318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743104Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#685525}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 968047 Change-Id: Ibebd81e88c85b0436356b25ec53495b86d6eac1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729075 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#685524}
-
Michael Lippautz authored
- Move PrefinalizerRegistration to top - More documentation - Move schedule helpers to private section - Remove dead code Bug: 982754 Change-Id: I8eaa76bae7f18cc881b66e65df099806a3234f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745988 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
arthursonzogni authored
They are all failing because of https://crbug.com/991194. A document is frozen. When the back-forward-cache is enabled, it blocks JavaScript and evict the document. The problem is that it applies to every frozen documents, even the ones not in the BackForwardCache. Bug: 992325, 991194 Change-Id: I8239dcfab079630e192fa433c7a7e456a43ccaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746247Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#685522}
-
Rafał Godlewski authored
Bug: 724869 Change-Id: I07b9db1021f7256dfe363f6f22857b29ffeaf51c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718425 Commit-Queue: Rafał Godlewski <rgod@google.com> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=benwells@chromium.org, pwnall@chromium.org, rsesek@chromium.org Bug: 968047 Change-Id: I103a15fe7e1ac0e6dfbbe02875bca4f6a31c0456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738595 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/64c217c797c4..34e00069a965 git log 64c217c797c4..34e00069a965 --date=short --no-merges --format='%ad %ae %s' 2019-08-09 nicomazz@google.com Merge "Allow Perfetto UI extension to work in predefined hosts" Created with: gclient setdep -r src/third_party/perfetto@34e00069a965 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: If0a695531ae9003db528571e62271bf382e0eccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746286Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5e4af85c4796..273e263d25b4 git log 5e4af85c4796..273e263d25b4 --date=short --no-merges --format='%ad %ae %s' 2019-08-09 nisse@webrtc.org Delete old placeholder file android_network_monitor_jni.h 2019-08-09 nisse@webrtc.org Delete unused Opus-specific methods of AudioCodingModule 2019-08-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6fb8f3c6..87ee38fb (685365:685466) 2019-08-09 nisse@webrtc.org Delete unused class MockTargetTransferRateObserver Created with: gclient setdep -r src/third_party/webrtc@273e263d25b4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: Ibb51b7beaa2c1e5491e12ca6225419b9e81df41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746201Reviewed-by:
-
Hiroshige Hayashizaki authored
As a preparation for adding parser-related tests. Bug: 990561 Change-Id: Iebd54fe15ae2943ea9f5cc9aeefac4d32a854316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734195 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#685517}
-
arthursonzogni authored
Understand for every failing content_browsertests, why they are failing with the BackForwardCache. Bug: 991488 Change-Id: I71feeea5432d44896d5f03503d43ac61829b343e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741681 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Daniel Vogelheim authored
This is a purely speculatively fix for an item reported by fuzzers, but not (easily) reproducible. See bug for details. Bug: 970282 Change-Id: I5b04cbe5b6e8b5fe2013aaf1a0e9b2f34c4f607b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742087Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e94c274fe0f7..2bd4849cc139 Created with: gclient setdep -r src-internal@2bd4849cc139 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I81b77b09809862b1118d2fb38bc337e0d3cc1121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746196Reviewed-by:
-
Javier Ernesto Flores Robles authored
MDCCollectionView uses a white background by default. This overrides the default color with one that supports dark mode. Bug: 976675 Change-Id: I3b2f6688698c90f29093cb17dbc9d30e9e3a45ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741913Reviewed-by:
-
Friedrich Horschig authored
This is a reland of e9756386 It failed on test builds since UNIT_TEST is never defined in CC files. This causes the definition to exist without declaration which resulted in the linker error. Inlining the operator<< definition into the header allows to keep the test and non-Release scoping and fixes the error. (The "inline" keyword prevent duplicate symbols caused by the repeated inclusion of the headers in different CC files.) Original change's description: > [MFill Android] Allow warnings in credit card controller > > This CL allows to add a warning to the credit card accessory sheet. It > is used if a form is deemed to insecure to allow filling. > If this warning is set, it means the context isn't secure enough to fill > a card. Therefore, the input chips are disabled and don't allow inputs*. > If there is no warning, we still check whether the current frame uses > HTTPS. In case the frame doesn't use HTTPS, we disable the chips*. > > * The chips are not disabled _yet_. This requires an update on the > Android side. > > Bug: 965500 > Change-Id: Ia8d5dce9d7d3f540e789f73f383b49a3b42d63d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729592 > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684744} Bug: 965500 Change-Id: I4b90ecf6609f5e3f9f2608535e3d60e65f0f07c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741916Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#685512}
-
