GitLab

This CL:
1. Removes Android-specific code from paint_preview_base_service.(cc|h).
2. Replaces the PaintPreviewBaseService Java class with the
   NativePaintPreviewServiceProvider interface. This enables each
   implementer of paint_preview_base_service.cc to independently handle
   its JNI communications.

Bug: 1058405
Change-Id: Id629aa95560cb4c0f202079c1437a16c67798d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090592Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747475}

The iconSet property of most volume types is empty, but we expect that
third party volumes (ANDROID_FILES, DOCUMENT_PROVIDERS and File System
Providers) should provide icons in their respective iconSets.

CL:2032469 added a shouldProvideIcons() helper to volume manager so we
can detect these volumes. ANDROID_FILES is done (CL:1945958) and noted
File System Providers and DOCUMENT_PROVIDERS were still todo.

In this change, use the shouldProvideIcons() helper to detect the File
System Providers and DOCUMENT_PROVIDERS that provide no icons, and use
a generic icon for these volumes instead.

files-ng only: this to avoid drawing a dull gray box for these volumes
in files-ng if they provide no icons.

Bug: 992819
Change-Id: Ia2b4c6caf70d3b8250acc8d9706f476a486199ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089178Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747474}

Add a key event handler to the create note action, looking for events
with a special flag showing that they were generated by a stylus
bluetooth button.

This will allow users to open a new note by double clicking the tail
stylus button

Bug: b:139781900
Change-Id: Ie77e12b4b5256922f3653bacb425a15fdafcf8b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079836
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747473}

Bug: 1017499
Fixes: 1017499
Change-Id: I0b4f6da09b8cb5804fe85e7402f3e1ea83193497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088502Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747472}

Instead of defining a function object and then adding functions to it,
wrap everything in a cr.define, which can be removed later once
these tests are fully migrated to use JS modules.

Update all test classes to es6 classes.

Bug: 1026426
Change-Id: I004fb0798b5a855bda2de9c3f996fe346937e1cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088650Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747471}

Marking the entire ancestry for invalidation while inside pre-paint
probably isn't too healthy anyway, and when the pre paint machinery is
updated to walk the NG physical fragment tree rather than the layout
object tree, we're potentially going to visit the same layout object
more than once, and not always in exact tree order.

Bug: 1043787
Change-Id: Id99f46f4704cc279323a94a80762c4e0d2cd166b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089832Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747470}

Cleans up the StackCopier interface/implementations by reusing
the stack copier delegate for metadata recording. This allows us to
remove the awkward dependency on ProfileBuilder within the StackCopier
implementations (awkward since the StackCopiers otherwise don't know
anything about building a profile). This requires one additional function
on the delegate interface to allow the metadata provider to be eagerly
destroyed.

Bug: 1035855
Change-Id: I59bf1abbddfeb1a54442a826e309a1b29ffbe31d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075881
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747469}

https://android.googlesource.com/platform/external/perfetto.git/+log/0c6dfdbceb9e..7e47609cf293

git log 0c6dfdbceb9e..7e47609cf293 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 pmuetschard@google.com Adds a LAST_NON_NULL window function to the trace processor.

Created with:
  gclient setdep -r src/third_party/perfetto@7e47609cf293

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I04128556754d1670bd6635b503b300ff5391631f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090228Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747468}

Instead of correcting timing data when doing reporting,
this change makes it so that timing data is corrected
before it is written to the json files. That makes
reports easier to write since we don't need to figure
out if a platform is running reference builds or not.
Also, it means that we don't incorrectly apply doubling
to gtest perf tests, which never run reference builds.

R=tdresser@chromium.org, wenbinzhang@google.com

Bug: 1054000
Change-Id: I78de317099a1af0a77d4a6d5802a6ffa46a8840d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089436
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747467}

This means it doesn't show in the launcher, and it records the correct
metric.

Bug: b/150738188
Change-Id: I8e14ca21a68bac95f0b7dae8b8719632289089ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086382Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Cr-Commit-Position: refs/heads/master@{#747466}

A display transform pass could be added during capturing when
devices are not in their default orientation. Making the display
transform pass to copy |has_transparent_background| flag from
root renderer pass fixed the problem on Dru. Without the flag
copied, Dru (ARM/Mali) somehow shows the display transform pass
as a black frame and causes the flicker.

Bug: 1041901
Change-Id: I9651073cf8f9ab75ae5aaf6bfcd20a25fd4349d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089957
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747465}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f5b833c6d2ac..61f8ad8b69f9

git log f5b833c6d2ac..61f8ad8b69f9 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 jalyn@microsoft.com Add titles for all actions

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@61f8ad8b69f9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:174309
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ibff34cf56959a847252ce4d464c5470c21b698ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089776Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747464}

This CL re-enables OffscreenCanvas tests that depedends on surface
embedding as VizForWebView is enabled in fieldtrial_testing_config.json
for a while now.
Tests pass on gpu-fyi-try-android-m-nexus-5x-64 bot.

Bug: 805739
Change-Id: I2dbb32e684005fe9521d91289d2d5c992a261394
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088339Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747463}

The kWeb branch in AppServiceContextMenu::IsCommandIdChecked() is
capable of handling web apps that run using BMO or Extensions as the
backend. This CL removes the flag check and fallthrough behaviour.

Bug: 897314
Change-Id: I530988629aa92e13d3cac9ccb8bcd500c1e7f7c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087247
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747462}

https://pdfium.googlesource.com/pdfium.git/+log/a40862f237fc..8ecb862ae74d

git log a40862f237fc..8ecb862ae74d --date=short --first-parent --format='%ad %ae %s'
2020-03-05 tsepez@chromium.org Retain layout item in all CFXA_FF.*::Paste() method overrides.
2020-03-05 nigi@chromium.org Add FXSYS_IsLowerASCII().
2020-03-05 nigi@chromium.org Add a caller for FXSYS_ToUpperASCII() to simplify code.
2020-03-04 tsepez@chromium.org Retain layout item in a few more places where text changes.
2020-03-04 nigi@chromium.org Add FXSYS_IsUpperASCII().

Created with:
  gclient setdep -r src/third_party/pdfium@8ecb862ae74d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1055869,chromium:1058653
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I221c2f725aa0dce901bf6c3c8f2fd91c0aea28a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090223Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747461}

https://quiche.googlesource.com/quiche.git/+log/7e5e609bc7a1..c7e392d65eb9

$ git log 7e5e609bc..c7e392d65 --date=short --no-merges --format='%ad %ae %s'
2020-03-05 nharper Fix initialization of vectors in tls_connection.cc
2020-03-05 dschinazi Add missing QUIC_EXPORT_PRIVATE to fix QUIC merge
2020-03-04 bnc Add helper functions for PROTOCOL_QUIC_CRYPTO versions.
2020-03-03 wub gfe-relnote: (n/a) Pluming work for loss detection tuning using go/smartchoices. No behavior change, not protected.
2020-03-03 renjietang Move stream static checks from QuicSession to QuicStream.
2020-03-03 renjietang Let session methods that write data take argument of TransmissionType so that it's clear at which transmission type the data is written.
2020-03-03 fayang gfe-relnote: In QUIC, do not bother stream ID manager on pending stream closing if connection disconnects. Protected by existing gfe2_reloadable_flag_quic_enable_version_draft_25_3.
2020-03-03 wub gfe-relnote: (n/a) Add a histogram to record the writer status code from QuicConnection::FlushPackets. Stats only, not protected.
2020-03-02 wub gfe-relnote: (n/a) In QUIC BBRv2, avoid unnecessary PROBE_RTTs when coming out of quiescence. Protected by --gfe2_reloadable_flag_quic_bbr2_avoid_unnecessary_probe_rtt.
2020-03-02 fayang gfe-relnote: In QUIC, use standard deviation to calculate PTO timeout. Protected by gfe2_reloadable_flag_quic_use_standard_deviation_for_pto.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Iab4ea0a1ae1b3796e522be2359b9a7c536e21f52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090234
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747460}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I5d15630c9a5beb7462431867baf0adebb42b6647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090632Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747459}

ThumbnailPageEventAdapter is unused at the moment and there is no active
development in the directory.

Remove it to reduce the number of users of WebContentsObservers and
other content/public APIs and make changes to them (a little bit)
easier.

R=dfried@chromium.org

Change-Id: Ibba50f017a1ebf3b90eacf4392ea72413a97a113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085311Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747458}

Consider two windows (surfaces) one with DC layers enabled (A) and the
other disabled (B) and these sequence of events:

1) MakeCurrent with B
2) SetDrawRectangle on B. |g_current_surface| is null since B doesn't
   have a |dcomp_surface_| and B's |draw_texture_| is |swap_chain_| back
   buffer.
3) MakeCurrent on A
4) SetDrawRectangle on A. |g_current_surface| is A's |dcomp_surface_|.
5) MakeCurrent on B before SwapBuffers on A so that |g_current_surface|
   is not null

We will enter the `if (g_current_surface != dcomp_surface_.Get())`
branch and then `if (draw_texture_)` branch which will cause this crash.

The fix is to check that |dcomp_surface_| is not null before calling
ResumeDraw().

Bug: 1055909
Change-Id: I2d14d0713a51474ca757125a99a525b14ee0a568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090028
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747457}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3ccfc90f5032..99df04e8aa24

git log 3ccfc90f5032..99df04e8aa24 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 ehmaldonado@google.com git-cl: Check if author exists before adding to presubmit command line.

Created with:
  gclient setdep -r src/third_party/depot_tools@99df04e8aa24

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I2b065dd26545e6c4c61da18142dfe8c1d30c0645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090220Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747456}

Bug: 720034
Change-Id: I6afea3c8fe453ca5519f7255a5b24850aafed2d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089995Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747455}

Crostini tests were failing on E2 machines because there was no KVM available.
This CL requires that browser tests are run on machines that have a KVM.

Bug: 1058924
Change-Id: I9178dd5c8fb8e704e853c75c58cf5d0899c4c593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088408
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747454}

The current watchdog V2 has the same timeout value as V1. All experiment
code in V2 is removed.

Bug: 949839
Change-Id: I5f85d2ee538833234e328bbe2b98c2891e305a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083755Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747453}

This is dead code, no being built, and would fail to compile if it were,
due to the OnceCallback work.  It was added when we were planning to
experiment with throttling requests below the disk cache layer, but that
plan ended up not coming to fruition.  When the other code for the
project was removed, this was accidentally left in place.

Bug: None
Change-Id: I3b124af1b0872a178651cd8cfe4ddb2a37678a0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088017Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747452}

Keeping the grandfathered list separated with OWNERS restrictions
prevents adding new keys to it.

Change-Id: I829feaed50c1d426fbcea7785e253b6b1e7f7726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080203
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747451}

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I4e4b0225fcf8252e5fa7cad00efc60df6d2f1f59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087611
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Auto-Submit: Jose Lopes <jabolopes@google.com>
Cr-Commit-Position: refs/heads/master@{#747450}

Add an event converter to handle bluetooth stylus buttons.  Since we
only support one device so far, hard-code the key generated by
double-click.

Bug: b:139781900

Change-Id: I546845563b55f6001259cb198850e43a4e404156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079893
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747449}

This CL migrates font-display from feature policy to document policy.

Note: font-display-feature-polcy-01.tentative.html was migrated to document policy in a previous CL(https://chromium-review.googlesource.com/c/chromium/src/+/2017927)

Bug: 993790
Change-Id: Id4c822e0a42594ab75919819e4f1b78ca6a263f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036518
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747448}

Change-Id: I75d7a82c613c899a40dda56b61729c8e8b58ce90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071098Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747447}

Bug: 812428
Change-Id: I5960d158ff820180c8ecf320aaf3833c5aa675d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089989Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747446}

The unhashed |client_uuid| will be set in the system profile when
creating a MetricsLog alongside with the |client_id|.

Bug: 1058124
Change-Id: Ic0d1b98fa84e125d9667849f023e685c60ee59b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085634
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747445}

func_name has been removed in Python 3.
__name__ does the same thing and exists in both Python 2 and 3.

Traceback (most recent call last):
  File "../../third_party/blink/renderer/build/scripts/make_document_policy_features.py", line 38, in <module>
    json5_generator.Maker(DocumentPolicyFeatureWriter).main()
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 337, in main
    writer = self._writer_class(args.files, args.output_dir)
  File "../../third_party/blink/renderer/build/scripts/make_document_policy_features.py", line 19, in __init__
    def generate_implementation():
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\template_expander.py", line 76, in real_decorator
    generator_internal.func_name = generator.func_name
AttributeError: 'function' object has no attribute 'func_name'

Bug: 941669
Change-Id: Idc9654bfb71c2a0a53448ad81e680c6f460c8c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089842
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747444}

As preparation for NativeUnwinderAndroid, Chrome Module is injected into
ChromeUnwinderAndroid. Module are compared using their addresses.
The chrome module will eventually be created from proc/maps.

Bug: 989102
Change-Id: I3120c4e352fcefef577c4ef9d8c3e7ed7b5a370b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083439
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747443}

The test tries to tap the home button (using GetBoundsInScreen to get
the button location), but misses it in some cases (because it gets
coordinates that are outside the screen bounds).

This started flaking out when the navingation buttons bounds
animator was switched to use transforms instead of bounds - CL:2086257 -
when setting home button bounds without animation, ShelfNavigationWidget
would just set the new button bounds rect, without stopping any in
progress bounds animation. This works well if only bounds are animated,
but it doesn't stop the transform animation. So if the bounds are set
directly, the transform would keep animating, but transform would be
calculated relative to the actual target bounds.

BUG=1058514

Change-Id: Ib53f40bcb828ce4fce01364e02c48b8c28586b92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090460Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747442}

This is a speculative fix. But I think it has few / no side effects.

Not 100% sure what's causing this crash, but I have two theories:
 1. Perhaps navigation_handle()->GetWebContents() can return nullptr
    now. On Android only maybe?
 2. I think posting to the UI thread is wrong in any case, we should be
    posting to the current sequence, as otherwise dereferencing the
    weak pointer is invalid. (It's not sequence-safe).

Bug: 1058303
Change-Id: I75fcb86d58602d26e7b8d6991fd933b70881bd99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090300
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747441}

Notifications should be shown only when app limit has changed. To
know if app limit has changed at the beginning of each session, check
if the new limit's update is after the latest seen before. If so, show
notification.

Bug: 1056463
Change-Id: I5a66563898c46cbee1b91e30d2306cfc68efebce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086254
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747440}

This is a reland of b5018edf

Original change's description:
> [Offline indicator v2] Add Java animations
> 
> This CL implements the color and text transition animations that run when
> showing or hiding the status indicator.
> 
> Show:
> 1- Transition the status bar color.
> 2- Wait for the browser controls animation in cc to finish.
> 3- Fade in text.
> 
> Hide:
> 1- Transition the status bar and the indicator color.
> 2- Wait 2 seconds.
> 3- Fade out text, and transition the status bar and indicator color back
> to the original status bar color.
> 4- Let the browser controls hide animation run in cc.
> 
> Bug: 989148
> Change-Id: If19a51e6c5091436d78e34ef50f11ffa0118ee0d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067095
> Commit-Queue: Sinan Sahin <sinansahin@google.com>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747080}

Bug: 989148
Change-Id: I0bf7813c4ef7833d66e449863d16cc1068bc9572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090015Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#747439}

Upon receiving the updated metadata and position information for the
active media session from Media Session Controller, cras_audio_handler
will parse and repack the data for the audio client for further
processing.

Categorize the MediaSessionInfo::SessionState::kDucking to "playing"
instead of "stopped" for audio client.

BUG=b:147365593, b:147365793, b:147367068
TEST=chromeos_unittests

Change-Id: Iea65b931580b5725b807ae268958cf225e121195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088799Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Michael Sun <michaelfsun@google.com>
Cr-Commit-Position: refs/heads/master@{#747438}

Also, add warnings, because far too many people see a file with
alphabetized contents and then just drop their stuff at the end.

BUG=none

Change-Id: Ib2acab6ae1e4ff041ea8665790524a8494ca29eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087114
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747437}

Bug: 1007815
Change-Id: Ie29c204ced96f1975cb5f2c287dfb8a3a6a36325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089875Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747436}