- 26 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ba57aa2b4a60..d617d5d29ca5 git log ba57aa2b4a60..d617d5d29ca5 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 senorblanco@chromium.org Update DEPS: roll spirv-tools and spirv-headers. Created with: gclient setdep -r src/third_party/skia@d617d5d29ca5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I54b9e3965bfed4f21bfd88b0e0742a5aacd3967c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690383}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/c8c02a5f788c..3de7170b31c5 $ git log c8c02a5f7..3de7170b3 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 renjietang Maybe send SETTINGS for MaxPushIdFrame. 2019-08-23 renjietang Use real QPACK streams in QPACK stream tests instead of creating artificial ones. 2019-08-23 rch Change QUIC's AlpnForVersion method to omit the "google-" from the string to reduce the size of Alt-Svc advertisements which use this format. 2019-08-23 bnc Remove unused accessor. 2019-08-23 bnc Add knobs to QuicSpdySession for QPACK maximum table capacity and blocked stream limit. 2019-08-22 fayang gfe-relnote: In QUIC, add anti-amplification limit. Protected by version T099. 2019-08-22 rch gfe-relnote: n/a - Rename filtered_supported_versions() to filtered_transport_versions() in QuicVersionManager to match the name of the member variable. 2019-08-22 quiche-dev Deprecate --gfe2_reloadable_flag_quic_log_cert_name_for_empty_sct. 2019-08-22 fayang gfe-relnote: In QUIC, do not send control frames if connection does not have application keys for v99. Protected by quic_enable_version_99. 2019-08-22 fayang In QuicSentPacketManager, rename enable_pto_ to pto_enabled_. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I561c73d8f72584055896ae8c784d61ad1ce6655d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769543 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#690382}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 99bf5708. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 6a3beaa9 "[WPT/referrer-policy] Fix races around history.back()" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifb5a1ffcdf603c502935835a57dd94f59ccac597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771616Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690381}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6558fa5d64c4..4869bd6309bb git log 6558fa5d64c4..4869bd6309bb --date=short --no-merges --format='%ad %ae %s' 2019-08-26 asapersson@webrtc.org Add method CanAdaptUp based on bitrate to BalancedDegradationSettings. 2019-08-26 sprang@webrtc.org Removes deprecated InsertPacket/TimeToSendPacket/TimeToSendPadding Created with: gclient setdep -r src/third_party/webrtc@4869bd6309bb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: I869bf5990d94545241b7708ce33cfd913b66f166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771544Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690380}
-
Morten Stenshorne authored
For nested multicol we had some magic, so that we'd only consider the last child break token when resuming layout in an inner multicol. Get rid of that. Change-Id: I22837176695092655aea1db9eb607f83b7b44dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769438Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#690379}
-
Sergey Ulanov authored
Previously vkCreateImagePipeSurfaceFUCHSIA was resolved in VulkanImplementationScenic. Moving it to VulkanFunctionPointer makes it more consistent with how all other Vulkan functions are resolved. Change-Id: I20f2e394b0f529a5ebfedca5745c2c734b42e3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769231 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#690378}
-
Peter Kasting authored
* "Bitmap Array" files (OS/2) * BITMAPV2HEADER info headers (Photoshop?) * BITMAPV3HEADER info headers (Photoshop?) * BI_ALPHABITFIELDS compression (Windows CE) * 2bpp palettes (Windows CE) * Top-down bitmaps with RLE compression (illegal per spec, but supported by Windows and Firefox) * Truncated color palettes This increases the number of testcases Chrome can render on http://entropymine.com/jason/bmpsuite/bmpsuite/html/bmpsuite.html . Bug: 552274 Change-Id: I4c86b8328d326992a2ebca2e5178727aeab3afc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769524 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#690377}
-
Vasilii Sukhanov authored
On win it's also flaky with the same error: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/39888 TBR=juncai@chromium.org Bug: 997549 Change-Id: I5a6464aba2edff9d397581d103a1cc0d3548b772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768534Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690376}
-
Rune Lillesveen authored
System colors should resolve differently based on the used color-scheme value. See [1]. Ideally they should compute to the keyword to make inheritance work and have different used values for system colors based on color-scheme, but that needs to be resolved[2]. System colors are used for forms rendering. This CL is preparing for color-scheme specific forms rendering. Some places we use initial color-scheme in contexts where we have no ComputedStyle. These are typically offscreen canvas not connected to a particular element. It's possible we should use the root element computed value instead. The color interpolation needs to be fixed and I've added a TODO. Will follow up in another CL. No tests as there are no behavioral changes. [1] https://github.com/w3c/csswg-drafts/issues/3804 [2] https://github.com/w3c/csswg-drafts/issues/3847 Bug: 929098 Change-Id: Ie734e399c0dba82c59b221222c8e7ef365cae79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768139Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#690375}
-
arthursonzogni authored
Bug: None. Change-Id: Icdc78e4134664feb9fca3c27c907bec11b093466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768138 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#690374}
-
Vasilii Sukhanov authored
TBR=hta@chromium.org Bug: 997201 Change-Id: Iab008004a321cd54f8a4b3ff5cc6aabd7841a3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768470Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690373}
-
Vladislav Kuzkokov authored
Bug: 964919 Change-Id: I59ced1c7e2807b22e2ff9227cb2696822e8bea91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768632Reviewed-by:
Nikita Podguzov <nikitapodguzov@google.com> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#690372}
-
Nicolas Ouellet-Payeur authored
extractor.py outputs relative paths rather than absolute paths (like the clang-tool). This caused problems when running the auditor from anywhere else than the src/ directory. This CL updates MakeRelativePath() in the auditor to accept output from extractor.py, even when running from another location (as it does on CQ and waterfall). Bug: 966883 Change-Id: I3c69d682635af6ed378bc863e1886d643a6d5c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759061 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#690371}
-
Vasilii Sukhanov authored
TBR=kevers@chromium.org Bug: 997149 Change-Id: I726001d9f8ba39f87caaed3e0fb819d0765cbce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768773Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690370}
-
Josh Nohle authored
The CryptAuth v2 scheduler retries the first few consecutive failures after a short delay (~5 min). If more consecutive failures occur, the next attempts are scheduled after an extended delay (~12 hr). The number of retries with a short delay is specified by CryptAuth in ClientDirective.retry_attempts. Here, we fix an off-by-one error in the scheduler to adhere to ClientDirective.retry_attempts. Bug: 899080, 951969 Change-Id: I553ee42d878a722501a23bb6be66d299ffa6a21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753182Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#690369}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.PresentationService interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I807ca31efa84176c22224104fdfd810dac830451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764135 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#690368}
-
Vasilii Sukhanov authored
The test fails on Win and Mac. TBR=lazyboy@chromium.org Bug: 997686 Change-Id: I3214c57c4f8e75438794dc0250b108f5bef90269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768329Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690367}
-
Yi Gu authored
The failure on ChromeOS started when VizHitTesting was turned on by default and it should be fixed by crrev.com/c/1693442. Tested locally and the test is no longer failing. Bug: 997676 Change-Id: Ie4855e4ea0e3f10276671e9a9743b7c4ee4ae244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770039 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#690366}
-
Niels Möller authored
Intended to enable landing of https://webrtc-review.googlesource.com/c/src/+/149812 Bug: None Change-Id: I4ec2880c9804ae3c238076ea306def10f80a762c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768433 Auto-Submit: Niels Möller <nisse@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690365}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.PresentationReceiver interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I5b3db354a14cca90841a71df8e67cc778c53a1df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764188 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#690364}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.PresentationController interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I3dcc608a424d64e456d9b4cc4361bef0ca2c51d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764130 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#690363}
-
Finnur Thorarinsson authored
to UMA logging and UKM. Metrics review: https://docs.google.com/document/d/15na0QNN02V4IhfSphRjBazZJ218OxvmMD2BIgCscec4/edit Bug: 993775, 860467 Change-Id: I5e9be794b5841486edcee44a10c4516b0e498838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757940 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#690362}
-
Nico Weber authored
This is a reland of 02536c57 In the reland, use just '../' until https://crbug.com/997673 is fixed. Original change's description: > mb: Make check for generated `data` directories work on Win and enable there. > > The line `os.path.normpath(self.PathJoin(build_dir, f))` had two problems > on Windows: > > 1. Since `build_dir` was something like `//out/Release`, on Windows normpath > wouldn't resolve '..' against it, so `//out/Release/../../net/data` > would become `\\out\Release\net\data` > > 2. The slash flipping for `path` made the `path.startswith(build_dir)` always > fail. > > Just remove `path` completely and check if `f` starts with '../../' to find > directories that are not in the build dir instead. > > Also mixing stderr and stdout on Windows produced strange output, so print > the error message to stdout instead. > > The Windows build doesn't have any additional violations, so no new > whitelist entries are needed. > > Bug: 912946 > Change-Id: I4db9850103751b4736e5990caddddc9dd223786d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769205 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690259} Bug: 912946,997673 Change-Id: I672ba803530b749fd4f1a6888687360e59444a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769501Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690361}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.PresentationConnection interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: Ia52a7bf709a1497f84939531064ce17f3a558ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758443Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#690360}
-
Vasilii Sukhanov authored
external/wpt/css/css-animations/Element-getAnimations.tentative.html external/wpt/css/css-paint-api/custom-property-animation-on-main-thread.https.html TBR=futhark@chromium.org Bug: 626703 Change-Id: I7bdd807e50d1ee4a9c0382448dd216ea28855a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771400Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690359}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/afa3f633..bcfd55ce Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3c0f57526d0711ca40e7746147e74d6cdf4d29f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770237Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690358}
-
Alexander Hendrich authored
Since the created window has fixed size and is not draggable, multi-window support does not make sense anymore. We only ever expect there to be one login screen extension showing UI at a time. Bug: 957573 Change-Id: I90fcb01d3d8098abe2350c8773df03ce0cdedcfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768643 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Zakhar Voit <voit@google.com> Cr-Commit-Position: refs/heads/master@{#690357}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2ca0b3689f60..6558fa5d64c4 git log 2ca0b3689f60..6558fa5d64c4 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 saza@webrtc.org Reintroduce command line controlled reference data updating for ApmTest.Process 2019-08-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 318f298c..004b5082 (688507:690310) Created with: gclient setdep -r src/third_party/webrtc@6558fa5d64c4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I5c9a8c95d4957e0e5c0b43ba6946c464c3e390e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771540Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690356}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef4177b1f655..13847ac79387 Created with: gclient setdep -r src-internal@13847ac79387 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Ia32b6dff389b3ebedd4bb84ffaf0fb19045c5825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771539Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690355}
-
Dominic Farolino authored
The blink::ResourceRequest::priority_ member defaults to kUnresolved, which is unexpected by anything beyond ResourceFetcher. blink::ResourceFetcher::EmulateLoadStartedForInspector basically emulates a request from the inspector's point-of-view, however it doesn't set the request's priority. Once the inspector's BuildObjectForResourceRequest is invoked on this path, it calls ResourcePriorityJSON, which DCHECKs on unresolved priorities. This happens on debug builds, when the DevTools window is open, and a page is refreshed whose resources go through the EmulateLoadStartedForInspector path. Bug: 666214 Change-Id: I95d8df7193ab11e96ae210eb127146fb6ce9903c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768607Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#690354}
-
Yi Gu authored
The failure on ChromeOS started when VizHitTesting was turned on by default and it should be fixed by crrev.com/c/1693442. Tested locally and the test is no longer failing. Bug: 997676 Change-Id: Ie3b10fc2eb7a176ca2aa0a53cb02cd64c4da082b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770081 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#690353}
-
Yi Gu authored
The failure on ChromeOS started when VizHitTesting was turned on by default and it should be fixed by crrev.com/c/1693442. Tested locally and the test is no longer failing. Bug: 997676 Change-Id: I71892e0b1ffb1829f73fac3b5ee6572f770a4021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770080 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#690352}
-
Alexander Hendrich authored
So far the login screen extension UI window's dialog title was in the form of "This authentication service is hosted by <<<EXTENSION_NAME>>>", with <<<EXTENSION_NAME>>> being replaced by the extension's short name. Privacy (yzd@) requested to update the title so that the extension has no control over it, since a compromised extension could just have "Google" as its short name, which would lead to a misleading dialog title. Since the list of extensions being able to display login screen UI is very small, we will just hardcode the respective dialog title per extension. Bug: 997167 Change-Id: Iedd5b469df65cf1e125bcca5c5edc6bb71448e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768626Reviewed-by:
Zakhar Voit <voit@google.com> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#690351}
-
Vasilii Sukhanov authored
TBR=mrobinson@igalia.com Bug: 981913 Change-Id: I920c8c1fe841c46b6503cf0eace19c06bd3e6e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768532Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690350}
-
Guido Urdaneta authored
Prior to this CL, the state of the execution context (destroyed or not) was stored in a boolean field updated when the execution context was destroyed. After UserMediaClient/UserMediaProcessor was moved to Blink, the timing for the stopping of sources changed slightly. Instead of clearing state upon starting a new navigation, it is now cleared when the execution context is destroyed. If the dying context notifies UMC/UMP before notifying the MediaStreamTrack about the destruction it can happen that MediaStreamTrack tries to fire an event on the destroyed context without knowing that the context has already been destroyed. To prevent this from happening, instead of keeping the state of the context in a separate variable updated via ContextLifecycleObserver, we now track the context using a WeakMember. Bug: 996051 Change-Id: I0027c267a0d067ba67ffcf8f508c1bc56f36a72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768460 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#690349}
-
Kush Sinha authored
|CrOSOAuthDelegate| was renamed to |ProfileOAuth2TokenServiceDelegateChromeOS| but its unit tests were not. Rename the unit tests for consistency. Bug: 967602 Change-Id: I85fd3bc5dd601bea8301dd091194f391a07693b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771597 Commit-Queue: Kush Sinha <sinhak@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#690348}
-
Clemens Arbesser authored
This is a reland of 8667827a Original change's description: > [Autofill Assistant] Adds action to use login credentials. > > This CL extends SetFormFieldValueAction such that it can also fill a selector with a previously stored username or password. To this end, the action is refactored to allow for better code reuse and readability. Also, the CL adds unit tests (not just for the new functionality, but for the entire action). > > > Bug: b/128833341 > Change-Id: I43e57bee5681047f1df954040f62265e0ab44f28 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728560 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Stephane Zermatten <szermatt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689877} Bug: b/128833341 Change-Id: I87eadf3a335dec9244d5adf94cd004326ed52597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768422Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#690347}
-
Gabriel Charette authored
This is a reland of 0567f059 Reason for reland: - joelhockey@ fixed the chromeos build in https://chromium-review.googlesource.com/c/chromium/src/+/1767447 Original change's description: > Reland "Reland "Reland [base] Require task posters to specify an explicit destination"" > > This is a reland of d7b74986 > > As usual, if this fails **please** paste the build failure, not just > silent revert, logs can be hard to find in retrospect. > > Reason for reland: > - joenotcharles@ fixed the windows build in > https://chromium-review.googlesource.com/c/chromium/src/+/1764471 > - google chromeos build failure fixed in > https://chromium-review.googlesource.com/c/chromium/src/+/1764256 > > Original change's description: > > Reland "Reland [base] Require task posters to specify an explicit destination" > > > > This is a reland of dd34a877 > > > > Rebased on a few more fixes including a local full build of: > > - Windows + is_chrome_branded > > - ChromeOS + is_chrome_branded > > (except for the libassistant portion which is giving weird errors...) > > > > Original change's description: > > > Reland [base] Require task posters to specify an explicit destination > > > > > > This patch makes it a requirement for all task traits to specify their > > > thread affinity. Previously task traits that did not name a specific > > > thread would implicitly run on the thread pool, which could be > > > surprising. To make this more obvious, thread pool tasks must now use > > > the base::ThreadPool() trait. > > > > > > This is the final reland of > > > https://chromium-review.googlesource.com/c/chromium/src/+/1635827 > > > (will attempt to fix errors that caused original revert before > > > relanding). > > > > > > Bug: 968047 > > > Change-Id: Ice339db270a27815b2be68200930e5bc105e8a96 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759056 > > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > > Reviewed-by: François Doray <fdoray@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#688782} > > > > Bug: 968047 > > Change-Id: Iccd12e0a9f1535cb10b903777c5004a7d1acb34a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761362 > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689097} > > Bug: 968047 > Change-Id: Ie338781aba9b5f5990ffe74e02bb85f08fe683d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764398 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689665} Bug: 968047 Change-Id: Idca1ec9ef83aad51def481b2ed4f8f1baf1385da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769080Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#690346}
-
Vasilii Sukhanov authored
TBR=estade@chromium.org Bug: 997649 Change-Id: I3649c29efaa2343f97b5d27cd5c124a033882a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768326Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690345}
-
Friedrich Horschig authored
The spacing around the footer hasn't been consistent across all sheets. This CL generalizes the class that was introduced by two of the three sheets and uses this spacing class in all of them. To fully fix the footer spacing, overscroll is now extended from 8dip to 64dip as shown in the mocks in the linked bug. Bug: 997611 Change-Id: I33f813b174a887f496413240efeebdaea3844426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768466Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#690344}
-