- 14 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b71a96f818c6..08f4d59e0b17 git log b71a96f818c6..08f4d59e0b17 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 Jianning) Ding Decode the returned encoded bytes of subprocess.check_all/check_output. Created with: gclient setdep -r src/third_party/depot_tools@08f4d59e0b17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068779 Tbr: agable@chromium.org Change-Id: I59323b98c1d6f31cc004639eedc8bbcc5afe0fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758739}
-
Tanmoy Mollik authored
Currently ProfileDataCache doesn't support vector graphics. This cl replaces the use of Bitmap with Drawable in ProfileDataCache.BadgeConfige so that vector graphics can be provided to it. Also this cl adds a new factory method in ProfileDataCache to create an instance of this class with a provided badge resource id. Bug: 1064957 Change-Id: I23e5417611787f5d3d17f1a2b81c195bcea781ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130246 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#758738}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile without argument is getting deprecated. Use cases of this call that only refer to incognito or guest mode can use GetPrimaryOTRProfile() instead. All calls to this function in c/b/apps/platform_apps/* are updated. This CL does not make any behavioral changes. Bug: 1060940 Change-Id: I3b7c0abc5487711936a028549c21b28b8cc50fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135751Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#758737}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7c51f5914703..3ce8c96ad90a git log 7c51f5914703..3ce8c96ad90a --date=short --first-parent --format='%ad %ae %s' 2020-04-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-04-14 kimanh@chromium.org Add e2e test for setting a breakpoint in wasm Created with: gclient setdep -r src/third_party/devtools-frontend/src@3ce8c96ad90a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3809f6d0839c252d799a0296ca45b280041b925d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148487Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0574822f9f69..8a948a3e2b43 git log 0574822f9f69..8a948a3e2b43 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision edcfd61b..41d2eaa4 (758565:758687) Created with: gclient setdep -r src/third_party/webrtc@8a948a3e2b43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2f742a0242cadf8c8cdcccd05bb28d198dd9ae5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148486Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/297fffa4987b..a79a2f646d24 git log 297fffa4987b..a79a2f646d24 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 pwang@chromium.org telemetry: Make CrOSInterface::_GetMountSourceAndTarget more robust. Created with: gclient setdep -r src/third_party/catapult@a79a2f646d24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1057755 Tbr: sadrul@google.com Change-Id: I93b3a77795ebf290ec5e2866d335a083e619256b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148485Reviewed-by:
-
Yuki Yamada authored
Makes BeginFrameProvider a GarbageCollected class, and also makes BeginFrameProvider a GarbageCollectedMixin class. This was split into multiple CLs. Another CL: https://chromium-review.googlesource.com/c/chromium/src/+/2145746 Bug: 1049056 Change-Id: I0346e4db178b0cf85e08e2b4e54c961872457e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145739Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758733}
-
https://crbug.com/1006814Fergal Daly authored
Bug: 1006814 Change-Id: I2678fe90ca62b7940b49830233278c27bc39ee39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143180 Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#758732}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Id332b7292a6ca080760fd0cf0c62d29043200a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145745Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f17b60208fa..f50063625a0c git log 4f17b60208fa..f50063625a0c --date=short --first-parent --format='%ad %ae %s' 2020-04-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9d2fd9c161ab..711867566999 (3 commits) Created with: gclient setdep -r src/third_party/skia@f50063625a0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ic0a4e8d5ccf9594cb1e8fb268a55a07a505af837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148483Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I65ca59280e0c913bdb18eef57c9aeaa621f6adc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147480Reviewed-by:
-
John Z Wu authored
Also updated unit tests. Bug: 1069338 Change-Id: Ib5117cb42990020d4de14c7388141b26605115f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146140Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#758728}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/46572440189e..4d2298bfd78a git log 46572440189e..4d2298bfd78a --date=short --first-parent --format='%ad %ae %s' 2020-04-14 cnorthrop@google.com Support multiple swizzled out operands (#2175) Created with: gclient setdep -r src/third_party/glslang/src@4d2298bfd78a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I3e33b13608d183cdac6c15c4e5c1151c3ce05934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148479Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 41d2eaa4. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" 2f3bb77d "[device-orientation] Upstream web tests to WPT" d53acfce "[css-grid] Migrate positioned-grid-items-crash.html to WPT" 03a85d57 "[client hints]: Properly apply persisted accept-CH policy in 3P context" f064e48f "Make will-change: backdrop-filter a containing block for fixed and abs" c21ee9b0 "[css-masking] Migrate clip-path-descendant-text-mutated.html to WPT" 8ab053d0 "[css-flexbox] Move stretch-table-child.html test to WPT" c05b5149 "[css-flexbox] Move relpos-with-scrollable-with-abspos-crash.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I4c074bb4284f5581bc3c48fc7dcd36625e4e7aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144220Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758726}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a01816b0bae9..b71a96f818c6 git log a01816b0bae9..b71a96f818c6 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 yiwzhang@google.com Replace customzied test failure assertion with ResultReasonRE from engine Created with: gclient setdep -r src/third_party/depot_tools@b71a96f818c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I2700144d3fd99e32f695e7dc75c8d4b2ed628a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148477Reviewed-by:
-
Shakti Sahu authored
This CL adds : 1 - Submit query and show SRP on the last level tile click 2 - Shorten most visited tile section to 1 row for smaller screens Bug: 1068308 Change-Id: Icae29ad8bcc563ca6cfa3bfd35d18fa90ff65b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147041 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#758724}
-
Mitsuru Oshima authored
* Screenshot should still work if the power button is pressed first. Bug: 1024118 Test: Covered by unittests. Manually tested on Slate. Change-Id: I14c07d0f8419b5755776346d2c5f5e2e156861c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130638 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#758723}
-
Shakti Sahu authored
This CL attempts to create MVC for the fake search box. Fake search box is used from NTP and TasksView as well. Extracted most of the view details into properties. There are still a few issues specific to NewTabPageLayout where we directly try to set padding on the fake box. Bug: 1069194 Change-Id: Icaa919e2de302a8d398eb8fd42cb0afd1f6c7040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141200 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile without argument is getting deprecated. Use cases of this call that only refer to incognito or guest mode can use GetPrimaryOTRProfile() instead. All calls to this function in c/b/app_list/* are updated. This CL does not make any behavioral changes. Bug: 1060940 Change-Id: I886bead3bca36605f4c3aedc59707403850f0c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131628Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#758721}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b8d1780b324..7c51f5914703 git log 3b8d1780b324..7c51f5914703 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@7c51f5914703 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8ca2151100eac321ad76753b7d69825670d9c6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148474Reviewed-by:
-
Miras Myrzakerey authored
Bug: 1047624 Change-Id: I969e657025db1be7b9acc11a042a9fef4cb6cd66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061768 Commit-Queue: Miras Myrzakerey <myrzakereyms@google.com> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#758719}
-
Kenichi Ishibashi authored
Use structs instead. Bug: 1055677 Change-Id: Ic8aed9b67d352da33e0d6bc0c76525c3f2c1aa21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147432 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#758718}
-
Fergal Daly authored
This is mainly something to point at when sending CLs that fix tests for render document. TBR=arthursonzogni@chromium.org Change-Id: I6bbe153ac31f042f556d8f9247d2ca3e5e5de8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147131Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#758717}
-
Fergal Daly authored
This will allow us to detect if we are in the process of calling process-exit observers when the crashes in the bug occur. Bug: 1006814 Change-Id: I654b9bd3ce088d6b493dde70121c5401c1a9498f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145520 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Peter Qiu authored
With recent change [1] to use visible size instead of coded size for the picture buffers, the DCHECK to ensure picture buffer size and egl_image_size_ to be the same is no longer valid. Since |egl_image_size_| is the coded size, which can be different from visible size. So remove the DCHECK. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2122484 Bug: b/153606160 Test: Verify no DCHECK on Cast display device when using V4l2VDA Change-Id: I83772e29d8f21e0b3afece1fa9970d3c100fdc78 Fixed: 2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143491Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758715}
-
Miyoung Shin authored
CL migrates stale-grid-layout-2.html to external/wpt/css/css-grid/grid-model, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-layout-stale-002.html. BUG=1063749, 767015 Change-Id: Icffe3be03fc9cd8b333860f9f1a83a6be585b3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147434 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#758714}
-
Miyoung Shin authored
CL migrates Migrate stale-grid-layout.html to external/wpt/css/css-grid/grid-model, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-layout-stale-001.html. BUG=1063749, 767015 Change-Id: I7f16395435b29f9cc19571dfc8725eca1ca04c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147163 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Hongchan Choi authored
This CL adds the initial set of benchmark tests designed for Web Audio API. For the technical detail, see go/webaudio-perf (googler-only). Bug: 1052424 Change-Id: Id1ff5ac7c3a197f49e78965478f78fd2a82fa073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064824Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
Flash support will be removed in M88. See https://www.chromium.org/flash-roadmap. Update the plugin UMAs' expiry to M88 accordingly. Bug: 1037201 Change-Id: I50da167033601d202f46c32e424d29fdc4bc10c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146303 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#758711}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9d2fd9c161ab..711867566999 git log 9d2fd9c161ab..711867566999 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 capn@google.com Use the type and result ID helpers 2020-04-14 capn@google.com Obtain type ID from instruction 2020-04-14 capn@google.com Add helper methods for obtaining type and result ID Created with: gclient setdep -r src/third_party/swiftshader@711867566999 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I00c7aa0d72d1a14c129d6daa2df2b44080b24e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148099Reviewed-by:
-
Lei Zhang authored
In this case, GetPrinterHandler(PrinterType::kLocal) will never return nullptr. Also make all GetPrinterHandler() calls consistent, in that they save the result to a variable, which auto-formats better. Change-Id: Ic5b6a2f333d1b519e92aa399a325e30ce1dacb41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145868 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#758709}
-
Tetsui Ohkubo authored
In the standard Wayland protocol, null should be allowed for the icon argument of wl_data_device::start_drag. However, when nullptr was passed to the |icon| of DragDropOperation, ScheduleStartDragDropOperation would never be called, because couter_ assumed the icon was always present. This CL fixes that issue. TEST=manual BUG=b:64963392 Change-Id: Ibb504096c31ed6e0048c6fcf7038190db9498fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143177 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#758708}
-
Toby Huang authored
For supervised users, the kNewVersionApprovalGranted bucket in the SupervisedUsers.Extensions UMA histogram is only supposed to increment when an already-installed extension gets a version update. Currently, the enum increments every time the supervised user enables and disables the extension. This CL fixes the accuracy of this UMA metric. Moreover, SupervisedUserService::UpdateApprovedExtensions() currently gets called every time the extension is re-enabled. This operation is unnecessary and expensive because the function iterates over the entire map of approved extensions. This CL prevents this unnecessary operation from happening. Bug: 1068438 Change-Id: I521fca2bbb3d0bc83744d74e8d9abeb427864bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138637 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#758707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bed80858d3b..d9e072e138e6 Created with: gclient setdep -r src-internal@d9e072e138e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: I5dd78a00c1c44f2e86d69508917ed73e1e7332c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148209Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758706}
-
Lei Zhang authored
Pros: Consistent naming, smaller chance of naming conflict, can be forward declared. Cons: More casting required. Change-Id: Id2b11b1ebefe7fabaa03cb59edb39a77ce0c8b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145955Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I512bee0dbb638ce8d64f462bc0a4558c1801b1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148165Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758704}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e6e9fec904b8..5bc1f981df4d git log e6e9fec904b8..5bc1f981df4d --date=short --first-parent --format='%ad %ae %s' 2020-04-14 dhoss@chromium.org Add a helper to copy a ByteString to a buffer 2020-04-13 thestig@chromium.org Remove third_party/yasm from DEPS. 2020-04-13 thestig@chromium.org Roll third_party/libjpeg_turbo/ ce0e57e8e..7e3ad7980 (4 commits) 2020-04-13 thestig@chromium.org Add third_party/nasm to DEPS. 2020-04-13 thestig@chromium.org Fix nits in the DEPS file. 2020-04-13 tsepez@chromium.org Remove some needless locals from cxfa_ffwidgethandler.cpp 2020-04-13 tsepez@chromium.org Observe pagview across JS invocation in cpdfxfa_page.cpp Created with: gclient setdep -r src/third_party/pdfium@5bc1f981df4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1069700,chromium:766721 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2ec868838e528a83adbec69b7b1f1e00448e91eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148166Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I3057ee2bbc3c37113c3a7bf02d5b4cb7ab4fa276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147928Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758702}
-
Filip Gorski authored
This reverts commit 8dc3a74c. Reason for revert: Consistent failures on Android bots: https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel Original change's description: > Add pixel browser tests for focus rings > > Focus rings are rendered differently on different platforms, and the > platform specific differences are currently untested because layout > tests force a platform-agnostic focus ring rendering code path. This > browser test is needed in order to run the platform specific code. > > These tests need to be interactive_ui_tests because the window needs > dedicated focus in order to make the focus rings show up consistently. > > A similar test was added in the content layer in > http://crrev.com/c/1969772 > > Bug: 1038425 > Change-Id: I84ce398ab5d782e657cc13d0e073bf9997056bff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986972 > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758587} TBR=sky@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Change-Id: I804ffbeaee91c663e9bd93380e8edf7ea3aa21fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1038425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148472Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#758701}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e5287caf..834c6893 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I98dc51d47e487a6e6f31e9de735feeebb0d65cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148082Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758700}
-
