- 20 Dec, 2019 40 commits
-
-
Kurt Horimoto authored
This agent observes the OverlayPresenters at the kInfobarBanner and kInfobarModal modalities in order to update InfobarBadgeTabHelper state for infobar overlay UI interaction. DidShowOverlay() and DidHideOverlay() are used to update the badge item's presentation state. This BrowserAgent performs some ofthe functionality previously implemented via the InfobarBadgeUIDelegate protocol, which can be deleted once kInfobarOverlayUI is enabled by default. This CL also updates FakeOverlayPresentationContext to execute the presentation callback in ShowOverlayUI(). Bug: 1030357 Change-Id: I153d1a7e7b220587a2582faf29d0942dad6ead2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973104 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726962}
-
Eric Karl authored
A previous patch disallowed creating legacy mailboxes in threadsafe mode, but forgot to update unit test which tried to check this behavior. As tests are now fixed, re-enabling on P-bot (P+ is required for these tests) so we get coverage. Bug: 1034007 Change-Id: I33f36800b9edcecc7df57c20529d874d8a2cbe7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978753Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#726961}
-
Clark DuVall authored
This is a reland of 48f0e415 Original change's description: > [WebLayer] Allow passing command line arguments in instrumentation tests > > Switches all test to ContentJUnit4ClassRunner since it already has the > @CommandLine.Flags parsing bits set up. > > This also removes a sleep that was added because we couldn't pass > command line args before. > > Change-Id: Ic7e63c31e24d540af0bbf1dda58e800319a1d844 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975075 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726595} Change-Id: I135248418547a1185726f26217e2bbf13320aa6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979104Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726960}
-
Nikita Podguzov authored
Include chrome.printingMetrics html documentation to the list of available APIs. Bug: 992889 Change-Id: Icc12e3a7710e032a32d8e632cc0a3dc10a884cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976720Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726959}
-
Zhenyao Mo authored
BUG=1032907 TEST=manual R=kbr@chromium.org Change-Id: Ib55c09a71093b10d55fd31daf49f090da81cf6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975089 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726958}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I0e00da773ac5934bea8d938c91a40c0befb722da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726957}
-
Kurt Horimoto authored
This is a convenience factory method to create fake infobars with a specified type and badge support. Bug: none Change-Id: Ibc1c2df41d154b042a1d5e431450dbc2447f99a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977198 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
BUG=1006204 Change-Id: Ibf37042ed2e5f57671bcba707d83645d4713669e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979255Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#726955}
-
Yves Gerey authored
This cl removes the following dependency: //third_party/harfbuzz-gn (1) -> //components/paint_preview (2) Because for legacy reasons, (1) is rolled into WebRTC whereas for good reason (2) isn't. It will unblock chromium->WebRTC roll: https://webrtc-review.googlesource.com/c/src/+/162503/ currently failing with: ERROR at //third_party/harfbuzz-ng/BUILD.gn:9:1: Can't load input file. import("//components/paint_preview/buildflags/buildflags.gni") Bug: webrtc:11223, chromium:1031164 Change-Id: I67c75b3fc4cd8fa3daf93867f13209f785e7adf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978741Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
-
Mason Freed authored
With the [1] CL, the FormControlsRefresh flag was enabled by default for web_tests. To keep testing the disabled case, this virtual test suite will run the tests within the fast/forms directory with the flag disabled. Bug: 1035582 Change-Id: Ie635868c77d202c575ae5c0ce126575cae1d38e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976301 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#726953}
-
Andrew Xu authored
This reverts commit 988f969d. Reason for revert: Trigger the failure of around seven test cases in ash_unittests when enabling the hotseat flag. Original change's description: > overview: Grid bounds do not overlap with hotseat bounds. > > Test: added test > Fixed: 1026962 > Change-Id: I89e51a92bd8596e50099b755e48b355060fdd557 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970434 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725584} TBR=sammiequon@chromium.org,newcomer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I1e222e5aa5fa827c9a8a5d4522700a7e9af7737a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979128Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Andrew Grieve authored
And also unifies the timestamp logging approach across dex.py, compile_java.py, compile_resources.py via a build_utils.py helper. Looks like we should cache png->webp. Here's the output from chrome_apk: I 232916 29 Started D 232916 40 Extracting resource .zips D 232916 427 Applying locale transformations D 232916 598 Applying file-based blacklist D 232916 652 Converting png->webp D 232916 15519 Applying drawable transformations D 232916 16776 Starting: aapt2 link D 232916 16795 Created .res.info file D 232916 18066 Finished: aapt2 link D 232916 18072 Running: aapt2 optimize D 232916 18622 Creating R.srcjar D 232916 19088 Performing sanity check D 232916 19263 Copying outputs I 232916 19417 Job's done. Change-Id: I204cf6ad5e867b2ae83eb2a5f19efb00c14bc7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977060 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726951}
-
Stefan Zager authored
An idiom used by a few of the tests is to loop infinitely waiting for IPCs with the expected payload, ignoring IPCs with unexpected payload. This is a problematic structure, not least because test failures always manifest as a timeout. The loop-until-correct structure is meant to cope with the fact that the render process(es) do not synchronize lifecycle updates with the browser, so there may be race conditions associated with IPCs that are generated in the render process during lifecycle updates. A better way to handle this is to synchronize with the render process by forcing a lifecycle update via requestAnimationFrame; then waiting for all IPCs generated during the lifecycle update to be sent and received. EvalJsAfterLifecycleUpdate is a convenience method that blocks until a render process completes a lifecycle update. Once the browser synchronizes with the render process in this way, it can trigger an update in the render process, and then assert that the very next IPCs received by the browser contain the expected values. BUG=869758 Change-Id: I123d9fbe32015a9605c9d084faddd1bf7d3d8f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975455 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#726950}
-
Eric Stevenson authored
After this change, installing a TrichromeChrome or TrichromeWebview variant via. wrapper script (ex. out/bin/trichrome_chrome_bundle) will result in the required trichrome library version being installed first. The additional APKs don't support incremental install (only used for Trichrome library right now which doesn't support incremental). Uninstall is also not yet supported - it's a bit trickier since we likely want to make sure we don't accidentally uninstall a library that's used by another app on the device. Bug: 921288 Change-Id: Iefc6b5f06836395ef43c9c36a200b06beaac9da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972466 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#726949}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/816132a33463..abc8f2777133 git log 816132a33463..abc8f2777133 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 ianelliott@google.com Vulkan: Disallow multisampling with a sample count of 1 2019-12-20 jonahr@google.com Skip all Metal dEQP tests Created with: gclient setdep -r src/third_party/angle@abc8f2777133 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ib80241afb79f03890bef7fac5a8d7163897c2c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979130Reviewed-by:
-
Evan Stade authored
This moves WebLayer-reusable jsdialog code to //components/app_modal/. Despite the confusing name, this component is where cross-platform app modal and javascript dialog code lives, and the new android/ directory lives alongside views/ (where desktop UI code lives). Later, relevant native code such as JavascriptAppModalDialogAndroid will also be added to //components/app_modal/. To sever dependencies on ChromeActivity, WindowAndroid is given a new method getModalDialogManager(). For ChromeWindow, CrWindowAndroid, and SearchActivity's anonymous ActivityWindowAndroid subclass, this simply passes through to the activity's getModalDialog(). In the future, we may want to move ownership of the ModalDialogManager, but for now ownership is unchanged. Two new strings targets are introduced. . Strings unique to javascript dialogs are moved from //chrome/browser/ui/android/strings to //components/app_modal/android. These strings were and still are duplicates of strings in //components/app_modal_strings.grdp, but including the monolithic components_strings_grd leads to lots of UnusedResource warnings. . Generic strings are moved from //chrome/browser/ui/android/strings to //components/browser_ui/strings/android. These also happen to be duplicates of strings in components_strings.grd, but sharing has the same issue mentioned above. . Blank xtb files (which will automatically be replaced as part of the translation flow) were generated with this script: https://pastebin.com/7dxGc7JW TBR=agrieve@chromium.org,yusufo@chromium.org Bug: 1025256 Change-Id: I9630f511005adf16776bbfd21e195faa226ab9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966700 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#726947}
-
Brian Sheedy authored
Sets up "Linux FYI SkiaRenderer Dawn Release (Intel HD 630)" and its manual trybot counterpart. Bug: 1024385 Change-Id: I2fc6ed1a6692ba7ab8275be9accb07773efdb6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974575 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726946}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ab210f92a84f..6e3a387c0159 git log ab210f92a84f..6e3a387c0159 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 capn@google.com Exclude padding bytes from image size limit Created with: gclient setdep -r src/third_party/swiftshader@6e3a387c0159 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:835299 Tbr: swiftshader-team+autoroll@google.com Change-Id: Iec1192fd76f85c7b4bf69a7f2f62c958f5b11086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979131Reviewed-by:
-
Archana Simha authored
Design Doc: http://go/extensionscheckupmetrics Bug: 1034541 Change-Id: Ie29b858206e2570c13a4442ed53db0c7ec18cc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965996 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#726944}
-
Chris Harrelson authored
And in particular, don't do it earlier. Previously we independently pixel-snapped (most of) the various inputs to sticky position offset when committing from Blink to cc. This had two remaining problems: (a) failed to pixel-snap StickyPositionConstraint.{top|left|bottom|right|_offset} (b) possibility of aggregated pixel snapping errors due to pixel snapping multiple inputs and then adding them together. The new approach is much less fragile, and guarantees an integer sticky position offset. It is also likely numerically more accurate. Issue 1035232 was caused by (a). Bug: 1035232 Change-Id: I25bef08ad078e06c65dc0e79dcf460fad219fcdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977142Reviewed-by:Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726943}
-
Denis Kuznetsov authored
Bug: 1030832 Change-Id: Ib6003711ca80cded6a028c453661778278afae37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978684Reviewed-by:
-
Samuel Huang authored
TBR=agrieve@chromium.org Change-Id: I35897c00fc044f9662640d910324fe941764b498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979250Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5acd2910. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." db8e5d7d "Enable file uploads in web_tests via testdriver-vendor.js." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-break NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6cfde0cecb82273b1ee9fe0d373634cebd45ba76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978421Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726940}
-
Mia Glaese authored
Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1960080 Before: Tabswitcher toolbar is not hidden when focusing omnibox in incognito. Voice recognition button sometimes disappeared in normal mode when closing all Incognito tabs from notifications. After: Tabswitcher toolbar hides when focusing omnibox in incognito. Voice recognition button visibility is updated. Bug: 1031973, 1034867 Change-Id: Id5f9c694501b7b52f7710ad97491d82fe1b3acdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978876Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#726939}
-
Nikita Podguzov authored
This CL adds: * IDL declaration of getPrinterInfo() function * Its implementation * Unit tests covering this function * API integration tests covering this function Bug: 996785 Change-Id: I6c7475905c54bf58dc5265fb50a1bb488a83a8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917222Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726938}
-
Daniel Murphy authored
Bug: 1036449 Change-Id: I8bcc05ff972f6324cbace565fd0df7c1cbc0a16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978903 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#726937}
-
Peter Kotwicz authored
This CL: - Moves logic to launch WebappActivity to test rule so that it does not get run on KitKat (both of the WebappActionsNotificationTest tests are M+) - Increases the timeout for WebappActivityTestRule#waitUntilSplashHides(). Hopefully this will reduce test failures due to WebappActivityTestRule#waitUntilSplashHides() timing out BUG=1031094 Change-Id: I8cc1cec080460f74b0282fb472e471f11872df6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977188Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#726936}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2fad846c0b1c..c15afe488bfa git log 2fad846c0b1c..c15afe488bfa --date=short --first-parent --format='%ad %ae %s' 2019-12-20 reed@google.com move SkClipStack::asPath into PDFUtils 2019-12-20 michaelludwig@google.com Arenas struct for GrRecordingContext Created with: gclient setdep -r src/third_party/skia@c15afe488bfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I4e2d3483939660923f0f3aada15fa80d97551a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979129Reviewed-by:
-
Sajjad Mirza authored
On Windows it is possible for the coverage tryjob to compile a target that includes clang_coverage.cc but does not instrument any files. This causes a link-time failure, as clang_coverage.cc refers to __llvm_profile_dump, but with no instrumented files the compiler will not include the profile runtime library into the target. The symbol remains unresolved. To work around this, we can force coverage instrumentation for the clang_coverage.cc file itself, thus ensuring that any target that includes it will always have the profiling runtime pulled in. Bug: 990480 Change-Id: Ia6e1f003baaac4a050eec235942aa5a5e345ec52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978036 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#726934}
-
Tommy Li authored
This adds accessibility strings, just like the Tab Switch button has. It adds two PREFIX variants for when the button is focused. It doesn't add the SUFFIX variant, because so many suggestions have the removal feature, we don't want to be constantly announcing it. There are no screenshots because this is just a accessibility TTS announcement, with no graphical representation. Bug: 1036453, 1205 Change-Id: I0c2eac9fb2ba52e9ce01afa6e3e1d45f75bc0491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979286Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#726933}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f58f69f66bac..2cb76ab598e5 git log f58f69f66bac..2cb76ab598e5 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 enga@chromium.org perf_tests: Manually serialize JSON and remove dependency on jsoncpp 2019-12-20 enga@chromium.org perf_tests: Fixup perf test result printing format 2019-12-20 bryan.bernhart@intel.com Support for small resource placement for MSAA textures. Created with: gclient setdep -r src/third_party/dawn@2cb76ab598e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib858cede3b9a8bb141316b742d131f38bdbc9d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979127Reviewed-by:
-
Vitaly Buka authored
We are going to need attribute outside of blink as well. Bug: 977230 Change-Id: I5417c56a0c4b5b99211ea74b0489e52ea19a5ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974951Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#726931}
-
Pavel Yatsuk authored
BUG=1033590 TBR=gambard@chromium.org Change-Id: I62d7d7ea2a35415cb787692c6afa5c7990f5157e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965971 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#726930}
-
Yue Li authored
With the Assistant launcher UI and new shelf design feature turned on, if the Assistant is triggered in tablet mode the shelf style will be changed back to "home shelf". Added an additional check in ShelfConfig for the Assistant state to handle this case. Bug: 1026727 Test: Manual Test Change-Id: Ie9ca0980583117e5b17d21fa9257f91f3ebe5647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975114 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#726929}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers components/flags_ui/ Fixed: 1007691 Change-Id: I467a2c4866c6bd8498b4e74bfe31a81417f8d69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978818 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726928}
-
Andreas Haas authored
There is no user of this function anymore. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I093e96cbcc584495f176f1c53592e862ada98728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976470Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726927}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d3cd4926..129defb3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84511652dd5d1e62576d1ed7c92ba6f9a3559d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978420Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726926}
-
Jordan Bayles authored
https://chromium.googlesource.com/openscreen/+log/2b02e3287584..2c5e3d4c9d60 $ git log 2b02e3287..2c5e3d4c9 --date=short --no-merges --format='%ad %ae %s' 2019-12-12 rwkeane DNS-SD: Add HardRefresh Support 2019-12-18 jophba Fix chrome build 2019-12-18 rwkeane mDNS: Batch Announce + Goodbye Records 2019-12-18 rwkeane mDNS: Probe Skeleton 2019-12-18 rwkeane mDNS: Add NSEC record type 2019-12-17 btolsch Add receiver authentication steps 2019-12-16 btolsch Fix gmock build dep 2019-12-10 jophba Update Receiver ownership 2019-12-16 rwkeane Discovery: CastV2 Struct 2019-12-16 rwkeane mDNS: Support Truncated (TC) Bit 2019-12-12 rwkeane mDNS: Add validation on incoming query results 2019-12-12 rwkeane DNS-SD: Add support for updating registrations 2019-12-11 rwkeane mDNS: Add Querier HardRefresh Support 2019-12-11 jophba Disable fuzzing in Chrome 2019-12-11 rwkeane Discovery: mDNS + DNS-SD API Skeletons required for discovery 2019-12-10 rwkeane mDNS: Publisher Impl - Announcement Flow 2019-12-04 jophba Add ANSWER message sending to ReceiverSession 2019-12-10 jophba Revert "Upgrade Mac bot to 10.15, to auto-upgrade compiler/toolchain." 2019-12-09 miu Upgrade Mac bot to 10.15, to auto-upgrade compiler/toolchain. 2019-12-06 jophba Remove Json(Reader|Writer) in favor of namespace 2019-12-05 miu Cleanup platform/BUILD.gn to mirror DEPS relationships. 2019-12-05 rwkeane mDNS: Responder Bug Fix 2019-12-05 rwkeane mDNS: Publisher Impl - Registration flow 2019-12-05 rwkeane mDNS: Responder Impl 2019-12-03 jophba Add ANSWER messaging 2019-12-05 btolsch Respond to post-commit virtual connection router comments 2019-12-04 miu Clean-up: Use Alarm::ScheduleFromNow() in a few places. Created with: roll-dep src/third_party/openscreen/src Change-Id: Id4150af44a9ae0d3f21b181a6699df54f3080352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977146 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726925}
-
Dave Tapuska authored
As per updated explainer changes restrict to same frame or noopener navigations. BUG=872777 Change-Id: I8a9fca087c767afaba26bd3cade28b3bbe0cc3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979004Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#726924}
-
Eugene But authored
Bug: None Change-Id: Ib48589c9afe90c933a84706fdde04fc0e53095df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977180 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726923}
-
