- 04 Apr, 2018 40 commits
-
-
Esmael El-Moslimany authored
Bug: 698694 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I55642580b173c544659cceee504ecef035047d9b Reviewed-on: https://chromium-review.googlesource.com/992869Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#547931}
-
Tsuyoshi Horo authored
Bug: 768705,788621 Change-Id: I0e0b2eb03da7c6c65e871db94c836ac4c06a46e6 Reviewed-on: https://chromium-review.googlesource.com/994493Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547930}
-
Dave Schuyler authored
This CL is a step toward making views children manage their views. This step moves the data members, but still does the layout in the result view. A later Cl will move the layout. Bug: None Change-Id: I82c498c0ae648b57d750828f687d9064ccee29dd Reviewed-on: https://chromium-review.googlesource.com/994243 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#547929}
-
Andrii Shyshkalov authored
Testers: * "Mac Release (Intel)" * "Mac Retina Release (AMD)" R=hinoka@chromium.org, kbr@chromium.org Bug: 790063,790077,790066 Change-Id: I4a6fb8e97e7bae5462771d9d0a91cd3f02ebd095 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/994119 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#547928}
-
Kent Tamura authored
* Change the default log level from DEBUG to INFO * Change some logs from info() to debug() * Show "Update ..." log only if a file is actually updated. * Remove a raw |print| statement. Bug: 578345, 767672 Change-Id: I6fa6e5f548cd48bf7bad38795db7f3828f045d61 Reviewed-on: https://chromium-review.googlesource.com/991340Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#547927}
-
Emily Hanley authored
Bug:827663 Change-Id: I297b5307d40630bcbede26206cd449649d75876a NOTRY=true # Flake Change-Id: I297b5307d40630bcbede26206cd449649d75876a Reviewed-on: https://chromium-review.googlesource.com/992635 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#547926}
-
Bence Béky authored
Bug: 819101 Change-Id: Ic5070b5c26313a6b4c991abfc83228f9ef12f99b Reviewed-on: https://chromium-review.googlesource.com/990532Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#547925}
-
Kent Tamura authored
We don't need to update #includes in generated files. Bug: 578345 Change-Id: Ib559f672d1aa535967a71143bf56131dca890e1d Reviewed-on: https://chromium-review.googlesource.com/991272Reviewed-by:
-
Xianzhu Wang authored
The situation doesn't cause corrupted rendering but just slightly affects performance. It's fine not to DCHECK given that the situation is rare. Bug: 805024 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iac8cd617d5df51da2516fc6a9df1308a0daaedd0 Reviewed-on: https://chromium-review.googlesource.com/990074 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547923}
-
Stephen Lanham authored
Introduce better lifetime management for BluetoothAdapterCast, allowing the Cast embedder code to inject a factory for this class. This prevents potential races at destruct time. Also wires up the code to make Characteristic notifications work. With this patch (and some hacks in content), a JS application can receive notifications successfully. BUG=827672 Bug: b/75967216 Test: test page Change-Id: Idb8a1ba2c9ad94a80940083d31e307b3506f98e6 Reviewed-on: https://chromium-review.googlesource.com/988265 Commit-Queue: Stephen Lanham <slan@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#547922}
-
Tom Anderson authored
The check for GTK 3.20 was incorrect as the issue it was trying to fix was still occurring on GTK 3.20+ systems. This CL adds the correct, but more complex, check. Verified on these configurations: {GTK 3.18, GTK 3.22} X {Breeze, Adwaita, OSX-Arc-White, Greybird} X {scale=1, scale=2} X {fullscreen, restored} BUG=821881 R=thestig Change-Id: I05afa35c1452a46a1abf4c39191a13657bfd8e2c Reviewed-on: https://chromium-review.googlesource.com/990717Reviewed-by:Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547921}
-
Kyle Horimoto authored
Previously, CryptAuthEnrollmentManager::Observer was a pure-virtual class; however, not all observers override all observer functions, resulting in the need to define empty callback implementations for all derived classes. This change is in preparation for adding yet another observer which does not need to override all observer functions. Bug: 824568, 752273 Change-Id: I036c720f0331167a15fb0a36e1f4e7c19a6ac356 Reviewed-on: https://chromium-review.googlesource.com/994288 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#547920}
-
Alex Newcomer authored
Per request from UX: - Remove the hover highlight which is shown when a context menu is shown using mouse. It is only to be used for keyboard focus movement. Also in this cl: - Only send the SEND_GESTURE_EVENTS_TO_OWNERS run type when required (when the source type is touch). This fixes crbug.com/826939 Bug: 826943 Bug: 826939 Change-Id: Iad31bf5695e88a1bc69efb648664692f01067109 Reviewed-on: https://chromium-review.googlesource.com/991154 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#547919}
-
Hiroki Nakagawa authored
This CL reorders test expectations for off-main-thread WebSocket to clarify whether they are failing because of the experimental implementation or other reasons. Bug: 825740 Change-Id: Idc8cbf42b64966d4d01fef119d45fcca20c7f43e TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/994432Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#547918}
-
Eric Roman authored
Change BlockableProxyResolver to use a single ConditionVariable rather than multiple WaitableEvents. This simplification turns incorrect call sequences into a test failure rather than a data race. Change-Id: I8333ba47fd269559f55da2252a8f76895beb571d Reviewed-on: https://chromium-review.googlesource.com/988741Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547917}
-
Daniel Bratell authored
There are several classes/types named Display so to get the X11 one, you have to specify it with ::Display (gfx::Display is a common alternative when you're inside the gfx namespace). TBR=hubbe@google.com Bug: 822068 Change-Id: I402b7ad2d37a82d3091577733f3f06e673c29c7e Reviewed-on: https://chromium-review.googlesource.com/994212 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#547916}
-
Peter Kasting authored
This allows tests that want to provide mock implementations of these objects to just override what's necessary to change functional behavior, not provide boilerplate simply to instantiate the objects at all. BUG=none TEST=none Change-Id: I0b3ccc6da2ae2b3a87789c06d427cae227a2d662 Reviewed-on: https://chromium-review.googlesource.com/987326 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#547915}
-
Blake O'Hare authored
This unit test is redundant with VirtualKeyboardRootWindowControllerTest_FollowInputFocus which uses a test DisplayManager utility to properly mock the displays. The problem with the ui/keyboard unit test is that it simply mocks windows and treats them as root windows. I'll be following this CL up with more changes that use displays instead of just root windows and if this isn't removed, it will start failing. Change-Id: I20b5c8dfb947211161b7cd761390bc8a76229370 Reviewed-on: https://chromium-review.googlesource.com/991893Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547914}
-
Andrii Shyshkalov authored
Testers: * "Mac Release (Intel)" * "Mac Retina Release (AMD)" R=kbr@chromium.org Bug: 790063,790077,790066 Change-Id: Id7bdaa570abd2bae90051d6389f24a1f66426ed4 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/994534 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
Bug: 824562 Change-Id: Ib7af477a49036204517d6115e45cba2ce721ef2b Reviewed-on: https://chromium-review.googlesource.com/984037Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#547912}
-
Kent Tamura authored
Add snake_case per-file lines as well as CamelCase per-file lines in OWNERS files in //third_party/WebKit This is a preparation to rename all C++ files in //third_party/WebKit. A follow-up CL will remove CamelCase per-file lines. Bug: 768828 Change-Id: I398d3a8447f1f4fd025438310915b9f312b8c494 Reviewed-on: https://chromium-review.googlesource.com/991792 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Kent Tamura authored
Bug: 578345 Change-Id: I4da3ad3167bb8317c4273c832aac3e4308610c06 Reviewed-on: https://chromium-review.googlesource.com/991313Reviewed-by:
-
Chris Nardi authored
MediaList.appendMedium was able to throw an exception, but MediaQuerySet::Add() always returned true, making it impossible for that exception to be thrown. This matched the spec, as |appendMedium| cannot throw an exception. Remove the dead code surrounding the possible exception, and make MediaQuerySet::Add() return false if the medium is not added. Also remove the TODO as deleteMedium can throw an exception per the spec. Change-Id: I32c1b7b3ac90812ce036273e9c1c56f6d65c0af2 Reviewed-on: https://chromium-review.googlesource.com/993398 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#547909}
-
sczs authored
- Moves out the HistoryService and Driver creation from HistoryCollectionVC to HistoryPanelVC. Because of this HistoryCollectionVC will have less model responsibilities. On the new implementation this responsibilities will be owned by a Coordinator instead of a parent VC like HistoryPanel. Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I749be91308ed35eb8d08a2a9f6c4bf984eb8bb79 Reviewed-on: https://chromium-review.googlesource.com/991253 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547908}
-
Andrii Shyshkalov authored
Testers: * "Mac Release (Intel)" * "Mac Retina Release (AMD)" R=kbr@chromium.org Bug: 790063,790077,790066 Change-Id: Iebe7718ee74428f7d1f89d590ca59c8b1dacd524 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/994114Reviewed-by:
-
Pete Williamson authored
Bug: 758690 Change-Id: I829790f7f53d97b4717b653b3eeae9065387e7ad Reviewed-on: https://chromium-review.googlesource.com/994336Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#547906}
-
Xiaocheng Hu authored
This reverts commit 797a3802. Reason for revert: The overall approach is a hack that keeps generating regressions Original change's description: > Eliminate NOSCRIPT element from TranslateHelper text dump > > TranslateHelper uses a sample of the page text to determine the page > language. This patch eliminates content of NOSCRIPT elements from the > text dump, so that non-text contents in NOSCRIPT elements are not passed > to TranslateHelper. > > Bug: 813009 > Change-Id: Icf1781a69d17538103574bd149cb3d5851852a08 > Reviewed-on: https://chromium-review.googlesource.com/924111 > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537557} TBR=groby@chromium.org,eae@chromium.org,tkent@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 813009 Change-Id: Ibb2557436cdb5b07586bc69177f1456dc435568c Reviewed-on: https://chromium-review.googlesource.com/994059Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547905}
-
Peter Kasting authored
This avoids instantiating a real InfoBarService in tests that don't need it, which will in turn avoid constructing platform-specific InfoBar instances, which will in turn prevent crashes in an upcoming change where I make the views-specific implementation rely on objects these tests don't create. This also addresses my followup comments on https://chromium-review.googlesource.com/c/chromium/src/+/953711 . BUG=none TEST=none Change-Id: Iab027693b982db7b91a3be8681647a112ba86e9e Reviewed-on: https://chromium-review.googlesource.com/989213Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#547904}
-
Fady Samuel authored
This CL makes progress on a number of fronts. This CL makes progress towards enabling viz::LocalSurfaceId allocation on the child renderer process by allocating a new LocalSurfaceId when auto-resize is enabled. This is accomplished by moving auto-resize from RenderViewHost to RenderWidgetHostView. This allows the behavior to be async and for child frames to call out to the parent renderer to request a new parent-allocated LocalSurfaceId when that state changes. This CL pulls out ResizeParams in BrowserPlugin and RenderFrameProxy and moves them one step closer to unification with content::ResizeParams by adding some more properties that are in common with content::ResizeParams for auto-resize. Change-Id: I63749d8a652630f4b2bf3500660081e6c093c935 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/991602 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#547903}
-
bsheedy authored
Adds support for saving shared preference files to the encrypted data directory in the instrumentation test runner and VR Telemetry tests and sets the VR shared preference files to use this new functionality. Prerequisite Catapult change is at https://chromium-review.googlesource.com/c/catapult/+/986951. Bug: 826501 Change-Id: Ie51003fac40536c77b5814076ae67c4a153ed31d Reviewed-on: https://chromium-review.googlesource.com/986926Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547902}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/668c1d8d1f1a..adcf030f6910 $ git log 668c1d8d1..adcf030f6 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 agable Continue the story 2018-04-03 ehmaldonado roll_dep: Make roll_dep.py use gclient_eval instead of regexes. Created with: roll-dep src/third_party/depot_tools BUG=chromium:828154,chromium:760633 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia25847fe34f0686dd3c1edc3176bc8a7135f3d1f Reviewed-on: https://chromium-review.googlesource.com/994055Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547901}
-
Fabio Tirelo authored
With the introduction of the 3p removal trigger, the concern is that subtitles make the card too heavy, so we are simply removing them. Bug: 816666 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I48fc29fac751c6fe54a3e7c87567d14bcf7f4f6c Reviewed-on: https://chromium-review.googlesource.com/938625 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
-
sczs authored
Since [mediator initObservers] users the Browser state we need to set it before calling this method. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I757b5c28f48c782b5984212ad39a7f27e643d21f Reviewed-on: https://chromium-review.googlesource.com/994137Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5138441.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "5138441.html" to "indent_before_blockquote.html". Note: "5138441.html" is failed on layout_ng bot due by pixel test. Bug: 679977, 636993 Change-Id: Id82a24a4b2c742fe729b1696ad428085965ee300 Reviewed-on: https://chromium-review.googlesource.com/991697Reviewed-by:
-
Dan Harrington authored
Thumbnails are downloaded when a prefetched page finishes downloading. This CL also adds thumbnail methods to OfflinePageModel. Bug: 794828 Change-Id: I91263c58028d2b18dba22d33ee9964e909a0823e Reviewed-on: https://chromium-review.googlesource.com/985205 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#547897}
-
Paul Meyer authored
Since interventions actually block or change browser behavior, their messages should be reported as errors rather than just warnings. Bug: 564071 Change-Id: Id8f1110466f127903bd362c4c7ada454aa3df0d6 Reviewed-on: https://chromium-review.googlesource.com/985028Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#547896}
-
Kyle Horimoto authored
When a device registers to use the CryptAuth back-end, it sends a GcmDeviceInfo proto message. Before this CL, this was done from within ChromeCryptAuthService, which resides in //chrome. In order to share this code with the in-progress DeviceSync service, this CL refactors this code and moves it to a new location where it can be shared between both clients. Implementation is split between a pure-virtual GcmDeviceInfoProvider class living in //components/cryptauth and an implementation which has //chrome dependencies in //chrome/browser/chromeos/cryptauth. This separation is necessary so that the DeviceSync services, which resides in //chromeos, can utilize this class behind an interface. Bug: 824568, 752273 Change-Id: I0b5a4401809185cf3beef7e95cc1a68c369eaa79 Reviewed-on: https://chromium-review.googlesource.com/991234Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#547895}
-
Yoshifumi Inoue authored
This patch changes "focus-body.html" to utilize |selection_test()| for ease of maintenance. Note: "focus-body.html" is failed on layout_ng bot du by pixel test. Bug: 679977, 636993 Change-Id: I6c3be17a3b92aab4fff714fc7798a2b323d97d52 Reviewed-on: https://chromium-review.googlesource.com/992076Reviewed-by:
-
John Budorick authored
Bug: 776495 Change-Id: Ie982fe018f7f075c7e3c335cfb0b0b0eae62dbc5 Reviewed-on: https://chromium-review.googlesource.com/994413Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547893}
-
Yoshifumi Inoue authored
This patch changes "editable-inline-element.html" to utilize |selection_test()| for ease of maintenance. Note: "editable-inline-element.html" is failed on layout_ng bot du by pixel test. Bug: 679977, 636993 Change-Id: Iba8e093c7dccd28be883b43dbcfd19fd72b46add Reviewed-on: https://chromium-review.googlesource.com/992012Reviewed-by:
-
