- 01 Aug, 2018 40 commits
-
-
Eric Roman authored
Bug: 869495 Change-Id: I96b3eb4e72b3c46b94bdafcbc4daaf0d9466b35b Reviewed-on: https://chromium-review.googlesource.com/1159175Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579927}
-
David Tseng authored
ChromeVox now imports the SRE as a third party library. Previously, ChromeVox shipped with a large number of unicode translations for English. Much of this is actually already handled by the underlying tts engine, which can also do a better job of localisation (given the right voice is selected). This change also tries to fix recent Closure compiler errors as of the latest update to Closure compiler. Change-Id: Idb9362c8760bf0fa6ce0c1a1a03a29c5a7452871 Reviewed-on: https://chromium-review.googlesource.com/1159099Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#579926}
-
Alex Moshchuk authored
We have collected the data we need and found the likely cause of crashes. Bug: 794625 Change-Id: I1e730b27e17b916bec6bbbe20b7734f2b81481db Reviewed-on: https://chromium-review.googlesource.com/1158721Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#579925}
-
Peter Collingbourne authored
Bug: 855193 Change-Id: I2e30bd2e6188a7695b469955c896dd5900fb1793 Reviewed-on: https://chromium-review.googlesource.com/1157545Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579924}
-
edchin authored
It is possible that the navigation completes in the time it takes to animate to the tab grid. The navigation completion will trigger another snapshot. But that snapshot may have the previous webpage because the rendering is not guaranteed to have been completed at navigation completion. This CL implements a pausing/resuming mechanism so that we pause snapshotting when animating to the tab grid while the webpage was loading. We resume snapshotting once the animation to the tab grid has completed. This CL also fixes the snapshot going blank for a second while animating to the tab grid. Bug: 853569, 862799 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib6f5cf1ca896c06940c7ce142518b94ffb3c7d37 Reviewed-on: https://chromium-review.googlesource.com/1156135 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579923}
-
Reid Kleckner authored
Bug: 866225 Change-Id: I11d97d9a97432a1abb97e69a1395948b9d3e19fe Reviewed-on: https://chromium-review.googlesource.com/1157290 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579922}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I9cc14f7277eb4ddad9add50a333f106b27b6ebd2 Reviewed-on: https://chromium-review.googlesource.com/1159186Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#579921}
-
Lei Zhang authored
Change-Id: I199d5c97e50be57f9dd0ca08e16f75e5c4315e95 Reviewed-on: https://chromium-review.googlesource.com/1157922Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#579920}
-
Etienne Bergeron authored
Adding estimated memory usage to the quick history provider. it is suspected to be slow and cause jank on UI thread when memory usage is high. These metrics will be received with slow-reports and will help to investigate some jank on UI thread. R=mpearson@chromium.org Bug: 868419 Change-Id: I344f84ec00f318fdb9db63c5b464b119a9d5e3eb Reviewed-on: https://chromium-review.googlesource.com/1156847 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#579919}
-
James Cook authored
When working on out-of-process mojo services it is hard to figure out which log line comes from which process. Often both the browser process and the remote process are running shared components (e.g. code in //ui/views in both out-of-process ash and browser process). Trying to back-correlate pids with process types is really awkward. Add a optional prefix to the start of log lines so things look like: [my_process:80672:80672:0730/151208.285440:ERROR:file.cc(2982)]... Only add the prefix to new mojo service processes because it's possible there are consumers of existing browser process logging and I don't want change the format of existing browser or renderer logs. Bug: 869181 Test: added to base_unittests Change-Id: Ia26a78d69c19e1f5cbf8ecd269e962ad0589d008 Reviewed-on: https://chromium-review.googlesource.com/1156988Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#579918}
-
Christopher Cameron authored
This did not produce any useful data. Bug: 863817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9a4923c76b5b4ddf49ba778fb12656b05c42282b Reviewed-on: https://chromium-review.googlesource.com/1155743Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#579917}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like this callsite can use the THREAD_POOL_EXECUTOR instead, since this use doesn't appear to rely on the concurrency guarantees that SERIAL_EXECUTOR provides. Bug: 869907 Change-Id: I2f5b412edaf9e6f9ec2e634af757f3b238987afe Reviewed-on: https://chromium-review.googlesource.com/1159112Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#579916}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like this callsite can use the THREAD_POOL_EXECUTOR instead, since this use doesn't appear to rely on the concurrency guarantees that SERIAL_EXECUTOR provides. Bug: 869907 Change-Id: Iad83ebccb137eec01ff32bc1f78d72047859efc8 Reviewed-on: https://chromium-review.googlesource.com/1158789Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#579915}
-
dan sinclair authored
This CL updates the SPIRV-Tools DEPS entry. This requires adding a SPIRV-Headers third_party dependency as the headers are no-longer part of SPIRV-Tools. The BUILD.gn file for SPIRV-Tools is added directly to the SPIRV-Tools repo and so third_party/SPIRV-Tools/BUILD.gn can be removed. The SPIRV-Tools build contains fuzzing targets which are enabled with this change. Change-Id: I9181a1b50c1f08bbe4e68dff0e00b927d297745f Reviewed-on: https://chromium-review.googlesource.com/1142028 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579914}
-
Yuri Wiitala authored
A minimal FrameSinkVideoCaptureOverlay implementation for browser window video capture on ChromeOS (i.e., not desktop capture, and not WebContents capture). The intention is for this code to be a temporary solution until more work is complete on services/ui/ws (the new Window Service). Bug: 810133,806366 Change-Id: I4f929248a9620f96f2a538caaac9761a472cbe09 Reviewed-on: https://chromium-review.googlesource.com/1155985 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579913}
-
Anita Woodruff authored
- This is a precursor to removing the generic 'Sites' notification channel - now that we should have a specific site channel for each origin with notification permission, the sites channel should never be used, but adding UMA to verify this. Bug: 802380 Change-Id: I911b569dad291a4a9f01530f1185adc4dbcaa41e Reviewed-on: https://chromium-review.googlesource.com/1159020 Commit-Queue: Anita Woodruff <awdf@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#579912}
-
chaopeng authored
In this patch, we make 3 changes to measure pinch zoom latency: 1. Separate touchpad pinch zoom latency info from wheel 2. Add histogram to measure pinch zoom latency from when receiving event from system to when sending event to render. This helps us understand the latency of waiting synthetic wheel event. 3. Add histogram to measure pinch zoom latency from when receiving event from system to when the resulting GPU frame swap completed. This helps us understand the latency of the end to end touchpad pinch. Bug: 565980 Change-Id: I304675684746e6d8f6001937264afa0fc9037324 Reviewed-on: https://chromium-review.googlesource.com/1142447Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#579911}
-
Koji Ishii authored
Following bot results are included. 8499 8501 8504 8506 8507 8511 8515 8519 8523 8526 8533 8536 8539 8543 8547 10 lines were removed and 7 lines were deflaked by consecutive results since 8506. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9e5b22037f39e7eeaedd9c46f1704f18604f553d Reviewed-on: https://chromium-review.googlesource.com/1155280 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579910}
-
Adrienne Walker authored
GetLevelSize calls GLTargetToFaceIndex which asserts if the target is bogus, so move the early out before this call. Bug: 868242 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I24a6262e2f7cf3ebf70c814bfca818365ec6c242 Reviewed-on: https://chromium-review.googlesource.com/1158801Reviewed-by:
-
Jared Saul authored
Bug: 868552 Change-Id: Iac64b875611994439dae09d65ff7c999cde74ff8 Reviewed-on: https://chromium-review.googlesource.com/1153301Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#579908}
-
Mao Huang authored
Original CL: - https://chromiumcodereview.appspot.com/9722025 Fix virtual memory regression from new tcmalloc: use old kPageShift and kMaxSize w/ kNumClasses = 54. (retry of r127301) BUG=118329 TEST=perf tests. TBR=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127381 BUG=724399,b:70905156 Change-Id: I491bb82db0e94a71dc7c7b2742f9c4ef47b2eca1 Reviewed-on: https://chromium-review.googlesource.com/1130783Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#579907}
-
Lu Chen authored
Add recording of AnchorElementMetrics.Clicked.RatioRootHeight. Bug: 850624 Change-Id: Ia5ff57cc729cf7d577a59967f473c50da99e1e3b Reviewed-on: https://chromium-review.googlesource.com/1157282Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Travis Skare authored
Bug: 864302, 869221 Change-Id: I29318c89757dbf21ace69a83519d62d237691f2c Reviewed-on: https://chromium-review.googlesource.com/1139404Reviewed-by:
-
Gauthier Ambard authored
The bubble presentation of UI Refresh tips in non-UI Refresh app should be a no-op. Bug: 869400 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I308c2a5dee2088af8b6ca56567a7089944f8bf34 Reviewed-on: https://chromium-review.googlesource.com/1156694 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/70c787ae5bbc..e632dfcb362e git log 70c787ae5bbc..e632dfcb362e --date=short --no-merges --format='%ad %ae %s' 2018-08-01 bsalomon@google.com Use GrTextureType to determine highest supported filter 2018-08-01 halcanary@google.com sk_tool::Registry: make an iterator. 2018-08-01 egdaniel@google.com Use our own checked in Vulkan header to build skia source code. 2018-08-01 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ad63728be30d..038e725af257 (1 commits) 2018-08-01 bsalomon@google.com templatize GrSurfaceProxyRef 2018-08-01 brucewang@google.com Generate Emoji rendering test using typeface created by different font files. 2018-08-01 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms dc97dc542b6d..95d1987a561d (1 commits) 2018-08-01 fmalita@chromium.org Fix !defined(SK_XML) builds Created with: gclient setdep -r src/third_party/skia@e632dfcb362e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I54c8312a0706a107d752f029f7fc0c0e96f4c38f Reviewed-on: https://chromium-review.googlesource.com/1158787Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579903}
-
sczs authored
On iOS 10 the footer wasn't being loaded since the tableView sectionFooterHeight and estimatedSectionFooterHeight properties weren't being set. Because of this the footerForSection method wasn't getting called. This CL also updates tableView.estimatedRowHeight to a more adequate value of 50. Bug: 843827 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia3c17df5ab3c4d5aad4d2a391bbd804dd6a0aec0 Reviewed-on: https://chromium-review.googlesource.com/1157525Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
|-openNewTabInPage:focusOmnibox:| was a no-op if the page was the remote tabs page, but TabGridCoordinator's |-showActiveTabInPage: focusOmnibox:| used a NOTREACH() when called with the remote tabs page. This CL updates them both to use NOTREACH(), and short-circuits from the command+T handler if the page is the remote tabs page. Bug: 869820 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib394cc37a2b70420d3611e1440ad2b628a27c0a6 Reviewed-on: https://chromium-review.googlesource.com/1159087Reviewed-by:
-
bsheedy authored
Switches the "Mac FYI Experimental Retina Release (AMD)" and "Mac FYI Experimental Retina Release (NVIDIA)" builders to run tests on 10.13.6. Bug: 868032 Change-Id: Ice3945b56ae57260910970188d81266b6f4b2355 Reviewed-on: https://chromium-review.googlesource.com/1158984Reviewed-by:
-
Wez authored
52ff1accbbe8 linux: Fix locating modules with multiple mappings from offset 0 063ff78a2571 Use __aarch64__ instead of __arm64__ 1e662c2fcb6c [cq.cfg] Add all luci trybots as experimental 42b57efa554a CQ: Flip all builders except Windows to LUCI 6759969bf653 doc: Update Doxyfile to 1.8.14 bc50af15a28d Migrate from ScopedZxHandle to libzx containers 9cd2bae5ab23 Use Microsoft's ARM64 context layout Change-Id: I9bca31d7177efc1fb20e8d5cbfc7d76e4dd4616f Reviewed-on: https://chromium-review.googlesource.com/1159109Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#579899}
-
Robbie McElrath authored
This adds a NetworkConnectionTracker::AddLeakyNetworkConnectionObserver method and makes DialRegistry use it. Prior to this change, every NetworkConnectionTracker observer needed to unregister itself before the NetworkConnectionTracker was deleted, but there are several observers that are leaky singletons. We can't have BrowserProcessImpl call a cleanup method on every leaky singleton since that's horrible, and we can't hook into thread or message loop destruction to do the unregistering because that happens after the NetworkConnectionTracker gets deleted and asserts that everyone has cleaned up. I want to keep the clean up assertion, so I decided to add this AddLeakyNetworkConnectionObserver method, the callers of which will not be expected to unregister themselves before exit. Callers of the AddNetworkConnectionObserver method are still expected to clean up. Bug: 868001 Change-Id: I200d991828d958f8a2849f8d7e031ccb204a0da3 Reviewed-on: https://chromium-review.googlesource.com/1157541 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#579898}
-
Mathieu Perreault authored
Bug: 867893, 853940, 869912 Change-Id: Ia9a2729682dd8cbbc662562ab4ce9f79bfc1fbd2 Reviewed-on: https://chromium-review.googlesource.com/1158720Reviewed-by:
-
Mikel Astiz authored
We don't actually make use of the reference counting, so let's simplify lifetime and adopt a single ownership model. In the new implementation, we also enforce sequence affinity during object destruction, because it's likely to catch future bugs where future datatypes adopt BlockingModelTypeStore directly. The changes affect a few tests which assumed that two in-memory stores coexisting in time would share the same underlying data, which is quite brittle and counter intuitive. Bug: 862942 # Bypass PRESUBMIT script bug, see crbug.com/867823 No-Presubmit: true Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I98b754dd63d6bca65fe79769ae3a105e10328dbc Reviewed-on: https://chromium-review.googlesource.com/1142778 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579896}
-
Peter K. Lee authored
This unifies the addition of a new Tab to WebStateList in Tab Grid with that used in Tools menu and long tap menu of the Tab Grid icon on the bottom toolbar. See tab_model.mm -insertTabWithLoadParams:opener:openedByDOM:atIndex:inBackground:. In order to have InfoBars added to a New Tab Page, new page must be loaded before added to WebStateList because the latter triggers the observers. Bug: 867623 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia5f3b0ee4a70bebd6713e5c8e242edd36d8f8ce5 Reviewed-on: https://chromium-review.googlesource.com/1157552 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#579895}
-
Rayan Kanso authored
After a fetch resumes, the Job Controller needs a BackgroundFetchRequestInfo to update and complete the download. Change-Id: Id8f8721381049cdf057214f08fa7372b5256c095 Reviewed-on: https://chromium-review.googlesource.com/1155584 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Daniel Rubery authored
The changes are: 1. If the found navigation event has no referrer, always check for a retargeting event, instead of stopping in the case of user gesture. 2. If a navigation handle is not renderer initiated, and has no gestures, mark it as BROWSER_INITIATED instead of RENDERER_INITIATED_WITHOUT_USER_GESTURE, since the latter is confusing. 3. Do not terminate the referrer chain on BROWSER_INITIATED events. Change-Id: Ia6746a1a85ab63968199f90a7fbef3fef7104293 Reviewed-on: https://chromium-review.googlesource.com/1157542 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#579893}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/56094c50c0da..ad39141331e5 git log 56094c50c0da..ad39141331e5 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 thestig@chromium.org Fix sign mismatch in CPDFSDK_FormFillEnvironment::GetPageViewCount(). Created with: gclient setdep -r src/third_party/pdfium@ad39141331e5 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9fadd3d75a1be3b62594ad93aaad39c3bfa47f79 Reviewed-on: https://chromium-review.googlesource.com/1159021Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579892}
-
Derek Cheng authored
This helps increasing discovery reliability by refreshing the list of DIAL devices and obtaining the latest list on user gesture. This patch also shifts where |latest_sinks_| is cleared in the discovery code. This is to allow RemoveSink() (called from Cast discovery code) and the subsequent triggering of the timer to be handled correctly after a round of discovery has ended. Bug: 808720 Change-Id: Ib109e6ac8081b99001a76058ff51bd424a07080e Reviewed-on: https://chromium-review.googlesource.com/1157000Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#579891}
-
David Tseng authored
Bug: 862419 Change-Id: Icbf4fd7664324c25099f3125076b793fd8846ba2 Reviewed-on: https://chromium-review.googlesource.com/1150832Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Tommy C. Li authored
Tweak the Touchable Refresh dimensions to make everything in the Omnibox and Suggestions box line up. Bug: 865766 Change-Id: Ibe9ec38e6b2c1c9d92e56ffff60cf32faa92c59c Reviewed-on: https://chromium-review.googlesource.com/1157562Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#579889}
-
Mark Cogan authored
Exiting the tab grid on iPad, especially for tabs close to the top of the screen, shows a white flicker in the toolbar area of the tab. This is due to the fade in/fade out of the grid cell header and the toolbar snapshot, which transitions through a state where the header is totally white. The timing is such that this can happen right when the top of the tab is in position, making for a distinct flash in the toolbar. This CL fixes this by using a crossfade instead of the fade in/ fade out. The transition is fast enough that the crossfade doesn't look muddy, and it remove the abrupt flash. Bug: 865440 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifbceef6a79cbde4ea08c76b6f7e6a35bd8225330 Reviewed-on: https://chromium-review.googlesource.com/1158832 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
-
