- 23 Jul, 2018 40 commits
-
-
Justin Cohen authored
Bug: 865408 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I43ace7047750f8754cf6882d35fd598c3fffda3a Reviewed-on: https://chromium-review.googlesource.com/1146209Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577139}
-
Laís Minchillo authored
Originally the webview content was always set to clickable but after http://crrev.com/551479 it wasn't. This CL restores original behaviour. Also adds a test to ensure this remains true in the future. Bug: 857427 Change-Id: If7a765f146290b933f57e514f26ad8a672f7695e Reviewed-on: https://chromium-review.googlesource.com/1127951Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#577138}
-
Marek Haranczyk authored
Random failures encountered so far can be reproduced by compiling third_party/blink/renderer/bindings/core/v8:testing target on clean repo. Change-Id: If92737cdfdc6f12533776b6ded935ac1a2689137 Reviewed-on: https://chromium-review.googlesource.com/1127040 Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577137}
-
Friedrich Horschig authored
This CL fixes what caused the revert in commit bed2f341. (No TBRs because the original is quite old) Original change's description: > Revert "Clear password search on X and close it with back button" > > This reverts commit dcb5b1f4. > > Reason for revert: > Regressed on some devices. Failure reason is not obvious enough for confident immediate fix. > > Bug: 834676 > > Original change's description: > > Clear password search on X and close it with back button > > > > Right now, clicking the X button in the search will close it. > > To start a new search, you have to open a new search. > > That experience isn't very discoverable, so UX developed an improved > > workflow - details in the bug. > > > > The new flow needs these changes: > > - the X button _only_ clears the query text field now > > - the X button is _only_ available when a query was entered > > - closing the search happens only via the "navigate up" button > > in the action bar. > > - the three-dots overflow menu is hidden while a search is active > > (already the case on small screens - now large screens do the same) > > > > Tests cover all of these cases. > > > > Bug: 821755 > > Change-Id: Ieb2e16c096750d66874aa4c4999759629332491b > > Reviewed-on: https://chromium-review.googlesource.com/966070 > > Reviewed-by: Theresa <twellington@chromium.org> > > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#550955} > > TBR=twellington@chromium.org,fhorschig@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 821755 > Change-Id: I9035e5aed91dca19bcff94e195cf060ef61f2b29 > Reviewed-on: https://chromium-review.googlesource.com/1019150 > Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552101} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834676, 821755, 864607 Change-Id: I7afbcd0022a84a10c13b89f7538f63105ab04e52 Reviewed-on: https://chromium-review.googlesource.com/1143204Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577136}
-
Marcin Wiacek authored
This patch is fixing change made with the https://chromium-review.googlesource.com/c/chromium/src/+/1097408. Before patch: ContentSettingException permissions are not displayed. After patch: ContentSettingException are visible. Affected path: Settings->Site Settings->(setting)->(exception site) BUG=865032 Change-Id: I35dffa8c071fae4f4e76c69850b542b747dc493e Reviewed-on: https://chromium-review.googlesource.com/1145434Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#577135}
-
Matt Falkenhagen authored
This is one of the tricky parts of service worker code, and its role has changed after various changes over the years. There is no longer such thing as a "new registration" associating with a provider host. Association happens only during: 1) main resource requests in ServiceWorkerControlleeRequestHandler 2) claim() in ServiceWorkerRegistration. There is no need for ServiceWorkerControlleeRequestHandler to defend against itself. So claim() is the only thing to defend against. So the whole point of it is to stop claim() from claiming provider hosts that are still undergoing their main resource request. This should be the same thing as |is_execution_ready_|. But unfortunately there is still edge cases/trickiness around shared workers and about:blank iframes. Add some comments and revisit after NetS13nServiceWorker. Change-Id: I508f13c52fc30aa40776e17d4966ff05c0c57e14 Bug: 866353 Reviewed-on: https://chromium-review.googlesource.com/1146414 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577134}
-
Wez authored
This reverts commit 81626592. Reason for revert: MetricsOnlyFromUILoops test appears to be flaky (see https://crbug.com/866299). Original change's description: > [MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread > > Addresses crbug.com/860801 in time for the M69 branch while keeping the > diagnosis signals which will be used to assess future improvements > (MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle that is). > > Removed MessageLoop.DelayedTaskQueue.PostedDelay as we've > learnt everything we needed from this one, that is : > We now know that while 99% of tasks are posted with a delay under 30s, > 95% of users post at least one task in every portion of the 0ms-3hours > range at least once per day: > https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.DelayedTaskQueue.PostedDelay&fixupData=true&uniqueUsers=true&showMax=true&filters=platform%2Ceq%2CW%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial > > Removed MessageLoop.ScheduledSleep.* metrics as we've also > learnt what we wanted from it, that is : > The maximum sleep a MessageLoop ever completes is 1 hour (and > even then 99% of completed sleeps are under 1 second), all > longer delays are reliably always interrupted. > Win : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial > Mac : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial > Android : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CA%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial > > Added a test for MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle > but it appears to be broken on MacOSX (prior to this CL). Added a note > to investigate on the metric but it shouldn't block this CL which > doesn't make it worse. > > R=kylechar@chromium.org, rkaplow@chromium.org > > Bug: 860801, 850450, 786597 > Change-Id: I7a693886ab4e1b9c8e9fbe8a64d906a95019a609 > Reviewed-on: https://chromium-review.googlesource.com/1142589 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Robert Kaplow (OOO until 0730) <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576686} TBR=gab@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,kylechar@chromium.org Bug: 860801, 850450, 786597, 866299 Change-Id: I848621acf9ddbec69d72649d16a459910ffa937e Reviewed-on: https://chromium-review.googlesource.com/1146300 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577133}
-
Peter Beverloo authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6018c94b02d241c416d14fb7431aea912524d8f5 Reviewed-on: https://chromium-review.googlesource.com/1137826Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#577132}
-
Marc Treib authored
EXPECT_CALL(...).WillRepeatedly(...) doesn't actually set up any expectation, only a default return value. That's what ON_CALL is for. Bug: none Change-Id: I26ff25929f191e29651f0c1eb69e1785f2e40441 Reviewed-on: https://chromium-review.googlesource.com/1145062 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577131}
-
Yoshifumi Inoue authored
This patch introduces weak member callback in |DocumentMarkerController| to detect empty weak hash map |markers_| to avoid unregistering mutation observer during mutation callback. This patch is follow-up of the patch[1]. [1] http://crrev.com/c/1137988 Blink Editing: Workaround unsafe iteration in DocumentMarkerController. TBR=jbroman@chromium.org Bug: 862960 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icd6acfed2ca00dabc4ed79959df2fdf0bd6fce4b Reviewed-on: https://chromium-review.googlesource.com/1143113Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577130}
-
Ivan Sandrk authored
Public Session startup UI should be updated according to attached mocks (see linked bug) in order to highlight possible MITM certs that might be installed by device admin. Bug: 862078 Change-Id: I50a1bed05bdc4966932c5649eb62e5dc5a6f861a Reviewed-on: https://chromium-review.googlesource.com/1142145 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577129}
-
Ricky Liang authored
Adding shik@ and hywu@ as owners of Chrome OS Video Capture. R=wuchengli Bug: None Change-Id: I3ea88421720ea252ea1d74fb3bf0e63d0fec5327 Reviewed-on: https://chromium-review.googlesource.com/1146124Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#577128}
-
Christian Dullweber authored
When deleting with an EmptyBlacklist filter, we shouldn't create a Network deletion filter to properly use optimized "delete all" code paths. Bug: 843995 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ifc84f403dc2f2b50471e7fab273d20ebcba3f4f4 Reviewed-on: https://chromium-review.googlesource.com/1068736Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#577127}
-
Timothy Loh authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=viz_browser_tests&tests=ResourceLoadingHintsBrowserTest.ResourceLoadingHints TBR=tbansal Bug: 866212 Change-Id: Ie4e1ff6848b2b28d7daf98a74057296a6de2a5df Reviewed-on: https://chromium-review.googlesource.com/1146532Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577126}
-
Sam McNally authored
Wait for IPC propagation to ensure the tests do not try to navigate before the beforeunload handler registration has informed the browser. Also, use a navigation instead of a reload to avoid ending up back at the page with a beforeunload handler during shutdown, causing shutdown to be blocked by a beforeunload dialog. TBR=rdevlin.cronin@chromium.org Bug: 866209 Change-Id: Id7c34e7a371f10f05297ea6cd3e3addeef75a49b Reviewed-on: https://chromium-review.googlesource.com/1146528Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#577125}
-
Takayoshi Kochi authored
The frame's initialization code focuses the content from browser process via an IPC (browser->renderer), but its handling in the renderer can be delayed until after the test code script execution is started. This caused the test to have a race condition, that a focus event is delivered where it is not expected, and resulted the flakiness. The test can fail on the initial use of content_shell process. Delay the execution of test function so that it will not be affected by the frame initial focus event. Bug: 863067 Change-Id: I475d912b0e9baffa3917212b2fc0735189381cb8 Reviewed-on: https://chromium-review.googlesource.com/1146523 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#577124}
-
Wojciech Dzierżanowski authored
When DecoderStream<DemuxerStream::AUDIO> encounters a config change it needs to do two things, among others: flush the decoder and reset the audio timestamp validator. It's important that it does the latter only after processing any decoder output produced during the flushing. This CL moves the responsibility of resetting the validator from DecoderStream to DecoderStreamTraits<DemuxerStream::AUDIO>. It also adds a test where the decoder's behavior of releasing internally buffered samples upon flushing is mocked. Bug: 865926 Test: New test AudioBufferStreamTest.FlushOnConfigChange doesn't fail assertions. No regressions in media_unittests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8cbb01df3792ca9de5db8ab637285d1e64188b39 Reviewed-on: https://chromium-review.googlesource.com/1145188Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#577123}
-
Max Morin authored
RenderProcessHostTest.KillProcessZerosAudioStreams flakes with an indeterminate result. This CL hopes to make the test fail explicitly instead as a way of debugging the test. Sheriffs: This test was flaky before this CL. Instead of reverting the CL, disable the test on Android and post a log in the bug. Bug: 864476 Change-Id: I372bfa8f82245b9306554641fc56d651fd84dad9 Reviewed-on: https://chromium-review.googlesource.com/1145265Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577122}
-
Oscar Johansson authored
When building using jumbo, files get merged and variables, functions and defines could end up in the same scope and conflict. This commit solves issues with includes and defines for the mac specific part of chrome/browser/ui. Bug: 803406 Change-Id: I55d1f6110a6144bc7ee3037a374d3e33c36a9879 Reviewed-on: https://chromium-review.googlesource.com/1144928Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#577121}
-
Yutaka Hirano authored
With this CL, CORSURLLoader only allows "http", "https" and "data" schemes for CORS enabled requests. This CL adds a new error code, kCORSDisabledScheme, for the error. As noted in the design doc[1], no one updates the scheme list in Chromium, so it's safe to assume url::GetCORSEnabledSchemes is equivalent to the counterpart in blink::SchemeRegistry. We are planning to remove blink::SchemeRegistry::RegisterURLSchemeAsSecure. The existing xmlhttprequest/resources/cross-origin-unsupported-url.js output relies heavily on the error output timing. This CL fixes the test. Because the error is reported asynchronously, console messages change a bit (i.e., the line number doesn't show up). We accept that change. 1: https://docs.google.com/document/d/1JNmUcvbw2UcjfdI2uyUpveHXCbae-DQ1n8d_sVs5fLg/edit#heading=h.r9hjqrw3gn9e Bug: 736308 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id49ad02e1413353e96c9fed1d0a84d34f0262fab Reviewed-on: https://chromium-review.googlesource.com/1144903Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#577120}
-
Marc Treib authored
IsEngineInitialized can now be implemented in terms of GetState (as an intermediate step before fully removing it). Moving the implementation into the base class makes sure tests can't expose inconsistent state. TBR=marq for ios/ who did say LGTM, but forgot to press "+1" :) Bug: 839834 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I67b5174d4a0bdb0b286526a6deecfed58d01267f Reviewed-on: https://chromium-review.googlesource.com/1141844 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Christopher Cameron authored
This function was computing the right transform, and then applying it to a temporary variable instead of the input. TBR=fsamuel Bug: 860344 Change-Id: I917b1ea2610b6edaaa43eb2d7abc6febbb44f0fc Reviewed-on: https://chromium-review.googlesource.com/1146480Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#577118}
-
Hiroki Nakagawa authored
This is a preparation CL for PlzWorker for shared workers. SharedWorkerServiceImpl needs to access ChromeAppCacheService to create a NavigationLoaderInterceptor for AppCache. Subsequent CLs will actually use it. DesignDoc: https://docs.google.com/document/d/1Jtn33bvqkqWxq6K7HIA4uU6HLWPTmOD7vFviacfTmhM/edit?usp=sharing Bug: 715632 Change-Id: Ib2e8e8d2ae9adb2bc4851fb985eb121dc4ad2917 Reviewed-on: https://chromium-review.googlesource.com/1146405Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#577117}
-
Kunihiko Sakamoto authored
This patch makes SignedExchangeLoader propagate URL fragment from outer request URL to redirect (inner) URL. Bug: 865852 Change-Id: Ib4000508464a4d0cf82c4757aca05c0d670ed647 Reviewed-on: https://chromium-review.googlesource.com/1146410 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Iede57623b883810db7ee5f8829feefb79b5da08e Reviewed-on: https://chromium-review.googlesource.com/1146482Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577115}
-
Yoichi Osato authored
This patch stabilizes LayoutSelection by letting it be off from LayoutObject reference. Design doc: https://bit.ly/2KT87L9 Algorithm updates: Mark SelectionState::kContain to all ascendants of each leaf selected node on flat tree. Do nothing while Node/LayoutObject::RemoveChild(). At prepaint phase, collect all selected LayoutObject from root using kContain on flat tree. Bug: 843144 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib4b39c621043d5fe03f46e0ce8b4d2b972e9ed3e Reviewed-on: https://chromium-review.googlesource.com/1125709Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#577114}
-
Matt Falkenhagen authored
(1) Account for multiple main resource requests at the same time, by adding a ref count of expected hints. (2) Also update the intermediate service workers in redirect chains. This both conforms to the spec and is needed to implement (1) sensibly, since we don't know which service workers are intermediate and which are final when incrementing the ref count. Bug: 853635 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If4212e12c9e2084c8f1b34c76e80b094053a207f Reviewed-on: https://chromium-review.googlesource.com/1144905 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: -
Rakina Zata Amni authored
This CL moves ReportFindInPageMatchCount and ReportFindInPageSelection from RenderFrameImpl to FindInPage. This is done in preparation of mojoifying FindInPage::Find. ReportFindInPage{MatchCount,Selection} sends FindReply frame host messages through IPC for calls to the Find method. After mojoification, these functions will instead call SetNumberOfMatches/SetActiveMatch on FindInPageClient. We are moving them now to make the CL for the mojoification smaller/simpler. Mojoifying doc: https://goo.gl/JenyGm Previous CLs: Introduce FindInPageClient with SetNumberOfMatches and SetActiveMatch crrev.com/c/1080568 Mojoify FindInPage::StopFinding crrev.com/c/1058731 (other CLs linked in the CL above) Bug: 819919 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2841d2841a44d1473d4118215cd7dd0f238ca001 Reviewed-on: https://chromium-review.googlesource.com/1097237Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#577112}
-
Noel Gordon authored
Add helper to read the "full test case name". Any derived classes that have testing options (TabletMode, GuestMode, etc) can include those in the full test case name. Update FileManagerBrowertestBase to log the "full test case name" when starting a browser test. Bug: 836254 Change-Id: I9613a4682a6ae91fb03a842ce20924ceb21c1930 Reviewed-on: https://chromium-review.googlesource.com/1146412 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Timothy Loh authored
This reverts commit 26399bca. Reason for revert: OmniboxViewViewsTest.SelectAllOnTabToFocus is Flaky Original change's description: > Match security chip visibility with focus ring > > Instantly hides or shows the IconLabelBubbleView separator when focus > rings are available to prevent showing the separator when a focus ring > overlaps it. > > Bug: chromium:865029 > Change-Id: I21a4c296c1da06b81dc91d66101d46e8ad52ad99 > Reviewed-on: https://chromium-review.googlesource.com/1142442 > Commit-Queue: Peter Boström <pbos@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576358} TBR=pbos@chromium.org,bsep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 865029, 866230 Change-Id: I30372e90c1613b33690b43dd28fbe151abddddef Reviewed-on: https://chromium-review.googlesource.com/1146421Reviewed-by:
-
Khushal authored
This reverts commit 13e510ef. Reason for revert: Causing crashes on the latest canary. I'll debug on Monday. Original change's description: > gpu: Hook up activity flags for glProgramBinary for OOPR. > > The activity flags are used to notify the browser if the GPU process > crashes during shader compilation which could indicate a corrupted disk > shader cache. Hook this up for the persistent shader caching on the > GrContext for OOPR. > > R=ericrk@chromium.org, piman@chromium.org > > Bug: 854416 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I4ed69d41768856b649a500dd5b86777bf0023d26 > Reviewed-on: https://chromium-review.googlesource.com/1142367 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576819} TBR=khushalsagar@chromium.org,piman@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 854416 Change-Id: I51f5ff5b7427348b06159b7a8a3ec11161d9b6f3 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1146087Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#577109}
-
Timothy Loh authored
This reverts commit 5c4bc1ff. Reason for revert: CanvasRenderingContext2DTest.LowLatencyIsSingleBuffered failing I suppose this depended on https://chromium-review.googlesource.com/c/1144602/, which was reverted, so the test this CL adds is failing now. Original change's description: > Add a single buffered mode to CanvasResourceProvider > > This CL completes the initial implementation of Low Latency mode for 2d > canvases > > Bug: 788439 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I58fcd3fe4ab19fa10f2876f3da4f078fd4fbc2a9 > Reviewed-on: https://chromium-review.googlesource.com/1145235 > Commit-Queue: Justin Novosad <junov@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576962} TBR=junov@chromium.org,fserb@chromium.org NOTRY=TRUE Bug: 788439,866211 Change-Id: I8e976b4cb6aca452f6d1891677e35e4411e2a5e4 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1146460 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Bug: 736308 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I86bccc93b2e2050326d59c26a03d05a51ed1ae81 Reviewed-on: https://chromium-review.googlesource.com/1144807 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577107}
-
Rakina Zata Amni authored
FindInPageClient is a per-frame client for FindInPage. FindRequestManager has a map of frame -> FindInPageClient. FindInPageClient manages per-frame number of matches, and also updates the global number of matches and the current active match rect and ordinal. In this CL, we are changing ActivateNearestFindResult to call methods on FindInPageClient instead of calling a callback. SetNumberOfMatches is called to update the corresponding frame's number of find-in-page matches and also update the total number of matches in a tab. SetActiveMatch updates the tab's active match rect and ordinal. When we mojoify FindInPage::Find, we'll use FindInPageClient to receive the find replies and remove FindRequestManager::OnFindReply. Mojoifying doc: https://goo.gl/JenyGm Previous CLs: Mojoify FindInPage::StopFinding crrev.com/c/1058731 (other CLs linked in the CL above) Bug: 819919 Change-Id: I25a6d81037655801db1b1337f335073f11aa7862 Reviewed-on: https://chromium-review.googlesource.com/1080568 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Timothy Loh authored
This reverts commit c2bc780a. Reason for revert: Lots of breakages on Debug builders # Fatal error in ../../v8/src/api.cc, line 5960 # Check failed: expected == value ((nil) vs. 0x11b5bca8d0e8). # # # #FailureMessage Object: 0x7fff42dfe070#0 0x7fd6fdc375fd base::debug::StackTrace::StackTrace() #1 0x7fd6fd9443cc base::debug::StackTrace::StackTrace() #2 0x7fd6e76e76f7 gin::(anonymous namespace)::PrintStackTrace() #3 0x7fd6dad0b918 V8_Fatal() #4 0x7fd6f9eecfcc v8::String::VerifyExternalStringResourceBase() #5 0x7fd6e2a5a310 blink::ToBlinkString<>() #6 0x7fd6e501a9f5 blink::V8StringResource<>::ToString<>() #7 0x7fd6e501416c blink::V8StringResource<>::operator WTF::AtomicString() #8 0x7fd6e69322d1 blink::ElementV8Internal::removeAttributeMethod() #9 0x7fd6e6931faa blink::V8Element::removeAttributeMethodCallback() #10 0x7fd6f9fa5444 v8::internal::FunctionCallbackArguments::Call() #11 0x7fd6f9fa3870 v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #12 0x7fd6f9fa1ba8 v8::internal::Builtin_Impl_HandleApiCall() #13 0x7fd6f9fa15e1 v8::internal::Builtin_HandleApiCall() #14 0x7fd6fac565f5 <unknown> Received signal 4 ILL_ILLOPN 7fd6dad10b62 #0 0x7fd6fdc375fd base::debug::StackTrace::StackTrace() #1 0x7fd6fd9443cc base::debug::StackTrace::StackTrace() #2 0x7fd6fdc37054 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fd6df1c60c0 <unknown> #4 0x7fd6dad10b62 v8::base::OS::Abort() #5 0x7fd6dad0b925 V8_Fatal() #6 0x7fd6f9eecfcc v8::String::VerifyExternalStringResourceBase() #7 0x7fd6e2a5a310 blink::ToBlinkString<>() #8 0x7fd6e501a9f5 blink::V8StringResource<>::ToString<>() #9 0x7fd6e501416c blink::V8StringResource<>::operator WTF::AtomicString() #10 0x7fd6e69322d1 blink::ElementV8Internal::removeAttributeMethod() #11 0x7fd6e6931faa blink::V8Element::removeAttributeMethodCallback() #12 0x7fd6f9fa5444 v8::internal::FunctionCallbackArguments::Call() #13 0x7fd6f9fa3870 v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #14 0x7fd6f9fa1ba8 v8::internal::Builtin_Impl_HandleApiCall() #15 0x7fd6f9fa15e1 v8::internal::Builtin_HandleApiCall() #16 0x7fd6fac565f5 <unknown> Original change's description: > Update V8 to version 7.0.1. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/d7b61abe..8766d3dd > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Id0a466229f294e8afa3e887d9814926b592815b7 > Reviewed-on: https://chromium-review.googlesource.com/1145698 > Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#576998} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com NOTRY=TRUE Change-Id: I86ecc3dba8ab82f9e2968b3905033539f9363098 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1146420 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I674947b92fc11e1aac2b4855d0a87fe1c8f7c9a2 Reviewed-on: https://chromium-review.googlesource.com/1146212Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#577104}
-
Xiaocheng Hu authored
This patch removes a header inclusion for better build performance, and clearer code dependency. Bug: 866120 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8d3bb813807bbae08350f1b649043752a1198d42 Reviewed-on: https://chromium-review.googlesource.com/1145694 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577103}
-
Stefan Zager authored
This is an abstraction to facilitate moving the bulk of platform/scroll into core. WebScrollbarTheme provides a Mac-only API which is called into from content, and affects the styling of all scrollbars. After this patch, all of the other scrollbar and scrollbar theme code can move out of platform. BUG=823365 R=skobes@chromium.org,chrishtr@chromium.org TBR=dgozman@chromium.org Change-Id: I888e08676b5343156ae391c44b2084e90023de0f Reviewed-on: https://chromium-review.googlesource.com/1141116 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577102}
-
Darren Shen authored
In a previous patch, we removed KeyboardLayoutManager's dependency on KeyboardController's SetContainerType. This means that the friend declaration in KeyboardController is no longer needed. TBR=blakeo@chromium.org Bug: 845780 Change-Id: I56ea22d989dcefc3bc70d4ca054678fd52c5bef7 Reviewed-on: https://chromium-review.googlesource.com/1146139Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#577101}
-
Timothy Loh authored
This CL adds a vector icon for use in notifications for Linux packages. Using a vector icon allows this to get blue/red colours automatically to match the notification title color. Bug: 822464 Change-Id: Ie21f437b8c65aefb8d5be4732e864f826445d361 Reviewed-on: https://chromium-review.googlesource.com/1143046Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577100}
-
