GitLab

Mark kUseMonitorColorSpace disabled by default to avoid
the blue-color-looks-purple problems detailed in the bug.
This is just a temporary CL to allow cherry-picking it
into the beta branch.

TBR=dcastagna@chromium.org

Bug: 809909
Change-Id: I35bb8cc48c26091cb1752d3d7709a48d23fb4c6e
Reviewed-on: https://chromium-review.googlesource.com/1012305Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551152}

Fixes occasional crashes seen in render thread profiling when
attempting to unwind from the sigtramp function in non-leaf frames.

Bug: 831793
Change-Id: Ie07b9679c288262d8409904d4f4fe818324339bf
Reviewed-on: https://chromium-review.googlesource.com/1013337
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551151}

This reverts commit 79605d54.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Reland "Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink""
> 
> This reverts commit 79edda64.
> 
> Reason for revert: We have branched into M68.
> 
> Original change's description:
> > Reland "Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink"
> > 
> > This is a reland of 119455cb
> > 
> > Original change's description:
> > > Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink
> > >
> > > There's a race in cc somewhere from commit to draw. I don't know exactly
> > > how to repro the race yet even though I have a high probably fix. This
> > > CL is intended to catch the race in the wild and produce a stack trace
> > > in a crash log. Hopefully from there we can acertain repro steps.
> > >
> > > Once repo steps are produced locally (either via user interaction or
> > > unit test) then this CL will be reverted.
> > >
> > > Bug: 672962
> > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> > > Change-Id: I3bce066591e15d5c3aac7d4c8685dce411e284b7
> > > Reviewed-on: https://chromium-review.googlesource.com/973987
> > > Reviewed-by: Saman Sami <samans@chromium.org>
> > > Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#544834}
> > 
> > Bug: 672962
> > TBR: samans@chromium.org
> > Change-Id: I880540f3f00c419efb4055007787e86f4722d675
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> > Reviewed-on: https://chromium-review.googlesource.com/981154
> > Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> > Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#545994}
> 
> TBR=fsamuel@chromium.org,samans@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 672962
> Change-Id: I02cc346dddda60a02e9233ec6fcb7c9df50e1d8a
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/1008610
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550171}

TBR=fsamuel@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 672962
Change-Id: Ib3730fc78117cbaac36d141bfe03430a665bb3ea
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1012785Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551150}

Bug: 832919, 831251
Change-Id: I113dbedec6ee9b79f109aff876a2ccc97e057b73
Reviewed-on: https://chromium-review.googlesource.com/1014283Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551149}

This reverts commit 90c5a257.

Reason for revert: flaky leaks on WebKit_Linux_Trusty_Leak. See crbug.com/833609.

Original change's description:
> Onion-soupify blink leak detector
> 
> - Expose LeakDetector interface in render process, remove unneeded plumbing.
> - Switch from IPCs to Mojo in layout test runner.
> - Move implementation to controller.
> - Migrate inspector usage to browser.
> - Merged two methods of LeakDetector into a single one.
> - Fixed leaks in existing tests.
> 
> Needs a followup to not register fetchers in leak detector,
> but instead have a collection in ResourceFetcher.
> 
> Change-Id: Iba0ffc95de5b8beb27409b4eb51435c5e1397951
> Reviewed-on: https://chromium-review.googlesource.com/999170
> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
> Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551012}

TBR=dgozman@chromium.org,dcheng@chromium.org,haraken@chromium.org,kolos@chromium.org,yuzus@chromium.org

Change-Id: I1c7471b3b910ab9a3cbd34794307dd5e0fecca41
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1014520Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551148}

This is another step toward out-of-process ash (go/mustash).

* Create the Widget in FirstRunController in chrome
* Move escape key handling into chrome
* Stop using OverlayEventFilter in ash. The old code wasn't actually
  relying on it for blocking event propagation, just for escape key
  handling and detecting screen lock and shutdown. The old code was
  also watching for LoginStatus changes, but that dates back to the
  use of OverlayEventFilter for partial screenshots (no longer used)
  and isn't relevant to first-run.
* Add mojo interfaces to tell ash to start/stop tutorial

Bug: 756057
Test: ash_unittests, browser_tests
Change-Id: Icfd88e3541f1393b6a2309120c74bbe6a69b967f
Reviewed-on: https://chromium-review.googlesource.com/1000395
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551147}

- The legacy IPC pathway was checking the max data
size *before* the IPC call, and rejecting if it was
exceeded.

- This patch reinstates the check for the new mojo
pathway, so that we don't risk crashing the renderer
(thanks to verification in struct traits) if max data
is exceeded.

- This involved moving the max data constant to mojo
so it can be accessed from both blink and content.

R=peter@chromium.org

Bug: 798742,796991
Change-Id: I14ae782c9265411da1374beb7ae7312cb265b07e
Reviewed-on: https://chromium-review.googlesource.com/1011602Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551146}

Following bot results are included.
4797 4801 4802 4804 4805 4806 4812 4817

Rebaseline for editing/unsupported-content/table-delete-001 was
deleted as the test was changed to testharness.

3 lines were removed and 1 lines were deflaked by consecutive
results since 4749.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I389bdc815aab7c97e4c90ee3508b8429c0d9eb9f
Reviewed-on: https://chromium-review.googlesource.com/1013669
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551145}

The current link is a 404.

Bug: 715355
Change-Id: Id31bb3b61e468b948f4ccdc0dd553321d67f3808
Reviewed-on: https://chromium-review.googlesource.com/1013361Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551144}

This reverts commit 39b4e33b.

Reason for revert:
https://ci.chromium.org/buildbot/chromium/Android/84236[32116/66287]

In file included from gen/services/network/public/mojom/network_service.mojom-shared.h:23:
gen/services/network/public/mojom/network_service.mojom-shared-internal.h:26:10: fatal error: 'services/network/public/mojom/websocket.mojom-shared-internal.h' file not found
#include "services/network/public/mojom/websocket.mojom-shared-internal.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original change's description:
> [subresource_filter] Move test-only JNI calls out of binary
> 
> Before, the JNI shim called into native code that was compiled into
> Chrome proper.
> 
> Now, due to r517541 there is a better way to do this by including the
> JNI code in libchromefortest.
> 
> Bug: None
> Change-Id: I9f34f5105366b927d6dd6676d97a9da6d2540385
> Reviewed-on: https://chromium-review.googlesource.com/997877
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551131}

TBR=yfriedman@chromium.org,csharrison@chromium.org,jbudorick@chromium.org

Change-Id: If96fd947654bd36763943de4302f5a820a467f22
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/1013344Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551143}

Bug: 27175
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2fed4c16cf0406ea5361413840fe5ab2f5968f69
Reviewed-on: https://chromium-review.googlesource.com/1003056
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551142}

Builders:
* Win x64 Builder
* Win10 Tests x64
* Win 7 Tests x64 (1)

BUG=790642,790660,790638

Change-Id: I24b17ca255dcb127f20d2ce9ab1078afb5bd919d
Reviewed-on: https://chromium-review.googlesource.com/1014329Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551141}

Would like to see if the tests are no longer flaky after
https://chromium-review.googlesource.com/1010466.

TBR=kbr@chromium.org

Bug: 735228,735171
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic2bdeb13f52f4fff4f94cc7f7ee46f503c7646f3
Reviewed-on: https://chromium-review.googlesource.com/1012985
Commit-Queue: Olivia Lai <xlai@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551140}

https://chromium.googlesource.com/catapult.git/+log/0371983030f2..5d0c16d725ca

$ git log 037198303..5d0c16d72 --date=short --no-merges --format='%ad %ae %s'
2018-04-12 crouleau [Telemetry] Explain when no browsers available for a device

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:830834


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I89bb2ef6dda43a6c723fc7686e01f9278876c1d3
Reviewed-on: https://chromium-review.googlesource.com/1014276
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551139}

bug: chromium:821353

Change-Id: If1c7bb0daf8b9c295e7ec2d58145fabdee17bcff
Reviewed-on: https://chromium-review.googlesource.com/1010511
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551138}

When Steady State Elisions is on, there's currently the following bug:

When the user clicks the Omnibox (and selects everything), then Alt-Tabs
out of the window, and Alt-Tabs back in, the selection changes from
select-all to a cursor at the beginning of the Omnibox.

This CL fixes the bug and adds a test to prevent regression. The bug
was caused by some old code in OmniboxEditModel that should have been
deleted a while ago.

It also refactors the test a bit to make the focus and blur fake events
more robust.

It also updates the OmniboxViewViews::OnFocus method to be suitable for
usage within tests (rather than overriding and defining a fake one).

Bug: 797354
Change-Id: I4516455cf81e4097f27605f52a669f01f7c17f61
Reviewed-on: https://chromium-review.googlesource.com/1013209
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551137}

Update comments in //services/identity/public/cpp to better reflect the
current reality of IdentityManager.

Change-Id: I20fef4d73aec6737927bdc0dc398dd366fccbd9a
Reviewed-on: https://chromium-review.googlesource.com/1013479Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551136}

These were exposed by leak detector change, dgozman@ is going to fix them.

Bug: 833609
Change-Id: I068afd816b67158a0d1ee5aef515525685398069
Reviewed-on: https://chromium-review.googlesource.com/1014462
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551135}

BUG=833179
R=dpranke

Change-Id: Ie9fa320c6d532844f85d34f5d6f8a1195a9eb107
Reviewed-on: https://chromium-review.googlesource.com/1014263
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551134}

This CL corrects two erroneous byte positions during EDID parsing, namely for
Green and White LSByte positions. Affected unit tests are fixed.

Bug: 821393
Change-Id: Ica3c54258e0d58b55bd5c5779e9ef6b6f5e4a610
Reviewed-on: https://chromium-review.googlesource.com/1005534
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551133}

BUG=731502

Change-Id: I12565be7b445c34d2ac16a3b1fca7feb9c88a2b4
Reviewed-on: https://chromium-review.googlesource.com/1014403Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551132}

Before, the JNI shim called into native code that was compiled into
Chrome proper.

Now, due to r517541 there is a better way to do this by including the
JNI code in libchromefortest.

Bug: None
Change-Id: I9f34f5105366b927d6dd6676d97a9da6d2540385
Reviewed-on: https://chromium-review.googlesource.com/997877
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551131}

Bug: 755418
Change-Id: I6265cc98f0f70d9387275cb1e346acdc1978f488
Reviewed-on: https://chromium-review.googlesource.com/994276
Commit-Queue: Nathan Parker <nparker@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551130}

This migrates some usage of notifications.

BUG=170921

Change-Id: I2c824659f50d3838d65842fc4bec5db9a4c1a7df
Reviewed-on: https://chromium-review.googlesource.com/1011682
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551129}

- Clarify lifetime model.
- Clarify thread model.
- Remove GetClassIdentifier(). Moving foreard, we should add virtual
  methods to CdmContext to support platform-specific interfaces, instead
  of using static_cast.

TBR=jrummell@chromium.org,rkuroiwa@chromium.org

Bug: 821288
Test: No functionality change.
Change-Id: I13e30ed2c508855727219edd3975abf5d67e6721
Reviewed-on: https://chromium-review.googlesource.com/1014284Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551128}

Accessing cookies from WKHTTPCookieStore doesn't work correctly when
there is not a  WKWebView object alive. previously a work around was
created, but it seems to not solve the problem.
The problem always existed but to be able to WKHTTPCookieStore as the
main cookieStore, it had to be addressed.

Bug: 661630, 746947
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie5f67102a7cfb804a47b8aa5c1316c25be5d9609
Reviewed-on: https://chromium-review.googlesource.com/1011584Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551127}

This reverts commit fc9d1583.

Reason for revert: Now that we've branched for M68, I'm relanding this.

Original change's description:
> Revert "Surface synchronization: Add diagnostic CHECK"
> 
> This reverts commit 3fb6e543.
> 
> Reason for revert: This is blocking branch cut. We know we hit this case and we've collected some crash logs to sift through now.
> 
> Original change's description:
> > Surface synchronization: Add diagnostic CHECK
> > 
> > Current evidence points to a race in cc that is causing surface invariants
> > violations (No invariants violations detected in LayerTreeHost but detected
> > in ClientLayerTreeFrameSink).
> > 
> > My suspicion is viewport is updated out of sync with LocalSurfaceId and
> > device scale factor.
> > 
> > This CL adds a diagnostic CHECK between the pending and active LayerImpls to
> > attempt to detect the race and produce a better stack trace. The invariant
> > we want to test here is if active tree has an invalid viewport (viewport has
> > changed), then the LocalSurfaceId MUST change.
> > 
> > Bug: 672962
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I975c9dfb9c86c292d7aac052bac01510e6efb1c2
> > Reviewed-on: https://chromium-review.googlesource.com/989851
> > Reviewed-by: enne <enne@chromium.org>
> > Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#547457}
> 
> TBR=enne@chromium.org,fsamuel@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 672962
> Change-Id: Id1ad5997e12b7f966df5f7b034bd5a30baa5ae60
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1008642
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550175}

TBR=enne@chromium.org,fsamuel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 672962
Change-Id: I7e460b4177d7690cc324d0feadeed7aacbcb24ec
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1012407Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551126}

This adds VdaVideoDecoder, an adapter that implements the media::VideoDecoder interface using a
media::VideoDecodeAccelerator. VdaVideoDecoder expects to run in the GPU process, with access
to a command buffer stub, as will be the case for decoders created by MojoVideoDecoder.

VdaVideoDecoder runs on the (mojo) IO thread as much as possible, but the VDA interface is
inherently tied to the GPU thread.

Compared to the original landing (commit e192695d), this change
casts kMaxPlanes to uint32_t before using it as a parameter to DCHECK_LE() in
PictureBufferManager::CreatePictureBuffers().

Bug: 522298
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie3e1b346f9b88692bcb2be12434fb0b6b81ef025
Reviewed-on: https://chromium-review.googlesource.com/1012936
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551125}

The current .yaml files are wrapping duplicate directory names like
'public/tools', which cause downloaded packages as
'public/public/tools'. This cl fixed that issue by add the root
directory info to yaml files.

TBR=jbudorick@chromium.org

Bug: 659808
Change-Id: I3be84d33cff2974c7bea481349aef04a45b9548f
Reviewed-on: https://chromium-review.googlesource.com/1013389
Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>
Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551124}

See https://skia-review.googlesource.com/c/skia/+/121582

Bug: skia:7810
Change-Id: Ibc32853736c539e76d84e135e3ef45201056026b
Reviewed-on: https://chromium-review.googlesource.com/1014249Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551123}

Supervised user notification was generated in TraySupervisedUser, which
is a SystemTrayItem.

We're going to get rid of SystemTrayItems as UnifiedSystemTray will
replace them, so we should generate the notification outside system
tray.

TEST=SupervisedNotificationControllerTest
BUG=none

Change-Id: Ifc774e83eb28e996f3f337040f31d736ab8e5f52
Reviewed-on: https://chromium-review.googlesource.com/1013117Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551122}

This CL is a refactor with no intended behavior change.

This CL also updates Browser::SwapTabContents() to return a scoped object, as
this was a caller of TabStripModel::ReplaceWebContentsAt.

The end goal is to update all instances of content::WebContents to have explicit
ownership semantics, which will allow us to clean up the internal ownership
semantics of TabStripModel.

Bug: 832879
Change-Id: I3ff525f8a265eb7a2abb0ee3921ac74b6b7e4271
Reviewed-on: https://chromium-review.googlesource.com/1012574
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551121}

      system tray still works

Bug: 327885
Test: sign into one user, start signin to a second user, cancel;
Change-Id: I9fa93bbd87a1f4a0087746e3a42ead07ee308710
Reviewed-on: https://chromium-review.googlesource.com/1008825
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551120}

This patch implements the LayoutNG version of InSameLine() on top
of ComputeNGCaretPosition():
1. Use ComputeNGCaretPosition() to find the fragment for a position
2. Traverse up from the fragment to obtain line box
3. Compare line boxes to decide if positions are in the same line

The implementation is simple in concept but inefficient, since
ComputeNGCaretPosition() traverses the whole block flow. Follow up
work will optimize ComputeNGCaretPosition() to reduce traversal.

Bug: 830956
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I34a7bc19953bd5995b70afa1b2890d15ef8da744
Reviewed-on: https://chromium-review.googlesource.com/1008631
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551119}

This UpdateCursorCompositingEnabled call is happening before
the GPU process is properly initialized.

Remove it as it's not needed here. UpdateCursorCompositingEnabled
will be called later when preferences have been loaded and GPU
process is properly initialized.

Bug: 832979
Test: chrome --ash-enable-cursor-motion-blur on Eve
Change-Id: I8603c007f1b0d201a046ffb7e84706af95c21097
Reviewed-on: https://chromium-review.googlesource.com/1013238Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551118}

These are unnecessary and caused the cryptauth tests to be run twice
when running all test binaries.

R=hansberry@chromium.org

Bug: none
Test: none
Change-Id: I006eaa35234a11bc4366a5020369d64d4f119f1c
Reviewed-on: https://chromium-review.googlesource.com/1014401Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551117}

Mac sandbox version 1 warms up some system APIs before sandboxing the
process. For pdf compositor service, it needs to use system text color
for lcd text smoothing test. So text color API needs to be warmed up
same as PPAPI process.

We also allow accesses to system color profile for both pdf compositor
service and PPAPI process in Mac sandbox version 2. This allows system
color access, thus prevents bitmap context creation errors caused due to
failed color access.

BUG=822218

Change-Id: I2352588e76e9b8c82d0fa87b3b99b7c897973d6f
Reviewed-on: https://chromium-review.googlesource.com/1014345Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551116}

Surface Aggregator uses render surface to apply opacity. This CL uses
an epsilon value to determine when opacity is close enough to 1.f to be
considered opaque.

R=enne

Bug: 831779
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic5f11429e4679c0990a9e441358701b8e3b5c7d2
Reviewed-on: https://chromium-review.googlesource.com/1008129Reviewed-by: enne <enne@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551115}

This change makes the ResizeDueToAutoResize messages for child frames
transactional, with a begin/end. It also ensures that during a
transaction we don't allocate new LocalSurfaceIds, instead waiting
for the transaction to complete.

Bug: 789259,805073
Change-Id: I585ac6d14b9978280847f49205d03bf49b9bb4f8
Reviewed-on: https://chromium-review.googlesource.com/960981
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551114}

When rbp was less than the offset, the check was underflowing and
incorrectly passing. Add a check for rbp < offset to detect this
situation.

Bug: 831448
Change-Id: I4f780c1573782af3ca29b0f814e93ff2dca839f2
Reviewed-on: https://chromium-review.googlesource.com/1013213Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551113}