- 12 Jun, 2018 40 commits
-
-
wutao authored
The default alignment of label was wrong. It should be always ALIGN_LEFT no matter it is RTL or LTR. The default behavior is to align left in LTR UI and right in RTL UI. Bug: 850390 Test: add new unittest: StyledLabelTest.*AlignmentInRTL* Change-Id: I058afab144acd46e221f889c57207340ef5aa26e Reviewed-on: https://chromium-review.googlesource.com/1094328 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#566573}
-
Sasha Morrissey authored
Check for canDelete capability when deleting files in the Files App. If it's blank or set to false, disable 'Delete' in the context menu for that entry. Add browser test fixtures to test capabilities are respected for the Delete option in the context-menu for read-only files. Bug: 719959 Test: browser_test --gtest-filter="Delete/FilesApp*" Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie3e604266a48223802e78f9d7255a8961ae535ce Reviewed-on: https://chromium-review.googlesource.com/1068645 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#566572}
-
Chris Blume authored
In a previous CL I accidentally removed the lines which set device_queue_. As a result, dereferencing it would cause a null pointer exception. This patch sets device_queue_ again and fixes our Vulkan tests. BUG=851749 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I69b5c8038e6b02e42a462bbaabdb24c238d184b0 Reviewed-on: https://chromium-review.googlesource.com/1096439 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566571}
-
CJ DiMeglio authored
This CL prevents VideoFrameSubmitter from accessing a bare ptr of |context_provider_| after it has been deleted by changing ptr to be a scoped_refptr. Bug: 845136 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia574a206519857ddb4169aaec281b64e3689e8ce Reviewed-on: https://chromium-review.googlesource.com/1087514 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#566570}
-
Sasha Morrissey authored
Added capabilities (canCopy, canDelete, canRename, canAddChildren, canShare) to the metadata cache for Files App. This is pre-work to grey-out drag/drop and context-menu operations based on file permissions. Bug: 719959 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If86cc407e1355aa01bd0fb1120c24da6eedee9b7 Reviewed-on: https://chromium-review.googlesource.com/1068768 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#566569}
-
mrefaat authored
WebStatePolicyDecider shouldAllowRequest needs more information to be able to determine if it should launch applications or not & to detect user intents. Created PolicyDeciderNavigationInfo and passed it from crw_web_controller DecidePolicyForNavigationAction to web_state_impl shouldAllowRequest This will make it easier to add more data through WebStatePolicyDecider::ShouldAllowRequest without changing all the places that it's used on. And it will also make the code more readable because i'll need to pass (LastUserInteraction, userRecentlyClicked and navigation_from_main_frame). bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I028b42936f3d74bae99596d31f8004db3b16ad73 Reviewed-on: https://chromium-review.googlesource.com/1092035 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#566568}
-
khmel@google.com authored
This allows to force OptIn UI show for some autotests regardless of profile/policy settings. TEST=cheets_AuthPerf.managed BUG=b/109698835 Change-Id: I82979b13924662a5dff718ef94b160291f225e33 Reviewed-on: https://chromium-review.googlesource.com/1097581Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#566567}
-
Danyao Wang authored
If a new navigation has started before |webView:didFinishNavigation| arrives, early exit and stop processing. Bug: 851708 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iea6ed9be60a547bc3fc2ee5bad6104b3a9eaef40 Reviewed-on: https://chromium-review.googlesource.com/1097564 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#566566}
-
danakj authored
It was virtual just for tests, but tests can simply call SetIsDrawble() to control the value of DrawsContent on a Layer. R=weiliangc@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I195ee17cbcc047d2baa288259f0ebcda0aed13a1 Reviewed-on: https://chromium-review.googlesource.com/1097544Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#566565}
-
Daniel Cheng authored
klast should be set to the value of the largest enumerator, not one larger. Rename it to kMaxValue as well so clang can automatically enforce this. Bug: 482580 Change-Id: Ia37ffb8bb55331f55a74832e42d146669b32e059 Reviewed-on: https://chromium-review.googlesource.com/1097584Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566564}
-
Jialiu Lin authored
For a small portion of Canary and Dev users, there maybe captured sync password hashes with no |is_gaia_passord| field. This CL finds all these entries, and set |is_gaia_password| to true, or remove them if if there's already a matching hashes with |is_gaia_password| set. This CL should not impact the behavior of Beta and Stable channel. Bug: 830998 Change-Id: I96f236a8275c8cc78316d962a4e130761a568377 Reviewed-on: https://chromium-review.googlesource.com/1096372Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#566563}
-
Kai Ninomiya authored
See gpu/GLES2/extensions/CHROMIUM/CHROMIUM_nonblocking_readback.txt for documentation. Bug: 828135 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I16d8aeb2b902629c12684317bd8cea321f2a71e4 Reviewed-on: https://chromium-review.googlesource.com/1043024 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566562}
-
Danyao Wang authored
crrev.com/c/1087640 changed |webView:didFinishNavigation| to use navigation item in NavigationContext instead of self.currentNavItem, but missed the fact that WebUI navigation didn't set navigation item in NavigationContext. This fixes a crash caused in loading WebUI. Bug: 851969 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I57278078fad7abc7e14548ca52c03a573afa2f75 Reviewed-on: https://chromium-review.googlesource.com/1097607Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#566561}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=stevenjb@google.com Change-Id: I019c01fabfab58858ef7fd031a7392573ac39067 Reviewed-on: https://chromium-review.googlesource.com/1097622Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#566560}
-
Xiaohan Wang authored
- Move KeySystemProperties::GetSupportedSecureCodecs() from being Android-only to being available on all platforms. This is in preparation of supporing hardware secure codecs on Windows. - Also make hardware secure codecs handling logic in KeySystems available on all platforms. - Add more test cases related to hardware secure codecs. Bug: 848532 Test: Existing test enabled on more platforms; new tests added. Change-Id: I6e6ceb6299f59f49483ca8cb1d287498aa97a7be Reviewed-on: https://chromium-review.googlesource.com/1096356Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#566559}
-
Daniel Rubery authored
Adds field "content type" to LoginReputationClientRequest, and populates it using the MIME type of the web contents. Bug: 799227 Change-Id: I9c09e3e143ba9aa331613c24482d742fa51d1bba Reviewed-on: https://chromium-review.googlesource.com/1096407 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#566558}
-
Will Harris authored
BUG=767906 Change-Id: I6ee1d00152a67f751f299ebc63ed912dc29aba5c Reviewed-on: https://chromium-review.googlesource.com/1091393Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#566557}
-
Navid Zolghadr authored
Add a new version of scrolling metrics with even higher maximum to accomodate for low end devices. Bug: 849735 Change-Id: I29296c7a2ce6fcfad831b9f5fe81a86cdb759e28 Reviewed-on: https://chromium-review.googlesource.com/1095416 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#566556}
-
Chris Blume authored
Different translation units were seeing different structs holding the Vulkan function pointers. This was because those different translation units may or may not have had the Vulkan platform define set. This means one translation unit saw a struct which contained an Android-specific function pointer. Another translation unit saw a struct which didn't have that function pointer. The function pointers were being clobbered as these different translation units attempted to fill in the struct. This patch will set the Vulkan platform define in BUILD.gn so all Vulkan translation units have that define set. BUG=851718 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idb56c9caaeaf9ac8351cd58fb9c70877cc909487 Reviewed-on: https://chromium-review.googlesource.com/1096373 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566555}
-
Niels Möller authored
Needed for webrtc cl https://webrtc-review.googlesource.com/c/src/+/81240, which replaces plain enum by enum class. Bug: webrtc:7660 Change-Id: I1063b6cfc136c1a83e8972736440b68c58eceab6 Reviewed-on: https://chromium-review.googlesource.com/1096771Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566554}
-
Xianzhu Wang authored
This is the first step of refactoring raster invalidator, before moving raster invalidation code out of PaintController into paint/RasterInvalidator. Bug: 843606 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0bd4b98b2ccd0e0bc6b7c87255ce81c33115a16b Reviewed-on: https://chromium-review.googlesource.com/1097507Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566553}
-
Yi Gu authored
Currently we have two paths for adding keyframe models in animation test. The one in animation_test_common.h is a legacy to accommodate for SingleKeyframeEffectAnimation. The other one is in animation_unittest.cc which supports for animations with group effects. This patch unifies the two so that we are able to test group effects. Bug: 767043 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icd839152eef6becc8aa34af3342544ae02d70f4c Reviewed-on: https://chromium-review.googlesource.com/1092871Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566552}
-
Victor Costan authored
Bug: 851064 Change-Id: I54d15696e0d676e902e7b60660536a492f67b406 Reviewed-on: https://chromium-review.googlesource.com/1093546Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#566551}
-
Mikel Astiz authored
We rename ActivationContext-->DataTypeActivationResponse to avoid confusion, and introduce a new struct (DataTypeActivationRequest) that bundles context information that is relevant during activation of a datatype. In this implementation, ModelTypeController pulls those bits from SyncService's public API, but it may make sense to instead explicitly plumb them through DataTypeManager, in future patches. Bug: 833483,820049,850428 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I91c5c3552dbd5db1c446dd6e00ef74389135af87 Reviewed-on: https://chromium-review.googlesource.com/1087062Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#566550}
-
Sebastian Amend authored
These methods aren't used anymore and are associated with types that were deleted in earlier commits: WebMediaSession was removed in 93b95f8b, WebSyncProvider was removed in c5b9f364. Change-Id: Ibbcb47cb350c2ee6be84d159c5d9be70212601da Reviewed-on: https://chromium-review.googlesource.com/1086935 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566549}
-
Reid Kleckner authored
Otherwise, they will have exports from bits of the ASan runtime library that are linked statically into each ASan-instrumented DLL. R=pennymac@chromium.org,thakis@chromium.org BUG=848066 Change-Id: I93ebfe118423aa5c429465a901e709c31ccd80e4 Reviewed-on: https://chromium-review.googlesource.com/1096371 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#566548}
-
Dominic Battre authored
This CL adds some VLOG debug statements that help us identify problems in case they arise during launch. They turned out to be useful while working on a finch config. They won't replace debug data in chrome://password-manager-internals, though. But that will be based on the serialization introduced here. Bug: 846694 Change-Id: I20e8c1826cc8fa00860bfbeccaf832e93a0bb125 Reviewed-on: https://chromium-review.googlesource.com/1097086Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#566547}
-
Ted Choc authored
Adding and removing the suggestion view in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1091505 triggered complaints about adding/removing views multiple times. This ensures the view is not already in the tree before attempting to add. BUG=851442 Change-Id: I5de55e63edcc690861ba3917b0fabad4896a1f6f Reviewed-on: https://chromium-review.googlesource.com/1096424 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#566546}
-
Luciana Maroun authored
non-enterprise reporting. Bug: 851697 Change-Id: I60944e7e79b87d80a656e90ecc900bc0d08fee57 Reviewed-on: https://chromium-review.googlesource.com/1097203 Commit-Queue: Luciana Maroun <maroun@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#566545}
-
Ken MacKay authored
To avoid priority inversion, we need to use a different thread for post *to* the mixer than we use for post data *from* the mixer. Bug: internal b/106289282 Change-Id: I9dec6b2a4f8b38d7895de3d076e48c1e1ef6491b Reviewed-on: https://chromium-review.googlesource.com/1095858Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#566544}
-
Christian Fremerey authored
A recent CL https://chromium-review.googlesource.com/c/chromium/src/+/1026795 caused a regression by introducing a new mojo enum VideoCapturePixelType and typemapping it to media::VideoPixelFormat, see Bug 839742. The motivation for that change was to make the video capture service API, which had a dependency on the native enum VideoPixelFormat in media_types.mojom, compatible with an older version of Mojo used on ChromeOS. This older version does not support native enums. This CL replaces the bad solution from the CL above with the following: * Instead of using a native enum VideoPixelFormat in media_types.mojom, declare a Mojo enum and move it to a separate file. * Add typmapping from the Mojo enum to the native enum. * Have the video capture service API mojoms depend on only the new file containing the Mojo enum for VideoPixelFormat. This way we avoid the API depending on any file that uses native enums. Bug: 839742, 847598 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ifcff064b1f0eb95579119916b757dc6512f49a15 Reviewed-on: https://chromium-review.googlesource.com/1050489 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#566543}
-
Philip Rogers authored
The main scrolling coordinator update, ScrollingCoordinator:: UpdateAfterCompositingChangeIfNeeded, does not depend on the PrePaint phase and can be moved after PrePaint. This change will make it easier to compare the new PaintTouchActionRects update (ScrollingCoordinator::UpdateTouchActionRects) to the current update (ScrollingCoordinator::UpdateAfterCompositingChangeIfNeeded). This patch also renames UpdateAfterCompositingChangeIfNeeded to UpdateAfterPrePaint and adds a comment describing what it does. Bug: 851513 Change-Id: Idbcd515708a33d6955deb513808874b38d731c4f Reviewed-on: https://chromium-review.googlesource.com/1096297Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#566542}
-
Malay Keshav authored
Display zoom is responsible for scaling when the flag is enabled so we dont need to manualy set the device scale factor for external 4k displays. Bug: 851701 Change-Id: I7b2789fa233dda89d3f2dd5031b5507c4c64b1ed Component: Display Change Observer, 4k, Scaling Reviewed-on: https://chromium-review.googlesource.com/1096343Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#566541}
-
Mathieu Perreault authored
Per the mocks and designers, the dialog footers should be Grey050 and the top separator Grey200. This replaces the previously harcoded colors. Screenshots on the bug. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --draw-view-bounds-rects --test-launcher-interactive Change-Id: Ic450f161e56074fe04809aa577bce2dae17befd0 Reviewed-on: https://chromium-review.googlesource.com/1096912Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#566540}
-
Tessa Nijssen authored
When text is selected in a textfield, the touch bar displays options to replace the selected text. Clicking on one of the options will replace the selected text with the selected option. Currently, there are no functional unit tests for the suggested text touch bar. As functionality is fleshed out, unit tests will be created. A new folder (chrome/browser/ui/cocoa/touchbar) was created to house all files related to the Mac touch bar. The CreditCardAutofillTouchBarController files and the WebTextfieldTouchBarController files were moved to this new folder. Dependencies and header guards were updated to reflect this change. New files: - suggested_text_touch_bar_controller.h - suggested_text_touch_bar_controller.mm - suggested_text_touch_bar_controller_browsertest.mm Moved files: - credit_card_autofill_touch_bar_controller.h - credit_card_autofill_touch_bar_controller.mm - credit_card_autofill_touch_bar_controller_unittest.mm - web_textfield_touch_bar_controller.h - web_textfield_touch_bar_controller.mm BUILD files were updated to accomodate the change in location for the moved files and to include the new files. WebContentsImpl, WebContentsDelegate, and WebContentsObserver were modified so that the SuggestedTextTouchBarController can observe TextInputManager for a change in text selection. A feature flag SuggestedTextTouchBar was created and added to chrome://about so that the new touch bar is disabled by default and can be enabled via command line or chrome://flags with the flag #enable-suggested-text-touch-bar. This CL includes the following browser tests for SuggestedTextTouchBarController: - SetTextTest - TouchBarTest - TextSelectionChangedTest Bug: 717553 Change-Id: Iddba71339a3631a1405a37e461020345f921f817 Reviewed-on: https://chromium-review.googlesource.com/1096443 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566539}
-
Scott Graham authored
1f3052c1ccec Add support for attachments to generic crash report database f5564e6292b1 Roll gtest (and mini_chromium) 9839ef5605cf Clean up Fuchsia package() c86c9f0f730d Don't merge stack mappings with different names 3033802ed4ad Remove unused port wait/queue argument 5191992ae54c win: Fix SimulateCrash.ChildDumpWithoutCrashing under ASAN, disable others 5c49c598477c fuchsia: Implement TLS support in HTTPTransportSocket 26ef5c910fc7 aarch64: Use xzr instead of x31 in the ASM code dc22f05f6189 fuchsia: Fix build vs. TLS support when in-tree 129975417947 fuchsia: Migrate off launchpad 51ebe79f0619 fuchsia: Fix inverted CHECK condition in migration to fdio_spawn 9de3535bbb03 fuchsia: Re-add launchpad for now 3edb7869da31 Roll cpp-httplib to HEAD (5b3187e2f) 9a97daff395a Add libfuzzer support a42b5269b4b6 Add ProcessSnapshotSanitized d1e6a2130da4 android/linux: add a client interface to control sanitization bff3594594ab fuchsia: Update includes for new fdio header location 7c6d2334a93c Don't fail minidump write if memory snapshot read fails NOPRESUBMIT=true Change-Id: I1729f6873506ccbc82debc626faceac0f62a9965 Reviewed-on: https://chromium-review.googlesource.com/1097577Reviewed-by:Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#566538}
-
Boris Sazonov authored
This CL adds CheckableImageView widget that extends AppCompatImageView and allows simple transition animations by using AnimatedStateListDrawable. Bug: 814728 Change-Id: Ib2763d5089cb86c3db6d924af7870965ab5e04e2 Reviewed-on: https://chromium-review.googlesource.com/1097402Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#566537}
-
Jacob Dufault authored
Bug: 841451 Change-Id: I373922476fb2e875c80b160cfd77144b5695ea3e Reviewed-on: https://chromium-review.googlesource.com/1085635Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#566536}
-
Kyle Horimoto authored
These files are currently still stubs, but they are needed for a follow-up CL. Implementation will come once the other CLs are finished. Bug: 824568, 752273 Change-Id: I7456f713471f1608d99ba250bd3e001114c66c79 Reviewed-on: https://chromium-review.googlesource.com/1097586Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#566535}
-
jonross authored
This creates a new observer in viz, viz::HitTestRegionObserver, which can be used to listen for the arrival of hit test data within a Viz Host. This also creates a test class, viz::HitTestRegionObserver, which can be used by tests to wait upon hit test data. Since the Viz hit test path is not yet on by default, this has fallbacks to classic helpers which wait on cc::Surface embedding. Furthermore a series of existing callsites of WaitForChildSurfaceReady and WaitForGuestSurfaceReady have been converted to use the new api. They are being re-enable for Viz test configs. TBR=fsamuel@chromium.org TEST=viz_browser_tests, viz_content_browsertests Bug: 785986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I77889df44a96d81a37d4fb26255401c433069531 Reviewed-on: https://chromium-review.googlesource.com/1071886 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#566534}
-