- 26 Oct, 2020 40 commits
-
-
Daniel Libby authored
Add a couple of crashers missed in the first batch, add Failure for the handful of focus tests that don't pass with the flag turned on, and optimistically mark any seen Timeouts as Slow to see if the a11y code is moving these tests over the threshold. After iteration a handful of tests look like they somewhat consistently timeout and others do occasionally, so marked as such. This gets the bot to green as the set of failures is reduced enough to allow the with/without patch comparison to take place, but further follow up is needed for the remaining failures. Bug: 1138028 Change-Id: I699906828a7384bd129ed23cb22ccddb86cb4e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484326Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820872}
-
Bo Liu authored
Keep comment code such as creating SkColorSpace or converting parameters in AwDrawFnImpl. Fixed: 1141685 Change-Id: I0c7191b59fffe413259d7ee308eb2f4610424ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495918 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820871}
-
Dale Curtis authored
This gives VideoTrackRecorderImpl a WebGraphicsContext3DProvider bound to the encoder thread so frames can be retrieved inline before encoding instead of having to hop to the main thread. Local testing shows this is ~10% faster in terms of unit test run time; ~16s to ~14s. To facilitate this change, the existing worker-thread based context creation used by WebGLRenderingContextBase is extracted into a utility class in "blink/renderer/platform/graphics/". Fixed: 1138712 Change-Id: I137f4f6830ac1c7b0860f6c65584a85b276607a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495867 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#820870}
-
Shuran Huang authored
Clear window.name in top-level cross-browsing-context-group navigation. Because in those navigations, window.name loses its use purpose (e.g. postMessage and window lookup) but somehow the value still preserves. It's unlikely anyone is relying on the name being preserved. crrev/c/2276250 collects the metric for how often window.name is accessed in such cases and the UMA data proves the change should be low risk. This change is implemented behind a flag. Bug: 1090128 Change-Id: Ib3fd61b8b50f1452af2717e360da21fd2ecaf92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363389 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820869}
-
Nick Harper authored
Change-Id: I8e1a79c0077f86da02425cf796eebb9fbdc6d9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459527 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#820868}
-
Dan Harrington authored
This is in preparation for a test to be added in that location. Bug: 1141619 Change-Id: I5731ff84dcc79d81acb3f877ab47c4c6e2acaffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493125Reviewed-by:
Arthur Wang <wuwang@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820867}
-
Mugdha Lakhani authored
Per code review feedback here: https://chromium-review.googlesource.com/c/chromium/src/+/2470634/comment/fee3ad23_a4607e7f/ the API was introduced for M88 first. Once the API implementation has been cherry-picked to M87, this change will land, supporting it M87 onwards. Bug: 1136091 Change-Id: I9544c97faf807b5c59e9d4113768804e0fad96d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489999 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820866}
-
Sky Malice authored
This in product help bubble will only be displayed when the home button still points to the new tab page, and has not been overridden. Bug: 1130751 Change-Id: Ie26bdb34112e5ef94d8c3a6419488699dee937d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449932 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#820865}
-
Sebastien Lalancette authored
Moving the existing utility functions in ios/web to the new common folder along with the other utility functions. Bug: 1136043 Change-Id: I6970bce02c72c9794f6574c22816d5c3608364b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494990Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#820864}
-
Lei Zhang authored
Instead of std::unique_ptr<base::Value>. Bug: 1139221 Change-Id: Ie28bd486e0eed75cdb4287c3efd778aceac32f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496034Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820863}
-
Patrick Noland authored
Bug: 1142486 Change-Id: I6bcafa3f76de8a773a7caafe8f41d89d297c99ce TBR: michaelbai@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499442Reviewed-by:
-
Wei Li authored
These buttons are subclasses of ImageButton, LabelButton, or ColorTrackingVectorImageButton. They inherited their focus behavior previously. This CL explicitly DCHECK and set their behaviors so that the parent classes' changes won't affect them. The DCHECKs will be removed when we flip the parent classes' behaviors. Bug: 1001103 Change-Id: I30f0c08cbdbf7ed8b09c40aa1033e155cb67d6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495921Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#820861}
-
Oriol Brufau authored
These tests were failing in LayoutNG because overflowing list markers were not triggering scrollbars. But this was fixed in r814090 thanks to NGLayoutOverflowCalculator. So this patch expects the tests to pass. Bug: 1012294 Change-Id: Ic24eb1021d91cf30a09c190c54cf23b47a030bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498567 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#820860}
-
Jamie Walch authored
This CL improves the "best mode" selection logic to take into account the initial as well as the current orientation and frequency, preferring the initial values for both where available. Bug: 1140756 Change-Id: I1497df10d718ec5b297dc88c7f69694bc977fef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487877 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#820859}
-
Joe Downing authored
This CL adds an optional parameter to start_host which will be used to verify that the auth_code provided was generated by the expected user account. This flag is optional as it is only needed for scenarios where the host owner is not manually setting up the instance. Change-Id: I6f48d008c9ea59e94532f8f84d6a7d5cf20cf68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495877 Commit-Queue: Joe Downing <joedow@google.com> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#820858}
-
chrome://quota-internalsdpapad authored
Bug: 1132403 Change-Id: Icf389d0a6dff707bcb17e9e03006f06821d26765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497197 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#820857}
-
Kenichi Ishibashi authored
This is a refactoring CL to avoid raw pointer allocations in ServiceWorkerDiskCache. To remove raw pointers, this CL changes CreateEntry(), OpenEntry(), DoomEntry() from //net-style maybe-async to always-call-callback style. This CL also removes ServiceWorkerDiskCacheEntry::Close() to make its lifetime less surprising. Bug: 1117369, 586174 Change-Id: Ie310446b8b55361c47b778237af1a5f6f5582bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484022 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#820856}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie4998c154245055321fa28f762ab7697ee0faa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499322Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820855}
-
Guillaume Jenkins authored
Adds simple unit test cases for the ProfileReportGeneratorIOS class. The tests generate a report that includes some policies tied to the main profile (browser state), and check that the values in the proto make sense. Bug: 1114853 Change-Id: I4e56e79754c2e30e6e02080fc58b43ae63b8ae2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495342 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820854}
-
Sky Malice authored
The purpose being the method added in this CL is to allow experiments to optionally specify params. If they are specified at the experiment level, then they will always check and verify they are satisfied. However if they are not specified at the experiment level, then the check is a no-op. Bug: 1130751 Change-Id: Ifa31189f9f1d92340a66311bdcacba75623b807b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476713 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71002a226ac5..0fb0eb3e80c0 2020-10-26 alessiob@webrtc.org RNN VAD: LP residual optimized (part 4) 2020-10-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3aacaf7d..4d9dbbae (820594:820701) 2020-10-26 alessiob@webrtc.org RNN VAD: LP residual optimized (part 3) 2020-10-26 guidou@webrtc.org Remove support for legacy TLS protocols by default If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I63f3d00a1c986c52223862cee2f4d04531e24390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820852}
-
Keishi Hattori authored
ScriptState assumes DisposePerContextData() and DissociateContext() gets called on it before destruction. This was not happening for ScriptRegexpContext's ScriptState because it was only ever used on the main isolate and so it was never destroyed. To use it on the worker threads, we need to add cleanup code for it, script_regexp_script_state_. Bug: 1136219,1105265 Change-Id: Ifde0bf416bd68b15b55fe1dc266e7b6ae57a3432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494243 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#820851}
-
Mark Mentovai authored
In order for the update service to distinguish between single-architecture x86_64 and arm64 builds as installed, the architecture should be present in the tag that the update client presents. On its own, Keystone reports the architecture of the system it’s running on, but for cases where the installed version may be native to the system (an arm64 system running x86_64 Chrome under Rosetta translation), where it may be preferable to retain the existing build type for a period of time under our control, the architecture of the installed product must also be reported. This information can also be used to detect when a non-native version of Chrome is installed so that, again under our control, we can direct an update to a more suitable native version as appropriate. This makes no changes to the tags used for single-architecture mac-x86_64 builds. Whether this is advisable long-term is another question, but for now, the prudent thing to do is to maintain the status quo for the vast existing installed base. Any changes to that strategy must be coordinated with the server-side configuration. This changes the tags used for single-architecture mac-arm64 builds to contain the “arm64” string, like “arm64”, “arm64-dev”, and “arm64-full”. Bug: 1116601 Change-Id: I8e9dbc41285ea37018ebfd4e50b41bee985d9c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496200Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#820850}
-
adoneria authored
Also changes test case superclass to typ.TestCase. Bug: 1141577 Change-Id: I0d9b4b38543d1cd904808d9f85b6aa27ab973c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496180Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#820849}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ddda3e8e6f2..d2663acda4ce 2020-10-26 janscheffler@chromium.org [Network] Properly escape form data for copy as curl 2020-10-26 bmeurer@chromium.org [cleanup] Remove string internalization from DebuggerModel 2020-10-26 pfaffe@chromium.org TypeScriptify BreakpointEditDialog 2020-10-26 Luke.Swiderski@gmail.com Removed border-bottom from header, added border-top to container wrapper 2020-10-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-26 bmeurer@chromium.org [wasm] Hide gutter context menu options that don't work. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1133677,chromium:1136484 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id3674d6a4346ad0713e063c8ca4e18cd288b1115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498847Reviewed-by:
-
Alexander Hendrich authored
Field names should be wrapped inside a <ph>...</ph> to prevent translation. I've also synced the description for WebUsbAllowDevicesForUrls and DeviceLoginScreenWebUsbAllowDevicesForUrls again. Bug: b:171572150, b:171578694 Change-Id: Ia2c6d54dd6a644a83dda5db3bbfb9f0ce9850c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498524Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#820847}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/da8c46c5..f0fe38b2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I694d6047cdf215f64bfd344e9c8d2aba2cac42bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499321Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820846}
-
Sadrul Habib Chowdhury authored
Some of the stories (e.g. canvas_*_pixels_per_second, text_*_pixels_per_second, etc.) scroll the page, but depending on the velocity (e.g. when velocity is over 20000 pixels/second), it can end too quickly, and produce only a handful of frames. As a result, some of the metrics (e.g. PercentDroppedFrames.AllSequences) are not reported, since they require at least a minimum number of frames. This can result in some flakes (e.g. crbug.com/1113556) in the dashboard. To fix this, keep scrolling the page for at least 15 seconds, so that there are enough frames produced to report the metrics. Bug: 1141854 Fixes: 1141854 Change-Id: Ia6adb0257081bf2d321c62e2c362ece3fe4c9f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495340 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mingjing Zhang <mjzhang@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#820845}
-
Danan S authored
This CL adds: - Polymer template for all the screens of the UI - Shared styles for all the screens - Button templates and behaviors - Error screen - Network offline screens Also: - UI behaviors and event handler implementation to enable the flow to operate. These are mostly in: chrome/browser/resources/chromeos/edu_coexistence/edu_coexistence_ui.js chrome/browser/resources/chromeos/edu_coexistence/edu_coexistence_app.js But there are smaller bits of functionality in the other js files as required by their respective screens. Bug: 1133828,1133827,1123218 Change-Id: I297fe1a5c18bb3806d94b4c5e635c0dd4a990f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462673Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820844}
-
Dylan Cutler authored
SQLitePersistentCookieStore::Backend::MakeCookiesFromSQLStatement. This factory method is used when creating a CanonicalCookie from a cookie that has already entered the user agent storage model. Bug: 1102874 Change-Id: Ie6792b0348a40edb760e7da0192e4879952c415a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495802Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#820843}
-
Clark DuVall authored
Trichrome needs a dep on version_constants_java in the base module because it may be accessed in child processes here: https://source.chromium.org/chromium/chromium/src/+/master:chrome/app/chrome_main_delegate.cc;l=607;drc=1d71c85d74e18a75b10ac9c6bfb0282f193c157d Bug: 1126301 Change-Id: Ia5ddb4941718d6b9c0d05523d677fb1d87ef83f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499365 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#820842}
-
Ted Choc authored
Longer term, I wonder if HomepageManager should provide the ObservableSupplier itself and handle these updates internally without ToolbarManager (or something else querying). BUG= Change-Id: I3ccedd220332fb2ea5bdca936c619934cbfe0420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490491 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
After this CL, the rewriter will detect fields that are initialized with non-nullptr value in constexpr constructors. Such fields will be emitted as candidates for exclusion via --exclude-fields cmdline parameter. This CL should help ensure that the build is successful, once we stop excluding |const char* fields| from the rewrite. In particular, performance_manager::PriorityAndReason::reason_ field needs to be excluded in practice. Additionally, this CL should help to automate excluding of the various base::FeatureParam fields/scenarios (they are currently covered via manual-fields-to-ignore.txt). Bug: 1069567 Change-Id: I122a329577f77d8172e26f189b5155af742a33c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495719 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4280.20-1603104419-benchmark-88.0.4303.0-r1 to 88-4296.0-1603709458-benchmark-88.0.4303.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1ea9295966a7b0e91ce8fdeac2c168a5c3fc5661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499410Reviewed-by:
-
Lei Zhang authored
It is only used in ios/components/io_thread/, so move it there. Change-Id: Icc86011f711f2325a7bd33931fd8b12d6e2164ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373366Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820838}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603238376-a0754723f0cd6eaa7fc2494ab4a5f08c0cee1720.profdata to chrome-mac-master-1603713364-eb28cdd9672687229cd838b6373ed78fbaa1ba2f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4bda56d64f8d2a656be8992f4f00b7894370401d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499403Reviewed-by:
-
Lei Zhang authored
Use base::Value::FromUniquePtrValue() in many case to get a base::Value. Bug: 1139221 Change-Id: I343cfc81ac25b3fb1d49d9aa66ed664bf1e5bd72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482246Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820836}
-
Aaron Krajeski authored
Bug: 1141032 Change-Id: Ie60a6d659837517aada27bd99e4c88b1e2a26494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490261Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#820835}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4280.20-1603100572-benchmark-88.0.4303.0-r1 to 88-4296.0-1603705354-benchmark-88.0.4303.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie4f519be2ed8533e9c7fc3b41319fa2344d71dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498876Reviewed-by:
-
Josh Nohle authored
Notable changes needed in Chromium code: - A LocationHint argument was added to WebRtcMedium::GetSignalingMessenger() - V1 code was removed from the third_party nearby-connections library, and the "_v2" suffix was removed from directories and filenames. For consistency, we remove the "_v2" suffix from //chrome/services/sharing/nearby/platform_v2/ as well. Tested manually on ToT. Confirmed that Android <--> Chromebook works as expected for contact-based and high-visibility sharing. We hit crbug/1142071, but confirmed that occurs without the uprev as well. Change-Id: Ia1a61370b5b5f05b4f294d915a0ccb193bc339c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493108Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#820833}
-
