- 28 Sep, 2017 40 commits
-
-
Theresa Wellington authored
BottomToolbarPhone#updateVisualsForToolbarState() is now called from BottomToolbarPhone#onAttachedToWindow(). We have crash reports indicating that for some users the bottom sheet is null when the toolbar is attached to the window. Adding null checks. BUG=769612 Change-Id: I6dc5e86851b8c054f50e798ac854fff0e3629d43 Reviewed-on: https://chromium-review.googlesource.com/690800Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#505135}
-
Pavel Yatsuk authored
The problem that caused https://crbug.com/761476 is that signin flow didn't enable syncing in AndroidSyncSettings, but instead relied on sync engine initialization to implicitly update it. Because sync initialization takes time it was possible for untimely SyncController instantiation to propagate obsolete value of "sync automatically" flag and trigger sync engine shutdown. In this change I'm adjusting SigninManager to enable sync at the end of signin flow. This explicitly records intention to enable sync engine. If SyncController is instantiated by the time of this call then it would trigger ProfileSyncService.requestStart(). Otherwise it will propagate Android settings and start sync engine during normal initialization in GoogleServicesManager. BUG=761476 R=bsazonov@chromium.org Change-Id: I76c576afa3591cff105d4fb49caf1a938bf4efdd Reviewed-on: https://chromium-review.googlesource.com/688828 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#505134}
-
Tom Anderson authored
Canonical's notification development guidelines [1] specifies that only '<', '>', and '&' characters should be escaped when the notification server supports the 'body-markup' capability. Previously, we were escaping single and double quote characters as well. On Cinnamon, this would cause the ' character to render as '. This CL only escapes the recommended chracters. [1] https://wiki.ubuntu.com/NotificationDevelopmentGuidelines#If_a_notification_uses_a_.2BIBw.3C.2BIB0_or_.2BIBw.26.2BIB0_character.2C_and_it_has_missing_or_wrong_text BUG=676220 TBR=peter@chromium.org CC=thestig@chromium.org Change-Id: I3e6f6ea60be52a9e4f406c728701f9f666362bc6 Reviewed-on: https://chromium-review.googlesource.com/688294Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#505133}
-
Daniel Murphy authored
TBR: ericwilligers No-Try: true No-Presubmit: true Bug: 769879 Change-Id: I217c445a716c687e8942dee2fbdc8a59b7cef55b Reviewed-on: https://chromium-review.googlesource.com/690453 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#505132}
-
Matt Mueller authored
With use_byte_certs, creating an X509Certificate does not use the platform certificate implementation. Bug: 769549 Change-Id: I23d7871ee3d3f52f72e2293c60cd231d658a2845 Reviewed-on: https://chromium-review.googlesource.com/690780Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#505131}
-
Devlin Cronin authored
Don't show the dev-mode reload spinner for disabled extensions. Update tests to match. Bug: 769539 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I16927e8faa9c4cbe69042d62b41c93df5ec714b8 Reviewed-on: https://chromium-review.googlesource.com/688682Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505130}
-
Yuri Wiitala authored
Minor tweak to a GLOB to add this file to the set owned by ipc/SECURITY_OWNERS: services/viz/public/cpp/compositing/struct_traits_unittest.cc TBR=zmo@chromium.org Change-Id: Idbb29a60c13dd430bf18e56c34b17ad2c7bc7b81 Reviewed-on: https://chromium-review.googlesource.com/689194Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505129}
-
Daniel Murphy authored
No-Try: true No-Presubmit: true TBR: beccahughes Bug: 769881 Change-Id: If3a5a0a26b880907693d4906cfebdb42bd6f405e Reviewed-on: https://chromium-review.googlesource.com/690624Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#505128}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=benwells@chromium.org Bug: 666525 Change-Id: I4817794f96d6b0b428ad2be9d465452e2a863a85 Reviewed-on: https://chromium-review.googlesource.com/688170Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505127}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=timloh@chromium.org Bug: 666525 Change-Id: If15d845c29b7a81d392aa35774ed243f7db618e8 Reviewed-on: https://chromium-review.googlesource.com/689028Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505126}
-
David Benjamin authored
This doesn't particularly matter, but if we ever split the libraries up for enforcement, we'll want the dependencies out. The name of the issuing cert isn't going to change, so just hard-code it in the test. The ClientCertStore tests already do this and I'm not sure this field is used at all anyway. Bug: 706445 Change-Id: I780002ae90c9668507fba64a5c3acf0139c7bfe0 Reviewed-on: https://chromium-review.googlesource.com/690159Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#505125}
-
Bruce Dawson authored
Last week VS 2017 was made the default compiler on Windows. It didn't take long for a dependency to creep in and now VS 2017 is *required* to build Chrome on Windows. This CL makes this explicit, to avoid confusing error messages, and it requires a particular minimum *version* of VS 2017 in order to avoid compiler bugs that were seen in previous versions. crrev.com/c/678859 was the change that made VS 2017 the default. Bug: 683729 Change-Id: I3db12c0c9d98400077e6bd41afea16d4d071352a Reviewed-on: https://chromium-review.googlesource.com/688746Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#505124}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=fgorski@chromium.org Bug: 666525 Change-Id: I6e70f5ac9d552ad575fd9339f1af8d39bf04bed7 Reviewed-on: https://chromium-review.googlesource.com/689105Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505123}
-
Scott Chen authored
This CL ports over the kiosk app management modal from the existing extensions page to the MD extensions page. Bug: 764943 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib35d989227aa023dc08673fb54d8f38275abad80 Reviewed-on: https://chromium-review.googlesource.com/671905 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#505122}
-
Drew Davenport authored
Some symbols are not defined for __aarch64__ BUG=none TEST=this file successfully compiled on arm64 Change-Id: I96bd4db153307913ee3cfbe4f7f7f2a7f8288eaa Reviewed-on: https://chromium-review.googlesource.com/689746Reviewed-by:
Justin TerAvest <teravest@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#505121}
-
Matt Menke authored
Bug: None Change-Id: I441e3fcef320e94b0b1c690c66e9d433d5954e8c Reviewed-on: https://chromium-review.googlesource.com/690158Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#505120}
-
Miriam Gershenson authored
This CL merges the higher-level DNS histograms to include both async and system resolver timing in the same metrics. This will allow easier use in Finch experiments. It also adds the new Net.DNS.TotalTimeNotCached histogram, which is equivalent to Net.DNS.TotalTime minus cached and other synchronous resolutions, for better alerts. The current TotalTime histogram is hard to use for alerts because the median is 0. Bug: 769320 Change-Id: Iea7873ddd284fffe1e0e414f1e33f2e07053c0ca Reviewed-on: https://chromium-review.googlesource.com/673092 Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505119}
-
Yuke Liao authored
This reverts commit d909eb87. Reason for revert: This CL is causing RecentTabsTableTestCase/testClosedTabAppearsInRecentTabsPanel to fail on iPad: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/31975 Original change's description: > Respect safe area for NTP view > > The NTP view cannot use the safeAreaInsets property directly as it is > snapshotted before being inserted in the view hierarchy, and the safe > area is only available for views in the view hierarchy. > This CL introduces a property mirroring the safe area once the view is > in the view hierarchy. But it is also set up with the value used in the > first frame, allowing the snapshot to be done as if the view was in the > view hierarchy. > > Bug: 767869 > Change-Id: I605566105862e9f4c557736ec65df5f8ab1fc76b > Reviewed-on: https://chromium-review.googlesource.com/681942 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> > Reviewed-by: Jean-François Geyelin <jif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505041} TBR=rohitrao@chromium.org,jif@chromium.org,gambard@chromium.org Change-Id: I05bb5751f1ec6aec184dfe6ccff7741f2df4182d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767869 Reviewed-on: https://chromium-review.googlesource.com/690817Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#505118}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/591738408846..b9dc069a4752 $ git log 591738408..b9dc069a4 --date=short --no-merges --format='%ad %ae %s' 2017-09-27 simonhatch Dashboard - Add pinpoint-perf-job-dialog for perf try jobs. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2be21ac29627ff27a383e36b396d96f490494a9b Reviewed-on: https://chromium-review.googlesource.com/689702 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505117}
-
Sean O'Brien authored
After a pinch begin event, send subsequent pinch events to the same target until the next pinch end event. Bug: 769797 Change-Id: Id3b9d368290f7f07f7c8887929db8d7e7dc17da7 Reviewed-on: https://chromium-review.googlesource.com/685361 Commit-Queue: Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#505116}
-
Wei-Yin Chen (陳威尹) authored
Bug: 742386 Change-Id: I39a95db12e9ac08ed4d03146eea4ea9d61c15b8d Reviewed-on: https://chromium-review.googlesource.com/667822Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505115}
-
Matt Menke authored
NetLog needs to be moved into the network service. The first step is removing it from the BrowserProcess. The DialRegistry is now passed a pointer to a NetLog on construction, which is taken from a URLRequestContextGetter. Bug: 767450 Change-Id: I0dd79758dd05d92045cca56286a6dd0c511c1aa4 Reviewed-on: https://chromium-review.googlesource.com/677551 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#505114}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=torne@chromium.org Bug: 666525 Change-Id: I3600da8b60fb8a8a4d3f2c7e119777a4212afc1d Reviewed-on: https://chromium-review.googlesource.com/688767Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505113}
-
Alex Newcomer authored
can change app grid pages New behavior: Scroll events (ET_MOUSEWHEEL and ET_SCROLL) used to modify the app grid if the mouse was over the grid, and modify the AppListState otherwise. Now, we want scroll events to first try to move the grid. If this succeds, set a timer to keep the stream of scrolling events from also closing the AppListView. If the scroll could not move the grid, allow it to modify the AppListState. I used a timer because there is no reliable way to both determine the end of an ET_SCROLL and the end of a mousewheel scroll. We need to avoid acting twice with one user intent to scroll one surface. The behavior of this change was reviewed by UX/PM and approved for M61. Misc refactoring: - No longer need OnMouseWheel/OnScroll in AppsGridView because AppListView will handle all scroll events. - Broke AppListView::HandleScroll into a few different functions because it was starting to do multiple things. - In HandleScroll, also combined mousewheel and touchpad logic to avoid code duplication. - Added tests to AppsGridView while debugging. Also moved the scroll test from FullscreenAppListPresenterDelegateTest to AppListViewFullscreenTest. TEST=manual and automated BUG: 769356 Bug: Change-Id: I15396b9845404d0c13de916e01ef62ea9af22ae8 Reviewed-on: https://chromium-review.googlesource.com/688637 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#505112}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 666525 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I13380dbc5c3339e7b7acdd28c574517b668d4cf2 Reviewed-on: https://chromium-review.googlesource.com/689026Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505111}
-
David Reveman authored
This takes advantage of the animated image support added recently to allow users to capture short looping high-quality mini videos as avatar picture. Videos are created using the following parameters: - 10 photos taken over the interval of 1 second. - Stitched together in a seamless forwards/backwards loop. - Playback at 20 FPS. - Final animation time is 1 second. - Playback is 2X the speed of capture. The profile picture UI has been updated to support capture of motion stills by allowing the user to switch between photo and video capture by clicking a button in the camera element. Bug: 763735 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia921646cdfa649cbe7294d521f5d29f0bddc3035 Reviewed-on: https://chromium-review.googlesource.com/635488 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505110}
-
Xida Chen authored
This reverts commit 801c6e56. Reason for revert: <INSERT REASONING HERE> Causing test failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/56070 Original change's description: > [LayoutNG] Fix crash in ResolveInlineLength > > This patch fixes inline blocks with orthogonal writing mode: > 1. Not to crash in ResolveInlineLength. > 2. Uses the correct side of margins for the inline block. > > Bug: 636993 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I83abddd8e910985e6f9d9fba9f93954ef038e41d > Reviewed-on: https://chromium-review.googlesource.com/688523 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505069} TBR=eae@chromium.org,kojii@chromium.org Change-Id: I23d249eecdbb3733c3819307a103d0b3e124fb1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/690854Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505109}
-
Dan Elphick authored
This fixes a regression introduced in https://chromium-review.googlesource.com/c/chromium/src/+/636288 Also adds a unit test for DownloadDriverImpl::CreateDriverEntry. Change-Id: Ic456b868f5c51cd87cf6534681708f8c252ab9db Reviewed-on: https://chromium-review.googlesource.com/687055Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#505108}
-
Jeremy Roman authored
This replaces the construction (and destruction) of the map at runtime with a linear search of a compile-time constant structure. We could do this with a binary search, but the number of items in these lists is sufficiently small that a linear search is likely to be as fast as std::lower_bound. Since these maps never need to change, we gain memory locality by having the entire map in an array (and that array can be shared between processes). The array also contains the precomputed size of the schema, avoiding the need for a strlen at lookup time to convert from const char* to StringPiece. Finally, the Get function is modified not to do a map lookup twice (one to determine if it's present, and again to retrieve the value), but instead to do the lookup directly. Change-Id: Ia4c4b6a07b15aa81f48e63c5b40dcee912a7d21d Reviewed-on: https://chromium-review.googlesource.com/678017Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505107}
-
Maks Orlovich authored
This includes stream 0 all the time, and stream 1 if available from a prefetch. This change does regress some zero-length-read type cases from non-idle being sync to reduce code duplication, which may be worth reconsidering and undoing. This also includes a microbenchmark to measure some of our bookkeeping overhead, which is also improved a bit by this, but it's not the sort of numbers (order of half a microseconds) to get overly excited about. Bug: 719979 Change-Id: I1079d023fd3c555a87ae4175225154467243e6e3 Reviewed-on: https://chromium-review.googlesource.com/682139Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#505106}
-
Xida Chen authored
It is flaky TBR=rouslan@chromium.org NOTRY=true Bug: 769851 Change-Id: I4ba160fe8d0916729be86807253c408a4d853404 Reviewed-on: https://chromium-review.googlesource.com/690799Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505105}
-
Sergey Silkin authored
There is bug in AQ in v1.6.0 which causes very poor video quality in WebRTC when packetization mode 0 is used. The issue is fixed in v1.7 (https://github.com/cisco/openh264/releases/tag/v1.7.0). I modified MediaRecorderHandlerTest/EncodeVideoFrames test to make it pass with new encoder. The test expects encoded frame sizes to be equal or bigger than the hard coded thresholds. But due to changes in RC the new encoder uses different QPs. As result there is difference in frame sizes: the second frame produced by the new encoder is 1 byte smaller than the previous version produced. The test failed because of that. I changed the threshold from 13 to 12 bytes to make it work with the new version (it still works with previous version as well). Bug: webrtc:8070 Change-Id: I58f82be70b12f26bea306f7788d33db9aca47856 Reviewed-on: https://chromium-review.googlesource.com/674868Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Sergey Silkin <ssilkin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505104}
-
Friedrich Horschig authored
This CL introduces the name source and methods to record it. Most of the changes are then code to forward the new parameter of the recording method. The updated signature needs rewiring on: - Android NTP chrome/android/ chrome/browser/android/ntp/ - iOS ios/chrome/browser/ - Chrome Desktop chrome/browser/resources/ chrome/browser/search/ chrome/browser/ui/search chrome/common/ chrome/renderer/resources/extensions/ chrome/renderer/searchbox/ Bug: 767402 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id10b344f2280f9859db4c76cafe276e130f5dc53 Reviewed-on: https://chromium-review.googlesource.com/673187Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#505103}
-
David Benjamin authored
The Fuchsia code is not using the legacy X.509 stack. Bug: 706445 Change-Id: I6c2cc42bc302c01d38067657317aa1b958442270 Reviewed-on: https://chromium-review.googlesource.com/690376 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#505102}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/3a5e1fee080c..097900648b0b $ git log 3a5e1fee0..097900648 --date=short --no-merges --format='%ad %ae %s' 2017-09-28 borenet Fix path separators on Windows in zip_utils 2017-09-28 mtklein function santizer is not available on Mac 2017-09-28 brianosman Use wider types to compute bounds area and avoid overflow Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I8bb576e4296e83dbd8998e43bc9ce04c7ffc39e9 Reviewed-on: https://chromium-review.googlesource.com/689860Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505101}
-
Bo Liu authored
These tests got disabled on M and above due to flakes. However now webview tests no longer runs on K cq bot, meaning these tests have no coverage on cq. Tried running looping the 22 tests that are enabled here 50 times locally without any failure. So enable them with RetryOnFailure and see if there are any flakes on bots. Bug: 615483 Change-Id: I3bc20a1e1b89f3b925db3943441a5bd00efb9c9b Reviewed-on: https://chromium-review.googlesource.com/688798Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505100}
-
Fredrik Söderquist authored
Passing 'this' (which |object| will be in this case) to LayoutObject::NextInPreOrder, will turn it into a non-obvious way of saying FirstChild. Pass |root| instead of |object| to make the traversal actually pre- order. Bug: 769459 Change-Id: I6bc4c487faab053d02bc16826862234f15e2376e Reviewed-on: https://chromium-review.googlesource.com/690254Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#505099}
-
Alexis Hetu authored
Turning on SwiftShader for Layout Tests on Linux. Added expectations for tests which will require rebaselining. Attempting to reland: https://chromium-review.googlesource.com/c/chromium/src/+/651079 TBR=kbr@chromium.org,hubbe@chromium.org TBR_REASON=A few minor changes to content_browsertests which can be followed up on later Bug: 726075 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2c51376975217a7534b728f23c7881b60dd2f025 Reviewed-on: https://chromium-review.googlesource.com/687276 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505098}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/5f95f36cac52..79eab23d8f83 $ git log 5f95f36ca..79eab23d8 --date=short --no-merges --format='%ad %ae %s' 2017-09-28 npm Add Length1 in TrueType font streams 2017-09-28 art-snake Implement FakeFileAccess. 2017-09-28 dsinclair Cleanup CFGAS_GEFont methods 2017-09-28 dsinclair Simplify some OS checks to PLATFORM checks 2017-09-28 art-snake Fix load non first pages in linearized document with hints table. 2017-09-28 art-snake Fix infinite loop on form availability check. 2017-09-28 rharrison Remove no-op cast Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I5df7d33b7164e1b10bda6be4d6406aead78177c3 Reviewed-on: https://chromium-review.googlesource.com/690325 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505097}
-
Matthew Jones authored
This change adds a promo dialog and flag to enable it on every restart. Choosing a setting different from the one the browser is currently in will cause the browser's activity to restart when the dialog is closed. The enabled state of the browser when the promo is in use is driven off of a new shared preference "chrome_home_user_enabled". The new preference takes priority over about:flags. BUG=767738 Change-Id: I4d0b5da6cf47baf338dbbc2fd8ffb85ea9140211 Reviewed-on: https://chromium-review.googlesource.com/683248 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#505096}
-