GitLab

Previously, we used the bounds of the containing block. This can be very inefficient in cases
such as long paragraphs of text within a single block, leading to excessive numbers of column
fragments.

Bug:797591

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I455ef37cad4d97f8069aa37dc3542e290b6aeab6
Reviewed-on: https://chromium-review.googlesource.com/1070562
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561676}

This introduces additional methods in headless::Request so that we can
stop exposing GetURLRequest(). The end goal is to be able to have different
Request implementations not backed by a URLRequest.

TBR: eseckler@chromium.org, alexclarke@chromium.org

Change-Id: Ibdf18d28851e69c986b22f441692e94cb017d50d
Reviewed-on: https://chromium-review.googlesource.com/1072230Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561675}

This patch removes the !RLS codepaths in paint layer clipper and root
scroller controller. Now that Root Layer Scrolling (RLS) is enabled
by default, this code is no longer needed.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I55e925d572dfbcee2cb4db53c73ca9f841a4d01b
Reviewed-on: https://chromium-review.googlesource.com/1072632Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561674}

Drive-by: merge entries for timeline-recalculate-styles.js

TBR: alph@chromium.org, jam@chromium.org
Bug: 823837
Change-Id: I8d29104d3784747bfb5260c8349d409dc7d016f5
Reviewed-on: https://chromium-review.googlesource.com/1072413
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561673}

https://chromium.googlesource.com/infra/luci/client-py.git/+log/833f5ebf894b..34f5f28603eb

$ git log 833f5ebf8..34f5f2860 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 maruel [client] trim old named caches and CIPD.
2018-05-16 sergeyberezin [swarming.py] Allow description in query-list to be optional.
2018-05-14 maruel [client] stop mocking the file system in some unit test
2018-05-14 maruel [client] fix isolateserver client file mode handling with tarred filed
2018-05-14 maruel [client] better handle tarfile created on other OSes
2018-05-04 maruel [swarming] Add new task result state NO_RESOURCE

Created with:
  roll-dep src/tools/swarming_client

Change-Id: I58e9bde586483a74c9ce4d7130f40aed04b2a869
Reviewed-on: https://chromium-review.googlesource.com/1065469Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561672}

Bug: chromium:829504
Change-Id: I9360d8e3d7fd50289a0b59771447ec9bdc16a2ad
Reviewed-on: https://chromium-review.googlesource.com/1013489
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#561671}

This changes two more IPCs to resolve blob URLs in blink before
sending the request to the browser, hopefully covering all cases.

Still only works with the network service enabled (and that's
probably not going to change), but at least fixes ordering issues
the network service had between resolving and revoking blob URLs.

Design doc: https://docs.google.com/document/d/1DqVcTWE9Qb_3KpIRH2bFV-6hWEr8S92c4ppY67YL1KI/edit#heading=h.n4fzuc6mgziv

Bug: 800901
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iad88fc87264b248d15b03bdad2c24d2c5a46d9df
Reviewed-on: https://chromium-review.googlesource.com/899508Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561670}

Currently, the window is only resizeable from the top right corner. The
resizing hit points were removed on a previous change. This re-enables
resizing from all sides and corners of the window.

BUG: 845765
Change-Id: I04fb4dcfa5c05aa1112d13fa3d49edb37c0b054b
Reviewed-on: https://chromium-review.googlesource.com/1069930Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561669}

Elements inside an out-of-process iframe should inherit the effective
touch action of the parent frame, this CL propagates the computed touch
action to all of the element's OOPIF children.

Bug: 759042
Change-Id: I2ddfbd0a75ad7166a6ec94a44e039ea7384c7947
Reviewed-on: https://chromium-review.googlesource.com/982154Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561668}

Bug: 846055
Change-Id: Ibe860e7e25fb4396af0e48d34b04542673ae4f85
Reviewed-on: https://chromium-review.googlesource.com/1070552Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561667}

Ruling out https://crbug.com/826408#c17 as the source of the issue.

R=thestig@chromium.org

Bug: 826408
Change-Id: I00396084d674fa2f700eb917300280b6eed1684d
Reviewed-on: https://chromium-review.googlesource.com/1072030
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561666}

Now, when a FakeMultiplexedChannel is disconnected, it notifies its
delegate.

Bug: 824568, 752273
Change-Id: I52a5368b374c7633a09a5c154a37f972d7a207c7
Reviewed-on: https://chromium-review.googlesource.com/1072729Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561665}

This allows us to get "correct" sizing of orthogonal children when
computing min/max content sizes. I have not verified if this behavior
is 100% correct per the spec, but it certainly gets us much closer and
allows us to pass a number of additional tests.

This is done by adding a writing_mode parameter to
NGLayoutInputNode::ComputeMinMaxSize, and the block node is then responsible
for producing right value for that writing mode. If orthogonal, it does
layout with the given constraint space, if any.

Bug: 591099

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5cf30a91b9548a3894c2bee483ec3245fec962e6
Reviewed-on: https://chromium-review.googlesource.com/1069848
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561664}

R=dpranke

Change-Id: I469e7e478141e7c389f7a16a5e860122785bab44
Reviewed-on: https://chromium-review.googlesource.com/1072740Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561663}

Bug: 837798
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaf540c17a0c45da7b4197f4c8e80f0d8c1b8c10c
Reviewed-on: https://chromium-review.googlesource.com/1069967
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561662}

It previously inherited from LayoutNGBlockFlow, which, aside from
violating is-a, prevented inline flex children from being blockified --
LayoutNGBlockFlow::AddChild does not call LayoutBlock::AddChild, which
is where the blockification happens.

Considered inheriting from LayoutFlexibleBox to get better baseline and
intrinsic size support, but those will have to be reimplemented in
LayoutNG anyway.

With this change, IsLayoutNGMixin() is even further insufficient to
check if a LayoutObject is implemented in NG. I modified some of the
checks to include IsLayoutNGFlexibleBox, but am not sure about the
accuracy.

mac-specific css3/flexbox/button-expected.png is because the underline
in the link is 1 pixel shorter.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I42811edeb53e8e2a80a64d5b30bf6627e0957b7d
Bug: 845235
Reviewed-on: https://chromium-review.googlesource.com/1062499
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561661}

... as this is unnecessary.

Bug: 734095
Change-Id: I1fc028c91ecf5c282f72b749cdd6283ed8e19e86
Reviewed-on: https://chromium-review.googlesource.com/1070624Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561660}

I am working on https://crbug.com/831155. Some tests that are relying
on how things are scheduled in Blink are failing.

There was a race condition in this test. The iframe "#fr2" was asked to
navigate to a first URL, but soon after, a javascript function
modifies the iframe.src to navigate elsewhere.

What happened when it didn't work?
1) The first navigation starts.
2) The second navigation is scheduled (See blink's NavigationScheduler)
3) The first navigation commits. FrameLoader::CommitProvisionalLoad()
   executes: frame_->GetNavigationScheduler().Cancel(). It cancels the
   second navigation.

This CL fixes the race condition.

Bug: 831155
Change-Id: I2dd951140b4c5a671c749348ca0247f1901d8b77
Reviewed-on: https://chromium-review.googlesource.com/1069013
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561659}

This CL adds MediaCryptoDeferrer to ensure there will be only one
provisioning flow at any time. If NotProvisionedException is thrown
when another provisioning flow already started, the MediaCrypto creation
process will be deferred and resumed when the previous provisoning
process finishes. If creating MediaCrypto doesn't trigger provisioning,
it'll not be affected.

Note that when we resume the MediaCrypto creation, we may trigger
provisioning again, which is also handled in MediaCryptoDeferrer. This
could happen when per-origin provisioning is enabled and we have
different origin IDs.

MediaCryptoDeferrer is only used when mRequiresMediaCrypto is true.

Bug: 834965
Change-Id: I4e9ce60acbb6132b8170b9f47bc85ef5fc946f4c
Reviewed-on: https://chromium-review.googlesource.com/1071103
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561658}

I've accidentally copied the values into wrong sections, they need to
be swapped.

Bug: none
Change-Id: I19cb35c593b3e8666371b9d135d54a48e39c1086
Reviewed-on: https://chromium-review.googlesource.com/1072526Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561657}

Mash services like tap_visualizer are launched as utility processes
so Chrome's crash reporting system works fine with them. Using chrome's
crash system gives us Chrome's version number for the crashes (which
makes sense, since the services are built into the chrome binary),
support for chrome-specific crash features like crash-keys, etc.

Override the process type with the service name so these crashes
show up independently in the crash console, similar to what we do for
extension renderers.

Bug: 846123
Test: browser_tests, also kill -SEGV the tap_visualizer process and check reports
Change-Id: I133aedcf1f263beb2d349e9bc24e5b3624d03ea8
Reviewed-on: https://chromium-review.googlesource.com/1072205Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561656}

Bug: 844513
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic00f1af465b742a23701a85aad2f0d68d22f8808
Reviewed-on: https://chromium-review.googlesource.com/1071071Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561655}

https://chromium.googlesource.com/catapult.git/+log/7dc0e251e9a9..9a12da75442c

$ git log 7dc0e251e..9a12da754 --date=short --no-merges --format='%ad %ae %s'
2018-05-24 wangxianzhu Update reference builds of all channels
2018-05-24 csharrison Fix chown cmd in AndroidPlatformBackend.PushProfile

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia1f0a72544bf46fdf0d3ec443ea6d9959000411b
Reviewed-on: https://chromium-review.googlesource.com/1072149Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561654}

This utilizes the ic_play_arrow.svg and ic_pause.svg used for the modern
media controls. The SVGs are skiafied before replacing the previous
controls; the new controls do not have a white circular background
behind them.

This change also adds a way to specify the horizontal and vertical
alignment for images and background images separately for ImageButton.
Previously, the image and background image had the same alignment. No
other ImageButton that sets the background image currently specifies
alignment.

Part 1 of multiple diffs to move to modern styling.

BUG: 836389
Change-Id: I5d01fb237c262e0610907c580a12914d30500443
Reviewed-on: https://chromium-review.googlesource.com/1069265
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561653}

Bug: 846291
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I16f71655271eab77480c3744250618a2077481fe
Reviewed-on: https://chromium-review.googlesource.com/1072041Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561652}

- Start test_ime_driver when ash_shell_with_content starts;
- Make test_ime_driver handle keystroke events in addition
  to char events used in tests;
- Make test_ime_driver call DispatchKeyEventPostIME before
  handling it, similar to InputMethodMinimal, so that non-input
  keystrokes such as backspace, arrow keys are handled;

Bug: 837710
Change-Id: Ib70ac5e424ab7e30517200763b3cff0f9a9f13bd
Reviewed-on: https://chromium-review.googlesource.com/1070690Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561651}

Only the "real" name, if any, is added in the audio service. The
Default/Communications prefix is applied in the browser.

Also fix some lint/IWYU stuff.

Bug: 843145
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8a00a5d235807c8e7aeebac4a8062fa171152da6
Reviewed-on: https://chromium-review.googlesource.com/1071447
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561650}

This is avoid flooding about://media-internals with too many audio
timestamp gap warnings.

For an example of excessive audio timestamp gap warnings, and the
result after this CL: https://photos.app.goo.gl/9QiPxCVmJLtZNoIV2

Test: Manually verified
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic2570d98419407dde0643e62fe62975fddf2ef14
Reviewed-on: https://chromium-review.googlesource.com/1072027
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561649}

At the moment, we only notify the player if it was playing. This will
notify the player all the time but only pause it if it is playing.

Bug: 845560
Change-Id: Ifceafbc5eaa79927935ed4b5f50a147b03f955b5
Reviewed-on: https://chromium-review.googlesource.com/1069713
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561648}

>Adds variables for IPH
>Implementing/showing IPH in a separate patch

Bug: 843639
Change-Id: I9a20eca6504f083216dfc430a08d4bbda1c63d27
Reviewed-on: https://chromium-review.googlesource.com/1067778Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Daniel Park <danielpark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561647}

Previously we could crash, because within this method, we iterate over
a collection and update its elements, and subsequently invalidate the
very collection we are iterating over.

This CL fixes it. pbos@ provided the diagnosis.

Bug: 846406
Change-Id: Ibeadddfaef2e7a3700b9b9fae6143892aee10af1
Reviewed-on: https://chromium-review.googlesource.com/1072189Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561646}

Bug: 728378
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iea3a95e237792af3d1f99dc23e8b68b3ce10c60d
Reviewed-on: https://chromium-review.googlesource.com/1071088
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561645}

This reverts commit ce767464.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 561616 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NlNzY3NDY0NGQxM2UzN2IyNzQ3MTY4NzZhMzg2N2UxYjFkZDhiOGQM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/8468

Sample Failed Step: ozone_unittests

Original change's description:
> [Ozone-DRM] Refactor plane management and add tests
> 
> * We use plane properties on legacy DRM to get some details (plane
> type, in_formats). Read the properties in HardwareDisplayPlane and
> check that the required properties are available in DRM atomic.
> * Split dummy plane into its own class to clean up code.
> * Remove test plane since we can now create the real objects via
> injected state in DrmDevice.
> * Cleanup plane initialization.
> * Remove MockHardwareDisplayPlaneManager and rely on MockDrmDevice to
> inject the necessary state.
> 
> BUG=839487
> TEST=Ran unittests
> 
> Change-Id: I03c91620557dcf7426629cf97bb989d8d7e83c68
> Reviewed-on: https://chromium-review.googlesource.com/1048585
> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561616}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=839487

Change-Id: Ie87a4ecea2b6c31aa25acd3633cda1b7547b0151
Reviewed-on: https://chromium-review.googlesource.com/1072667
Cr-Commit-Position: refs/heads/master@{#561644}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0115c356f675..b1a5e452d31e

$ git log 0115c356f..b1a5e452d --date=short --no-merges --format='%ad %ae %s'
2018-05-23 agable Remove Rietveld-only apply_issue
2018-05-24 agable Remove more Rietveld support from presubmit

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:770408,chromium:770408


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I3c4783648fdd94df71a875e0444218c125cd94b6
Reviewed-on: https://chromium-review.googlesource.com/1072494
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561643}

Located by fuzzing ZTF Apply (WIP):
https://chromium-review.googlesource.com/c/chromium/src/+/1072231

Found two fatal errors:
- OffsetForKey always assumes a key is valid however, the validity of
  the key is not checked prior to the caller invoking the method. The
  caller also had no way to check validity if it was external to
  TargetPool.
  Fix: Add a method to check for key validity ahead of calling
       OffsetForKey.

- ConvertToTargetLineCol for absolute references had a logic bug that
  resulted in attempting to dereference an invalid base::Optional
  Fix: Change the logic to avoid issue.

Bug: 835341
Change-Id: I99c91741eef41dfaa3036af8e708eb3f0d5ca84a
Reviewed-on: https://chromium-review.googlesource.com/1072272
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561642}

zucchini_raw_apply_seed is failing on ToTWinCFI this disables building
the target on Windows. A first attempt at a fix failed so until a better
method of diagnosing the problem is determined we will disable it as it
wasn't used by ClusterFuzz anyway (Linux only).

Bug: 844826
Change-Id: I47820432ddb94334006ee727120a242684152b97
Reviewed-on: https://chromium-review.googlesource.com/1072506
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561641}

AuthenticatorData was previously created with the hash of the
clientDataJSON, rather than the hash of the RP ID. See
https://www.w3.org/TR/webauthn/#authenticator-data for reference.

Bug: 678128
Change-Id: I1628172212fadedd02a8ccf5daa46237bccd12bd
Reviewed-on: https://chromium-review.googlesource.com/1066486
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561640}

Metrics added: Arc.AppShortcuts.BuildMenuTime in unit of "ms".

Bug: 843676
Test: chrome://histograms
Change-Id: I89887e965bcd9b6dce943fd54e0c00020ce513e8
Reviewed-on: https://chromium-review.googlesource.com/1069907
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561639}

https://pdfium.googlesource.com/pdfium.git/+log/5bf772bade61..97db69faaeb4

$ git log 5bf772bad..97db69faa --date=short --no-merges --format='%ad %ae %s'
2018-05-24 thestig CPDF_HintTables should not try to read 0 bits.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:846394


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idef67cc9c19f519f36d8617c19c144253737f305
Reviewed-on: https://chromium-review.googlesource.com/1072493
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561638}

Media Remoting has launched. This change removes all the feature flag
conditionals.

TBR=rkaplow@chromium.org,imcheng@chromium.org

Bug: 632399
Change-Id: I08edd86bf97cc4d180379edd2c6c4b309e7421f4
Reviewed-on: https://chromium-review.googlesource.com/1071001Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561637}