- 02 Oct, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/820d185fa292..eb06828e0343 Created with: gclient setdep -r src-internal@eb06828e0343 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I83476f2580ab8a91721bc3b9f9adf12e5fa241ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835172Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701913}
-
chrome://sandboxAlex Gough authored
Exports basic fields of active sandbox policies and formats these into a table for the chrome://sandbox webui. Bug: 997273 Change-Id: Ic437441fc11a4ebc052fac159e786daf74479863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817417 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#701912}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/16236fcfbe31..017b54db6bea git log 16236fcfbe31..017b54db6bea --date=short --no-merges --format='%ad %ae %s' 2019-10-02 dberris@chromium.org PinpointScheduler: Port ReadValue to Tasks+Evaluators Created with: gclient setdep -r src/third_party/catapult@017b54db6bea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:988912 Change-Id: I85afb8f4e834a836a59b1ab2e45c51bab93acdc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701911}
-
David Grogan authored
Moved most of legacy's AlignChildren to the common method FlexLayoutAlgorithm::AlignChildren, to which Legacy and NG pass a callback that contains their respective stretch implementations. One test for baseline alignment regresses. I don't know why. Other tests for baseline alignment still fail, so maybe this test used to pass by accident. R=cbiesinger@chromium.org Bug: 845235 Change-Id: I6e58307d76a6f950017b89a3dcea4aef77c5f067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807184 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#701910}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c0d64b05d939..98592f6c5dbe git log c0d64b05d939..98592f6c5dbe --date=short --no-merges --format='%ad %ae %s' 2019-10-02 mmortensen@google.com Implementation of Sysroot.CreateSimpleChromeSysroot in the BuildAPI. 2019-10-02 ahassani@chromium.org chromeos_config: Move betty-arc64-paladin to experimental 2019-10-02 ahassani@chromium.org paygen: Don't stage the metadata signature file. 2019-10-02 vapier@chromium.org pylint: add linter for bad comment styles 2019-10-02 vapier@chromium.org pylint: drop custom excess-trailing-newlines check 2019-10-02 saklein@chromium.org services: chroot tempdir cleanup Created with: gclient setdep -r src/third_party/chromite@98592f6c5dbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I295647915dd7ddb8ed049d307fb5a46976c0322d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835062Reviewed-by:
-
Kush Sinha authored
Chrome OS Account Manager has been turned on by default on ToT, and has been launched via Finch for some time now. Clean up its flag's usages in JS browser tests. Bug: 1009960 Test: browser_tests --gtest_filter="*CrSettingsPeoplePageAccountManagerTest*" Test: browser_tests --gtest_filter="*OSSettingsPeoplePageAccountManagerTest*" Change-Id: I9dd25a6e943ebd3d9ac992e2957d609ebf1b072f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832813Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#701908}
-
Ken Rockot authored
Currently if a remote process is detected as disconnected (i.e. your internal Channel transport to that process signals an error), unread messages which have already arrived from that process may be unreadable from the ports that received them. Bug: 1005510 Change-Id: Id743ce4560a0309a2058d0b825a2bb4a6065b342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832244 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#701907}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/674f77a24b62..1ebaa15a4c62 git log 674f77a24b62..1ebaa15a4c62 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b26cb15a..c00626cb (462 commits) 2019-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3044c24181e9..0cd9a67ce84f (5 commits) Created with: gclient setdep -r src/third_party/skia@1ebaa15a4c62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None,chromium:None Change-Id: I4d8ee5bcd2bd6541fd5edf3f5d76440e8f216113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835059Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2958f7284bc353242721b2affd72562c7d26a2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834747Reviewed-by:
-
Takashi Sakamoto authored
test_support depends on third_party/blink/renderer/platform:bindings_buildflags, because (snip)/platform/heap/name_traits.h includes bindings/name_client.h and the name_client.h includes (snip)/platform/bindings/buildflags.h. Sample build to be fixed by this CL: https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/5277 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8900748397429231616/+/steps/compile/0/stdout?format=raw In file included from ../../third_party/blink/renderer/platform/heap/heap_test_utilities.cc:7: In file included from ../../third_party/blink/renderer/platform/heap/heap_test_utilities.h:15: In file included from ../../third_party/blink/renderer/platform/heap/handle.h:35: In file included from ../../third_party/blink/renderer/platform/heap/heap.h:40: In file included from ../../third_party/blink/renderer/platform/heap/gc_info.h:11: In file included from ../../third_party/blink/renderer/platform/heap/name_traits.h:9: ../../third_party/blink/renderer/platform/bindings/name_client.h:9:10: fatal error: 'third_party/blink/renderer/platform/bindings/buildflags.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Change-Id: Ib8b63d59fff2d9c828644e470101d9202453e5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833348Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#701904}
-
Alexandre Courbot authored
V4L2SVDA checks that imported buffers are as expected by checking their GpuMemoryBufferHandle information in ImportBufferForPicture(). V4L2SVDA reads |gl_image_planes_count_| to that effect. However, |gl_image_planes_count_| belongs to the decoder thread, so this check should be performed there as well. This is basically a port of crrev.com/c/1475551 to V4L2SVDA. Bug: b:139901663 Test: Video playback in Chromium and ARC++ on Kukui. Change-Id: I113665322c4a27c496b2f0696f7e0a7ae31c5f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832125 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#701903}
-
Maksim Sisov authored
The logic for ozone/linux has been moved to DWTHLinux. Thus, remove the same from DWTHPlatform. Bug: 990756 Change-Id: I9ea464a85fc055069f155ca28fef8f6ec4ff4bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833583Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#701902}
-
Adam Rice authored
Remove the JavaScript implementation of WHATWG Streams. See the design doc for the C++ implementation which replaced it at https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit. Also remove dependencies of the implementation and the StreamsNative feature flag. This CL removes the code, but the interfaces remain virtualised. A follow-up CL will de-virtualise the interfaces and simplify the names of the classes. BUG=902633 Change-Id: I0ea8095a453bba9756a309dd6310ba0fe996d172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746118 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#701901}
-
James Hollyer authored
The ble_scan_parser_ was bound when we tried to start discovery and reset when we stopped discovery. However, if we failed to start discovery it stayed bound and next time we tried to start discovery we called bind again. This patch fixes this by only binding the parser after successfully starting discovery. Bug: 996805 Change-Id: I217844a33924b2780fc9f831f2621837337a49f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832694 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#701900}
-
Hajime Hoshi authored
This CL is a pure refactoring. This is a preparation to introduce recording metrics at BackForwardCacheMetrics::DidCommitNavigation. Bug: 1004676 Change-Id: I8855a798bc5956c52321d6f731c7911076e0b96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833196Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#701899}
-
Tarun Bansal authored
Feature kSendPreviewsLoadingHintsBeforeCommit has been enabled by default since M-77. This CL removes the code that kicks in when kSendPreviewsLoadingHintsBeforeCommit is disabled. Change-Id: I2bda2e88c12d44a0590d935755a12e05b550602f Bug: 983219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830406Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#701898}
-
chrome://sandboxAlex Gough authored
Creates a webui to display a snapshot of sandboxed processes for Windows. This CL includes only the basic plumbing and very basic display of relevant information. Process information must be obtained from the sandbox (broker) and from the browser, as each knows different things about what is running. For now we simply display this as json but in later CLs the range of information available will be increased, and the lists of processes from different sources will be joined together to form a friendlier display of diagnostic information. This will result in a larger |sandbox_internals_win.js| file which we do not need on other platforms. Hence the file for Windows is split from that for Linux or ChromeOS. We will display different information to that provided by Linux or ChromeOS as the underlying sandbox technology specific to the host OS so much of the data extraction code is #ifdefed for OS_WIN or in _win.cc,h files. Bug: 997273 TEST=navigate to chrome://sandbox on Windows, see a page Change-Id: I91a4cb12a6a5b632d0da89f5ffccfcb30b177b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767660 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#701897}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1784cda8d57a..820d185fa292 Created with: gclient setdep -r src-internal@820d185fa292 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I4e379e7f4fccc1842f74b1c3e2aa472bb468c717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835131Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9cdcaeee872d..c0d64b05d939 git log 9cdcaeee872d..c0d64b05d939 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 bpastene@chromium.org chrome_chromeos_lkgm: Temporarily skip the betty trybot on the CQ. Created with: gclient setdep -r src/third_party/chromite@c0d64b05d939 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib26dba5c6fe30d47675ecfa6a531130394797262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834723Reviewed-by:
-
Reilly Grant authored
This change updates Blink to match the WebUSB specification in allowing control transfers with the recipient set to 'device' or 'other' when the device is in an unconfigured state. More test cases are added to exercise control transfer parameter validation. Bug: 1009886 Change-Id: I423a4307878714e07a62ef66715eb0c5b4f4d08d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834649Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#701894}
-
Austin Tankiang authored
With the change to DriveFS, drive files can be treated like local files, so the code needed to handle them can be deleted. Also delete job_event_router, as it is also only used by the legacy drive client. Bug: 1003238 Change-Id: I766bf4ef5413a4172e5b61d5d54655dd69d00d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833168Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#701893}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/df782a7348d8..0cd9a67ce84f git log df782a7348d8..0cd9a67ce84f --date=short --no-merges --format='%ad %ae %s' 2019-10-02 capn@google.com Enable running vk-unittests from any directory Created with: gclient setdep -r src/third_party/swiftshader@0cd9a67ce84f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/128618202 Change-Id: I8118fbc715149de485f5104fe0ae3fbd01a2dd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834695Reviewed-by:
-
calamity authored
This reverts commit c00626cb. Reason for revert: Broke compile: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/5241 Original change's description: > Revert "Downgrade security level on sites using legacy TLS versions" > > This reverts commit 5bb7d241. > > Reason for revert: Failing Linux MSan > https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/19658 > > Original change's description: > > Downgrade security level on sites using legacy TLS versions > > > > This adds a check to SecurityStateTabHelper to mark whether a page was > > loaded over legacy TLS versions in the VisibleSecurityState struct. This > > status is then used by the security_state code to downgrade the security > > level to WARNING. The SecurityStateTabHelper code also checks the pref > > set by the SSLVersionMin enterprise policy to determine whether to set > > the flag in the VisibleSecurityState. > > > > This version can be racy at browser startup, due to how the component > > proto is loaded from disk (as BEST_EFFORT). A followup CL will change > > that task to USER_VISIBLE to avoid this. > > > > Another followup CL will change the Page Info security summary for pages > > with the legacy TLS flag set in their VisibleSecurityState. > > > > Bug: 989607 > > Change-Id: I510eafc0124f433ec4e4ce81e4ece4f1321bde6d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829462 > > Commit-Queue: Christopher Thompson <cthomp@chromium.org> > > Reviewed-by: Emily Stark <estark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#701803} > > TBR=estark@chromium.org,cthomp@chromium.org > > Change-Id: I480bda2fac889d8f359f28c4a12843632f85dc90 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 989607 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833172 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: calamity <calamity@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701888} TBR=calamity@chromium.org,estark@chromium.org,cthomp@chromium.org Change-Id: I41107b4f51c615aaf7cb64ee6e7983863e7694c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833173Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#701891}
-
Maggie Cai authored
This CL adds unit tests for the Glob Match. NOTE: there are a couple of cases that didn't run as I expected but the logic is transcribed from Android codebase. Link: https://android.googlesource.com/platform/frameworks/base.git/+/e93165456c3c28278f275566bd90bfbcf1a0e5f7/core/java/android/os/PatternMatcher.java#186 BUG=853604 Change-Id: I82f0b726b66f8dd489b20ee1206f4594c1cdf2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833012 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701890}
-
Kevin Marshall authored
Adds a bogus CrKey version for now, until an actual version string can sourced from the Agent. Replace the Incognito web.Context creation helper function with a more generic ForParams() variation. Bug: b/141956135 Change-Id: Ia54c862799ecaf2d45d8095bf50445a1cf4824d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834823 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#701889}
-
calamity authored
This reverts commit 5bb7d241. Reason for revert: Failing Linux MSan https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/19658 Original change's description: > Downgrade security level on sites using legacy TLS versions > > This adds a check to SecurityStateTabHelper to mark whether a page was > loaded over legacy TLS versions in the VisibleSecurityState struct. This > status is then used by the security_state code to downgrade the security > level to WARNING. The SecurityStateTabHelper code also checks the pref > set by the SSLVersionMin enterprise policy to determine whether to set > the flag in the VisibleSecurityState. > > This version can be racy at browser startup, due to how the component > proto is loaded from disk (as BEST_EFFORT). A followup CL will change > that task to USER_VISIBLE to avoid this. > > Another followup CL will change the Page Info security summary for pages > with the legacy TLS flag set in their VisibleSecurityState. > > Bug: 989607 > Change-Id: I510eafc0124f433ec4e4ce81e4ece4f1321bde6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829462 > Commit-Queue: Christopher Thompson <cthomp@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701803} TBR=estark@chromium.org,cthomp@chromium.org Change-Id: I480bda2fac889d8f359f28c4a12843632f85dc90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833172Reviewed-by:
-
Maggie Chen authored
A build error in Window when setting enable_vulkan = true in args.gn Bug: 982922 Change-Id: Iaa4d0a893b23258fa9875ca5d3e4a961643e67f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834828 Auto-Submit: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701887}
-
Kuo Jen Wei authored
Bug: 980812 Test: Fire android.media.action.VIDEO_CAMERA and android.media.action.STILL_IMAGE_CAMERA, see if CCA is opened in correct mode. Change-Id: I6b50fc673ecf77948107a1280f0ea25129c33777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757571 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#701886}
-
Alex Danilo authored
Closing and reopening File Manager with progress operations continuing lost the text displayed on the feedback panels. Add storage of the source and destination file/directory strings to the background page to enable display when a new File Manager window is created. Needs test. Bug: 988137, 994954 Change-Id: I3a473a1512ab0d13f5694c18b2d0765a52a900f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828723 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701885}
-
Chinglin Yu authored
This adds LD_LIBRARY_PATH=./ to the test runner script to make it load dependent shraed objects in test invocation. Bug: 1002751 Change-Id: I96cb90a245ce83985971e776e14f6d9f5085b802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832848Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701884}
-
dpapad authored
Before this change chrome://test URLs could only serve files residing under chrome/test/data/webui. For the purposes of running PDF viewer tests as JS modules, it needs to serve content under chrome/test/data/pdf. Bug: 1005029 Change-Id: I59b2a38cd350b50e8d4c131e7ae19c1dc48cca7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833704Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#701883}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ic3ab6b56a63ca51d4cc13f96b710e9d603cb4409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835151Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701882}
-
Gyuyoung Kim authored
This CL applies pending_associated_remote to ListenToDeviceChanges() in XRRuntime interface. - Covert InterfaceAssociatedPtr to mojo::AssociatedRemote<> - Convert InterfaceAssociatedPtrInfo to mojo::PendingAssociatedRemote<> - Rename BindPtrInfo() to BindPendingRemote() Bug: 955171 Change-Id: I63bba4db383fa9f3a46987fa04fc0afa381abf18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831657 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#701881}
-
Ionel Popescu authored
This CL introduces AM/PM support to the popup by adding a new column when the in-page controls has the AM/PM option. Tests were added for validating the new UI and for selecting a value using the AM/PM column. Bug: 1004997 Change-Id: Idd6789cecf916bb46328ae1e0b199e2f1ae72433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833281Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#701880}
-
Jesse Schettler authored
Ensure the current profile is obtained even when outside a user window. This resolves an issue that occurred when printing from ARC apps using the ArcPrintService. Bug: 1010228 Test: Print from an ARC app using an ArcPrintService printer Change-Id: I886ccc17286b838a58604204f4d72b8723553913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834268Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#701879}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Change-Id: I096b96d0d93f7fb90de92dc370ebacffda94a6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835031 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701878}
-
Moe Ahmadi authored
Bug: 996516 Change-Id: Ie7a6048d5095a2b62db8b599626f2dc88c9a986d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825488 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#701877}
-
Eric Stevenson authored
New invalid references have been added (5 in about 2 months). Bug: 956839 Change-Id: I2c82dcbb461f048b2743fb266a2deaf26505cbb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834265 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Ryan Daum authored
* Adds new navigation decision calls in RPC. * When the setting has_navigation_delegate is true, uses a NavigationThrottle to defer navigation until a decision has been made over RPC. Bug: b/141853741 Test: manual Change-Id: Idefea26dbabe39d4afe8ae2a5c61349b483ed646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833790Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#701875}
-
Gabriel Charette authored
In an effort to help diagnose run timeouts. e.g.: https://bugs.chromium.org/p/chromium/issues/detail?id=1010061#c14 R=wez@chromium.org Bug: 1010061 Change-Id: I3c2a3d1898be58eaea9167d3202e5aa9dbf4deca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834743 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
