- 01 Sep, 2020 40 commits
-
-
Alex Ilin authored
The workaround to hide the profile menu view before showing the ProfileSigninConfirmationDialog is no longer needed. The dialog is now modal on all platforms and takes the focus away from all other menus. * Original bug: https://crbug.com/404711 Change-Id: I3b2dc4cfe2b0f8f36e8539ff6ee52024fe78b8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386736 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#803419}
-
Alex Ilin authored
Modal dialogs shouldn't have the X close button. This button is redundant as the dialog already has the Cancel button. Screenshot: https://drive.google.com/file/d/1eYpxgg4HuPjdpXs2Ea6FeRp3KPGFRWnF/view?usp=sharing Fixed: 1122471 Change-Id: I179e34e8bceac980d9835332e2d7dc521a67f4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387015 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Mathias Bynens authored
Prior to a recent change [1], `InspectorOverlayAgent::SetInspectTool` would call `InspectorOverlayAgent::LoadFrameForTool` which assigns to `overlay_page_`. With the patch, that no longer happened, resulting in `STATUS_ACCESS_VIOLATION` “oh snap” errors when using the “capture area screenshot” functionality in DevTools. This patch moves the “is the inspector agent enabled” check around so that we don’t hit any `nullptr`s while still getting the desired behavior of not rendering inspector overlays while taking screenshots. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2235553 Bug: chromium:1091037, chromium:1122038 Change-Id: I36ab8b883f1e643bcc89ebaed4063cc1409ee466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387560Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#803417}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d325ca00b9a..af609dca0136 2020-09-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I838df6edea4612318fcf46164c37657f37952850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803416}
-
Karel Král authored
Remove a TODO asking to support more kinds as this todo is no longer actual. All types are supported except two deprecated ones (covered by another comment) and typemapped types which should be supported in |base/trace_event/trace_conversion_helper.h|. Bug: 1103623 Change-Id: I5c2e44cc46e6b4b83be8c175b07a2f785dc805d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385278 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803415}
-
Ewann authored
This CL is developed under a flag. It adds an action sheet that asks for confirmation when 'Close All' button is tapped on the tab grid to avoid unwanted clearing Metrics related to the "Close all" button have been moved in the mediator. Bug: 1119319 Change-Id: Ie1901b7f24faf63745290310efef805d11859940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362925 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#803414}
-
Chris Lu authored
When a presenting popup infobar is replaced, the request is removed from the queue, set as removed_request_awaiting_dismissal_ in OverlayPresenter, and UI is dismissed. But, dismissal logic is async and resetting the request_ property of OverlayPresentationContext requires waiting for OverlayUIWasDismissed() callback. In the meantime, changing active WebStates causes the OverlayPresenter to ask the OverlayPresentationContext to hide its presented request by calling HideOverlayUI and passing the current front of the queue as the request to hide. This is where there is a discrepancy and a DCHECK on request_ fails. Check for removed_request_awaiting_dismissal_ before assuming the front request is the currently presenting request. Bug: 1120786 Change-Id: Icb25572bfcf9fb7450c2b7ce6d00eb3a3915e8e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383011Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#803413}
-
Ewann authored
This CL adds the following metrics: - IOS.OpenIn.Presented (user action) - IOS.OpenIn is renamed in IOS.OpenIn.Tapped" (user action) - IOS.OpenIn.MIMEType (histogram) And removes support for USDZ files. Bug: 1117398 Change-Id: Id7fbe91c73a8fc7859392b4cd492c283020c13f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377925Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-87.0.4247.0-r1 to 87-4183.74-1598869788-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I561b135ccc229e4ee59eaf03be714c02b1938cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387373Reviewed-by:
-
Rachel Carpenter authored
This reverts (part of) commit 6c131c38. Reason for revert: pak file got wrongly included Original change's description: > Use common App Service profile checks for incognito redirect. > > https://crrev.com/c/2318888 added a "GetOriginalProfile" call to fix a > crash in incognito. Unfortunally that introduced a new crash for Guest > sessions. GetOriginalProfile() returns something that crashes when > trying to open a browser - see https://crbug.com/1121553. Add a new > method to AppService to handle the profile redirects correctly and in a > single place. > > Also adds more tests. > > Bug: 1122480 > Change-Id: I63e3d2766d61b416d1e7590bc67a937b817848ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381230 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803399} TBR=tapted@chromium.org,dominickn@chromium.org,carpenterr@chromium.org Change-Id: If4f71581eddd4cffbd4a61ccef6bdee9f3c891f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1122480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386909 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803410}
-
Rachel Wong authored
This histogram was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2374466 but the names were mismatched. Since no data has ever been emitted to this histogram, we can change the name in histograms.xml. Bug: 1113960 Change-Id: Ie04a48c197a8217d2957837d828050522ca9c084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386686Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#803409}
-
sauski authored
Added JS type checking for: - privacy_page_test.js - clear_browsing_data_browser_proxy.js Bug: 1000989 Change-Id: I98d2a388a150af153c50118a994fa3c9e83ac37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377722Reviewed-by:dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#803408}
-
Kent Tamura authored
Fold it into LayoutBox and NGBlockNode like other controls. This CL has no behavior changes. Bug: 1040826 Change-Id: I7b54724afbaca12d300d2c27a4dd5f7068770ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386904Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#803407}
-
Weilun Shi authored
Besides normalizing the histograms paths in the index file, we also need to normalize all paths in the |histogram_paths.HISTOGRAMS_XMLS_RELATIVE| because it contains a hardcode path. Change-Id: I820de86efc7b816c0dba52e42838cbc55b5319c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386837 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#803406}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/59d28532a179..c0dda02196e8 2020-09-01 cclao@google.com Vulkan: release the ImageHelper's staging buffer after flush If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: If1b1ba4c61bf1efdae6dcde3beea4e970f038085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387304Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-87.0.4247.0-r1 to 87-4183.84-1598867895-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ica9d3a5a48e3dbe074836bacefef6f702fc53681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387371Reviewed-by:
-
Makoto Shimazu authored
Bug: n/a Change-Id: I2fc0288c129276b19757f74044be6169ce0915e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384690Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803403}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3913d3e137ed..a551fd288101 2020-09-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2f291c0bd181 to c0dda02196e8 (11 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I5492a01e0e0d3186a5101cb28e3f13d30b7d2363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387314Reviewed-by:
-
Minggang Wang authored
Recently, the SplitCacheDedicatedWorkersScripts test becomes flaky because of memory leak reported on ASan Linux build. The reason is that the nested dedicated worker thread blocks its parent dedicated worker termination when shutting down, as the parent thread will wait all its child threads to be terminated and terminate itself in the end. But the render main thread won't wait any worker thread, so the main thread may terminate earlier than the worker thread, which causes the memory leak sometimes. This patch changes the test case to close the nested dedicated worker in advance, so it will not block its parent thread when shutting down, also, re-enables the cases. Change-Id: I5c7ae0bb875862ab81a2ab76c429ebd40d46b302 Bug: 1104847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352509 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#803401}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-87.0.4247.0-r1 to 87-4183.84-1598870250-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5ae2f77db5625965ceb0b4b406b060e4ddd388b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387370Reviewed-by:
-
Rachel Carpenter authored
https://crrev.com/c/2318888 added a "GetOriginalProfile" call to fix a crash in incognito. Unfortunally that introduced a new crash for Guest sessions. GetOriginalProfile() returns something that crashes when trying to open a browser - see https://crbug.com/1121553. Add a new method to AppService to handle the profile redirects correctly and in a single place. Also adds more tests. Bug: 1122480 Change-Id: I63e3d2766d61b416d1e7590bc67a937b817848ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381230Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803399}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I641c684321d8506afa936293f7e706e9e6ba24ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387312Reviewed-by:
-
Eric Willigers authored
Builds on https://chromium-review.googlesource.com/c/chromium/src/+/2378144 Adds README.md and OWNERS files Adds a browser test for ShareServiceImpl, verifying that share() requests fail gracefully. ShareServiceImpl now implements content::WebContentsObserver, and overrides RenderFrameDeleted() to clear the render_frame_host_ member. ShareServiceImpl now builds for Chrome OS in addition to Windows. Bug: 1035527 Change-Id: Ic1ba0560468a69fb6ab0d3c141937e5439f656e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383228 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#803397}
-
David Black authored
As was previously done for file watching and persistence logic, moving downloads logic out of `HoldingSpaceKeyedService` into its own delegate. Bug: 1119496 Change-Id: Ibba263b73bda846b9c076361d72d0f05b231da8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386396 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#803396}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9e02f4716a1e..c2302e8e2eb6 2020-08-31 mmorrison@nvidia.com Fix compile error when rtc_enable_protobuf is false If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I06eaac83e136d1e4c64d716d35510fb72b1ab0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387300Reviewed-by:
-
Arnaud Mandy authored
Switch to loading *.mojom.js from /gen/ instead of resources/chromium in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Remove unused .mojom.js files from WPT. Bug: 1119858 Change-Id: I8c7226f4eca9f35ac88b3d02540aed31cf413ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385298 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#803394}
-
Minoru Chikamune authored
This reverts commit c7a29595. Reason for revert: We have finished to use this setting. Now the default mode of HeapMojoUseContextObserver is base::FEATURE_ENABLED_BY_DEFAULT. Original change's description: > Enable the HeapMojoUseContextObserver feature for waterfall testing > > To deprecate kWithoutContextObserver mode, we are going to enable > HeapMojoUseContextObserver feature for waterfall testing. By doing > this, we can detect crashes during the waterfall testing. > > Bug: 1049056 > Change-Id: I96e0be25ad6e6cc9eeac2fad600f1dadec02ecd6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277369 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Minoru Chikamune <chikamune@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784344} Bug: 1102041, 1049056 Change-Id: I23ec7ab38bc5bc7caaf965891e1b170e84770cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386857Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#803393}
-
James Vecore authored
Adds stub pages for high visibility and confirm to the receive dialog. Future CLs will flesh these out and wire up a mojo to communicate with the share service. Screenshots: http://screen/6QvnCB5NppKzGpC.png http://screen/32LmeXBLxmDvayD.png Bug: b:163148440, b:163147818 Change-Id: I68e248d54000ddd580ae8dc6a9ddc076b1ceddb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384790 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803392}
-
Toby Huang authored
This CL adds an observer to FamilyUserMetricsService, which is intended to be the interface for all future Family User Metrics classes. Common functionality can be refactored into this interface. For example, many metrics require daily reporting, so this interface initially contains a virtual function that's called when a new day is detected. FamilyUserMetricsService will own all the metrics objects, and can manipulate them in a uniform way through the interface. This CL also adds logic to FamilyUserMetricsService for detecting date changes using a repeating timer. Bug: 1103081,1110557,1114849 Change-Id: I77c30e3e8bccb5f55b37a4b57db167daa2819160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359028 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#803391}
-
Arnaud Mandy authored
switch to loading *.mojom.js from /gen/ instead ofresources/chromium in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Remove unused .mojom.js files from WPT. Bug: 1119858 Change-Id: Ifa1e07e47950b69c060880120f20bddb7556b90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385297 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
-
James Vecore authored
Adds a shared component to be used for all pages hosted in the receive dialog. This template just provides a common title, subTitle and utility/cancel/action buttons. The buttons fire events for the container element to receive. Final styling, a11y support will come in a follow up CL. Bug: b:163148440, b:163147818 Change-Id: Id52fd0eae2faa9e77e118acde3aace36f90c994e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384652 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1eb42f5ea752..d6c9e7955534 2020-09-01 jleconte@google.com Revert "Fix Bug ID layout on group report page." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: sadrul@google.com Change-Id: I452696de61f6b3e238c7b8086068173d1e1787b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386851Reviewed-by:
-
Morten Stenshorne authored
We have code that compensates for the scroll offset on screen when printing, but this didn't work correctly in vertical writing modes. When printing, we set a rectangle for each page in logical coordinates, and then transpose it to physical coordinates if writing mode is vertical. The scroll offset, however, is already in physical coordinates, so we have to apply this after transposing. Pagination in vertical writing modes is very broken (crbug.com/881727), but before we can even get to that problem, we need to make sure that scrolling doesn't cause problems. Bug: 1123706, 881727 Change-Id: Ie0370bcd5c0856afe2e1ca8f85ecaa1ce752f92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386735Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803387}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/676387126d72..2d325ca00b9a 2020-09-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4592f136624649e8962de6f6548689342bb988ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387305Reviewed-by:
-
Alice Boxhall authored
This is a reland of b89144a4 AX-Relnotes: n/a Original change's description: > Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest > > AX-Relnotes: n/a > > Bug: 1114959 > Change-Id: Ib6d9f51a04fa8059dc6bd6192d182b8e0244367d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352451 > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803007} TBR=ellyjones@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Bug: 1114959 Change-Id: I747aee7e8c533c564ec279b05e5511f25c38f603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386935Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#803385}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I764284990aef6c674f22e4805eb0cbc88e860ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382754Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803384}
-
Yue Zhang authored
This reverts commit bfd26dd3. Reason for revert: Disable the failing test on x86 bot to land the actual logic first. Original change's description: > Revert "Don't show default undo bar for closure in TabGridDialog" > > This reverts commit e5b906d1. > > Reason for revert: > https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1134 > > Original change's description: > > Don't show default undo bar for closure in TabGridDialog > > > > This CL prevents default undo closure snack bar from showing when a > > closure happens within TabGridDialog. We use the visibility of > > TabGridDialog as a proxy to decide whether a closure happens in dialog. > > This is the step2 in https://docs.google.com/document/d/1OOlOVYtcFXE--8TMdcFAqAMqcsRyEsvJr0vzsNCR_F4/edit?usp=sharing. > > > > Bug: 1119899 > > Change-Id: Ibdfe53847af25921f32436d80a5868b97340a524 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369469 > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803203} > > TBR=yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org > > Change-Id: Ie98c1246828bc48c3569184c2565338d54f67629 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1119899 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386374 > Reviewed-by: Gang Wu <gangwu@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803348} TBR=yusufo@chromium.org,mdjones@chromium.org,gangwu@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1119899 Change-Id: Id7ceb4c63e7f044df10341cbc53b45192773dfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387302 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#803383}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6522350f5c2..1a42d4b38183 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: I7cb07a2842d285b058aa71e4bc7dab3c1157ae27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387301Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803382}
-
Kent Tamura authored
crrev.com/802523 seems to introduce a null pointer dereference in the function. According to the 5th |if|, |scrollable_area| can be nullptr. This CL has no tests. We don't know how to reproduce the crash. Bug: 1123327 Change-Id: Iec8a746f549d60890f3f050b72e4791ce7efe828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383595 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#803381}
-
Wei Lee authored
This CL: 1. Add LaunchSystemWebApp() in autotest private API 2. Don't install platform app version of CCA if SWA version is used Bug: 980846 Test: Tested with related Tast CL and run "$tast run [DUT] camera.CCAUI*_swa" Change-Id: Ie66cc91bf5bfe574543f43f50b5a22dbb533bda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257086 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#803380}
-
