GitLab

We need to enforce exit_time_destructors compiler flag warning everywhere.

Bug: 860581
Change-Id: I7cbb2ef3ba5c71a69233bc8bd50725786b6ea0b1
Reviewed-on: https://chromium-review.googlesource.com/1155276Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579323}

Most test extensions manifest's have a descripton: the Files, Gallery,
Video Player, Audio Player test extension do not (how very odd). Let's
give them a description, for consistency with all test extensions.

Bug: 836254
Change-Id: I43dce817da53f9ae7a584f4b30907c3c0649ee85
Reviewed-on: https://chromium-review.googlesource.com/1156118
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579322}

Previously the field constructed_tree_scopes is added
to CSSStyleSheet to track addition of constructed CSSStyleSheets
in tree scopes when adding/removing them from
TreeScope.moreStyleSheets.

moreStyleSheets already was removed at blink[1].
so constructed_tree_scopes is not needed anymore.

[1]https://chromium-review.googlesource.com/1125741

Bug: 869244
Change-Id: Icc0b68393fd100d08ee826d6dbe0859468ee1e23
Reviewed-on: https://chromium-review.googlesource.com/1155286
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579321}

A test is added to check if an extension with command key binding can
not be accessed when it is not allowed in incognito.

Bug: 862075
Change-Id: Id49fb16958a9913978f8b054740c0ef4d0977c25
Reviewed-on: https://chromium-review.googlesource.com/1141727Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579320}

This reverts commit 903b12a4.

Reason for revert: https://crbug.com/869189 .

Original change's description:
> ChromeOS OOBE: Add Welcome screen animations.
>
> This Cl replaces static images with animations.
>
> Bug: 852038
> Change-Id: Id58f69e4275231dc4b6491358d10a343f529fc2f
> Reviewed-on: https://chromium-review.googlesource.com/1153832
> Commit-Queue: Alexander Alekseev <alemate@chromium.org>
> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578882}

TBR=alemate@chromium.org,wzang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 852038,869189
Change-Id: Icb34fb1b55268e0779e14deac01245397906c567
Reviewed-on: https://chromium-review.googlesource.com/1155503
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579319}

[LayoutNG] Label its own bug number for compositing/layer-creation/stacking-context-overlap-nested.html

TBR=atotic@chromium.org
NOTRY=true

Bug: 869265
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9a87e971df42fcef062344aae8a9bc34e7171ffd
Reviewed-on: https://chromium-review.googlesource.com/1156116
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579318}

This is for more than 30 mins compile steps like below builds.

3289s https://ci.chromium.org/b/8939589875030577744
2860s https://ci.chromium.org/b/8939533321978116048
2593s https://ci.chromium.org/b/8939552683394930304
2569s https://ci.chromium.org/b/8939542011766010272

Bug: 804251
Change-Id: I57f2a63c4e1fdcbdc21eeea5ed421b41237db268
Reviewed-on: https://chromium-review.googlesource.com/1155285Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579317}

Name various test extensions used in integration test consistently, in
particular, the test extensions used in the providers.js tests [1].

[1] these are the only integration testcases that explicitly depend on
test extension manifest name. Add a helper to return the name.

Bug: 869240
Change-Id: I9d5ab74af9083201ab2c0173c2e505ec6f6e05be
Reviewed-on: https://chromium-review.googlesource.com/1154784Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579316}

A primary use case for the All Sites page should be to view the sites that are
using the most disk space on the user's device. Implement this in this patch
with support for sorting via the number of cookies (descending), with local and
website storage to come later.

Bug: 835712
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia8ea3f75d1d102956bf31f9d409e642d47698aca
Reviewed-on: https://chromium-review.googlesource.com/1146534
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579315}

The web::test::HttpServer instance returned by GetSharedInstance has
zero reference count initially, HttpServer::StartOrDie implicitly
increments the reference count through base::Bind, and its
embedded_test_server_ destruction decrements the reference count.
That is, once the server stopped, the shared instance is destroyed, and
GetSharedInstance() starts returning a stale pointer.

After this CL, the resulting instance of GetSharedInstance has non-zero
reference count, so that it keeps alive after server stop.

Bug: 866456
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1f13dff1e86d08efb28b5805ae73426b874a4f80
Reviewed-on: https://chromium-review.googlesource.com/1146881Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579314}

Add metrics to measure the amount of time it takes for the BeginFrame
to travel to the Client from the DisplayCompositor.

Bug:814909

related design doc:
https://docs.google.com/document/d/1XIaAPkajbML0s0neajasWzvt856dUjF_1zAWO5KykCQ/edit

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6a13b5fcdbfc458e2d2dc84312e2e37459c11ac4
Reviewed-on: https://chromium-review.googlesource.com/1146337
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579313}

This reverts commit 1f75f99f.

Reason for revert: This breaks compile on "Google Chrome Win" builder due to a integer sign mismatch in incompatible_applications_updater_win.cc(289,32).

Original change's description:
> Fix to remove /wd4018 (-Wno-sign-compare) for /build/config
> 
> This is a part of effort to remove /wd4018 warning suppression.
> 
> Master CL is
> https://chromium-review.googlesource.com/c/chromium/src/+/1152755
> 
> This CL was uploaded by git cl split.
> 
> R=​dpranke@chromium.org
> 
> Bug: 868248, 588506
> Change-Id: I3c31dc8f72266eda85904c4a860e156fadb2a76e
> Reviewed-on: https://chromium-review.googlesource.com/1152840
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579311}

TBR=thakis@chromium.org,dpranke@chromium.org,pmonette@chromium.org,tikuta@chromium.org

Change-Id: Iaed7b5e6f2ff3c53e1846162ca8d14689f7ae5e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868248, 588506
Reviewed-on: https://chromium-review.googlesource.com/1156144Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579312}

This is a part of effort to remove /wd4018 warning suppression.

Master CL is
https://chromium-review.googlesource.com/c/chromium/src/+/1152755

This CL was uploaded by git cl split.

R=dpranke@chromium.org

Bug: 868248, 588506
Change-Id: I3c31dc8f72266eda85904c4a860e156fadb2a76e
Reviewed-on: https://chromium-review.googlesource.com/1152840
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579311}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b0e855a33353..1aefad2a5982


git log b0e855a33353..1aefad2a5982 --date=short --no-merges --format='%ad %ae %s'
2018-07-30 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@1aefad2a5982

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I8a228ba7556e1f43844e70d022aa9ec25a0593bf
Reviewed-on: https://chromium-review.googlesource.com/1155884Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579310}

Hide the Google Photos option for custom backgrounds as it will
not be launched in M69.

All service requests occur after clicking on the option, so simply
hiding it is sufficient.

Bug: 869230
Change-Id: I55ca201978323cd7031e618b6a9039b93a485130
Reviewed-on: https://chromium-review.googlesource.com/1155978Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579309}

This relands commit 748ac91e.

Includes workaround for LTO bug exposed by orderfile generation:
add -Wl,-u,__cyg_profile_func_enter_bare to ldflags. A fix for the
bug is under review: https://reviews.llvm.org/D50017

Original change's description:
> Reland "build: Enable ThinLTO in official Android builds."
>
> This relands commit 1ba5d611.
>
> Fixes chromeos build issue by checking whether we have a secondary
> toolchain before comparing it with the current toolchain.
>
> Original change's description:
> > build: Enable ThinLTO in official Android builds.
> >
> > With this change we start building Chromium with ThinLTO when targeting
> > Android. In 64-bit Monochrome builds, the 32-bit binary is also built
> > with ThinLTO. This change is expected to reduce code size significantly
> > (in local measurements it reduced the size of MonochromePublic.apk by 2.3MB)
> > and is a prerequisite for enabling control flow integrity in official
> > builds.
> >
> > Note that although this change enables ThinLTO, it does not enable
> > the cross-TU optimizations normally associated with LTO. Enabling
> > cross-TU optimizations is a separate project.
> >
> > On my local machine (a Lenovo P920) libmonochrome.so link times increase
> > as follows:
> >
> >          before  after (first link)  after (incremental links)
> > 32-bit    18s          140s                     50s
> > 64-bit    13s          107s                     41s
> >
> > All known blockers have now been fixed. This CL is likely to uncover
> > unknown blockers.
> >
> > Bug: 469376
> > Change-Id: I8981e17abd50bc5ca00440e0d74dda878c911749
> > Reviewed-on: https://chromium-review.googlesource.com/1150870
> > Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#578195}
>
> Bug: 469376, 868426
> Change-Id: Ie46ba0db0ac68130bc600415777de5c813b28ebd
> Reviewed-on: https://chromium-review.googlesource.com/1153612
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578854}

Bug: 469376, 867878
Change-Id: Iae4cc698b5955df5ae1970c71646fa05fca61109
Reviewed-on: https://chromium-review.googlesource.com/1155977Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579308}

This patch introduces a DCHECK checking if DocumentMarker.endoffset is
not over text length when adding each marker.

Bug: 868229
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I4f2681460d1de1aacf78b55d7bba454dfc557cf2
Reviewed-on: https://chromium-review.googlesource.com/1149763
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579307}

If the "No destinations" message was visible in the recent destinations
list, the iron-list containing the destinations was pushed down and
extended invisibly over the "Manage" link for the print destinations,
preventing the link from working.

Fix this by ensuring that the iron-lists are the correct height: height
of the parent - height of parent's header line - height of "No
destinations" message (if showing).

Bug: 868274
Change-Id: Idf574923d69ae1c0ff1265efe62b9cc67b70af11
Reviewed-on: https://chromium-review.googlesource.com/1153430
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579306}

Change-Id: If11eab039bdc86257da197d9adbe6ff64764c627
Reviewed-on: https://chromium-review.googlesource.com/1154435Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579305}

Change icons for each team drive in the directory tree and on file list
(RHS).

Bug: 865993
Change-Id: If880279f9776ff70b33d13ec02aaeb5d4ce44290
Reviewed-on: https://chromium-review.googlesource.com/1155282Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579304}

Bug: 809359
Change-Id: I8c04faa4761dc1d01cbb4ad1d2e77fda3c874c72
Reviewed-on: https://chromium-review.googlesource.com/1148948
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579303}

The default sort order of the All Sites page is by the amount of site engagement
each site has. Retrieve the site engagement score for each origin in All Sites
and sort the list by the max site engagement per domain (eTLD+1) group.

Bug: 835712
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I421c41f3307a4e5b3ea35683bc4455dfc69ecd96
Reviewed-on: https://chromium-review.googlesource.com/1141667
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579302}

TBR=tapted@chromium.org

Bug: 869241
Change-Id: I932f8c321839a21dda61285df3f8a5f5856ac9ea
Reviewed-on: https://chromium-review.googlesource.com/1155278
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579301}

This is mainly to pick up below change.
https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1105680

Change-Id: I1369f416e81cd8582dfd847589b1996bb38e6064
Reviewed-on: https://chromium-review.googlesource.com/1154864Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579300}

Currently, the settings menu is only shown when custom backgrounds is
enabled. Now it should also appear when custom links is enabled.

Menu options for the respective features are hidden if the feature is
disabled, and the "Restore default..." options are grayed out instead
of hidden when there is nothing to restore.

Bug: 868529, 868527
Change-Id: I383c7e6350e96f226ea39a9b1315cc274d03df51
Reviewed-on: https://chromium-review.googlesource.com/1154193
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579299}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: Ibfc1117d1c08fd3fd8a125a8dc2af9d159b4028b
Reviewed-on: https://chromium-review.googlesource.com/1156066Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579298}

This CL adds implementation to connect the CastRemotingConnector with
remoter when requested from Mirroring Service.

Bug: 734672
Change-Id: I213b4f06bdbd7ad188969310da867bf939cdd0f2
Reviewed-on: https://chromium-review.googlesource.com/1144409
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579297}

Make SetSelectionToDragCaret() not to use FrameSelection::ComputeVisibileSelectionInDOMTreeDeprecated()

This patch changes |SetSelectionToDragCaret()| to use
|FrameSelection::ComputeVisibileSelectionInDOMTree| instead of deprecated
version for improving code health.

This is 2/3 of series of patches:
 1. http://crrev.com/c/This patch
 2. This patch
 3. http://crrev.com/c/1153071

Bug: 698633
Change-Id: Ie51e4b8524c4429fb04a065cb13264e7277d2697
Reviewed-on: https://chromium-review.googlesource.com/1153070
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579296}

It will be executed "when the page has finished parsing" which seems right
for this script.

Bug: 868432
Change-Id: Icb0fb03518aca785c7a3d8583bcbfaecd4cb1487
Reviewed-on: https://chromium-review.googlesource.com/1154365Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579295}

Change-Id: I2ec5bafdb4ce19336b0cc4279fdab24cfacc4b09
Reviewed-on: https://chromium-review.googlesource.com/1154431Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579294}

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia2f39271db9f31ff6c462cb11ca65d436ed3018b
Reviewed-on: https://chromium-review.googlesource.com/1155803Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579293}

Bug: 867700, 860355
Change-Id: Ifcc4ada00bc459b8cd59a5c2b234af0ef3554c61
Reviewed-on: https://chromium-review.googlesource.com/1150015Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579292}

Bug: 851163
Change-Id: I4321ca15bc02b38e510c885c8e3ceb31875d9e1c
Reviewed-on: https://chromium-review.googlesource.com/1155965Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579291}

HTMLDocumentParser::IsExecutingScript() is in fact identical to the
"script nesting level is greater than 0" check in the current HTML
Standard.

The removed check originated from an older version of the HTML Standard
that read:

> If the Document has an active parser that isn't a script-created
> parser, and the insertion point associated with that parser's input
> stream is not undefined (that is, it does point to somewhere in the
> input stream), then the method does nothing.

but that was changed after [1]/[2] to the current text which covers
strictly more cases. Indeed, in the current coverage report the removed
check is never true [3].

The check is expected to stay in its current form in the upcoming
document.open() overhaul.

[1]: https://www.w3.org/Bugs/Public/show_bug.cgi?id=17869
[2]: https://github.com/whatwg/html/commit/7b0112bbfb4923e8f64b0fd1c66d14fbd526fc33
[3]: https://chromium-coverage.appspot.com/reports/577000/linux/chromium/src/third_party/blink/renderer/core/dom/document.cc.html#L3048

Bug: 866274
Change-Id: I5f4547ee62efe45a9831c003854279b3490a08f1
Reviewed-on: https://chromium-review.googlesource.com/1146202Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579290}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b438311bbf3..9093ff098254


git log 3b438311bbf3..9093ff098254 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@9093ff098254

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ief39f09b81135eba58e03df834d472357792a3b8
Reviewed-on: https://chromium-review.googlesource.com/1155887Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579289}

Parameters |white_list| and |black_list| in FilterSourceFile()
should be iterables, and it's fairly easy to wrongly pass a string
instead.

This checking caught _CheckCrbugLinksHaveHttps in unit tests.

Bug: 869103
Change-Id: I1cd6d62c3fa2b1500d9d7b6b35794f40e35378af
Reviewed-on: https://chromium-review.googlesource.com/1155379
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579288}

This change is part of the update to the chrome://power page. This
commit adds a new process data collector that will eventually be
integrated into chrome://power. Currently, for each process, it
aggregates what type of process and it approximates the average CPU
usage of that process across its lifetime for all processes in the
system. This will eventually be used as part of a battery usage
approximation metric.

BUG: crbug.com/851767
TEST: Run unittests provided in the commit.

Change-Id: If63289a827b530bca808626f9133c52276dc5d6f
Reviewed-on: https://chromium-review.googlesource.com/1096408
Commit-Queue: Nikhil Athreya <nathreya@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579287}

This reverts commit 7bfc1624.

Reason for revert: tests appear to have mostly recovered; unclear why.

Original change's description:
> Drop the layout tests to experimental on Mac10.13 Tests.
> 
> TBR=dpranke@chromium.org
> 
> Bug: 868180
> Change-Id: Ic9cb48f82954f102f60dd3e1b9c29bcca209f3bb
> Reviewed-on: https://chromium-review.googlesource.com/1152566
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578626}

TBR=dpranke@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 868180
Change-Id: Ibb217f63bb5b834565fafac4cb7ad15543ba70bb
Reviewed-on: https://chromium-review.googlesource.com/1155614Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579286}

Fixed some of the following issues:
- E302 expected 2 blank lines, found 1
- E703 statement ends with a semicolon
- E999 SyntaxError: invalid syntax

Bug: None
Change-Id: Ia4c9a2c81168395331f5d2135a7bba1eafcd3640
Reviewed-on: https://chromium-review.googlesource.com/1155625Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579285}

Bug: 868150
Change-Id: Ib0d3ea858fd1c51c34c2e0cdec0609f1a7f2d5d3
Reviewed-on: https://chromium-review.googlesource.com/1152447Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579284}