GitLab

The progress callback interface will be changed as the third parameter
goes to number from boolean. This change make translate.js support
both boolean and number for API migration. Once this change goes to stable
channel, server side library will change to return number to specify error code.

BUG=211308
TEST=none

Review URL: https://chromiumcodereview.appspot.com/24024004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221992 0039d316-1c4b-4281-b951-d872f2087c98

The primary goal of this change is to allow PasswordForm to depend on //
autofill code for password generation. A side benefit is that this change will
allow iOS to cleanly use PasswordForm.

To accommodate the fact that multiple message files need to know about PasswordForm, it is put into a newly-created autofill_param_traits_macros.h rather than autofill_messages.h.

BUG=263121

Review URL: https://chromiumcodereview.appspot.com/23742004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221991 0039d316-1c4b-4281-b951-d872f2087c98

Broke DriveFileSystemExtensionApiTest.FileWatch
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/151979


> file_manager: Remove FileWatchChangedEntry from fileBrowserPrivate
> 
> This type is not in use, and we don't plan to use this any time soon.
> We should add it back when it's needed.
> 
> BUG=257916
> TEST=Files.app works as before
> R=benwells@chromium.org, mtomasz@chromium.org
> 
> Review URL: https://codereview.chromium.org/23956009

TBR=satorux@chromium.org

Review URL: https://codereview.chromium.org/23791005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221990 0039d316-1c4b-4281-b951-d872f2087c98

> [Android WebView] Enable spatial navigation / DPAD
> 
> Turn on the --enable-spatial-navigation flag, and also bubble up
> unhandled DPAD events to the neighboring views in the view tree.
> Likewise, WebContentsDelegate::TakeFocus() bubble to logical next
> or previous neighbor view.
> 
> Also disabled the FileSystem API while in the area updating flags.
> 
> BUG=286698
> 
> Review URL: https://chromiumcodereview.appspot.com/23619024

TBR=joth@chromium.org

Review URL: https://codereview.chromium.org/23494033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221989 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221988 0039d316-1c4b-4281-b951-d872f2087c98

To consolidate fileBrowserPrivate tests into a single directory.
Als add OWNERS, so Files.app team can add tests without approval
from extensions owners.

BUG=231782
TEST=none
R=benwells@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/24024002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221987 0039d316-1c4b-4281-b951-d872f2087c98

These types are no longer used.

BUG=257916
TEST=none
R=benwells@chromium.org, hidehiko@chromium.org

Review URL: https://codereview.chromium.org/23882004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221986 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221985 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157413:157432&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23697003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221984 0039d316-1c4b-4281-b951-d872f2087c98

Originally, PreviewPanel is not used from any code.
This CL lets the FileManager class and the FileSelectorHandler class use the PreviewPanel class to control the visibility of preview panel.

Previously reverted CL: crrev.com/23464030

BUG=284215
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/23662004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221983 0039d316-1c4b-4281-b951-d872f2087c98

This type is not in use, and we don't plan to use this any time soon.
We should add it back when it's needed.

BUG=257916
TEST=Files.app works as before
R=benwells@chromium.org, mtomasz@chromium.org

Review URL: https://codereview.chromium.org/23956009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221982 0039d316-1c4b-4281-b951-d872f2087c98

The term path is incorrect as the parameter is for a URL.

FWIW, the URL looks like:
"filesystem:chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/external/"
where hhaomjibdihmijegdhdafkllkbggdgoj is the app ID for Files.app.

BUG=284963
TEST=Files.app works as before
R=benwells@chromium.org, kinuko@chromium.org

Review URL: https://codereview.chromium.org/23903016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221981 0039d316-1c4b-4281-b951-d872f2087c98

This is API clean up. The mountType is being replaced by VolumeType. This CL
refactors private APIs about the flag.
Note that this is preparation to return Drive as a Volume.

BUG=279276
TEST=Ran unit_tests, browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*:*FileBrowserPrivateApiTest*" and tested manually.
R=benwells@chromium.org, kinaba@chromium.org, satorux@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/23658009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221978 0039d316-1c4b-4281-b951-d872f2087c98

"fileUrl" and "errorCode" are no longer in use.

BUG=257916
TEST=Files.app works as before
R=benwells@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/23514043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221977 0039d316-1c4b-4281-b951-d872f2087c98

Instead introducing a static FileSystemOperation::Create method.

As a preparation for moving fileapi code from webkit/ to content/.
(file_system_operation.h will be placed under content/public/browser/ while
file_system_operation_impl.{h,cc} will be placed under content/browser/fileapi
and will be hidden from chrome/)

BUG=265770
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/23835005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221976 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221975 0039d316-1c4b-4281-b951-d872f2087c98

Currently the main menu is only modified for app windows when
--enable-app-shims is enabled. This change enables modifying
the main menu whenever app shims are enabled (i.e. when the app
launcher is enabled).

BUG=168080,276052

Review URL: https://chromiumcodereview.appspot.com/23558007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221974 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157410:157412&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/24065002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221973 0039d316-1c4b-4281-b951-d872f2087c98

Re-apply and disable for Chrome Frame.

> Revert 221944 "Add UMA to report Preferences File Corruption"
> 
> Breaks chrome_frame_tests on Win Aura.
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=chrome_frame_tests&builder=Win%20Aura%20Tests%20(1)
> 
> > Add UMA to report Preferences File Corruption
> > Adds PrefMetricsService methods to track changes to user preferences
> > that happen outside of Chrome and report discrepancies via UMA.
> > 
> > BUG=266569
> > 
> > Review URL: https://chromiumcodereview.appspot.com/22676002
> 
> TBR=bbudge@chromium.org
> 
> Review URL: https://codereview.chromium.org/23597020

TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/23788010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221972 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221971 0039d316-1c4b-4281-b951-d872f2087c98

Breaks chrome_frame_tests on Win Aura.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=chrome_frame_tests&builder=Win%20Aura%20Tests%20(1)

> Add UMA to report Preferences File Corruption
> Adds PrefMetricsService methods to track changes to user preferences
> that happen outside of Chrome and report discrepancies via UMA.
> 
> BUG=266569
> 
> Review URL: https://chromiumcodereview.appspot.com/22676002

TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/23597020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221966 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285016
TEST=YouTube playback works for videos that are available in the VP9 format.

Review URL: https://chromiumcodereview.appspot.com/23463020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221964 0039d316-1c4b-4281-b951-d872f2087c98

BUG=269131
TEST=none
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23851009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=none, no functional changes.
R=erg@chromium.org
TBR=thestig # for gyp change.

Review URL: https://chromiumcodereview.appspot.com/23743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221962 0039d316-1c4b-4281-b951-d872f2087c98

It allows us to run an experiment where only chrome.dll is instrumented.

TBR=chrisha@chromium.org, gab@chromium.org
CC=laforge@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23719017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221961 0039d316-1c4b-4281-b951-d872f2087c98

Replace --enable-device-discovery flags with --disable-device-discovery.

BUG=286157

Review URL: https://chromiumcodereview.appspot.com/23567023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221960 0039d316-1c4b-4281-b951-d872f2087c98

I don't think this is related to the crash I'm seeing, but I noticed
it when looking for dangling TabStripModelObservers.

BUG=286162
TEST=none
R=yoz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23547006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221959 0039d316-1c4b-4281-b951-d872f2087c98

The URLRequestJob interface this forwards to is const, and marking URLRequest::GetResponseCode() as const allows passing the URLRequest as const in some cases.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23494023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221958 0039d316-1c4b-4281-b951-d872f2087c98

The size of the print preview should be based off of the available
area for dialogs, not the size of the web contents view.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23460022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221957 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23454015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221956 0039d316-1c4b-4281-b951-d872f2087c98

The number of missing packets between the current received packet and the
previously largest received packet sequence number, when the current
received packet had a lower sequence number than the previously received
packet sequence number.

Review URL: https://chromiumcodereview.appspot.com/23451015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221955 0039d316-1c4b-4281-b951-d872f2087c98

breaks XP Tests:
ActivityLogPrerenderTest.TestScriptInjected
FindInPageTest.PrepopulateRespectBlank
KeyboardAccessTest.TestAltMenuKeyboardAccessFocusOmnibox
KeyboardAccessTest.TestMenuKeyboardOpenDismiss

> Switch all windows bots to use Aura.
> 
> Because we've been shipping Aura to canary for a while. And because force compositor landed 40 hours ago and things seem ok. See https://codereview.chromium.org/23874016/
> 
> This also allows to see perf numbers for Aura. 
> 
> This has happened before see for example r204698, r211007 and 214056 as an experiment but this time it might stick.
> 
> BUG=259185
> TEST=none
> TBR=scottmg
> 
> Review URL: https://codereview.chromium.org/23816007

TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/23523035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221952 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221948 0039d316-1c4b-4281-b951-d872f2087c98

Turn on the --enable-spatial-navigation flag, and also bubble up
unhandled DPAD events to the neighboring views in the view tree.
Likewise, WebContentsDelegate::TakeFocus() bubble to logical next
or previous neighbor view.

Also disabled the FileSystem API while in the area updating flags.

BUG=286698

Review URL: https://chromiumcodereview.appspot.com/23619024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221946 0039d316-1c4b-4281-b951-d872f2087c98

Consolidate common parts of VideoCaptureCapability and VideoCaptureParams into VideoCaptureFormat, renamed frames_per_second->frame_rate for all; 
VideoCaptureParams and VideoCaptureCapability changed to classes, since they have constructors.

Format extracted from VideoCaptureCapability and renamed to VideoPixelFormat (otherwise simply called "media::Format" ). Individual color "formats" renamed like kI420 -> PIXEL_FORMAT_I420, etc.


VideoCaptureFormat::isValid and VideoCaptureParams::isValid implementation.


BUG=260572
BUG=260220

Review URL: https://chromiumcodereview.appspot.com/22876027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221945 0039d316-1c4b-4281-b951-d872f2087c98

Adds PrefMetricsService methods to track changes to user preferences
that happen outside of Chrome and report discrepancies via UMA.

BUG=266569

Review URL: https://chromiumcodereview.appspot.com/22676002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221944 0039d316-1c4b-4281-b951-d872f2087c98

Added BookmarkUndoService that is owned by the profile to provide
multi-level undo and redo for bookmark changes.

This is a staged commit of a larger feature.

The code is not invoked anywhere other than the provided tests so
there should be no impact on the application at this time.
Further integration will continue in future commits.

BUG=126092

Review URL: https://chromiumcodereview.appspot.com/19287013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221943 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scottmg

Review URL: https://codereview.chromium.org/23693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221940 0039d316-1c4b-4281-b951-d872f2087c98

> Refactor KeySystems code to call a function to populate the info.
> 
> This allows KeySystems to call GetContentClient()->AddKeySystems() so we can
> move key system information to chrome/. The new ContentClient API is defined and
> called, but we still rely on key_systems_info.cc.
> 
> BUG=224793
> TEST=Existing content_unittests and content_browsertests pass.
> 
> Review URL: https://chromiumcodereview.appspot.com/23678008

It broke chromeOs compile:

FAILED: g++ -MMD -MF obj/content/renderer/media/crypto/content_renderer.key_systems_info.o.d -DCONTENT_IMPLEMENTATION -DANGLE_DX11 -DWTF_VECTOR_INITIAL_SIZE=4 -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DENABLE_RLZ -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS=1 -DUSE_X11=1 -DOS_CHROMEOS=1 -DFILE_MANAGER_EXTENSION=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DGL_GLEXT_PROTOTYPES -DLIBPEERCONNECTION_LIB=1 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DCHROMEOS -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_LINUX -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../.. -Igen -I../../third_party/khronos -I../../gpu -Igen/content -I../../third_party/skia/src/core -I../../skia/config -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../v8/include -I../../third_party/webrtc/modules/interface -I../../third_party/webrtc/modules/audio_device/include -I../../net/third_party/nss/ssl -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -g -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -O2 -fno-ident -fdata-sections -ffunction-sections -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare  -c ../../content/renderer/media/crypto/key_systems_info.cc -o obj/content/renderer/media/crypto/content_renderer.key_systems_info.o
../../content/renderer/media/crypto/key_systems_info.cc: In function 'void content::AddPepperBasedWidevine(std::vector<content::KeySystemInfo>*)':
../../content/renderer/media/crypto/key_systems_info.cc:104:23: error: invalid conversion from 'int' to 'content::SupportedCodecs' [-fpermissive]
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/57998/steps/compile/logs/stdio



TBR=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/23578015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221939 0039d316-1c4b-4281-b951-d872f2087c98

Because we've been shipping Aura to canary for a while. And because force compositor landed 40 hours ago and things seem ok. See https://codereview.chromium.org/23874016/

This also allows to see perf numbers for Aura. 

This has happened before see for example r204698, r211007 and 214056 as an experiment but this time it might stick.

BUG=259185
TEST=none
TBR=scottmg

Review URL: https://codereview.chromium.org/23816007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221936 0039d316-1c4b-4281-b951-d872f2087c98